solid_queue 1.3.0 → 1.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ae346e5b4e8249ab21441c1b45118745124d1d7d78b5b43c08cf6b333e0ec665
-  data.tar.gz: fc4b4a6131ff3cb5799f1325f9b0523606152bf8e331bf7122af4463c543e2b5
+  metadata.gz: fb6ce5453b198c213a9de3fd6214ad410e158f1941a024fff5256f5895532523
+  data.tar.gz: 8d9172270e0cbabbfde5c5084c4da52d615a787921acb1c837bccd494556d977
 SHA512:
-  metadata.gz: 2282d35fe14f5dfa424f1016dd8e00b2f3613e7023cb48cf99b82de5e2079de0154e7102fef72867060cdf4f1e7c9aa125cbed43c229ead9c200342c74e41099
-  data.tar.gz: cab19aa7d9d4a22fc3c068ebe00d2bbd1c288c023a37ef24b461bc8d84d9c3e100337ffcd53bf634d17e712e42937175e59cc6b2041e81661e91edfa9fb94282
+  metadata.gz: 3c9155032132f14e03132e651846fa4b2bec944f96eb62d988dc75a82abfcb5f4e3a1fde9f4bb4591866d8cb230bd188df4cb9f028b6adcdf09f161d9a48f2e0
+  data.tar.gz: 0aecdd6b91de9f6026b9ea041a673709e348ddaac093ad6ebb57b5bdd98cd6b4f255e8e9350d790a8635703d0249407871f2c6258594593871c56b690fc8f3e7

data/README.md

@@ -258,6 +258,8 @@ Here's an overview of the different options:
   ```
 
   This will create a worker fetching jobs from all queues starting with `staging`. The wildcard `*` is only allowed on its own or at the end of a queue name; you can't specify queue names such as `*_some_queue`. These will be ignored.
+  
+  Also, if a wildcard (*) is included alongside explicit queue names, for example: `queues: [default, backend, *]`, then it would behave like `queues: *`
 
   Finally, you can combine prefixes with exact names, like `[ staging*, background ]`, and the behaviour with respect to order will be the same as with only exact names.
 

data/app/models/solid_queue/failed_execution.rb

@@ -6,7 +6,7 @@ module SolidQueue
 
     serialize :error, coder: JSON
 
-    before_create :expand_error_details_from_exception
+    before_save :expand_error_details_from_exception, if: :exception
 
     attr_accessor :exception
 

data/app/models/solid_queue/job/concurrency_controls.rb

@@ -26,7 +26,7 @@ module SolidQueue
       end
 
       def concurrency_limited?
-        concurrency_key.present?
+        concurrency_key.present? && job_class.present?
       end
 
       def blocked?

data/app/models/solid_queue/job/retryable.rb

@@ -16,7 +16,16 @@ module SolidQueue
       end
 
       def failed_with(exception)
-        FailedExecution.create_or_find_by!(job_id: id, exception: exception)
+        FailedExecution.transaction(requires_new: true) do
+          FailedExecution.create!(job_id: id, exception: exception)
+        end
+      rescue ActiveRecord::RecordNotUnique
+        if (failed_execution = FailedExecution.find_by(job_id: id))
+          failed_execution.exception = exception
+          failed_execution.save!
+        else
+          retry
+        end
       end
 
       def reset_execution_counters

data/app/models/solid_queue/recurring_task.rb

@@ -6,9 +6,9 @@ module SolidQueue
   class RecurringTask < Record
     serialize :arguments, coder: Arguments, default: []
 
-    validate :supported_schedule
+    validate :ensure_schedule_supported
     validate :ensure_command_or_class_present
-    validate :existing_job_class
+    validate :ensure_existing_job_class
 
     scope :static, -> { where(static: true) }
 
@@ -102,19 +102,28 @@ module SolidQueue
     end
 
     private
-      def supported_schedule
+      def ensure_schedule_supported
         unless parsed_schedule.instance_of?(Fugit::Cron)
           errors.add :schedule, :unsupported, message: "is not a supported recurring schedule"
         end
+      rescue ArgumentError => error
+        message = if error.message.include?("multiple crons")
+          "generates multiple cron schedules. Please use separate recurring tasks for each schedule, " +
+          "or use explicit cron syntax (e.g., '40 0,15 * * *' for multiple times with the same minutes)"
+        else
+          error.message
+        end
+
+        errors.add :schedule, :unsupported, message: message
       end
 
       def ensure_command_or_class_present
         unless command.present? || class_name.present?
-          errors.add :base, :command_and_class_blank, message: "either command or class_name must be present"
+          errors.add :base, :command_and_class_blank, message: "either command or class must be present"
         end
       end
 
-      def existing_job_class
+      def ensure_existing_job_class
         if class_name.present? && job_class.nil?
           errors.add :class_name, :undefined, message: "doesn't correspond to an existing class"
         end
@@ -152,7 +161,7 @@ module SolidQueue
 
 
       def parsed_schedule
-        @parsed_schedule ||= Fugit.parse(schedule)
+        @parsed_schedule ||= Fugit.parse(schedule, multi: :fail)
       end
 
       def job_class

data/app/models/solid_queue/semaphore.rb

@@ -40,7 +40,7 @@ module SolidQueue
       end
 
       def wait
-        if semaphore = Semaphore.find_by(key: key)
+        if semaphore = Semaphore.lock.find_by(key: key)
           semaphore.value > 0 && attempt_decrement
         else
           attempt_creation

data/lib/puma/plugin/solid_queue.rb

@@ -82,9 +82,11 @@ Puma::Plugin.create do
     end
 
     def stop_solid_queue_fork
+      return unless solid_queue_pid
+
       Process.waitpid(solid_queue_pid, Process::WNOHANG)
       log "Stopping Solid Queue..."
-      Process.kill(:INT, solid_queue_pid) if solid_queue_pid
+      Process.kill(:INT, solid_queue_pid)
       Process.wait(solid_queue_pid)
     rescue Errno::ECHILD, Errno::ESRCH
     end

data/lib/solid_queue/async_supervisor.rb

@@ -19,17 +19,19 @@ module SolidQueue
 
       def check_and_replace_terminated_processes
         terminated_threads = process_instances.select { |thread_id, instance| !instance.alive? }
-        terminated_threads.each { |thread_id, instance| replace_thread(thread_id, instance) }
+        terminated_threads.each { |thread_id, _| replace_thread(thread_id) }
       end
 
-      def replace_thread(thread_id, instance)
+      def replace_thread(thread_id)
         SolidQueue.instrument(:replace_thread, supervisor_pid: ::Process.pid) do |payload|
-          payload[:thread] = instance
+          if (instance = process_instances.delete(thread_id))
+            payload[:thread] = instance
 
-          error = Processes::ThreadTerminatedError.new(terminated_instance.name)
-          release_claimed_jobs_by(terminated_instance, with_error: error)
+            error = Processes::ThreadTerminatedError.new(instance.name)
+            release_claimed_jobs_by(instance, with_error: error)
 
-          start_process(configured_processes.delete(thread_id))
+            start_process(configured_processes.delete(thread_id))
+          end
         end
       end
 

data/lib/solid_queue/cli.rb

@@ -8,7 +8,7 @@ module SolidQueue
       desc: "Path to config file (default: #{Configuration::DEFAULT_CONFIG_FILE_PATH}).",
       banner: "SOLID_QUEUE_CONFIG"
 
-    class_option :mode, type: :string, default: "fork", enum: %w[ fork async ],
+    class_option :mode, type: :string, enum: %w[ fork async ],
       desc: "Whether to fork processes for workers and dispatchers (fork) or to run these in the same process as the supervisor (async) (default: fork).",
       banner: "SOLID_QUEUE_SUPERVISOR_MODE"
 

data/lib/solid_queue/fork_supervisor.rb

@@ -38,7 +38,7 @@ module SolidQueue
         pid, status = ::Process.waitpid2(-1, ::Process::WNOHANG)
         break unless pid
 
-        if (terminated_fork = process_instances.delete(pid)) && !status.exited? || status.exitstatus > 0
+        if (terminated_fork = process_instances.delete(pid)) && (!status.exited? || status.exitstatus.to_i > 0)
           error = Processes::ProcessExitError.new(status)
           release_claimed_jobs_by(terminated_fork, with_error: error)
         end

data/lib/solid_queue/processes/registrable.rb

@@ -54,7 +54,7 @@ module SolidQueue::Processes
       end
 
       def heartbeat
-        process.heartbeat
+        process&.heartbeat
       rescue ActiveRecord::RecordNotFound
         self.process = nil
         wake_up

data/lib/solid_queue/version.rb

@@ -1,3 +1,3 @@
 module SolidQueue
-  VERSION = "1.3.0"
+  VERSION = "1.3.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: solid_queue
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.2
 platform: ruby
 authors:
 - Rosa Gutierrez
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-01-09 00:00:00.000000000 Z
+date: 2026-02-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord