solid_queue 1.0.0.beta → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '0185a60652945d7afadb3c4c8e646f9445eba35086ab88ddf1b93ff3b271e973'
-  data.tar.gz: 363d19a3e07ced689dd4a3ac3ec36c7cdfeecfc61a5588ccb6f67c28b782a5bf
+  metadata.gz: f0d576a078aa17199edc6614015a0953027fe2660e98eab5ef31c23a7417c6e3
+  data.tar.gz: dfdac5d1ae0b53d48dea6e31abd70a39858cb48d41e2ef51f4db777797b5db1a
 SHA512:
-  metadata.gz: 1fc522f72cf05273cd6d7fb98cbce44001c28532131952fb1bc139c2c80d808afb2bd7dc8acd337c3fe4834d30e1dc75a908aff7d3984a1e13dfbada8b25261f
-  data.tar.gz: 96c3d62e399468a193dc2f915797308b645eaf8c60b109a4344a757b4d91c4accf80192c4ebcd26022d08f876a8b0e95788250dfe27eb58e0b723082c6147b2d
+  metadata.gz: a0583ab02da0aac3e812a9e13a3a9853aca53cd67d15cd1a8ce2d666b7f48e9c669dd52bd45a74b03b5177f2b93dd98a1d85ef9f86ab2c0b4aeb82d38f26bb3f
+  data.tar.gz: 6e6cdb1ad994664f8132774e2d337758a2fea55bbb46bb618acbed3319490acf23f0cf59f12a66ac7c798c55a92b69167073fe932b41a453dbdfd91189cb3ae4

data/README.md

@@ -226,7 +226,6 @@ There are several settings that control how Solid Queue works that you can set a
 
   **This is not used for errors raised within a job execution**. Errors happening in jobs are handled by Active Job's `retry_on` or `discard_on`, and ultimately will result in [failed jobs](#failed-jobs-and-retries). This is for errors happening within Solid Queue itself.
 
-- `connects_to`: a custom database configuration that will be used in the abstract `SolidQueue::Record` Active Record model. This is required to use a different database than the main app. For example:
 - `use_skip_locked`: whether to use `FOR UPDATE SKIP LOCKED` when performing locking reads. This will be automatically detected in the future, and for now, you'd only need to set this to `false` if your database doesn't support it. For MySQL, that'd be versions < 8, and for PostgreSQL, versions < 9.5. If you use SQLite, this has no effect, as writes are sequential.
 - `process_heartbeat_interval`: the heartbeat interval that all processes will follow—defaults to 60 seconds.
 - `process_alive_threshold`: how long to wait until a process is considered dead after its last heartbeat—defaults to 5 minutes.
@@ -381,13 +380,14 @@ bin/jobs --recurring_schedule_file=config/schedule.yml
 The configuration itself looks like this:
 
 ```yml
-a_periodic_job:
-  class: MyJob
-  args: [ 42, { status: "custom_status" } ]
-  schedule: every second
-a_cleanup_task:
-  command: "DeletedStuff.clear_all"
-  schedule: every day at 9am
+production:
+  a_periodic_job:
+    class: MyJob
+    args: [ 42, { status: "custom_status" } ]
+    schedule: every second
+  a_cleanup_task:
+    command: "DeletedStuff.clear_all"
+    schedule: every day at 9am
 ```
 
 Tasks are specified as a hash/dictionary, where the key will be the task's key internally. Each task needs to either have a `class`, which will be the job class to enqueue, or a `command`, which will be eval'ed in the context of a job (`SolidQueue::RecurringJob`) that will be enqueued according to its schedule, in the `solid_queue_recurring` queue.
@@ -409,6 +409,8 @@ Tasks are enqueued at their corresponding times by the scheduler, and each task
 
 It's possible to run multiple schedulers with the same `recurring_tasks` configuration, for example, if you have multiple servers for redundancy, and you run the `scheduler` in more than one of them. To avoid enqueuing duplicate tasks at the same time, an entry in a new `solid_queue_recurring_executions` table is created in the same transaction as the job is enqueued. This table has a unique index on `task_key` and `run_at`, ensuring only one entry per task per time will be created. This only works if you have `preserve_finished_jobs` set to `true` (the default), and the guarantee applies as long as you keep the jobs around.
 
+**Note**: a single recurring schedule is supported, so you can have multiple schedulers using the same schedule, but not multiple schedulers using different configurations.
+
 Finally, it's possible to configure jobs that aren't handled by Solid Queue. That is, you can have a job like this in your app:
 ```ruby
 class MyResqueJob < ApplicationJob

data/app/models/solid_queue/record.rb

@@ -4,7 +4,7 @@ module SolidQueue
   class Record < ActiveRecord::Base
     self.abstract_class = true
 
-    connects_to **SolidQueue.connects_to if SolidQueue.connects_to
+    connects_to(**SolidQueue.connects_to) if SolidQueue.connects_to
 
     def self.non_blocking_lock
       if SolidQueue.use_skip_locked

data/app/models/solid_queue/recurring_task.rb

@@ -67,11 +67,15 @@ module SolidQueue
           end
         end
 
-        payload[:active_job_id] = active_job.job_id if active_job
+        active_job.tap do |enqueued_job|
+          payload[:active_job_id] = enqueued_job.job_id
+        end
       rescue RecurringExecution::AlreadyRecorded
         payload[:skipped] = true
+        false
       rescue Job::EnqueueError => error
         payload[:enqueue_error] = error.message
+        false
       end
     end
 

data/lib/generators/solid_queue/install/templates/config/recurring.yml

@@ -1,9 +1,10 @@
-# periodic_cleanup:
-#   class: CleanSoftDeletedRecordsJob
-#   queue: background
-#   args: [ 1000, { batch_size: 500 } ]
-#   schedule: every hour
-# periodic_command:
-#   command: "SoftDeletedRecord.due.delete_all"
-#   priority: 2
-#   schedule: at 5am every day
+# production:
+#   periodic_cleanup:
+#     class: CleanSoftDeletedRecordsJob
+#     queue: background
+#     args: [ 1000, { batch_size: 500 } ]
+#     schedule: every hour
+#   periodic_command:
+#     command: "SoftDeletedRecord.due.delete_all"
+#     priority: 2
+#     schedule: at 5am every day

data/lib/generators/solid_queue/install/templates/db/queue_schema.rb

@@ -1,4 +1,4 @@
-ActiveRecord::Schema[7.1].define(version: 2024_09_04_193154) do
+ActiveRecord::Schema[7.1].define(version: 1) do
   create_table "solid_queue_blocked_executions", force: :cascade do |t|
     t.bigint "job_id", null: false
     t.string "queue_name", null: false

data/lib/solid_queue/configuration.rb

@@ -111,7 +111,7 @@ module SolidQueue
       end
 
       def recurring_tasks_config
-        @recurring_tasks ||= config_from options[:recurring_schedule_file]
+        @recurring_tasks_config ||= config_from options[:recurring_schedule_file]
       end
 
 

data/lib/solid_queue/processes/runnable.rb

@@ -41,10 +41,6 @@ module SolidQueue::Processes
         end
       end
 
-      def run
-        raise NotImplementedError
-      end
-
       def shutting_down?
         stopped? || (running_as_fork? && supervisor_went_away?) || finished? || !registered?
       end

data/lib/solid_queue/supervisor/pidfile.rb

@@ -29,7 +29,7 @@ module SolidQueue
         else
           FileUtils.mkdir_p File.dirname(path)
         end
-      rescue Errno::ESRCH => e
+      rescue Errno::ESRCH
         # Process is dead, ignore, just delete the file
         delete
       rescue Errno::EPERM

data/lib/solid_queue/version.rb

@@ -1,3 +1,3 @@
 module SolidQueue
-  VERSION = "1.0.0.beta"
+  VERSION = "1.0.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: solid_queue
 version: !ruby/object:Gem::Version
-  version: 1.0.0.beta
+  version: 1.0.1
 platform: ruby
 authors:
 - Rosa Gutierrez
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-09-16 00:00:00.000000000 Z
+date: 2024-11-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord