solid_cable 3.0.8 → 3.0.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a0a720657c2026c2b54d9318eb7f9f66ed15b9d303d1c396c0328b9a5133a3c5
-  data.tar.gz: b73482b38813c809cfadcefc31ec0003f28000a9d911c41905f156dfe1e5cc94
+  metadata.gz: 1f58b4cc20ab57b3a84773c5e86cb01ff4a26cb2ab2ec0467db62d6d44a0cd34
+  data.tar.gz: ea3a3b978b731f2c8b8a6da3e565fdd3618276fad5ca0360e2583e8938ae2121
 SHA512:
-  metadata.gz: 8856d9432a9c81cc604133fdb7defe84c5f111454183e9ee4baf165ac4780bf04c88466187329fd591ccf215ee58014501ea197d525cfc065b7c1713454e3fdb
-  data.tar.gz: 5bc0f318209db0f1b981ef0e7ad0687a1c2af8ae515f9975b2cff46017265ce33243dafdf6d8f4524efb49737fb9adfb283328944e823943d7878a32f6a235a0
+  metadata.gz: d4e1abe347443f90c6e443721b3820910c567bfe8c7b8d6b4beb4f8849d2ad7816b7c334253215cf0668a7ecb672349ac2d5698ad6f3e55463734381ad442d18
+  data.tar.gz: e29b2151e8aeb9ce7b74f7f207f2777e1f83ca08eab200978b541d6bfeb87cbc281f0248357a115e1781f3b1439c5f862da7a66ae213ee719447e2998aeaa96f

data/README.md

@@ -1,6 +1,6 @@
 # Solid Cable
 
-Solid Cable is a database-backed Action Cable adapter that keeps messages in a table and continously polls for updates. This makes it possible to drop the common dependency on Redis, if it isn't needed for any other purpose. Despite polling, the performance of Solid Cable is comparable to Redis in most situations. And in all circumstances, it makes it easier to deploy Rails when Redis is no longer a required dependency for Action Cable functionality.
+Solid Cable is a database-backed Action Cable adapter that keeps messages in a table and continuously polls for updates. This makes it possible to drop the common dependency on Redis, if it isn't needed for any other purpose. Despite polling, the performance of Solid Cable is comparable to Redis in most situations. And in all circumstances, it makes it easier to deploy Rails when Redis is no longer a required dependency for Action Cable functionality.
 
 > [!NOTE]
 > Solid Cable is tested to work with MySQL, SQLite, and PostgreSQL.

data/app/models/solid_cable/message.rb

@@ -7,7 +7,7 @@ module SolidCable
     }
     scope :broadcastable, lambda { |channels, last_id|
       where(channel_hash: channel_hashes_for(channels)).
-        where(id: (last_id + 1)..).order(:id)
+        where(id: (last_id.to_i + 1)..).order(:id)
     }
 
     class << self

data/lib/action_cable/subscription_adapter/solid_cable.rb

@@ -89,7 +89,7 @@ module ActionCable
           end
 
           def add_channel(channel, on_success)
-            channels.add(channel)
+            channels[channel] = last_message_id
             event_loop.post(&on_success) if on_success
           end
 
@@ -103,21 +103,22 @@ module ActionCable
 
           private
             attr_reader :event_loop, :thread
-            attr_writer :last_id
 
-            def last_id
-              @last_id ||= ::SolidCable::Message.maximum(:id) || 0
+            def last_message_id
+              ::SolidCable::Message.maximum(:id) || 0
             end
 
             def channels
-              @channels ||= Set.new
+              @channels ||= Concurrent::Hash.new
             end
 
             def broadcast_messages
-              ::SolidCable::Message.broadcastable(channels, last_id).
+              ::SolidCable::Message.broadcastable(channels.keys, channels.values.min).
                 each do |message|
-                broadcast(message.channel, message.payload)
-                self.last_id = message.id
+                if channels[message.channel].present? && channels[message.channel] < message.id
+                  broadcast(message.channel, message.payload)
+                  channels[message.channel] = message.id
+                end
               end
             end
 
@@ -128,37 +129,6 @@ module ActionCable
                 yield
               end
             end
-
-            def wake_up
-              interrupt
-            end
-
-            SELF_PIPE_BLOCK_SIZE = 11
-
-            def interrupt
-              self_pipe[:writer].write_nonblock(".")
-            rescue Errno::EAGAIN, Errno::EINTR
-              # Ignore writes that would block and retry
-              # if another signal arrived while writing
-              retry
-            end
-
-            def interruptible_sleep(time)
-              if time > 0 && self_pipe[:reader].wait_readable(time)
-                loop { self_pipe[:reader].read_nonblock(SELF_PIPE_BLOCK_SIZE) }
-              end
-            rescue Errno::EAGAIN, Errno::EINTR
-            end
-
-            # Self-pipe for signal-handling (http://cr.yp.to/docs/selfpipe.html)
-            def self_pipe
-              @self_pipe ||= create_self_pipe
-            end
-
-            def create_self_pipe
-              reader, writer = IO.pipe
-              { reader: reader, writer: writer }
-            end
         end
     end
   end

data/lib/solid_cable/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SolidCable
-  VERSION = "3.0.8"
+  VERSION = "3.0.10"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: solid_cable
 version: !ruby/object:Gem::Version
-  version: 3.0.8
+  version: 3.0.10
 platform: ruby
 authors:
 - Nick Pezza
@@ -112,7 +112,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.8
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Database-backed Action Cable backend.
 test_files: []