solicit 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 239ba565f4a101f8d7e705663bba9e001c614854c40c24c4ed7ff9bf9da05896
-  data.tar.gz: 58a72e1639c8a440dedc7eed64d3bdf247017389505bf22992a26ddf1aefbe45
+  metadata.gz: 3c92629f063199635ccde07aba4584aacc9106d53cd7e910add1939cfc30fba0
+  data.tar.gz: 125cf7b47c20534a717be5574c99625b0490844b1de48dc35c8a64bfe38b36c2
 SHA512:
-  metadata.gz: 9f87726122bfcf127d144098f10bf5a3e617dd03ce242eefa375bc9ca6ec19b2c40c995e90ff654db5a26f4ff52b18c60ad9bf78a547fe1f7fec367c3e4140a2
-  data.tar.gz: bc47411a5692d44c2c0f1f0eeb8549c548258383773664dac274488d4547532700f3594c0d57543b9175b4962ab7752463ab89d2c635add48538986daa833ddd
+  metadata.gz: '034080a6aa99467cc4a200c87b8f6580917f6302b6e9d9ab328ebeae3c4d74548075e44205ed271116768d6bd23672bf5fdc2213406aca94d8b691590e2d3a76'
+  data.tar.gz: '0494515dfe1297ac1f658cd41f34020231da9016604ba81b8de7c18f084938aa737400798b1ff9326b785d71813239eeb7376fef8ee71e20b62e8f78d11a1521'

data/app/controllers/solicit/pull_requests_controller.rb

@@ -34,9 +34,11 @@ module Solicit
     end
 
     def ensure_can_notify
+      label = payload.dig(:label, :name).to_sym
       head :ok unless request_is_from_github? &&
                       payload[:action] == 'labeled' &&
-                      Solicit.labels_map.key?(payload.dig(:label, :name).to_sym) &&
+                      Solicit.labels_map.key?(label) &&
+                      Solicit.needs_more_assignees.call(payload.dig(:pull_request, :assignees), label) &&
                       payload.dig(:pull_request, :number) &&
                       payload.dig(:repository, :url)
     end

data/app/use_cases/solicit/post_to_slack.rb

@@ -1,22 +1,19 @@
 module Solicit
   class PostToSlack
-    attr_reader :text
-
     def initialize(url:, channel:, username:, payload:)
       @url      = url
       @channel  = channel
       @username = username
       @payload  = payload
-      @text     = I18n.t(:"engines.solicit.title", title_options)
     end
 
     def self.perform(*args)
-      new(*args).tap(&:perform)
+      new(*args).perform
     end
 
     def perform
       Slack::Notifier.new(@url, channel: @channel, username: @username).ping(
-        text: text,
+        text: I18n.t(:"engines.solicit.title", title_options),
         attachments: [{
           title: I18n.t(:"engines.solicit.review"),
           callback_id: callback_id,
@@ -30,10 +27,9 @@ module Solicit
 
     def title_options
       {
-        author: author_name,
-        link:   @payload.dig(:pull_request, :html_url),
-        title:  @payload.dig(:pull_request, :title),
-        label:  @payload.dig(:label, :name),
+        link: @payload.dig(:pull_request, :html_url),
+        title: @payload.dig(:pull_request, :title),
+        label: @payload.dig(:label, :name),
       }
     end
 
@@ -54,11 +50,5 @@ module Solicit
         value: @payload.dig(:label, :name),
       }
     end
-
-    def author_name
-      Solicit.contributors_map.detect do |_, value|
-        value[:handle] == @payload.dig(:sender, :login)
-      end&.dig(1, 'name') || I18n.t(:"engines.solicit.someone")
-    end
   end
 end

data/config/locales/en.yml

@@ -4,5 +4,4 @@ en:
       volunteer: "%{name} has volunteered! :%{emoji}:"
       claim:     "I'll do it!"
       review:    "Review this PR"
-      someone:   "Someone"
-      title:     "%{author} has added a %{label} label to a PR: <%{link}|%{title}>"
+      title:     "PR <%{link}|%{title}> now has a %{label} label!"

data/lib/solicit/version.rb

@@ -1,3 +1,3 @@
 module Solicit
-  VERSION = '0.1.1'.freeze
+  VERSION = "0.1.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: solicit
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Optimal Workshop
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-13 00:00:00.000000000 Z
+date: 2019-05-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -162,7 +162,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubyforge_project: 
+rubygems_version: 2.7.8
 signing_key: 
 specification_version: 4
 summary: Solicit reviewers for your github pull requests on Slack