solargraph 0.57.0 → 0.58.3

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (216) hide show
  1. checksums.yaml +4 -4
  2. data/.gitattributes +2 -0
  3. data/.github/workflows/linting.yml +4 -2
  4. data/.github/workflows/plugins.yml +63 -28
  5. data/.github/workflows/rspec.yml +19 -4
  6. data/.github/workflows/typecheck.yml +2 -2
  7. data/.gitignore +1 -0
  8. data/.rubocop.yml +1 -1
  9. data/.rubocop_todo.yml +90 -1438
  10. data/CHANGELOG.md +39 -0
  11. data/Rakefile +1 -1
  12. data/bin/solargraph +3 -0
  13. data/lib/solargraph/api_map/cache.rb +110 -110
  14. data/lib/solargraph/api_map/constants.rb +279 -218
  15. data/lib/solargraph/api_map/index.rb +193 -169
  16. data/lib/solargraph/api_map/source_to_yard.rb +97 -94
  17. data/lib/solargraph/api_map/store.rb +384 -374
  18. data/lib/solargraph/api_map.rb +945 -951
  19. data/lib/solargraph/bench.rb +45 -45
  20. data/lib/solargraph/complex_type/type_methods.rb +228 -223
  21. data/lib/solargraph/complex_type/unique_type.rb +482 -475
  22. data/lib/solargraph/complex_type.rb +444 -427
  23. data/lib/solargraph/convention/active_support_concern.rb +1 -1
  24. data/lib/solargraph/convention/data_definition/data_assignment_node.rb +61 -61
  25. data/lib/solargraph/convention/data_definition/data_definition_node.rb +91 -91
  26. data/lib/solargraph/convention/data_definition.rb +105 -105
  27. data/lib/solargraph/convention/gemfile.rb +15 -15
  28. data/lib/solargraph/convention/gemspec.rb +23 -23
  29. data/lib/solargraph/convention/rakefile.rb +17 -17
  30. data/lib/solargraph/convention/struct_definition/struct_assignment_node.rb +61 -61
  31. data/lib/solargraph/convention/struct_definition/struct_definition_node.rb +102 -102
  32. data/lib/solargraph/convention/struct_definition.rb +164 -164
  33. data/lib/solargraph/convention.rb +78 -78
  34. data/lib/solargraph/converters/dd.rb +17 -17
  35. data/lib/solargraph/converters/dl.rb +15 -15
  36. data/lib/solargraph/converters/dt.rb +15 -15
  37. data/lib/solargraph/converters/misc.rb +1 -1
  38. data/lib/solargraph/diagnostics/require_not_found.rb +53 -53
  39. data/lib/solargraph/diagnostics/rubocop.rb +118 -118
  40. data/lib/solargraph/diagnostics/rubocop_helpers.rb +68 -66
  41. data/lib/solargraph/diagnostics/type_check.rb +55 -55
  42. data/lib/solargraph/diagnostics/update_errors.rb +41 -41
  43. data/lib/solargraph/doc_map.rb +439 -436
  44. data/lib/solargraph/environ.rb +1 -1
  45. data/lib/solargraph/equality.rb +34 -33
  46. data/lib/solargraph/gem_pins.rb +98 -94
  47. data/lib/solargraph/language_server/error_codes.rb +20 -20
  48. data/lib/solargraph/language_server/host/diagnoser.rb +89 -89
  49. data/lib/solargraph/language_server/host/dispatch.rb +130 -130
  50. data/lib/solargraph/language_server/host/message_worker.rb +112 -112
  51. data/lib/solargraph/language_server/host/sources.rb +99 -99
  52. data/lib/solargraph/language_server/host.rb +878 -872
  53. data/lib/solargraph/language_server/message/base.rb +97 -97
  54. data/lib/solargraph/language_server/message/client/register_capability.rb +15 -15
  55. data/lib/solargraph/language_server/message/completion_item/resolve.rb +60 -60
  56. data/lib/solargraph/language_server/message/extended/check_gem_version.rb +114 -114
  57. data/lib/solargraph/language_server/message/extended/document.rb +23 -23
  58. data/lib/solargraph/language_server/message/extended/document_gems.rb +32 -32
  59. data/lib/solargraph/language_server/message/extended/download_core.rb +19 -19
  60. data/lib/solargraph/language_server/message/extended/search.rb +20 -20
  61. data/lib/solargraph/language_server/message/initialize.rb +191 -191
  62. data/lib/solargraph/language_server/message/text_document/completion.rb +56 -56
  63. data/lib/solargraph/language_server/message/text_document/definition.rb +40 -40
  64. data/lib/solargraph/language_server/message/text_document/document_highlight.rb +16 -16
  65. data/lib/solargraph/language_server/message/text_document/document_symbol.rb +26 -26
  66. data/lib/solargraph/language_server/message/text_document/formatting.rb +148 -145
  67. data/lib/solargraph/language_server/message/text_document/hover.rb +58 -58
  68. data/lib/solargraph/language_server/message/text_document/prepare_rename.rb +11 -11
  69. data/lib/solargraph/language_server/message/text_document/references.rb +16 -16
  70. data/lib/solargraph/language_server/message/text_document/rename.rb +19 -19
  71. data/lib/solargraph/language_server/message/text_document/signature_help.rb +24 -24
  72. data/lib/solargraph/language_server/message/text_document/type_definition.rb +25 -25
  73. data/lib/solargraph/language_server/message/workspace/did_change_configuration.rb +35 -35
  74. data/lib/solargraph/language_server/message/workspace/did_change_watched_files.rb +40 -40
  75. data/lib/solargraph/language_server/message/workspace/did_change_workspace_folders.rb +26 -26
  76. data/lib/solargraph/language_server/message/workspace/workspace_symbol.rb +23 -23
  77. data/lib/solargraph/language_server/message.rb +94 -94
  78. data/lib/solargraph/language_server/progress.rb +1 -1
  79. data/lib/solargraph/language_server/request.rb +27 -25
  80. data/lib/solargraph/language_server/transport/data_reader.rb +74 -74
  81. data/lib/solargraph/language_server/uri_helpers.rb +49 -49
  82. data/lib/solargraph/library.rb +683 -683
  83. data/lib/solargraph/location.rb +82 -81
  84. data/lib/solargraph/logging.rb +37 -37
  85. data/lib/solargraph/page.rb +92 -93
  86. data/lib/solargraph/parser/comment_ripper.rb +69 -69
  87. data/lib/solargraph/parser/flow_sensitive_typing.rb +255 -255
  88. data/lib/solargraph/parser/node_processor/base.rb +92 -92
  89. data/lib/solargraph/parser/node_processor.rb +62 -62
  90. data/lib/solargraph/parser/parser_gem/class_methods.rb +149 -159
  91. data/lib/solargraph/parser/parser_gem/flawed_builder.rb +19 -19
  92. data/lib/solargraph/parser/parser_gem/node_chainer.rb +166 -166
  93. data/lib/solargraph/parser/parser_gem/node_methods.rb +486 -499
  94. data/lib/solargraph/parser/parser_gem/node_processors/and_node.rb +22 -21
  95. data/lib/solargraph/parser/parser_gem/node_processors/args_node.rb +59 -59
  96. data/lib/solargraph/parser/parser_gem/node_processors/begin_node.rb +15 -15
  97. data/lib/solargraph/parser/parser_gem/node_processors/block_node.rb +46 -46
  98. data/lib/solargraph/parser/parser_gem/node_processors/def_node.rb +53 -53
  99. data/lib/solargraph/parser/parser_gem/node_processors/defs_node.rb +37 -37
  100. data/lib/solargraph/parser/parser_gem/node_processors/if_node.rb +23 -23
  101. data/lib/solargraph/parser/parser_gem/node_processors/ivasgn_node.rb +40 -40
  102. data/lib/solargraph/parser/parser_gem/node_processors/lvasgn_node.rb +29 -29
  103. data/lib/solargraph/parser/parser_gem/node_processors/masgn_node.rb +59 -59
  104. data/lib/solargraph/parser/parser_gem/node_processors/opasgn_node.rb +98 -42
  105. data/lib/solargraph/parser/parser_gem/node_processors/orasgn_node.rb +17 -17
  106. data/lib/solargraph/parser/parser_gem/node_processors/resbody_node.rb +38 -38
  107. data/lib/solargraph/parser/parser_gem/node_processors/sclass_node.rb +52 -43
  108. data/lib/solargraph/parser/parser_gem/node_processors/send_node.rb +291 -292
  109. data/lib/solargraph/parser/parser_gem/node_processors/until_node.rb +29 -29
  110. data/lib/solargraph/parser/parser_gem/node_processors/while_node.rb +29 -29
  111. data/lib/solargraph/parser/parser_gem/node_processors.rb +70 -70
  112. data/lib/solargraph/parser/parser_gem.rb +12 -12
  113. data/lib/solargraph/parser/region.rb +69 -69
  114. data/lib/solargraph/parser/snippet.rb +17 -17
  115. data/lib/solargraph/parser.rb +23 -23
  116. data/lib/solargraph/pin/base.rb +729 -708
  117. data/lib/solargraph/pin/base_variable.rb +126 -124
  118. data/lib/solargraph/pin/block.rb +104 -103
  119. data/lib/solargraph/pin/breakable.rb +9 -9
  120. data/lib/solargraph/pin/callable.rb +231 -227
  121. data/lib/solargraph/pin/closure.rb +72 -76
  122. data/lib/solargraph/pin/common.rb +79 -79
  123. data/lib/solargraph/pin/constant.rb +45 -45
  124. data/lib/solargraph/pin/conversions.rb +123 -123
  125. data/lib/solargraph/pin/delegated_method.rb +120 -121
  126. data/lib/solargraph/pin/documenting.rb +114 -114
  127. data/lib/solargraph/pin/instance_variable.rb +34 -34
  128. data/lib/solargraph/pin/keyword.rb +20 -20
  129. data/lib/solargraph/pin/local_variable.rb +75 -79
  130. data/lib/solargraph/pin/method.rb +672 -656
  131. data/lib/solargraph/pin/method_alias.rb +34 -34
  132. data/lib/solargraph/pin/namespace.rb +115 -115
  133. data/lib/solargraph/pin/parameter.rb +275 -271
  134. data/lib/solargraph/pin/proxy_type.rb +39 -36
  135. data/lib/solargraph/pin/reference/override.rb +47 -47
  136. data/lib/solargraph/pin/reference/superclass.rb +15 -15
  137. data/lib/solargraph/pin/reference.rb +39 -48
  138. data/lib/solargraph/pin/search.rb +61 -58
  139. data/lib/solargraph/pin/signature.rb +61 -61
  140. data/lib/solargraph/pin/symbol.rb +53 -53
  141. data/lib/solargraph/pin/until.rb +18 -18
  142. data/lib/solargraph/pin/while.rb +18 -18
  143. data/lib/solargraph/pin.rb +44 -44
  144. data/lib/solargraph/pin_cache.rb +245 -245
  145. data/lib/solargraph/position.rb +132 -118
  146. data/lib/solargraph/range.rb +112 -108
  147. data/lib/solargraph/rbs_map/conversions.rb +823 -802
  148. data/lib/solargraph/rbs_map/core_fills.rb +84 -66
  149. data/lib/solargraph/rbs_map/core_map.rb +58 -54
  150. data/lib/solargraph/rbs_map/stdlib_map.rb +43 -43
  151. data/lib/solargraph/rbs_map.rb +163 -163
  152. data/lib/solargraph/server_methods.rb +16 -16
  153. data/lib/solargraph/shell.rb +363 -271
  154. data/lib/solargraph/source/chain/array.rb +37 -37
  155. data/lib/solargraph/source/chain/call.rb +337 -333
  156. data/lib/solargraph/source/chain/class_variable.rb +13 -13
  157. data/lib/solargraph/source/chain/constant.rb +26 -89
  158. data/lib/solargraph/source/chain/global_variable.rb +13 -13
  159. data/lib/solargraph/source/chain/hash.rb +34 -34
  160. data/lib/solargraph/source/chain/if.rb +28 -28
  161. data/lib/solargraph/source/chain/instance_variable.rb +13 -13
  162. data/lib/solargraph/source/chain/link.rb +109 -109
  163. data/lib/solargraph/source/chain/literal.rb +48 -48
  164. data/lib/solargraph/source/chain/or.rb +23 -23
  165. data/lib/solargraph/source/chain/q_call.rb +11 -11
  166. data/lib/solargraph/source/chain/variable.rb +13 -13
  167. data/lib/solargraph/source/chain/z_super.rb +30 -30
  168. data/lib/solargraph/source/chain.rb +291 -289
  169. data/lib/solargraph/source/change.rb +82 -82
  170. data/lib/solargraph/source/cursor.rb +166 -166
  171. data/lib/solargraph/source/encoding_fixes.rb +23 -23
  172. data/lib/solargraph/source/source_chainer.rb +194 -194
  173. data/lib/solargraph/source/updater.rb +55 -55
  174. data/lib/solargraph/source.rb +498 -498
  175. data/lib/solargraph/source_map/clip.rb +226 -234
  176. data/lib/solargraph/source_map/data.rb +34 -34
  177. data/lib/solargraph/source_map/mapper.rb +259 -261
  178. data/lib/solargraph/source_map.rb +212 -207
  179. data/lib/solargraph/type_checker/checks.rb +124 -124
  180. data/lib/solargraph/type_checker/param_def.rb +37 -37
  181. data/lib/solargraph/type_checker/problem.rb +32 -32
  182. data/lib/solargraph/type_checker/rules.rb +84 -70
  183. data/lib/solargraph/type_checker.rb +814 -752
  184. data/lib/solargraph/version.rb +5 -5
  185. data/lib/solargraph/workspace/config.rb +255 -237
  186. data/lib/solargraph/workspace/require_paths.rb +97 -98
  187. data/lib/solargraph/workspace.rb +220 -225
  188. data/lib/solargraph/yard_map/helpers.rb +44 -44
  189. data/lib/solargraph/yard_map/mapper/to_method.rb +130 -129
  190. data/lib/solargraph/yard_map/mapper/to_namespace.rb +31 -30
  191. data/lib/solargraph/yard_map/mapper.rb +79 -79
  192. data/lib/solargraph/yard_map/to_method.rb +89 -88
  193. data/lib/solargraph/yard_tags.rb +20 -20
  194. data/lib/solargraph/yardoc.rb +87 -64
  195. data/lib/solargraph.rb +105 -105
  196. data/rbs/fills/bundler/0/bundler.rbs +4271 -0
  197. data/rbs/fills/open3/0/open3.rbs +172 -0
  198. data/rbs/fills/rubygems/0/basic_specification.rbs +326 -0
  199. data/rbs/fills/rubygems/0/errors.rbs +364 -0
  200. data/rbs/fills/rubygems/0/spec_fetcher.rbs +107 -0
  201. data/rbs/fills/rubygems/0/specification.rbs +1753 -0
  202. data/rbs/shims/ast/0/node.rbs +5 -0
  203. data/rbs/shims/ast/2.4/.rbs_meta.yaml +9 -0
  204. data/rbs/shims/ast/2.4/ast.rbs +73 -0
  205. data/rbs/shims/parser/3.2.0.1/manifest.yaml +7 -0
  206. data/rbs/shims/parser/3.2.0.1/parser.rbs +201 -0
  207. data/rbs/shims/parser/3.2.0.1/polyfill.rbs +4 -0
  208. data/rbs_collection.yaml +4 -4
  209. data/solargraph.gemspec +15 -4
  210. metadata +71 -16
  211. data/lib/solargraph/parser/node_methods.rb +0 -97
  212. /data/rbs/fills/{tuple.rbs → tuple/tuple.rbs} +0 -0
  213. /data/{sig → rbs}/shims/parser/3.2.0.1/builders/default.rbs +0 -0
  214. /data/{sig → rbs}/shims/thor/1.2.0.1/.rbs_meta.yaml +0 -0
  215. /data/{sig → rbs}/shims/thor/1.2.0.1/manifest.yaml +0 -0
  216. /data/{sig → rbs}/shims/thor/1.2.0.1/thor.rbs +0 -0
@@ -1,752 +1,814 @@
1
- # frozen_string_literal: true
2
-
3
- module Solargraph
4
- # A static analysis tool for validating data types.
5
- #
6
- class TypeChecker
7
- autoload :Problem, 'solargraph/type_checker/problem'
8
- autoload :ParamDef, 'solargraph/type_checker/param_def'
9
- autoload :Rules, 'solargraph/type_checker/rules'
10
- autoload :Checks, 'solargraph/type_checker/checks'
11
-
12
- include Checks
13
- include Parser::NodeMethods
14
-
15
- # @return [String]
16
- attr_reader :filename
17
-
18
- # @return [Rules]
19
- attr_reader :rules
20
-
21
- # @return [ApiMap]
22
- attr_reader :api_map
23
-
24
- # @param filename [String]
25
- # @param api_map [ApiMap, nil]
26
- # @param level [Symbol]
27
- def initialize filename, api_map: nil, level: :normal
28
- @filename = filename
29
- # @todo Smarter directory resolution
30
- @api_map = api_map || Solargraph::ApiMap.load(File.dirname(filename))
31
- @rules = Rules.new(level)
32
- # @type [Array<Range>]
33
- @marked_ranges = []
34
- end
35
-
36
- # @return [SourceMap]
37
- def source_map
38
- @source_map ||= api_map.source_map(filename)
39
- end
40
-
41
- # @return [Source]
42
- def source
43
- @source_map.source
44
- end
45
-
46
- # @return [Array<Problem>]
47
- def problems
48
- @problems ||= begin
49
- all = method_tag_problems
50
- .concat(variable_type_tag_problems)
51
- .concat(const_problems)
52
- .concat(call_problems)
53
- unignored = without_ignored(all)
54
- unignored.concat(unneeded_sgignore_problems)
55
- end
56
- end
57
-
58
- class << self
59
- # @param filename [String]
60
- # @param level [Symbol]
61
- # @return [self]
62
- def load filename, level = :normal
63
- source = Solargraph::Source.load(filename)
64
- api_map = Solargraph::ApiMap.new
65
- api_map.map(source)
66
- new(filename, api_map: api_map, level: level)
67
- end
68
-
69
- # @param code [String]
70
- # @param filename [String, nil]
71
- # @param level [Symbol]
72
- # @return [self]
73
- def load_string code, filename = nil, level = :normal
74
- source = Solargraph::Source.load_string(code, filename)
75
- api_map = Solargraph::ApiMap.new
76
- api_map.map(source)
77
- new(filename, api_map: api_map, level: level)
78
- end
79
- end
80
-
81
- private
82
-
83
- # @return [Array<Problem>]
84
- def method_tag_problems
85
- result = []
86
- # @param pin [Pin::Method]
87
- source_map.pins_by_class(Pin::Method).each do |pin|
88
- result.concat method_return_type_problems_for(pin)
89
- result.concat method_param_type_problems_for(pin)
90
- end
91
- result
92
- end
93
-
94
- # @param pin [Pin::Method]
95
- # @return [Array<Problem>]
96
- def method_return_type_problems_for pin
97
- return [] if pin.is_a?(Pin::MethodAlias)
98
- result = []
99
- declared = pin.typify(api_map).self_to_type(pin.full_context).qualify(api_map, pin.full_context.tag)
100
- if declared.undefined?
101
- if pin.return_type.undefined? && rules.require_type_tags?
102
- if pin.attribute?
103
- inferred = pin.probe(api_map).self_to_type(pin.full_context)
104
- result.push Problem.new(pin.location, "Missing @return tag for #{pin.path}", pin: pin) unless inferred.defined?
105
- else
106
- result.push Problem.new(pin.location, "Missing @return tag for #{pin.path}", pin: pin)
107
- end
108
- elsif pin.return_type.defined? && !resolved_constant?(pin)
109
- result.push Problem.new(pin.location, "Unresolved return type #{pin.return_type} for #{pin.path}", pin: pin)
110
- elsif rules.must_tag_or_infer? && pin.probe(api_map).undefined?
111
- result.push Problem.new(pin.location, "Untyped method #{pin.path} could not be inferred")
112
- end
113
- elsif rules.validate_tags?
114
- unless pin.node.nil? || declared.void? || virtual_pin?(pin) || abstract?(pin)
115
- inferred = pin.probe(api_map).self_to_type(pin.full_context)
116
- if inferred.undefined?
117
- unless rules.ignore_all_undefined? || external?(pin)
118
- result.push Problem.new(pin.location, "#{pin.path} return type could not be inferred", pin: pin)
119
- end
120
- else
121
- unless (rules.require_all_return_types_match_inferred? ? all_types_match?(api_map, inferred, declared) : any_types_match?(api_map, declared, inferred))
122
- result.push Problem.new(pin.location, "Declared return type #{declared.rooted_tags} does not match inferred type #{inferred.rooted_tags} for #{pin.path}", pin: pin)
123
- end
124
- end
125
- end
126
- end
127
- result
128
- end
129
-
130
- # @todo This is not optimal. A better solution would probably be to mix
131
- # namespace alias into types at the ApiMap level.
132
- #
133
- # @param pin [Pin::Base]
134
- # @return [Boolean]
135
- def resolved_constant? pin
136
- return true if pin.typify(api_map).defined?
137
- constant_pins = api_map.get_constants('', *pin.closure.gates)
138
- .select { |p| p.name == pin.return_type.namespace }
139
- return true if constant_pins.find { |p| p.typify(api_map).defined? }
140
- # will need to probe when a constant name is assigned to a
141
- # class/module (alias)
142
- return true if constant_pins.find { |p| p.probe(api_map).defined? }
143
- false
144
- end
145
-
146
- # @param pin [Pin::Base]
147
- def virtual_pin? pin
148
- pin.location && source.comment_at?(pin.location.range.ending)
149
- end
150
-
151
- # @param pin [Pin::Method]
152
- # @return [Array<Problem>]
153
- def method_param_type_problems_for pin
154
- stack = api_map.get_method_stack(pin.namespace, pin.name, scope: pin.scope)
155
- params = first_param_hash(stack)
156
- result = []
157
- if rules.require_type_tags?
158
- pin.signatures.each do |sig|
159
- sig.parameters.each do |par|
160
- break if par.decl == :restarg || par.decl == :kwrestarg || par.decl == :blockarg
161
- unless params[par.name]
162
- if pin.attribute?
163
- inferred = pin.probe(api_map).self_to_type(pin.full_context)
164
- if inferred.undefined?
165
- result.push Problem.new(pin.location, "Missing @param tag for #{par.name} on #{pin.path}", pin: pin)
166
- end
167
- else
168
- result.push Problem.new(pin.location, "Missing @param tag for #{par.name} on #{pin.path}", pin: pin)
169
- end
170
- end
171
- end
172
- end
173
- end
174
- # @todo Should be able to probe type of name and data here
175
- # @param name [String]
176
- # @param data [Hash{Symbol => BasicObject}]
177
- params.each_pair do |name, data|
178
- # @type [ComplexType]
179
- type = data[:qualified]
180
- if type.undefined?
181
- result.push Problem.new(pin.location, "Unresolved type #{data[:tagged]} for #{name} param on #{pin.path}", pin: pin)
182
- end
183
- end
184
- result
185
- end
186
-
187
- # @return [Array<Pin::Base>]
188
- def ignored_pins
189
- @ignored_pins ||= []
190
- end
191
-
192
- # @return [Array<Problem>]
193
- def variable_type_tag_problems
194
- result = []
195
- all_variables.each do |pin|
196
- if pin.return_type.defined?
197
- declared = pin.typify(api_map)
198
- next if declared.duck_type?
199
- if declared.defined?
200
- if rules.validate_tags?
201
- inferred = pin.probe(api_map)
202
- if inferred.undefined?
203
- next if rules.ignore_all_undefined?
204
- if declared_externally?(pin)
205
- ignored_pins.push pin
206
- else
207
- result.push Problem.new(pin.location, "Variable type could not be inferred for #{pin.name}", pin: pin)
208
- end
209
- else
210
- unless any_types_match?(api_map, declared, inferred)
211
- result.push Problem.new(pin.location, "Declared type #{declared} does not match inferred type #{inferred} for variable #{pin.name}", pin: pin)
212
- end
213
- end
214
- elsif declared_externally?(pin)
215
- ignored_pins.push pin
216
- end
217
- elsif !pin.is_a?(Pin::Parameter) && !resolved_constant?(pin)
218
- result.push Problem.new(pin.location, "Unresolved type #{pin.return_type} for variable #{pin.name}", pin: pin)
219
- end
220
- else
221
- inferred = pin.probe(api_map)
222
- if inferred.undefined? && declared_externally?(pin)
223
- ignored_pins.push pin
224
- end
225
- end
226
- end
227
- result
228
- end
229
-
230
- # @return [Array<Pin::BaseVariable>]
231
- def all_variables
232
- source_map.pins_by_class(Pin::BaseVariable) + source_map.locals.select { |pin| pin.is_a?(Pin::LocalVariable) }
233
- end
234
-
235
- # @return [Array<Problem>]
236
- def const_problems
237
- return [] unless rules.validate_consts?
238
- result = []
239
- Solargraph::Parser::NodeMethods.const_nodes_from(source.node).each do |const|
240
- rng = Solargraph::Range.from_node(const)
241
- chain = Solargraph::Parser.chain(const, filename)
242
- block_pin = source_map.locate_block_pin(rng.start.line, rng.start.column)
243
- location = Location.new(filename, rng)
244
- locals = source_map.locals_at(location)
245
- pins = chain.define(api_map, block_pin, locals)
246
- if pins.empty?
247
- result.push Problem.new(location, "Unresolved constant #{Solargraph::Parser::NodeMethods.unpack_name(const)}")
248
- @marked_ranges.push location.range
249
- end
250
- end
251
- result
252
- end
253
-
254
- # @return [Array<Problem>]
255
- def call_problems
256
- result = []
257
- Solargraph::Parser::NodeMethods.call_nodes_from(source.node).each do |call|
258
- rng = Solargraph::Range.from_node(call)
259
- next if @marked_ranges.any? { |d| d.contain?(rng.start) }
260
- chain = Solargraph::Parser.chain(call, filename)
261
- block_pin = source_map.locate_block_pin(rng.start.line, rng.start.column)
262
- location = Location.new(filename, rng)
263
- locals = source_map.locals_at(location)
264
- type = chain.infer(api_map, block_pin, locals)
265
- if type.undefined? && !rules.ignore_all_undefined?
266
- base = chain
267
- missing = chain
268
- found = nil
269
- closest = ComplexType::UNDEFINED
270
- until base.links.first.undefined?
271
- found = base.define(api_map, block_pin, locals).first
272
- break if found
273
- missing = base
274
- base = base.base
275
- end
276
- closest = found.typify(api_map) if found
277
- # @todo remove the internal_or_core? check at a higher-than-strict level
278
- if !found || found.is_a?(Pin::BaseVariable) || (closest.defined? && internal_or_core?(found))
279
- unless closest.generic? || ignored_pins.include?(found)
280
- if closest.defined?
281
- result.push Problem.new(location, "Unresolved call to #{missing.links.last.word} on #{closest}")
282
- else
283
- result.push Problem.new(location, "Unresolved call to #{missing.links.last.word}")
284
- end
285
- @marked_ranges.push rng
286
- end
287
- end
288
- end
289
- result.concat argument_problems_for(chain, api_map, block_pin, locals, location)
290
- end
291
- result
292
- end
293
-
294
- # @param chain [Solargraph::Source::Chain]
295
- # @param api_map [Solargraph::ApiMap]
296
- # @param closure_pin [Solargraph::Pin::Closure]
297
- # @param locals [Array<Solargraph::Pin::Base>]
298
- # @param location [Solargraph::Location]
299
- # @return [Array<Problem>]
300
- def argument_problems_for chain, api_map, closure_pin, locals, location
301
- result = []
302
- base = chain
303
- # @type last_base_link [Solargraph::Source::Chain::Call]
304
- last_base_link = base.links.last
305
- return [] unless last_base_link.is_a?(Solargraph::Source::Chain::Call)
306
-
307
- arguments = last_base_link.arguments
308
-
309
- pins = base.define(api_map, closure_pin, locals)
310
-
311
- first_pin = pins.first
312
- unresolvable = first_pin.is_a?(Pin::DelegatedMethod) && !first_pin.resolvable?(api_map)
313
- if !unresolvable && first_pin.is_a?(Pin::Method)
314
- # @type [Pin::Method]
315
- pin = first_pin
316
- ap = if base.links.last.is_a?(Solargraph::Source::Chain::ZSuper)
317
- arity_problems_for(pin, fake_args_for(closure_pin), location)
318
- elsif pin.path == 'Class#new'
319
- fqns = if base.links.one?
320
- closure_pin.namespace
321
- else
322
- base.base.infer(api_map, closure_pin, locals).namespace
323
- end
324
- init = api_map.get_method_stack(fqns, 'initialize').first
325
-
326
- init ? arity_problems_for(init, arguments, location) : []
327
- else
328
- arity_problems_for(pin, arguments, location)
329
- end
330
- return ap unless ap.empty?
331
- return [] if !rules.validate_calls? || base.links.first.is_a?(Solargraph::Source::Chain::ZSuper)
332
-
333
- params = first_param_hash(pins)
334
-
335
- all_errors = []
336
- pin.signatures.sort { |sig| sig.parameters.length }.each do |sig|
337
- signature_errors = signature_argument_problems_for location, locals, closure_pin, params, arguments, sig, pin
338
- if signature_errors.empty?
339
- # we found a signature that works - meaning errors from
340
- # other signatures don't matter.
341
- return []
342
- end
343
- all_errors.concat signature_errors
344
- end
345
- result.concat all_errors
346
- end
347
- result
348
- end
349
-
350
- # @param location [Location]
351
- # @param locals [Array<Pin::LocalVariable>]
352
- # @param closure_pin [Pin::Closure]
353
- # @param params [Hash{String => Hash{Symbol => String, Solargraph::ComplexType}}]
354
- # @param arguments [Array<Source::Chain>]
355
- # @param sig [Pin::Signature]
356
- # @param pin [Pin::Method]
357
- # @param pins [Array<Pin::Method>]
358
- #
359
- # @return [Array<Problem>]
360
- def signature_argument_problems_for location, locals, closure_pin, params, arguments, sig, pin
361
- errors = []
362
- # @todo add logic mapping up restarg parameters with
363
- # arguments (including restarg arguments). Use tuples
364
- # when possible, and when not, ensure provably
365
- # incorrect situations are detected.
366
- sig.parameters.each_with_index do |par, idx|
367
- return errors if par.decl == :restarg # bail out and assume the rest is valid pending better arg processing
368
- argchain = arguments[idx]
369
- if argchain.nil?
370
- if par.decl == :arg
371
- final_arg = arguments.last
372
- if final_arg && final_arg.node.type == :splat
373
- argchain = final_arg
374
- return errors
375
- else
376
- errors.push Problem.new(location, "Not enough arguments to #{pin.path}")
377
- end
378
- else
379
- final_arg = arguments.last
380
- argchain = final_arg if final_arg && [:kwsplat, :hash].include?(final_arg.node.type)
381
- end
382
- end
383
- if argchain
384
- if par.decl != :arg
385
- errors.concat kwarg_problems_for sig, argchain, api_map, closure_pin, locals, location, pin, params, idx
386
- next
387
- else
388
- if argchain.node.type == :splat && argchain == arguments.last
389
- final_arg = argchain
390
- end
391
- if (final_arg && final_arg.node.type == :splat)
392
- # The final argument given has been seen and was a
393
- # splat, which doesn't give us useful types or
394
- # arities against positional parameters, so let's
395
- # continue on in case there are any required
396
- # kwargs we should warn about
397
- next
398
- end
399
- if argchain.node.type == :splat && par != sig.parameters.last
400
- # we have been given a splat and there are more
401
- # arguments to come.
402
-
403
- # @todo Improve this so that we can skip past the
404
- # rest of the positional parameters here but still
405
- # process the kwargs
406
- return errors
407
- end
408
- ptype = params.key?(par.name) ? params[par.name][:qualified] : ComplexType::UNDEFINED
409
- ptype = ptype.self_to_type(par.context)
410
- if ptype.nil?
411
- # @todo Some level (strong, I guess) should require the param here
412
- else
413
- argtype = argchain.infer(api_map, closure_pin, locals)
414
- if argtype.defined? && ptype.defined? && !any_types_match?(api_map, ptype, argtype)
415
- errors.push Problem.new(location, "Wrong argument type for #{pin.path}: #{par.name} expected #{ptype}, received #{argtype}")
416
- return errors
417
- end
418
- end
419
- end
420
- elsif par.decl == :kwarg
421
- errors.push Problem.new(location, "Call to #{pin.path} is missing keyword argument #{par.name}")
422
- next
423
- end
424
- end
425
- errors
426
- end
427
-
428
- # @param sig [Pin::Signature]
429
- # @param argchain [Source::Chain]
430
- # @param api_map [ApiMap]
431
- # @param block_pin [Pin::Block]
432
- # @param locals [Array<Pin::LocalVariable>]
433
- # @param location [Location]
434
- # @param pin [Pin::Method]
435
- # @param params [Hash{String => Hash{Symbol => String, Solargraph::ComplexType}}]
436
- # @param idx [Integer]
437
- #
438
- # @return [Array<Problem>]
439
- def kwarg_problems_for sig, argchain, api_map, block_pin, locals, location, pin, params, idx
440
- result = []
441
- kwargs = convert_hash(argchain.node)
442
- par = sig.parameters[idx]
443
- argchain = kwargs[par.name.to_sym]
444
- if par.decl == :kwrestarg || (par.decl == :optarg && idx == pin.parameters.length - 1 && par.asgn_code == '{}')
445
- result.concat kwrestarg_problems_for(api_map, block_pin, locals, location, pin, params, kwargs)
446
- else
447
- if argchain
448
- data = params[par.name]
449
- if data.nil?
450
- # @todo Some level (strong, I guess) should require the param here
451
- else
452
- ptype = data[:qualified]
453
- unless ptype.undefined?
454
- argtype = argchain.infer(api_map, block_pin, locals)
455
- if argtype.defined? && ptype && !any_types_match?(api_map, ptype, argtype)
456
- result.push Problem.new(location, "Wrong argument type for #{pin.path}: #{par.name} expected #{ptype}, received #{argtype}")
457
- end
458
- end
459
- end
460
- elsif par.decl == :kwarg
461
- result.push Problem.new(location, "Call to #{pin.path} is missing keyword argument #{par.name}")
462
- end
463
- end
464
- result
465
- end
466
-
467
- # @param api_map [ApiMap]
468
- # @param block_pin [Pin::Block]
469
- # @param locals [Array<Pin::LocalVariable>]
470
- # @param location [Location]
471
- # @param pin [Pin::Method]
472
- # @param params [Hash{String => [nil, Hash]}]
473
- # @param kwargs [Hash{Symbol => Source::Chain}]
474
- # @return [Array<Problem>]
475
- def kwrestarg_problems_for(api_map, block_pin, locals, location, pin, params, kwargs)
476
- result = []
477
- kwargs.each_pair do |pname, argchain|
478
- next unless params.key?(pname.to_s)
479
- ptype = params[pname.to_s][:qualified]
480
- argtype = argchain.infer(api_map, block_pin, locals)
481
- if argtype.defined? && ptype && !any_types_match?(api_map, ptype, argtype)
482
- result.push Problem.new(location, "Wrong argument type for #{pin.path}: #{pname} expected #{ptype}, received #{argtype}")
483
- end
484
- end
485
- result
486
- end
487
-
488
- # @param pin [Pin::Method]
489
- # @return [Hash{String => Hash{Symbol => String, ComplexType}}]
490
- def param_hash(pin)
491
- # @type [Hash{String => Hash{Symbol => String, ComplexType}}]
492
- result = {}
493
- pin.parameters.each do |param|
494
- type = param.typify(api_map)
495
- next if type.nil? || type.undefined?
496
- result[param.name.to_s] = {
497
- tagged: type.tags,
498
- qualified: type
499
- }
500
- end
501
- # see if we have additional tags to pay attention to from YARD -
502
- # e.g., kwargs in a **restkwargs splat
503
- tags = pin.docstring.tags(:param)
504
- tags.each do |tag|
505
- next if result.key? tag.name.to_s
506
- next if tag.types.nil?
507
- result[tag.name.to_s] = {
508
- tagged: tag.types.join(', '),
509
- qualified: Solargraph::ComplexType.try_parse(*tag.types).qualify(api_map, pin.full_context.namespace)
510
- }
511
- end
512
- result
513
- end
514
-
515
- # @param pins [Array<Pin::Method>]
516
- # @return [Hash{String => Hash{Symbol => String, ComplexType}}]
517
- def first_param_hash(pins)
518
- return {} if pins.empty?
519
- first_pin_type = pins.first.typify(api_map)
520
- first_pin = pins.first.proxy first_pin_type
521
- param_names = first_pin.parameter_names
522
- results = param_hash(first_pin)
523
- pins[1..].each do |pin|
524
- # @todo this assignment from parametric use of Hash should not lose its generic
525
- # @type [Hash{String => Hash{Symbol => BasicObject}}]
526
-
527
- # documentation of types in superclasses should fail back to
528
- # subclasses if the subclass hasn't documented something
529
- superclass_results = param_hash(pin)
530
- superclass_results.each do |param_name, details|
531
- next unless param_names.include?(param_name)
532
-
533
- results[param_name] ||= {}
534
- results[param_name][:tagged] ||= details[:tagged]
535
- results[param_name][:qualified] ||= details[:qualified]
536
- end
537
- end
538
- results
539
- end
540
-
541
- # @param pin [Pin::Base]
542
- def internal? pin
543
- return false if pin.nil?
544
- pin.location && api_map.bundled?(pin.location.filename)
545
- end
546
-
547
- # True if the pin is either internal (part of the workspace) or from the core/stdlib
548
- # @param pin [Pin::Base]
549
- def internal_or_core? pin
550
- # @todo RBS pins are not necessarily core/stdlib pins
551
- internal?(pin) || pin.source == :rbs
552
- end
553
-
554
- # @param pin [Pin::Base]
555
- def external? pin
556
- !internal? pin
557
- end
558
-
559
- # @param pin [Pin::BaseVariable]
560
- def declared_externally? pin
561
- return true if pin.assignment.nil?
562
- chain = Solargraph::Parser.chain(pin.assignment, filename)
563
- rng = Solargraph::Range.from_node(pin.assignment)
564
- block_pin = source_map.locate_block_pin(rng.start.line, rng.start.column)
565
- location = Location.new(filename, Range.from_node(pin.assignment))
566
- locals = source_map.locals_at(location)
567
- type = chain.infer(api_map, block_pin, locals)
568
- if type.undefined? && !rules.ignore_all_undefined?
569
- base = chain
570
- missing = chain
571
- found = nil
572
- closest = ComplexType::UNDEFINED
573
- until base.links.first.undefined?
574
- found = base.define(api_map, block_pin, locals).first
575
- break if found
576
- missing = base
577
- base = base.base
578
- end
579
- closest = found.typify(api_map) if found
580
- if !found || closest.defined? || internal?(found)
581
- return false
582
- end
583
- end
584
- true
585
- end
586
-
587
- # @param pin [Pin::Method]
588
- # @param arguments [Array<Source::Chain>]
589
- # @param location [Location]
590
- # @return [Array<Problem>]
591
- def arity_problems_for pin, arguments, location
592
- results = pin.signatures.map do |sig|
593
- r = parameterized_arity_problems_for(pin, sig.parameters, arguments, location)
594
- return [] if r.empty?
595
- r
596
- end
597
- results.first
598
- end
599
-
600
- # @param pin [Pin::Method]
601
- # @param parameters [Array<Pin::Parameter>]
602
- # @param arguments [Array<Source::Chain>]
603
- # @param location [Location]
604
- # @return [Array<Problem>]
605
- def parameterized_arity_problems_for(pin, parameters, arguments, location)
606
- return [] unless pin.explicit?
607
- return [] if parameters.empty? && arguments.empty?
608
- return [] if pin.anon_splat?
609
- unchecked = arguments.dup # creates copy of and unthaws array
610
- add_params = 0
611
- if unchecked.empty? && parameters.any? { |param| param.decl == :kwarg }
612
- return [Problem.new(location, "Missing keyword arguments to #{pin.path}")]
613
- end
614
- settled_kwargs = 0
615
- unless unchecked.empty?
616
- if any_splatted_call?(unchecked.map(&:node))
617
- settled_kwargs = parameters.count(&:keyword?)
618
- else
619
- kwargs = convert_hash(unchecked.last.node)
620
- if parameters.any? { |param| [:kwarg, :kwoptarg].include?(param.decl) || param.kwrestarg? }
621
- if kwargs.empty?
622
- add_params += 1
623
- else
624
- unchecked.pop
625
- parameters.each do |param|
626
- next unless param.keyword?
627
- if kwargs.key?(param.name.to_sym)
628
- kwargs.delete param.name.to_sym
629
- settled_kwargs += 1
630
- elsif param.decl == :kwarg
631
- last_arg_last_link = arguments.last.links.last
632
- return [] if last_arg_last_link.is_a?(Solargraph::Source::Chain::Hash) && last_arg_last_link.splatted?
633
- return [Problem.new(location, "Missing keyword argument #{param.name} to #{pin.path}")]
634
- end
635
- end
636
- kwargs.clear if parameters.any?(&:kwrestarg?)
637
- unless kwargs.empty?
638
- return [Problem.new(location, "Unrecognized keyword argument #{kwargs.keys.first} to #{pin.path}")]
639
- end
640
- end
641
- end
642
- end
643
- end
644
- req = required_param_count(parameters)
645
- if req + add_params < unchecked.length
646
- return [] if parameters.any?(&:rest?)
647
- opt = optional_param_count(parameters)
648
- return [] if unchecked.length <= req + opt
649
- if req + add_params + 1 == unchecked.length && any_splatted_call?(unchecked.map(&:node)) && (parameters.map(&:decl) & [:kwarg, :kwoptarg, :kwrestarg]).any?
650
- return []
651
- end
652
- return [] if arguments.length - req == parameters.select { |p| [:optarg, :kwoptarg].include?(p.decl) }.length
653
- return [Problem.new(location, "Too many arguments to #{pin.path}")]
654
- elsif unchecked.length < req - settled_kwargs && (arguments.empty? || (!arguments.last.splat? && !arguments.last.links.last.is_a?(Solargraph::Source::Chain::Hash)))
655
- # HACK: Kernel#raise signature is incorrect in Ruby 2.7 core docs.
656
- # See https://github.com/castwide/solargraph/issues/418
657
- unless arguments.empty? && pin.path == 'Kernel#raise'
658
- return [Problem.new(location, "Not enough arguments to #{pin.path}")]
659
- end
660
- end
661
- []
662
- end
663
-
664
- # @param parameters [Enumerable<Pin::Parameter>]
665
- # @todo need to use generic types in method to choose correct
666
- # signature and generate Integer as return type
667
- # @return [Integer]
668
- def required_param_count(parameters)
669
- parameters.sum { |param| %i[arg kwarg].include?(param.decl) ? 1 : 0 }
670
- end
671
-
672
- # @param parameters [Enumerable<Pin::Parameter>]
673
- # @param pin [Pin::Method]
674
- # @return [Integer]
675
- def optional_param_count(parameters)
676
- parameters.select { |p| p.decl == :optarg }.length
677
- end
678
-
679
- # @param pin [Pin::Method]
680
- def abstract? pin
681
- pin.docstring.has_tag?('abstract') ||
682
- (pin.closure && pin.closure.docstring.has_tag?('abstract'))
683
- end
684
-
685
- # @param pin [Pin::Method]
686
- # @return [Array<Source::Chain>]
687
- def fake_args_for(pin)
688
- args = []
689
- with_opts = false
690
- with_block = false
691
- pin.parameters.each do |pin|
692
- if [:kwarg, :kwoptarg, :kwrestarg].include?(pin.decl)
693
- with_opts = true
694
- elsif pin.decl == :block
695
- with_block = true
696
- elsif pin.decl == :restarg
697
- args.push Solargraph::Source::Chain.new([Solargraph::Source::Chain::Variable.new(pin.name)], nil, true)
698
- else
699
- args.push Solargraph::Source::Chain.new([Solargraph::Source::Chain::Variable.new(pin.name)])
700
- end
701
- end
702
- args.push Solargraph::Parser.chain_string('{}') if with_opts
703
- args.push Solargraph::Parser.chain_string('&') if with_block
704
- args
705
- end
706
-
707
- # @return [Set<Integer>]
708
- def sg_ignore_lines_processed
709
- @sg_ignore_lines_processed ||= Set.new
710
- end
711
-
712
- # @return [Set<Integer>]
713
- def all_sg_ignore_lines
714
- source.associated_comments.select do |_line, text|
715
- text.include?('@sg-ignore')
716
- end.keys.to_set
717
- end
718
-
719
- # @return [Array<Integer>]
720
- def unprocessed_sg_ignore_lines
721
- (all_sg_ignore_lines - sg_ignore_lines_processed).to_a.sort
722
- end
723
-
724
- # @return [Array<Problem>]
725
- def unneeded_sgignore_problems
726
- return [] unless rules.validate_sg_ignores?
727
-
728
- unprocessed_sg_ignore_lines.map do |line|
729
- Problem.new(
730
- Location.new(filename, Range.from_to(line, 0, line, 0)),
731
- 'Unneeded @sg-ignore comment'
732
- )
733
- end
734
- end
735
-
736
- # @param problems [Array<Problem>]
737
- # @return [Array<Problem>]
738
- def without_ignored problems
739
- problems.reject do |problem|
740
- node = source.node_at(problem.location.range.start.line, problem.location.range.start.column)
741
- ignored = node && source.comments_for(node)&.include?('@sg-ignore')
742
- unless !ignored || all_sg_ignore_lines.include?(problem.location.range.start.line)
743
- # :nocov:
744
- Solargraph.assert_or_log(:sg_ignore) { "@sg-ignore accounting issue - node is #{node}" }
745
- # :nocov:
746
- end
747
- sg_ignore_lines_processed.add problem.location.range.start.line if ignored
748
- ignored
749
- end
750
- end
751
- end
752
- end
1
+ # frozen_string_literal: true
2
+
3
+ module Solargraph
4
+ # A static analysis tool for validating data types.
5
+ #
6
+ class TypeChecker
7
+ autoload :Problem, 'solargraph/type_checker/problem'
8
+ autoload :ParamDef, 'solargraph/type_checker/param_def'
9
+ autoload :Rules, 'solargraph/type_checker/rules'
10
+ autoload :Checks, 'solargraph/type_checker/checks'
11
+
12
+ include Checks
13
+ include Parser::NodeMethods
14
+
15
+ # @return [String]
16
+ attr_reader :filename
17
+
18
+ # @return [Rules]
19
+ attr_reader :rules
20
+
21
+ # @return [ApiMap]
22
+ attr_reader :api_map
23
+
24
+ # @param filename [String, nil]
25
+ # @param api_map [ApiMap, nil]
26
+ # @param level [Symbol] Don't complain about anything above this level
27
+ # @param workspace [Workspace, nil] Workspace to use for loading
28
+ # type checker rules modified by user config
29
+ # @param type_checker_rules [Hash{Symbol => Symbol}] Overrides for
30
+ # type checker rules - e.g., :report_undefined => :strong
31
+ # @param rules [Rules] Type checker rules object
32
+ def initialize filename,
33
+ api_map: nil,
34
+ level: :normal,
35
+ workspace: filename ? Workspace.new(File.dirname(filename)) : nil,
36
+ rules: workspace ? workspace.rules(level) : Rules.new(level, {})
37
+ @filename = filename
38
+ # @todo Smarter directory resolution
39
+ @api_map = api_map || Solargraph::ApiMap.load(File.dirname(filename))
40
+ @rules = rules
41
+ # @type [Array<Range>]
42
+ @marked_ranges = []
43
+ end
44
+
45
+ # @return [SourceMap]
46
+ def source_map
47
+ @source_map ||= api_map.source_map(filename)
48
+ end
49
+
50
+ # @return [Source]
51
+ def source
52
+ @source_map.source
53
+ end
54
+
55
+ # @return [Array<Problem>]
56
+ def problems
57
+ @problems ||= begin
58
+ all = method_tag_problems
59
+ .concat(variable_type_tag_problems)
60
+ .concat(const_problems)
61
+ .concat(call_problems)
62
+ unignored = without_ignored(all)
63
+ unignored.concat(unneeded_sgignore_problems)
64
+ end
65
+ end
66
+
67
+ class << self
68
+ # @param filename [String]
69
+ # @param level [Symbol]
70
+ # @return [self]
71
+ def load filename, level = :normal
72
+ source = Solargraph::Source.load(filename)
73
+ api_map = Solargraph::ApiMap.new
74
+ api_map.map(source)
75
+ new(filename, api_map: api_map, level: level)
76
+ end
77
+
78
+ # @param code [String]
79
+ # @param filename [String, nil]
80
+ # @param level [Symbol]
81
+ # @return [self]
82
+ def load_string code, filename = nil, level = :normal
83
+ source = Solargraph::Source.load_string(code, filename)
84
+ api_map = Solargraph::ApiMap.new
85
+ api_map.map(source)
86
+ new(filename, api_map: api_map, level: level)
87
+ end
88
+ end
89
+
90
+ private
91
+
92
+ # @return [Array<Problem>]
93
+ def method_tag_problems
94
+ result = []
95
+ # @param pin [Pin::Method]
96
+ source_map.pins_by_class(Pin::Method).each do |pin|
97
+ result.concat method_return_type_problems_for(pin)
98
+ result.concat method_param_type_problems_for(pin)
99
+ end
100
+ result
101
+ end
102
+
103
+ # @param pin [Pin::Method]
104
+ # @return [Array<Problem>]
105
+ def method_return_type_problems_for pin
106
+ return [] if pin.is_a?(Pin::MethodAlias)
107
+ result = []
108
+ declared = pin.typify(api_map).self_to_type(pin.full_context).qualify(api_map, *pin.gates)
109
+ if declared.undefined?
110
+ if pin.return_type.undefined? && rules.require_type_tags?
111
+ if pin.attribute?
112
+ inferred = pin.probe(api_map).self_to_type(pin.full_context)
113
+ result.push Problem.new(pin.location, "Missing @return tag for #{pin.path}", pin: pin) unless inferred.defined?
114
+ else
115
+ result.push Problem.new(pin.location, "Missing @return tag for #{pin.path}", pin: pin)
116
+ end
117
+ elsif pin.return_type.defined? && !resolved_constant?(pin)
118
+ result.push Problem.new(pin.location, "Unresolved return type #{pin.return_type} for #{pin.path}", pin: pin)
119
+ elsif rules.must_tag_or_infer? && pin.probe(api_map).undefined?
120
+ result.push Problem.new(pin.location, "Untyped method #{pin.path} could not be inferred")
121
+ end
122
+ elsif rules.validate_tags?
123
+ unless pin.node.nil? || declared.void? || virtual_pin?(pin) || abstract?(pin)
124
+ inferred = pin.probe(api_map).self_to_type(pin.full_context)
125
+ if inferred.undefined?
126
+ unless rules.ignore_all_undefined? || external?(pin)
127
+ result.push Problem.new(pin.location, "#{pin.path} return type could not be inferred", pin: pin)
128
+ end
129
+ else
130
+ unless (rules.require_all_return_types_match_inferred? ? all_types_match?(api_map, inferred, declared) : any_types_match?(api_map, declared, inferred))
131
+ result.push Problem.new(pin.location, "Declared return type #{declared.rooted_tags} does not match inferred type #{inferred.rooted_tags} for #{pin.path}", pin: pin)
132
+ end
133
+ end
134
+ end
135
+ end
136
+ result
137
+ end
138
+
139
+ # @todo This is not optimal. A better solution would probably be to mix
140
+ # namespace alias into types at the ApiMap level.
141
+ #
142
+ # @param pin [Pin::Base]
143
+ # @return [Boolean]
144
+ def resolved_constant? pin
145
+ return true if pin.typify(api_map).defined?
146
+ constant_pins = api_map.get_constants('', *pin.closure.gates)
147
+ .select { |p| p.name == pin.return_type.namespace }
148
+ return true if constant_pins.find { |p| p.typify(api_map).defined? }
149
+ # will need to probe when a constant name is assigned to a
150
+ # class/module (alias)
151
+ return true if constant_pins.find { |p| p.probe(api_map).defined? }
152
+ false
153
+ end
154
+
155
+ # @param pin [Pin::Base]
156
+ def virtual_pin? pin
157
+ pin.location && source.comment_at?(pin.location.range.ending)
158
+ end
159
+
160
+ # @param pin [Pin::Method]
161
+ # @return [Array<Problem>]
162
+ def method_param_type_problems_for pin
163
+ stack = api_map.get_method_stack(pin.namespace, pin.name, scope: pin.scope)
164
+ result = []
165
+ pin.signatures.each do |sig|
166
+ params = param_details_from_stack(sig, stack)
167
+ if rules.require_type_tags?
168
+ sig.parameters.each do |par|
169
+ break if par.decl == :restarg || par.decl == :kwrestarg || par.decl == :blockarg
170
+ unless params[par.name]
171
+ if pin.attribute?
172
+ inferred = pin.probe(api_map).self_to_type(pin.full_context)
173
+ if inferred.undefined?
174
+ result.push Problem.new(pin.location, "Missing @param tag for #{par.name} on #{pin.path}", pin: pin)
175
+ end
176
+ else
177
+ result.push Problem.new(pin.location, "Missing @param tag for #{par.name} on #{pin.path}", pin: pin)
178
+ end
179
+ end
180
+ end
181
+ end
182
+ # @param name [String]
183
+ # @param data [Hash{Symbol => BasicObject}]
184
+ params.each_pair do |name, data|
185
+ # @type [ComplexType]
186
+ type = data[:qualified]
187
+ if type.undefined?
188
+ result.push Problem.new(pin.location, "Unresolved type #{data[:tagged]} for #{name} param on #{pin.path}", pin: pin)
189
+ end
190
+ end
191
+ end
192
+ result
193
+ end
194
+
195
+ # @return [Array<Pin::Base>]
196
+ def ignored_pins
197
+ @ignored_pins ||= []
198
+ end
199
+
200
+ # @return [Array<Problem>]
201
+ def variable_type_tag_problems
202
+ result = []
203
+ all_variables.each do |pin|
204
+ if pin.return_type.defined?
205
+ declared = pin.typify(api_map)
206
+ next if declared.duck_type?
207
+ if declared.defined? && pin.assignment
208
+ if rules.validate_tags?
209
+ inferred = pin.probe(api_map)
210
+ if inferred.undefined?
211
+ next if rules.ignore_all_undefined?
212
+ if declared_externally?(pin)
213
+ ignored_pins.push pin
214
+ else
215
+ result.push Problem.new(pin.location, "Variable type could not be inferred for #{pin.name}", pin: pin)
216
+ end
217
+ else
218
+ unless any_types_match?(api_map, declared, inferred)
219
+ result.push Problem.new(pin.location, "Declared type #{declared} does not match inferred type #{inferred} for variable #{pin.name}", pin: pin)
220
+ end
221
+ end
222
+ elsif declared_externally?(pin)
223
+ ignored_pins.push pin
224
+ end
225
+ elsif !pin.is_a?(Pin::Parameter) && !resolved_constant?(pin)
226
+ result.push Problem.new(pin.location, "Unresolved type #{pin.return_type} for variable #{pin.name}", pin: pin)
227
+ end
228
+ elsif pin.assignment
229
+ inferred = pin.probe(api_map)
230
+ if inferred.undefined? && declared_externally?(pin)
231
+ ignored_pins.push pin
232
+ end
233
+ end
234
+ end
235
+ result
236
+ end
237
+
238
+ # @return [Array<Pin::BaseVariable>]
239
+ def all_variables
240
+ source_map.pins_by_class(Pin::BaseVariable) + source_map.locals.select { |pin| pin.is_a?(Pin::LocalVariable) }
241
+ end
242
+
243
+ # @return [Array<Problem>]
244
+ def const_problems
245
+ return [] unless rules.validate_consts?
246
+ result = []
247
+ Solargraph::Parser::NodeMethods.const_nodes_from(source.node).each do |const|
248
+ rng = Solargraph::Range.from_node(const)
249
+ chain = Solargraph::Parser.chain(const, filename)
250
+ closure_pin = source_map.locate_closure_pin(rng.start.line, rng.start.column)
251
+ closure_pin.rebind(api_map)
252
+ location = Location.new(filename, rng)
253
+ locals = source_map.locals_at(location)
254
+ pins = chain.define(api_map, closure_pin, locals)
255
+ if pins.empty?
256
+ result.push Problem.new(location, "Unresolved constant #{Solargraph::Parser::NodeMethods.unpack_name(const)}")
257
+ @marked_ranges.push location.range
258
+ end
259
+ end
260
+ result
261
+ end
262
+
263
+ # @return [Array<Problem>]
264
+ def call_problems
265
+ result = []
266
+ Solargraph::Parser::NodeMethods.call_nodes_from(source.node).each do |call|
267
+ rng = Solargraph::Range.from_node(call)
268
+ next if @marked_ranges.any? { |d| d.contain?(rng.start) }
269
+ chain = Solargraph::Parser.chain(call, filename)
270
+ closure_pin = source_map.locate_closure_pin(rng.start.line, rng.start.column)
271
+ namespace_pin = closure_pin
272
+ if call.type == :block
273
+ # blocks in the AST include the method call as well, so the
274
+ # node returned by #call_nodes_from needs to be backed out
275
+ # one closure
276
+ closure_pin = closure_pin.closure
277
+ end
278
+ closure_pin.rebind(api_map)
279
+ location = Location.new(filename, rng)
280
+ locals = source_map.locals_at(location)
281
+ type = chain.infer(api_map, closure_pin, locals)
282
+ if type.undefined? && !rules.ignore_all_undefined?
283
+ base = chain
284
+ missing = chain
285
+ found = nil
286
+ closest = ComplexType::UNDEFINED
287
+ until base.links.first.undefined?
288
+ found = base.define(api_map, closure_pin, locals).first
289
+ break if found
290
+ missing = base
291
+ base = base.base
292
+ end
293
+ closest = found.typify(api_map) if found
294
+ # @todo remove the internal_or_core? check at a higher-than-strict level
295
+ if !found || found.is_a?(Pin::BaseVariable) || (closest.defined? && internal_or_core?(found))
296
+ unless closest.generic? || ignored_pins.include?(found)
297
+ if closest.defined?
298
+ result.push Problem.new(location, "Unresolved call to #{missing.links.last.word} on #{closest}")
299
+ else
300
+ result.push Problem.new(location, "Unresolved call to #{missing.links.last.word}")
301
+ end
302
+ @marked_ranges.push rng
303
+ end
304
+ end
305
+ end
306
+ result.concat argument_problems_for(chain, api_map, closure_pin, locals, location)
307
+ end
308
+ result
309
+ end
310
+
311
+ # @param chain [Solargraph::Source::Chain]
312
+ # @param api_map [Solargraph::ApiMap]
313
+ # @param closure_pin [Solargraph::Pin::Closure]
314
+ # @param locals [Array<Solargraph::Pin::Base>]
315
+ # @param location [Solargraph::Location]
316
+ # @return [Array<Problem>]
317
+ def argument_problems_for chain, api_map, closure_pin, locals, location
318
+ result = []
319
+ base = chain
320
+ # @type last_base_link [Solargraph::Source::Chain::Call]
321
+ last_base_link = base.links.last
322
+ return [] unless last_base_link.is_a?(Solargraph::Source::Chain::Call)
323
+
324
+ arguments = last_base_link.arguments
325
+
326
+ pins = base.define(api_map, closure_pin, locals)
327
+
328
+ first_pin = pins.first
329
+ if first_pin.is_a?(Pin::DelegatedMethod) && !first_pin.resolvable?(api_map)
330
+ # Do nothing, as we can't find the actual method implementation
331
+ elsif first_pin.is_a?(Pin::Method)
332
+ # @type [Pin::Method]
333
+ pin = first_pin
334
+ ap = if base.links.last.is_a?(Solargraph::Source::Chain::ZSuper)
335
+ arity_problems_for(pin, fake_args_for(closure_pin), location)
336
+ elsif pin.path == 'Class#new'
337
+ fqns = if base.links.one?
338
+ closure_pin.namespace
339
+ else
340
+ base.base.infer(api_map, closure_pin, locals).namespace
341
+ end
342
+ init = api_map.get_method_stack(fqns, 'initialize').first
343
+ init ? arity_problems_for(init, arguments, location) : []
344
+ else
345
+ arity_problems_for(pin, arguments, location)
346
+ end
347
+ return ap unless ap.empty?
348
+ return [] if !rules.validate_calls? || base.links.first.is_a?(Solargraph::Source::Chain::ZSuper)
349
+
350
+ all_errors = []
351
+ pin.signatures.sort { |sig| sig.parameters.length }.each do |sig|
352
+ params = param_details_from_stack(sig, pins)
353
+
354
+ signature_errors = signature_argument_problems_for location, locals, closure_pin, params, arguments, sig, pin
355
+
356
+ if signature_errors.empty?
357
+ # we found a signature that works - meaning errors from
358
+ # other signatures don't matter.
359
+ return []
360
+ end
361
+ all_errors.concat signature_errors
362
+ end
363
+ result.concat all_errors
364
+ end
365
+ result
366
+ end
367
+
368
+ # @param location [Location]
369
+ # @param locals [Array<Pin::LocalVariable>]
370
+ # @param closure_pin [Pin::Closure]
371
+ # @param params [Hash{String => Hash{Symbol => String, Solargraph::ComplexType}}]
372
+ # @param arguments [Array<Source::Chain>]
373
+ # @param sig [Pin::Signature]
374
+ # @param pin [Pin::Method]
375
+ # @param pins [Array<Pin::Method>]
376
+ #
377
+ # @return [Array<Problem>]
378
+ def signature_argument_problems_for location, locals, closure_pin, params, arguments, sig, pin
379
+ errors = []
380
+ # @todo add logic mapping up restarg parameters with
381
+ # arguments (including restarg arguments). Use tuples
382
+ # when possible, and when not, ensure provably
383
+ # incorrect situations are detected.
384
+ sig.parameters.each_with_index do |par, idx|
385
+ return errors if par.decl == :restarg # bail out and assume the rest is valid pending better arg processing
386
+ argchain = arguments[idx]
387
+ if argchain.nil?
388
+ if par.decl == :arg
389
+ final_arg = arguments.last
390
+ if final_arg && final_arg.node.type == :splat
391
+ argchain = final_arg
392
+ return errors
393
+ else
394
+ errors.push Problem.new(location, "Not enough arguments to #{pin.path}")
395
+ end
396
+ else
397
+ final_arg = arguments.last
398
+ argchain = final_arg if final_arg && [:kwsplat, :hash].include?(final_arg.node.type)
399
+ end
400
+ end
401
+ if argchain
402
+ if par.decl != :arg
403
+ errors.concat kwarg_problems_for sig, argchain, api_map, closure_pin, locals, location, pin, params, idx
404
+ next
405
+ else
406
+ if argchain.node.type == :splat && argchain == arguments.last
407
+ final_arg = argchain
408
+ end
409
+ if (final_arg && final_arg.node.type == :splat)
410
+ # The final argument given has been seen and was a
411
+ # splat, which doesn't give us useful types or
412
+ # arities against positional parameters, so let's
413
+ # continue on in case there are any required
414
+ # kwargs we should warn about
415
+ next
416
+ end
417
+ if argchain.node.type == :splat && par != sig.parameters.last
418
+ # we have been given a splat and there are more
419
+ # arguments to come.
420
+
421
+ # @todo Improve this so that we can skip past the
422
+ # rest of the positional parameters here but still
423
+ # process the kwargs
424
+ return errors
425
+ end
426
+ ptype = params.key?(par.name) ? params[par.name][:qualified] : ComplexType::UNDEFINED
427
+ ptype = ptype.self_to_type(par.context)
428
+ if ptype.nil?
429
+ # @todo Some level (strong, I guess) should require the param here
430
+ else
431
+ argtype = argchain.infer(api_map, closure_pin, locals)
432
+ argtype = argtype.self_to_type(closure_pin.context)
433
+ if argtype.defined? && ptype.defined? && !any_types_match?(api_map, ptype, argtype)
434
+ errors.push Problem.new(location, "Wrong argument type for #{pin.path}: #{par.name} expected #{ptype}, received #{argtype}")
435
+ return errors
436
+ end
437
+ end
438
+ end
439
+ elsif par.decl == :kwarg
440
+ errors.push Problem.new(location, "Call to #{pin.path} is missing keyword argument #{par.name}")
441
+ next
442
+ end
443
+ end
444
+ errors
445
+ end
446
+
447
+ # @param sig [Pin::Signature]
448
+ # @param argchain [Source::Chain]
449
+ # @param api_map [ApiMap]
450
+ # @param closure_pin [Pin::Closure]
451
+ # @param locals [Array<Pin::LocalVariable>]
452
+ # @param location [Location]
453
+ # @param pin [Pin::Method]
454
+ # @param params [Hash{String => Hash{Symbol => String, Solargraph::ComplexType}}]
455
+ # @param idx [Integer]
456
+ #
457
+ # @return [Array<Problem>]
458
+ def kwarg_problems_for sig, argchain, api_map, closure_pin, locals, location, pin, params, idx
459
+ result = []
460
+ kwargs = convert_hash(argchain.node)
461
+ par = sig.parameters[idx]
462
+ argchain = kwargs[par.name.to_sym]
463
+ if par.decl == :kwrestarg || (par.decl == :optarg && idx == pin.parameters.length - 1 && par.asgn_code == '{}')
464
+ result.concat kwrestarg_problems_for(api_map, closure_pin, locals, location, pin, params, kwargs)
465
+ else
466
+ if argchain
467
+ data = params[par.name]
468
+ if data.nil?
469
+ # @todo Some level (strong, I guess) should require the param here
470
+ else
471
+ ptype = data[:qualified]
472
+ ptype = ptype.self_to_type(pin.context)
473
+ unless ptype.undefined?
474
+ # @sg-ignore https://github.com/castwide/solargraph/pull/1127
475
+ argtype = argchain.infer(api_map, closure_pin, locals).self_to_type(closure_pin.context)
476
+ # @sg-ignore Unresolved call to defined?
477
+ if argtype.defined? && ptype && !any_types_match?(api_map, ptype, argtype)
478
+ result.push Problem.new(location, "Wrong argument type for #{pin.path}: #{par.name} expected #{ptype}, received #{argtype}")
479
+ end
480
+ end
481
+ end
482
+ elsif par.decl == :kwarg
483
+ result.push Problem.new(location, "Call to #{pin.path} is missing keyword argument #{par.name}")
484
+ end
485
+ end
486
+ result
487
+ end
488
+
489
+ # @param api_map [ApiMap]
490
+ # @param closure_pin [Pin::Closure]
491
+ # @param locals [Array<Pin::LocalVariable>]
492
+ # @param location [Location]
493
+ # @param pin [Pin::Method]
494
+ # @param params [Hash{String => [nil, Hash]}]
495
+ # @param kwargs [Hash{Symbol => Source::Chain}]
496
+ # @return [Array<Problem>]
497
+ def kwrestarg_problems_for(api_map, closure_pin, locals, location, pin, params, kwargs)
498
+ result = []
499
+ kwargs.each_pair do |pname, argchain|
500
+ next unless params.key?(pname.to_s)
501
+ ptype = params[pname.to_s][:qualified]
502
+ ptype = ptype.self_to_type(pin.context)
503
+ argtype = argchain.infer(api_map, closure_pin, locals)
504
+ argtype = argtype.self_to_type(closure_pin.context)
505
+ if argtype.defined? && ptype && !any_types_match?(api_map, ptype, argtype)
506
+ result.push Problem.new(location, "Wrong argument type for #{pin.path}: #{pname} expected #{ptype}, received #{argtype}")
507
+ end
508
+ end
509
+ result
510
+ end
511
+
512
+ # @param param_details [Hash{String => Hash{Symbol => String, ComplexType}}]
513
+ # @param pin [Pin::Method, Pin::Signature]
514
+ # @param relevant_pin [Pin::Method, Pin::Signature] the pin which is under inspection
515
+ # @return [void]
516
+ def add_restkwarg_param_tag_details(param_details, pin, relevant_pin)
517
+ # see if we have additional tags to pay attention to from YARD -
518
+ # e.g., kwargs in a **restkwargs splat
519
+ tags = pin.docstring.tags(:param)
520
+ tags.each do |tag|
521
+ next if param_details.key? tag.name.to_s
522
+ next if tag.types.nil?
523
+ details = {
524
+ tagged: tag.types.join(', '),
525
+ qualified: Solargraph::ComplexType.try_parse(*tag.types).qualify(api_map, pin.full_context.namespace)
526
+ }
527
+ # don't complain about a param that didn't come from the pin we're looking at anyway
528
+ if details[:qualified].defined? ||
529
+ relevant_pin.parameter_names.include?(tag.name.to_s)
530
+ param_details[tag.name.to_s] = details
531
+ end
532
+ end
533
+ end
534
+
535
+ # @param pin [Pin::Signature]
536
+ # @return [Hash{String => Hash{Symbol => String, ComplexType}}]
537
+ def signature_param_details(pin)
538
+ # @type [Hash{String => Hash{Symbol => String, ComplexType}}]
539
+ result = {}
540
+ pin.parameters.each do |param|
541
+ type = param.typify(api_map)
542
+ next if type.nil? || type.undefined?
543
+ result[param.name.to_s] = {
544
+ tagged: type.tags,
545
+ qualified: type
546
+ }
547
+ end
548
+ # see if we have additional tags to pay attention to from YARD -
549
+ # e.g., kwargs in a **restkwargs splat
550
+ tags = pin.docstring.tags(:param)
551
+ tags.each do |tag|
552
+ next if result.key? tag.name.to_s
553
+ next if tag.types.nil?
554
+ result[tag.name.to_s] = {
555
+ tagged: tag.types.join(', '),
556
+ qualified: Solargraph::ComplexType.try_parse(*tag.types).qualify(api_map, *pin.closure.gates)
557
+ }
558
+ end
559
+ result
560
+ end
561
+
562
+ # The original signature defines the parameters, but other
563
+ # signatures and method pins can help by adding type information
564
+ #
565
+ # @param param_details [Hash{String => Hash{Symbol => String, ComplexType}}]
566
+ # @param param_names [Array<String>]
567
+ # @param new_param_details [Hash{String => Hash{Symbol => String, ComplexType}}]
568
+ #
569
+ # @return [void]
570
+ def add_to_param_details(param_details, param_names, new_param_details)
571
+ new_param_details.each do |param_name, details|
572
+ next unless param_names.include?(param_name)
573
+
574
+ param_details[param_name] ||= {}
575
+ param_details[param_name][:tagged] ||= details[:tagged]
576
+ param_details[param_name][:qualified] ||= details[:qualified]
577
+ end
578
+ end
579
+
580
+ # @param signature [Pin::Signature]
581
+ # @param method_pin_stack [Array<Pin::Method>]
582
+ # @return [Hash{String => Hash{Symbol => String, ComplexType}}]
583
+ def param_details_from_stack(signature, method_pin_stack)
584
+ signature_type = signature.typify(api_map)
585
+ signature = signature.proxy signature_type
586
+ param_details = signature_param_details(signature)
587
+ param_names = signature.parameter_names
588
+
589
+ method_pin_stack.each do |method_pin|
590
+ add_restkwarg_param_tag_details(param_details, method_pin, signature)
591
+
592
+ # documentation of types in superclasses should fail back to
593
+ # subclasses if the subclass hasn't documented something
594
+ method_pin.signatures.each do |sig|
595
+ add_restkwarg_param_tag_details(param_details, sig, signature)
596
+ add_to_param_details param_details, param_names, signature_param_details(sig)
597
+ end
598
+ end
599
+ param_details
600
+ end
601
+
602
+ # @param pin [Pin::Base]
603
+ def internal? pin
604
+ return false if pin.nil?
605
+ pin.location && api_map.bundled?(pin.location.filename)
606
+ end
607
+
608
+ # True if the pin is either internal (part of the workspace) or from the core/stdlib
609
+ # @param pin [Pin::Base]
610
+ def internal_or_core? pin
611
+ # @todo RBS pins are not necessarily core/stdlib pins
612
+ internal?(pin) || pin.source == :rbs
613
+ end
614
+
615
+ # @param pin [Pin::Base]
616
+ def external? pin
617
+ !internal? pin
618
+ end
619
+
620
+ # @param pin [Pin::BaseVariable]
621
+ def declared_externally? pin
622
+ raise "No assignment found" if pin.assignment.nil?
623
+
624
+ chain = Solargraph::Parser.chain(pin.assignment, filename)
625
+ rng = Solargraph::Range.from_node(pin.assignment)
626
+ closure_pin = source_map.locate_closure_pin(rng.start.line, rng.start.column)
627
+ location = Location.new(filename, Range.from_node(pin.assignment))
628
+ locals = source_map.locals_at(location)
629
+ type = chain.infer(api_map, closure_pin, locals)
630
+ if type.undefined? && !rules.ignore_all_undefined?
631
+ base = chain
632
+ missing = chain
633
+ found = nil
634
+ closest = ComplexType::UNDEFINED
635
+ until base.links.first.undefined?
636
+ found = base.define(api_map, closure_pin, locals).first
637
+ break if found
638
+ missing = base
639
+ base = base.base
640
+ end
641
+ closest = found.typify(api_map) if found
642
+ if !found || closest.defined? || internal?(found)
643
+ return false
644
+ end
645
+ end
646
+ true
647
+ end
648
+
649
+ # @param pin [Pin::Method]
650
+ # @param arguments [Array<Source::Chain>]
651
+ # @param location [Location]
652
+ # @return [Array<Problem>]
653
+ def arity_problems_for pin, arguments, location
654
+ results = pin.signatures.map do |sig|
655
+ r = parameterized_arity_problems_for(pin, sig.parameters, arguments, location)
656
+ return [] if r.empty?
657
+ r
658
+ end
659
+ results.first
660
+ end
661
+
662
+ # @param pin [Pin::Method]
663
+ # @param parameters [Array<Pin::Parameter>]
664
+ # @param arguments [Array<Source::Chain>]
665
+ # @param location [Location]
666
+ # @return [Array<Problem>]
667
+ def parameterized_arity_problems_for(pin, parameters, arguments, location)
668
+ return [] unless pin.explicit?
669
+ return [] if parameters.empty? && arguments.empty?
670
+ return [] if pin.anon_splat?
671
+ unchecked = arguments.dup # creates copy of and unthaws array
672
+ add_params = 0
673
+ if unchecked.empty? && parameters.any? { |param| param.decl == :kwarg }
674
+ return [Problem.new(location, "Missing keyword arguments to #{pin.path}")]
675
+ end
676
+ settled_kwargs = 0
677
+ unless unchecked.empty?
678
+ if any_splatted_call?(unchecked.map(&:node))
679
+ settled_kwargs = parameters.count(&:keyword?)
680
+ else
681
+ kwargs = convert_hash(unchecked.last.node)
682
+ if parameters.any? { |param| [:kwarg, :kwoptarg].include?(param.decl) || param.kwrestarg? }
683
+ if kwargs.empty?
684
+ add_params += 1
685
+ else
686
+ unchecked.pop
687
+ parameters.each do |param|
688
+ next unless param.keyword?
689
+ if kwargs.key?(param.name.to_sym)
690
+ kwargs.delete param.name.to_sym
691
+ settled_kwargs += 1
692
+ elsif param.decl == :kwarg
693
+ last_arg_last_link = arguments.last.links.last
694
+ return [] if last_arg_last_link.is_a?(Solargraph::Source::Chain::Hash) && last_arg_last_link.splatted?
695
+ return [Problem.new(location, "Missing keyword argument #{param.name} to #{pin.path}")]
696
+ end
697
+ end
698
+ kwargs.clear if parameters.any?(&:kwrestarg?)
699
+ unless kwargs.empty?
700
+ return [Problem.new(location, "Unrecognized keyword argument #{kwargs.keys.first} to #{pin.path}")]
701
+ end
702
+ end
703
+ end
704
+ end
705
+ end
706
+ req = required_param_count(parameters)
707
+ if req + add_params < unchecked.length
708
+ return [] if parameters.any?(&:rest?)
709
+ opt = optional_param_count(parameters)
710
+ return [] if unchecked.length <= req + opt
711
+ if req + add_params + 1 == unchecked.length && any_splatted_call?(unchecked.map(&:node)) && (parameters.map(&:decl) & [:kwarg, :kwoptarg, :kwrestarg]).any?
712
+ return []
713
+ end
714
+ return [] if arguments.length - req == parameters.select { |p| [:optarg, :kwoptarg].include?(p.decl) }.length
715
+ return [Problem.new(location, "Too many arguments to #{pin.path}")]
716
+ elsif unchecked.length < req - settled_kwargs && (arguments.empty? || (!arguments.last.splat? && !arguments.last.links.last.is_a?(Solargraph::Source::Chain::Hash)))
717
+ # HACK: Kernel#raise signature is incorrect in Ruby 2.7 core docs.
718
+ # See https://github.com/castwide/solargraph/issues/418
719
+ unless arguments.empty? && pin.path == 'Kernel#raise'
720
+ return [Problem.new(location, "Not enough arguments to #{pin.path}")]
721
+ end
722
+ end
723
+ []
724
+ end
725
+
726
+ # @param parameters [Enumerable<Pin::Parameter>]
727
+ # @todo need to use generic types in method to choose correct
728
+ # signature and generate Integer as return type
729
+ # @return [Integer]
730
+ def required_param_count(parameters)
731
+ parameters.sum { |param| %i[arg kwarg].include?(param.decl) ? 1 : 0 }
732
+ end
733
+
734
+ # @param parameters [Enumerable<Pin::Parameter>]
735
+ # @param pin [Pin::Method]
736
+ # @return [Integer]
737
+ def optional_param_count(parameters)
738
+ parameters.select { |p| p.decl == :optarg }.length
739
+ end
740
+
741
+ # @param pin [Pin::Method]
742
+ def abstract? pin
743
+ pin.docstring.has_tag?('abstract') ||
744
+ (pin.closure && pin.closure.docstring.has_tag?('abstract'))
745
+ end
746
+
747
+ # @param pin [Pin::Method]
748
+ # @return [Array<Source::Chain>]
749
+ def fake_args_for(pin)
750
+ args = []
751
+ with_opts = false
752
+ with_block = false
753
+ pin.parameters.each do |pin|
754
+ if [:kwarg, :kwoptarg, :kwrestarg].include?(pin.decl)
755
+ with_opts = true
756
+ elsif pin.decl == :block
757
+ with_block = true
758
+ elsif pin.decl == :restarg
759
+ args.push Solargraph::Source::Chain.new([Solargraph::Source::Chain::Variable.new(pin.name)], nil, true)
760
+ else
761
+ args.push Solargraph::Source::Chain.new([Solargraph::Source::Chain::Variable.new(pin.name)])
762
+ end
763
+ end
764
+ args.push Solargraph::Parser.chain_string('{}') if with_opts
765
+ args.push Solargraph::Parser.chain_string('&') if with_block
766
+ args
767
+ end
768
+
769
+ # @return [Set<Integer>]
770
+ def sg_ignore_lines_processed
771
+ @sg_ignore_lines_processed ||= Set.new
772
+ end
773
+
774
+ # @return [Set<Integer>]
775
+ def all_sg_ignore_lines
776
+ source.associated_comments.select do |_line, text|
777
+ text.include?('@sg-ignore')
778
+ end.keys.to_set
779
+ end
780
+
781
+ # @return [Array<Integer>]
782
+ def unprocessed_sg_ignore_lines
783
+ (all_sg_ignore_lines - sg_ignore_lines_processed).to_a.sort
784
+ end
785
+
786
+ # @return [Array<Problem>]
787
+ def unneeded_sgignore_problems
788
+ return [] unless rules.validate_sg_ignores?
789
+
790
+ unprocessed_sg_ignore_lines.map do |line|
791
+ Problem.new(
792
+ Location.new(filename, Range.from_to(line, 0, line, 0)),
793
+ 'Unneeded @sg-ignore comment'
794
+ )
795
+ end
796
+ end
797
+
798
+ # @param problems [Array<Problem>]
799
+ # @return [Array<Problem>]
800
+ def without_ignored problems
801
+ problems.reject do |problem|
802
+ node = source.node_at(problem.location.range.start.line, problem.location.range.start.column)
803
+ ignored = node && source.comments_for(node)&.include?('@sg-ignore')
804
+ unless !ignored || all_sg_ignore_lines.include?(problem.location.range.start.line)
805
+ # :nocov:
806
+ Solargraph.assert_or_log(:sg_ignore) { "@sg-ignore accounting issue - node is #{node}" }
807
+ # :nocov:
808
+ end
809
+ sg_ignore_lines_processed.add problem.location.range.start.line if ignored
810
+ ignored
811
+ end
812
+ end
813
+ end
814
+ end