solargraph 0.23.4 → 0.23.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3d2dc2283964f7972f289ef9aa43a939948049b02d351f244ec522afc1033265
-  data.tar.gz: 8e60c7d6d9a3f7bd25fcbc66566c1ce795b3b8999572b454e6d07a027460ec4d
+  metadata.gz: 9c281911d4b36b81d86b88a11979ee08e9c974cd10cbe83e1d07a03cf3f52185
+  data.tar.gz: 65d1fe2602ac1ac9b9272aaf52a0a4772edd5897465b29d370ee6ebc15cedb44
 SHA512:
-  metadata.gz: 9ffd40c951fb253bef3653525c9cbf10362582c292c529559b59698a1636939ed589fe76d9eacb01b26f6e7340c4f854d557fff0bd94a34e4b9d277196c3e637
-  data.tar.gz: d589e62eb1024c07eb2bd15cde0f29552a07089fa812b2508c51ad701622b1ab59e783b69f2cb4bc40645044c514f6167e83f2b1c3064c7eea8c372aad95c380
+  metadata.gz: d1c5981b4b14c3651833ddc5589c8002ede7d7d690519ee70d8a8e82a59bbfaecdcd6576b0d6706b29d6d92bda3f1a5c990a23286114d81b84ec49b99ca9bb8e
+  data.tar.gz: 0c75eb3da1835a7cd35ee8a594554ec0e6638c4afbe471aa27f05c7233df0841b47d5e313fb53d319b56af6fc46fd1876756dc9b8ace48476ca4e9353c23dba1

data/lib/solargraph.rb

@@ -3,17 +3,22 @@ require 'rubygems/package'
 require 'yard-solargraph'
 
 module Solargraph
-  class InvalidOffsetError <      RangeError; end
-  class DiagnosticsError <        RuntimeError; end
-  class FileNotFoundError <       RuntimeError; end
+  class InvalidOffsetError <      RangeError;    end
+  class DiagnosticsError <        RuntimeError;  end
+  class FileNotFoundError <       RuntimeError;  end
   class SourceNotAvailableError < StandardError; end
-
-  class WorkspaceTooLargeError < RuntimeError
+  class WorkspaceTooLargeError <  RuntimeError
+    # @return [Integer]
     attr_reader :size
 
+    # @return [Integer]
+    attr_reader :max
+
     # @param size [Integer] The number of files included in the workspace
-    def initialize size
+    # @param max [Integer] The maximum number of files allowed
+    def initialize size, max
       @size = size
+      @max = max
     end
   end
 

data/lib/solargraph/api_map.rb

@@ -336,7 +336,8 @@ module Solargraph
     # @param fragment [Solargraph::Source::Fragment]
     # @return [Array<Solargraph::Pin::Base>]
     def define fragment
-      return [] if fragment.string? or fragment.comment? or fragment.literal?
+      return get_path_suggestions(fragment.namespace) if fragment.whole_signature == 'self'
+      return [] if fragment.string? or fragment.comment? or fragment.literal? or fragment.whole_signature == 'self'
       if fragment.base_literal?
         probe.infer_signature_pins fragment.whole_signature, Pin::ProxyMethod.new(fragment.base_literal), fragment.locals
       else
@@ -526,6 +527,7 @@ module Solargraph
         fqis = qualify(is, fqns)
         result.concat inner_get_constants(fqis, [:public], skip) unless fqis.nil?
       end
+      result.concat live_map.get_constants(fqns)
       result
     end
 

data/lib/solargraph/api_map/probe.rb

@@ -48,6 +48,7 @@ module Solargraph
       def infer_signature_type signature, context_pin, locals
         pins = infer_signature_pins(signature, context_pin, locals)
         pins.each do |pin|
+          return pin.return_type unless pin.return_type.nil?
           type = resolve_pin_type(pin, locals - [pin])
           return qualify(type, pin.named_context) unless type.nil?
         end
@@ -59,8 +60,9 @@ module Solargraph
       # Word search is ALWAYS internal
       def infer_word_pins word, context_pin, locals
         return [] if word.empty?
+        return infer_self(context_pin) if word == 'self'
         lvars = locals.select{|pin| pin.name == word}
-        return lvars unless lvars.empty?
+        return resolve_word_types(lvars, locals) unless lvars.empty?
         return api_map.get_global_variable_pins.select{|pin| pin.name == word} if word.start_with?('$')
         namespace, scope = extract_namespace_and_scope_from_pin(context_pin)
         return api_map.pins.select{|pin| word_matches_context?(word, namespace, scope, pin)} if variable_name?(word)
@@ -75,7 +77,28 @@ module Solargraph
         result.concat api_map.get_path_suggestions(word) if result.empty?
         result.concat api_map.get_methods(namespace, scope: scope, visibility: [:public, :private, :protected]).select{|pin| pin.name == word} unless word.include?('::')
         result.concat api_map.get_constants('', namespace).select{|pin| pin.name == word} if result.empty?
-        result
+        resolve_word_types(result, locals)
+      end
+
+      def resolve_word_types(pins, locals)
+        pins.each do |p|
+          next unless p.return_type.nil?
+          type = resolve_pin_type(p, locals)
+          # @todo Smelly instance variable access
+          p.instance_variable_set(:@return_type, type)
+        end
+      end
+
+      def infer_self context_pin
+        if context_pin.kind == Pin::METHOD
+          if context_pin.scope == :instance
+            return [Pin::ProxyMethod.new(context_pin.namespace)]
+          else
+            return api_map.get_path_suggestions(context_pin.namespace)
+          end
+        else
+          return api_map.get_path_suggestions(context_pin.path)
+        end
       end
 
       # Method name search is external by default
@@ -154,24 +177,27 @@ module Solargraph
       def resolve_pin_type pin, locals
         pin.return_type
         return pin.return_type unless pin.return_type.nil?
-        return resolve_block_parameter(pin) if pin.kind == Pin::BLOCK_PARAMETER
+        return resolve_block_parameter(pin, locals) if pin.kind == Pin::BLOCK_PARAMETER
         return resolve_variable(pin, locals) if pin.variable?
         nil
       end
 
-      def resolve_block_parameter pin
+      def resolve_block_parameter pin, locals
         return pin.return_type unless pin.return_type.nil?
         signature = pin.block.receiver
         # @todo Not sure if assuming the first pin is good here
-        meth = @api_map.probe.infer_signature_pins(signature, pin.block, []).first
+        meth = infer_signature_pins(signature, pin.block, locals).first
         return nil if meth.nil?
         if (Solargraph::CoreFills::METHODS_WITH_YIELDPARAM_SUBTYPES.include?(meth.path))
           base = signature.split('.')[0..-2].join('.')
           return nil if base.nil? or base.empty?
           # @todo Not sure if assuming the first pin is good here
-          bmeth = @api_map.probe.infer_signature_pins(base, pin.block, []).first
+          bmeth = infer_signature_pins(base, pin.block, locals).first
           return nil if bmeth.nil?
-          subtypes = get_subtypes(bmeth.return_type)
+          btype = bmeth.return_type
+          btype = infer_signature_type(bmeth.signature, pin.block, locals) if btype.nil? and bmeth.variable?
+          subtypes = get_subtypes(btype)
+          return nil if subtypes.nil?
           return subtypes[0]
         else
           unless meth.docstring.nil?

data/lib/solargraph/diagnostics.rb

@@ -8,11 +8,39 @@ module Solargraph
     autoload :Rubocop, 'solargraph/diagnostics/rubocop'
     autoload :RequireNotFound, 'solargraph/diagnostics/require_not_found'
 
-    # Reporters identified by name for activation in .solargraph.yml files.
-    #
-    REPORTERS = {
-      'rubocop' => Rubocop,
-      'require_not_found' => RequireNotFound
-    }
+    class << self
+      # Add a reporter with a name to identify it in .solargraph.yml files.
+      #
+      # @param name [String] The name
+      # @param klass [Class<Solargraph::Diagnostics::Base>] The class implementation
+      def register name, klass
+        reporter_hash[name] = klass
+      end
+
+      # Get an array of reporter names.
+      #
+      # @return [Array<String>]
+      def reporters
+        reporter_hash.keys
+      end
+
+      # Find a reporter by name.
+      #
+      # @param name [String] The name with which the reporter was registered
+      # @return [Class<Solargraph::Diagnostics::Base>]
+      def reporter name
+        reporter_hash[name]
+      end
+
+      private
+
+      # @return [Hash]
+      def reporter_hash
+        @reporter_hash ||= {}
+      end
+    end
+
+    register 'rubocop', Rubocop
+    register 'require_not_found', RequireNotFound
   end
 end

data/lib/solargraph/language_server/host.rb

@@ -40,16 +40,27 @@ module Solargraph
         @options ||= default_configuration
       end
 
+      # Cancel the method with the specified ID.
+      #
+      # @param id [Integer]
       def cancel id
         @cancel_semaphore.synchronize { @cancel.push id }
       end
 
+      # True if the host received a request to cancel the method with the
+      # specified ID.
+      #
+      # @param id [Integer]
+      # @return [Boolean]
       def cancel? id
         result = false
         @cancel_semaphore.synchronize { result = @cancel.include? id }
         result
       end
 
+      # Delete the specified ID from the list of cancelled IDs if it exists.
+      #
+      # @param id [Integer]
       def clear id
         @cancel_semaphore.synchronize { @cancel.delete id }
       end
@@ -120,6 +131,7 @@ module Solargraph
 
       # True if the specified file is currently open in the library.
       #
+      # @param uri [String]
       # @return [Boolean]
       def open? uri
         result = nil
@@ -129,6 +141,9 @@ module Solargraph
         result
       end
 
+      # Close the file specified by the URI.
+      #
+      # @param uri [String]
       def close uri
         @change_semaphore.synchronize do
           library.close uri_to_file(uri)
@@ -200,7 +215,7 @@ module Solargraph
           rescue WorkspaceTooLargeError => e
             send_notification 'window/showMessage', {
               'type' => Solargraph::LanguageServer::MessageTypes::WARNING,
-              'message' => "The workspace is too large to index (#{e.size} files, max #{Workspace::MAX_WORKSPACE_SIZE})"
+              'message' => "The workspace is too large to index (#{e.size} files, max #{e.max})"
             }
             @library = Solargraph::Library.load(nil)
           end
@@ -397,6 +412,8 @@ module Solargraph
         result
       end
 
+      # @param uri [String]
+      # @return [Array<Solargraph::Pin::Base>]
       def file_symbols uri
         library.file_symbols(uri_to_file(uri))
       end

data/lib/solargraph/language_server/message/text_document/hover.rb

@@ -9,22 +9,17 @@ module Solargraph::LanguageServer::Message::TextDocument
       col = params['position']['character']
       contents = []
       suggestions = host.definitions_at(filename, line, col)
-      last_path = nil
+      last_link = nil
       suggestions.each do |pin|
         parts = []
-        this_path = nil
-        if pin.kind_of?(Solargraph::Pin::BaseVariable)
-          this_path = pin.return_type
-        else
-          this_path = pin.path
-        end
-        if !this_path.nil? and this_path != last_path
-          parts.push link_documentation(this_path)
+        this_link = pin.link_documentation
+        if !this_link.nil? and this_link != last_link
+          parts.push this_link
         end
         parts.push HTMLEntities.new.encode(pin.detail) unless pin.kind == Solargraph::Pin::NAMESPACE or pin.detail.nil?
         parts.push pin.documentation unless pin.documentation.nil? or pin.documentation.empty?
         contents.push parts.join("\n\n") unless parts.empty?
-        last_path = this_path unless this_path.nil?
+        last_link = this_link unless this_link.nil?
       end
       set_result(
         contents: {
@@ -33,13 +28,5 @@ module Solargraph::LanguageServer::Message::TextDocument
         }
       )
     end
-
-    private
-
-    # @todo: DRY this method. It exists in Conversions
-    def link_documentation path
-      uri = "solargraph:/document?query=" + URI.encode(path)
-      "[#{path}](#{uri})"
-    end
   end
 end

data/lib/solargraph/library.rb

@@ -218,14 +218,19 @@ module Solargraph
       api_map.query_symbols query
     end
 
+    # @param filename [String]
+    # @return [Array<Solargraph::Pin::Base>]
     def file_symbols filename
       read(filename).all_symbols
     end
 
+    # @param path [String]
+    # @return [Array<Solargraph::Pin::Base>]
     def path_pins path
       api_map.get_path_suggestions(path)
     end
 
+    # @param updater [Solargraph::Source::Updater]
     def synchronize updater
       source = read(updater.filename)
       source.synchronize updater
@@ -242,6 +247,7 @@ module Solargraph
 
     # Get diagnostics about a file.
     #
+    # @param filename [String]
     # @return [Array<Hash>]
     def diagnose filename
       # @todo Only open files get diagnosed. Determine whether anything or
@@ -251,7 +257,7 @@ module Solargraph
       result = []
       source = read(filename)
       workspace.config.reporters.each do |name|
-        reporter = Diagnostics::REPORTERS[name]
+        reporter = Diagnostics.reporter(name)
         raise DiagnosticsError, "Diagnostics reporter #{name} does not exist" if reporter.nil?
         result.concat reporter.new.diagnose(source, api_map)
       end

data/lib/solargraph/live_map.rb

@@ -54,13 +54,14 @@ module Solargraph
       suggestions = []
       result.uniq.each do |r|
         path = (r['namespace'].empty? ? '' : "#{r['namespace']}::") + r['name']
-        kind = Suggestion::CONSTANT
+        kind = Pin::CONSTANT
         if r['class'] == 'Class'
-          kind = Suggestion::CLASS
+          suggestions.push Pin::Namespace.new(nil, r['namespace'], r['name'], YARD::Docstring.new("(defined at runtime)"), :class, :public, nil)
         elsif r['class'] == 'Module'
-          kind = Suggestion::MODULE
+          suggestions.push Pin::Namespace.new(nil, r['namespace'], r['name'], YARD::Docstring.new("(defined at runtime)"), :module, :public, nil)
+        else
+          suggestions.push Pin::Constant.new(nil, r['namespace'], r['name'], YARD::Docstring.new("(defined at runtime"), nil, nil, nil, :public)
         end
-        suggestions.push(Suggestion.new(r['name'], kind: kind, path: path))
       end
       cache.set_constants(namespace, root, suggestions)
       suggestions

data/lib/solargraph/pin/attribute.rb

@@ -22,6 +22,10 @@ module Solargraph
         Solargraph::LanguageServer::CompletionItemKinds::PROPERTY
       end
 
+      def symbol_kind
+        Solargraph::LanguageServer::SymbolKinds::PROPERTY
+      end
+
       def path
         @path ||= namespace + (scope == :instance ? '#' : '.') + name
       end

data/lib/solargraph/pin/block_parameter.rb

@@ -21,6 +21,10 @@ module Solargraph
         Solargraph::LanguageServer::CompletionItemKinds::VARIABLE
       end
 
+      def symbol_kind
+        Solargraph::LanguageServer::SymbolKinds::VARIABLE
+      end
+
       def index
         block.parameters.index(self)
       end

data/lib/solargraph/pin/conversions.rb

@@ -21,7 +21,7 @@ module Solargraph
         if @resolve_completion_item.nil?
           extra = {}
           alldoc = ''
-          alldoc += link_documentation(path) unless path.nil?
+          alldoc += link_documentation unless link_documentation.nil?
           alldoc += "\n\n" unless alldoc.empty?
           alldoc += documentation unless documentation.nil?
           extra[:documentation] = alldoc unless alldoc.empty?
@@ -50,10 +50,19 @@ module Solargraph
         @detail
       end
 
+      # Get a markdown-flavored link to a documentation page.
+      #
+      # @return [String]
+      def link_documentation
+        @link_documentation ||= generate_link
+      end
+
       private
 
-      def link_documentation path
-        @link_documentation ||= "[#{path}](solargraph:/document?query=#{URI.encode(path)})"
+      def generate_link
+        this_path = path || return_type
+        return nil if this_path.nil?
+        "[#{this_path.gsub('_', '\\\\_')}](solargraph:/document?query=#{URI.encode(this_path)})"
       end
     end
   end

data/lib/solargraph/pin/plugin/method.rb

@@ -17,7 +17,6 @@ module Solargraph
         end
 
         def completion_item_kind
-          # Solargraph::Suggestion::METHOD
           Solargraph::LanguageServer::CompletionItemKinds::METHOD
         end
       end

data/lib/solargraph/pin/proxy_method.rb

@@ -4,7 +4,7 @@ module Solargraph
     # to type inference methods. ApiMap::Probe can treat it as an anonymous
     # method while analyzing signatures.
     #
-    class ProxyMethod
+    class ProxyMethod < Base
       # @return [String]
       attr_reader :return_type
 

data/lib/solargraph/pin/reference.rb

@@ -10,16 +10,16 @@ module Solargraph
       # @return [String]
       attr_reader :name
 
+      # @param location [Source::Location]
+      # @param namespace [String]
+      # @param name [String]
       def initialize location, namespace, name
         @location = location
         @namespace = namespace
         @name = name
       end
 
-      # @todo Deprecaate
-      def resolve api_map
-      end
-
+      # @return [String]
       def filename
         location.filename
       end

data/lib/solargraph/plugin/process.rb

@@ -61,20 +61,21 @@ module Solargraph
 
       def get_methods args
         result = []
+        # @type [Class]
         con = find_constant(args['namespace'], args['root'])
         unless con.nil?
           if (args['scope'] == 'class')
-            result.concat con.methods(false) if args['with_private']
-            result.concat con.public_methods(false)
+            result.concat con.methods if args['with_private']
+            result.concat con.public_methods
           elsif (args['scope'] == 'instance')
-            result.concat con.instance_methods(false) if args['with_private']
-            result.concat con.public_instance_methods(false)
+            result.concat con.instance_methods if args['with_private']
+            result.concat con.public_instance_methods
           end
         end
         result.keep_if{|m| m.to_s.match(/^[a-z_]/i)}
         respond_ok (result.uniq.sort.map do |name|
           # @type [Method]
-          meth = con.method(name)
+          meth = args['scope'] == 'class' ? con.method(name) : con.instance_method(name)
           {
             name: name,
             parameters: build_parameter_array(meth.parameters)

data/lib/solargraph/shell.rb

@@ -125,7 +125,7 @@ module Solargraph
 
     desc 'reporters', 'Get a list of diagnostics reporters'
     def reporters
-      puts Solargraph::Diagnostics::REPORTERS.keys.sort
+      puts Solargraph::Diagnostics.reporters
     end
   end
 end

data/lib/solargraph/source.rb

@@ -44,6 +44,7 @@ module Solargraph
     # @return [Array<Solargraph::Pin::Base>]
     attr_reader :pins
 
+    # @return [Array<Solargraph::Pin::Reference>]
     attr_reader :requires
 
     attr_reader :domains
@@ -53,15 +54,18 @@ module Solargraph
     include NodeMethods
 
     def initialize code, filename = nil
-      @code = code
-      @fixed = code
-      @filename = filename
-      # @stubbed_lines = stubbed_lines
-      @version = 0
       begin
-        parse
-      rescue Parser::SyntaxError, EncodingError
-        hard_fix_node
+        @code = code
+        @fixed = code
+        @filename = filename
+        @version = 0
+        begin
+          parse
+        rescue Parser::SyntaxError, EncodingError
+          hard_fix_node
+        end
+      rescue Exception => e
+        raise RuntimeError, "Error parsing #{filename || '(source)'}: [#{e.class}] #{e.message}"
       end
     end
 
@@ -75,6 +79,7 @@ module Solargraph
     end
 
     # @todo Name problem
+    # @return [Array<Solargraph::Pin::Reference>]
     def required
       requires
     end
@@ -111,6 +116,7 @@ module Solargraph
       pins.select{|pin| pin.kind == Pin::CLASS_VARIABLE}
     end
 
+    # @return [Array<Solargraph::Pin::Base>]
     def locals
       @locals
     end
@@ -130,6 +136,7 @@ module Solargraph
       @symbols
     end
 
+    # @return [Array<Solargraph::Pin::Symbol>]
     def symbols
       symbol_pins
     end
@@ -171,6 +178,11 @@ module Solargraph
       tree_at(line, column).first
     end
 
+    # True if the specified location is inside a string.
+    #
+    # @param line [Integer]
+    # @param column [Integer]
+    # @return [Boolean]
     def string_at?(line, column)
       node = node_at(line, column)
       # @todo raise InvalidOffset or InvalidRange or something?
@@ -232,7 +244,7 @@ module Solargraph
 
     def all_symbols
       @all_symbols ||= pins.select{ |pin|
-        [Pin::ATTRIBUTE, Pin::CONSTANT, Pin::METHOD, Pin::NAMESPACE].include?(pin.kind)
+        [Pin::ATTRIBUTE, Pin::CONSTANT, Pin::METHOD, Pin::NAMESPACE].include?(pin.kind) and !pin.name.empty?
       }
     end
 

data/lib/solargraph/source/change.rb

@@ -25,13 +25,15 @@ module Solargraph
       # @return [String] The updated text.
       def write text, nullable = false
         if nullable and !range.nil? and new_text.match(/[\.\[\{\(@\$:]$/)
-          if new_text == ':'
+          [':', '@'].each do |dupable|
+            next unless new_text == dupable
             offset = Position.to_offset(text, range.start)
-            if text[offset - 1] == ':'
+            if text[offset - 1] == dupable
               p = Position.from_offset(text, offset - 1)
               r = Change.new(Range.new(p, range.start), ' ')
               text = r.write(text)
             end
+            break
           end
           commit text, "#{new_text[0..-2]} "
         elsif range.nil?

data/lib/solargraph/source/fragment.rb

@@ -3,8 +3,14 @@ module Solargraph
     class Fragment
       include NodeMethods
 
+      # The zero-based line number of the fragment's location.
+      #
+      # @return [Integer]
       attr_reader :line
 
+      # The zero-based column number of the fragment's location.
+      #
+      # @return [Integer]
       attr_reader :column
 
       # @return [Solargraph::Source]
@@ -21,10 +27,14 @@ module Solargraph
         @calculated_literal = false
       end
 
+      # An alias for #column.
+      #
+      # @return [Integer]
       def character
         @column
       end
 
+      # @return [Source::Position]
       def position
         @position ||= Position.new(line, column)
       end
@@ -40,6 +50,8 @@ module Solargraph
         @namespace
       end
 
+      # True if the fragment is inside a method argument.
+      #
       # @return [Boolean]
       def argument?
         @argument ||= !signature_position.nil?
@@ -159,6 +171,8 @@ module Solargraph
 
       # Get the word before the current offset. Given the text `foo.bar`, the
       # word at offset 6 is `ba`.
+      #
+      # @return [String]
       def word
         @word ||= word_at(offset)
       end
@@ -194,14 +208,17 @@ module Solargraph
         @whole_word_range ||= word_range_at(offset, true)
       end
 
+      # @return [Solargraph::Pin::Base]
       def block
         @block ||= @source.locate_block_pin(line, character)
       end
 
+      # @return [Solargraph::Pin::Base]
       def named_path
         @named_path ||= @source.locate_named_path_pin(line, character)
       end
 
+      # @return [Array<Solargraph::Pin::Base>]
       def locals
         @locals ||= @source.locals.select{|pin| pin.visible_from?(block, position)}
       end
@@ -227,10 +244,17 @@ module Solargraph
         @base_literal
       end
 
+      # True if the fragment is inside a literal value.
+      #
+      # @return [Boolean]
       def literal?
         !literal.nil?
       end
 
+      # The fragment's literal type, or nil if the fragment is not inside a
+      # literal value.
+      #
+      # @return [String]
       def literal
         if @literal.nil? and !@calculated_actual_literal
           @calculated_actual_literal = true
@@ -299,7 +323,7 @@ module Solargraph
               end
               if brackets.zero? and parens.zero? and squares.zero?
                 break if ['"', "'", ',', ';', '%'].include?(char)
-                signature = char + signature if char.match(/[a-z0-9:\._@\$]/i) and @code[index - 1] != '%'
+                signature = char + signature if char.match(/[a-z0-9:\._@\$\?\!]/i) and @code[index - 1] != '%'
                 break if char == '$'
                 if char == '@'
                   signature = "@#{signature}" if @code[index-1, 1] == '@'

data/lib/solargraph/source/mapper.rb

@@ -18,10 +18,7 @@ module Solargraph
         @filename = filename
         @code = code
         @node = node
-        @comments = comments
         @node_stack = []
-        # @node_tree = []
-        @comment_hash = {}
         @directives = {}
         @docstring_hash = associate_comments(node, comments)
         # @todo Stuff that needs to be resolved
@@ -60,18 +57,10 @@ module Solargraph
         frag.strip.gsub(/,$/, '')
       end
 
-      def comment_hash
-        @comment_hash
-      end
-
       def filename
         @filename
       end
 
-      def comments
-        @comments
-      end
-
       def pins
         @pins ||= []
       end
@@ -334,10 +323,6 @@ module Solargraph
         @pins.select{|pin| [Pin::NAMESPACE, Pin::METHOD].include?(pin.kind) and pin.location.range.contain?(position)}.last
       end
 
-      def get_namespace_pin position
-        @pins.select{|pin| pin.kind == Pin::NAMESPACE and pin.location.range.contain?(position)}.last
-      end
-
       # @return [YARD::Docstring]
       def docstring_for node
         return @docstring_hash[node.loc] if node.respond_to?(:loc)

data/lib/solargraph/source/updater.rb

@@ -25,6 +25,7 @@ module Solargraph
         @output = nil
       end
 
+      # @return [String]
       def write text, nullable = false
         can_nullify = (nullable and changes.length == 1)
         return @output if @input == text and can_nullify == @did_nullify
@@ -37,6 +38,7 @@ module Solargraph
         @output
       end
 
+      # @return [String]
       def repair text
         changes.each do |ch|
           text = ch.repair(text)

data/lib/solargraph/version.rb

@@ -1,3 +1,3 @@
 module Solargraph
-  VERSION = '0.23.4'
+  VERSION = '0.23.5'
 end

data/lib/solargraph/workspace.rb

@@ -101,10 +101,16 @@ module Solargraph
       false
     end
 
+    # True if the workspace contains at least one gemspec file.
+    #
+    # @return [Boolean]
     def gemspec?
-      return true unless gemspecs.empty?
+      !gemspecs.empty?
     end
 
+    # Get an array of all gemspec files in the workspace.
+    #
+    # @return [Array<String>]
     def gemspecs
       return [] if directory.nil?
       @gemspecs ||= Dir[File.join(directory, '**/*.gemspec')]
@@ -121,7 +127,7 @@ module Solargraph
       source_hash.clear
       unless directory.nil?
         size = config.calculated.length
-        raise WorkspaceTooLargeError.new(size) if config.max_files > 0 and size > config.max_files
+        raise WorkspaceTooLargeError.new(size, config.max_files) if config.max_files > 0 and size > config.max_files
 
         config.calculated.each do |filename|
           source_hash[filename] = Solargraph::Source.load(filename)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: solargraph
 version: !ruby/object:Gem::Version
-  version: 0.23.4
+  version: 0.23.5
 platform: ruby
 authors:
 - Fred Snyder
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-07-09 00:00:00.000000000 Z
+date: 2018-07-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser