solargraph-rails 1.2.0 → 1.2.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: 5805a34ade746eabc3ae7e5f304bd695b19fb2ec997f0fa436530c4954f26e94
4
- data.tar.gz: a4bc0f6c610f76165cddf26f27e8eefecb0996ac9c836bbc1c9e24a8b3df5ca3
3
+ metadata.gz: 7a6cabad967b50006505d8c0d36f88fd69e514fdc2c22a48cb8c765f4c5e572f
4
+ data.tar.gz: e19dd4c1ee77895fe2be5d210e9858d0b965c2a33e5046d38b95087a2ff08491
5
5
  SHA512:
6
- metadata.gz: ca807080c14c79a539f2452d63bebb57d9b977598b9df5e02d53048a0be03cf644a1a81b322b09e55dee2d07657973f60c5a856c1b167b622e2f17f9192c4994
7
- data.tar.gz: cc1901a6eab796d45178d5b4f06e8339edd422a61123e2c20f1580d48d9778d83e6c2d600f02ae76067b535e81e10b705c702ac706a0e924b4500171241b087c
6
+ metadata.gz: 42351f405a2b3d318659adb43a26d26a1d991d61127e2e7159986181015f610ea0368cbd89956c132be5494551f698544379147aa87eb3acfeed1e7b8da282f0
7
+ data.tar.gz: ca5bf29bbd10ab72d015faed081d295ac7fecb11b380939b3e4e5739a3115daa786ab2ccb7e870d344270e05fd5e664780e0731c3a0b33650ade3b5590803159
@@ -4,7 +4,7 @@
4
4
  # act pull_release -j overcommit
5
5
  #
6
6
 
7
- name: Overcommit
7
+ name: Linter
8
8
 
9
9
  on:
10
10
  workflow_dispatch: {}
@@ -16,6 +16,9 @@ on:
16
16
  tags:
17
17
  - 'v*'
18
18
 
19
+ permissions:
20
+ pull-requests: write
21
+
19
22
  jobs:
20
23
  overcommit:
21
24
  runs-on: ubuntu-latest
@@ -28,7 +31,7 @@ jobs:
28
31
  rails-minor: "0"
29
32
  run_coverage: true
30
33
  solargraph-version:
31
- - "0.56.alpha"
34
+ - "0.57.alpha"
32
35
  fail-fast: false
33
36
  steps:
34
37
  - uses: actions/checkout@v2
@@ -69,3 +72,23 @@ jobs:
69
72
  MATRIX_SOLARGRAPH_VERSION: ${{ matrix.solargraph-version }}
70
73
  MATRIX_RAILS_VERSION: ${{ matrix.versions.rails-major }}.${{ matrix.versions.rails-minor }}
71
74
  MATRIX_RAILS_MAJOR_VERSION: ${{ matrix.versions.rails-major }}
75
+ rubocop:
76
+ name: rubocop
77
+ runs-on: ubuntu-latest
78
+ env:
79
+ BUNDLE_ONLY: rubocop
80
+ steps:
81
+ - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
82
+ - uses: ruby/setup-ruby@1a615958ad9d422dd932dc1d5823942ee002799f # v1.227.0
83
+ with:
84
+ ruby-version: '3.3'
85
+ bundler-cache: true
86
+ - uses: reviewdog/action-rubocop@fcb74ba274da10b18d038d0bcddaae3518739634 # v2.21.2
87
+ with:
88
+ reporter: github-pr-check
89
+ skip_install: true
90
+ use_bundler: true
91
+ rubocop_extensions: 'rubocop-performance:gemfile rubocop-rspec:gemfile rubocop-rake:gemfile rubocop-yard:gemfile'
92
+ fail_level: info
93
+ rubocop_version: Gemfile
94
+ level: info
@@ -3,7 +3,7 @@
3
3
  # act pull_request
4
4
  #
5
5
 
6
- name: Ruby
6
+ name: Test
7
7
 
8
8
  on:
9
9
  workflow_dispatch: {}
@@ -16,7 +16,7 @@ on:
16
16
  - 'v*'
17
17
 
18
18
  jobs:
19
- test:
19
+ rspec:
20
20
  runs-on: ubuntu-latest
21
21
  strategy:
22
22
  matrix:
@@ -33,7 +33,7 @@ jobs:
33
33
  - ruby: "3.1"
34
34
  rails-major: "7"
35
35
  rails-minor: "2"
36
- # # ruby 3.2 is minimum Ruby supported by Rails 8.0
36
+ # ruby 3.2 is minimum Ruby supported by Rails 8.0
37
37
  - ruby: "3.2"
38
38
  rails-major: "8"
39
39
  rails-minor: "0"
@@ -43,14 +43,16 @@ jobs:
43
43
  - "0.50.0"
44
44
  - "0.51.2"
45
45
  - "0.52.0"
46
- - "0.56.alpha"
47
46
  - "0.56.0"
47
+ - "0.56.1"
48
+ - "0.56.2"
49
+ - "0.57.alpha"
48
50
  include:
49
51
  - versions:
50
52
  ruby: "3.2"
51
53
  rails-major: "8"
52
54
  rails-minor: "0"
53
- solargraph-version: "0.56.alpha"
55
+ solargraph-version: "0.57.alpha"
54
56
  run_coverage: true
55
57
  fail-fast: false
56
58
  steps:
@@ -68,6 +70,15 @@ jobs:
68
70
  MATRIX_RAILS_MAJOR_VERSION: ${{ matrix.versions.rails-major }}
69
71
  MATRIX_RAILS_VERSION: ${{ matrix.versions.rails-major }}.${{ matrix.versions.rails-minor }}
70
72
 
73
+ - name: Update solargraph from branch if needed
74
+ run: |
75
+ bundle update solargraph
76
+ env:
77
+ # Used in Gemfile/gemspec
78
+ MATRIX_SOLARGRAPH_VERSION: ${{ matrix.solargraph-version }}
79
+ MATRIX_RAILS_MAJOR_VERSION: ${{ matrix.versions.rails-major }}
80
+ MATRIX_RAILS_VERSION: ${{ matrix.versions.rails-major }}.${{ matrix.versions.rails-minor }}
81
+
71
82
  - name: Install child bundle
72
83
  run: |
73
84
  set -x
@@ -82,8 +93,11 @@ jobs:
82
93
  # don't pay attention to the rbs collection regardless
83
94
  if [[ "$MATRIX_SOLARGRAPH_VERSION" != "0.48.0" && "$MATRIX_SOLARGRAPH_VERSION" != "0.49.0" && "$MATRIX_SOLARGRAPH_VERSION" != "0.50.0" ]]
84
95
  then
96
+ cd ../..
97
+ bundle update rbs
98
+ cd ${RAILS_DIR}
85
99
  bundle exec --gemfile ../../Gemfile rbs --version
86
- bundle exec --gemfile ../../Gemfile rbs collection install
100
+ bundle exec --gemfile ../../Gemfile rbs collection update
87
101
  fi
88
102
  cd ../..
89
103
  env:
@@ -17,7 +17,7 @@ on:
17
17
  - 'v*'
18
18
 
19
19
  jobs:
20
- typecheck:
20
+ solargraph:
21
21
  runs-on: ubuntu-latest
22
22
  steps:
23
23
  - uses: actions/checkout@v2
@@ -62,6 +62,8 @@ jobs:
62
62
  # same as used by ruby/setup-ruby
63
63
  ruby --version
64
64
  bundle install
65
+ # reject known bad versions
66
+ echo 'gem "solargraph", ["!= 0.56.2"]' >> .Gemfile
65
67
  bundle update solargraph
66
68
  bundle exec solargraph version
67
69
  # SOLARGRAPH_ASSERTS=on
data/.rubocop.yml CHANGED
@@ -118,6 +118,9 @@ Naming/BlockForwarding: # new in 1.24
118
118
  Enabled: true
119
119
  Naming/PredicateMethod: # new in 1.76
120
120
  Enabled: true
121
+ Naming/PredicatePrefix:
122
+ Exclude:
123
+ - lib/solargraph/rails/annotations/**/*.rb
121
124
  Security/CompoundHash: # new in 1.28
122
125
  Enabled: true
123
126
  Security/IoMethods: # new in 1.22
@@ -218,6 +221,9 @@ Style/OpenStructUse: # new in 1.23
218
221
  Enabled: true
219
222
  Style/OperatorMethodCall: # new in 1.37
220
223
  Enabled: true
224
+ Style/OptionalBooleanParameter:
225
+ Exclude:
226
+ - lib/solargraph/rails/annotations/**/*.rb
221
227
  Style/QuotedSymbols: # new in 1.16
222
228
  Enabled: true
223
229
  Style/RedundantArgument: # new in 1.4
@@ -325,3 +331,4 @@ plugins:
325
331
  - rubocop-performance
326
332
  - rubocop-rspec
327
333
  - rubocop-rake
334
+ - rubocop-yard
data/.rubocop_todo.yml CHANGED
@@ -1,12 +1,12 @@
1
1
  # This configuration was generated by
2
2
  # `rubocop --auto-gen-config`
3
- # on 2025-06-18 12:12:37 UTC using RuboCop version 1.76.1.
3
+ # on 2025-07-11 18:58:31 UTC using RuboCop version 1.78.0.
4
4
  # The point is for the user to remove these configuration records
5
5
  # one by one as the offenses are removed from the code base.
6
6
  # Note that changes in the inspected code, or installation of new
7
7
  # versions of RuboCop, may require this file to be generated again.
8
8
 
9
- # Offense count: 4
9
+ # Offense count: 5
10
10
  # This cop supports safe autocorrection (--autocorrect).
11
11
  # Configuration parameters: TreatCommentsAsGroupSeparators, ConsiderPunctuation, Include.
12
12
  # Include: **/*.gemfile, **/Gemfile, **/gems.rb
@@ -24,7 +24,7 @@ Gemspec/AddRuntimeDependency:
24
24
  Exclude:
25
25
  - 'solargraph-rails.gemspec'
26
26
 
27
- # Offense count: 4
27
+ # Offense count: 6
28
28
  # Configuration parameters: EnforcedStyle, AllowedGems, Include.
29
29
  # SupportedStyles: Gemfile, gems.rb, gemspec
30
30
  # Include: **/*.gemspec, **/Gemfile, **/gems.rb
@@ -65,20 +65,12 @@ Layout/BlockAlignment:
65
65
  Exclude:
66
66
  - 'spec/solargraph-rails/annotate_spec.rb'
67
67
 
68
- # Offense count: 4
68
+ # Offense count: 3
69
69
  # This cop supports safe autocorrection (--autocorrect).
70
70
  Layout/ClosingHeredocIndentation:
71
71
  Exclude:
72
- - 'spec/helpers.rb'
73
72
  - 'spec/solargraph-rails/rails_spec.rb'
74
73
 
75
- # Offense count: 2
76
- # This cop supports safe autocorrection (--autocorrect).
77
- # Configuration parameters: AllowForAlignment.
78
- Layout/CommentIndentation:
79
- Exclude:
80
- - 'Gemfile'
81
-
82
74
  # Offense count: 1
83
75
  # This cop supports safe autocorrection (--autocorrect).
84
76
  Layout/ElseAlignment:
@@ -103,14 +95,12 @@ Layout/EmptyLineBetweenDefs:
103
95
  Exclude:
104
96
  - 'lib/solargraph/rails/model.rb'
105
97
 
106
- # Offense count: 4
98
+ # Offense count: 2
107
99
  # This cop supports safe autocorrection (--autocorrect).
108
100
  Layout/EmptyLines:
109
101
  Exclude:
110
102
  - 'lib/solargraph/rails/model.rb'
111
103
  - 'solargraph-rails.gemspec'
112
- - 'spec/helpers.rb'
113
- - 'spec/solargraph-rails/rails_spec.rb'
114
104
 
115
105
  # Offense count: 3
116
106
  # This cop supports safe autocorrection (--autocorrect).
@@ -121,14 +111,6 @@ Layout/EmptyLinesAroundAttributeAccessor:
121
111
  - 'lib/solargraph/rails/walker.rb'
122
112
  - 'spec/helpers.rb'
123
113
 
124
- # Offense count: 1
125
- # This cop supports safe autocorrection (--autocorrect).
126
- # Configuration parameters: EnforcedStyle.
127
- # SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines, beginning_only, ending_only
128
- Layout/EmptyLinesAroundClassBody:
129
- Exclude:
130
- - 'lib/solargraph/rails/annotations/active_record.rb'
131
-
132
114
  # Offense count: 1
133
115
  # This cop supports safe autocorrection (--autocorrect).
134
116
  # Configuration parameters: EnforcedStyleAlignWith, Severity.
@@ -154,11 +136,10 @@ Layout/HashAlignment:
154
136
  Exclude:
155
137
  - 'lib/solargraph/rails/schema.rb'
156
138
 
157
- # Offense count: 8
139
+ # Offense count: 7
158
140
  # This cop supports safe autocorrection (--autocorrect).
159
141
  Layout/HeredocIndentation:
160
142
  Exclude:
161
- - 'spec/helpers.rb'
162
143
  - 'spec/solargraph-rails/annotate_spec.rb'
163
144
  - 'spec/solargraph-rails/model_spec.rb'
164
145
  - 'spec/solargraph-rails/rails_spec.rb'
@@ -235,12 +216,6 @@ Lint/BooleanSymbol:
235
216
  - 'lib/solargraph/rails/delegate.rb'
236
217
  - 'lib/solargraph/rails/model.rb'
237
218
 
238
- # Offense count: 1
239
- # Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches, IgnoreDuplicateElseBranch.
240
- Lint/DuplicateBranch:
241
- Exclude:
242
- - 'spec/helpers.rb'
243
-
244
219
  # Offense count: 1
245
220
  Lint/DuplicateMethods:
246
221
  Exclude:
@@ -263,11 +238,6 @@ Lint/RedundantStringCoercion:
263
238
  Exclude:
264
239
  - 'script/generate_definitions.rb'
265
240
 
266
- # Offense count: 1
267
- Lint/SelfAssignment:
268
- Exclude:
269
- - 'script/generate_definitions.rb'
270
-
271
241
  # Offense count: 1
272
242
  Lint/SharedMutableDefault:
273
243
  Exclude:
@@ -290,20 +260,19 @@ Lint/UnusedMethodArgument:
290
260
  - 'lib/solargraph-rails.rb'
291
261
  - 'spec/helpers.rb'
292
262
 
293
- # Offense count: 4
263
+ # Offense count: 3
294
264
  # This cop supports safe autocorrection (--autocorrect).
295
265
  # Configuration parameters: AutoCorrect.
296
266
  Lint/UselessAssignment:
297
267
  Exclude:
298
268
  - 'lib/solargraph/rails/delegate.rb'
299
- - 'script/generate_definitions.rb'
300
269
  - 'spec/helpers.rb'
301
270
  - 'spec/spec_helper.rb'
302
271
 
303
- # Offense count: 17
272
+ # Offense count: 22
304
273
  # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
305
274
  Metrics/AbcSize:
306
- Max: 124
275
+ Max: 104
307
276
 
308
277
  # Offense count: 2
309
278
  # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns, inherit_mode.
@@ -311,40 +280,30 @@ Metrics/AbcSize:
311
280
  Metrics/BlockLength:
312
281
  Max: 32
313
282
 
314
- # Offense count: 1
315
- # Configuration parameters: CountBlocks, CountModifierForms.
316
- Metrics/BlockNesting:
317
- Max: 4
318
-
319
- # Offense count: 2
283
+ # Offense count: 3
320
284
  # Configuration parameters: CountComments, CountAsOne.
321
285
  Metrics/ClassLength:
322
286
  Max: 252
323
287
 
324
- # Offense count: 9
288
+ # Offense count: 11
325
289
  # Configuration parameters: AllowedMethods, AllowedPatterns.
326
290
  Metrics/CyclomaticComplexity:
327
- Max: 46
291
+ Max: 36
328
292
 
329
- # Offense count: 20
293
+ # Offense count: 23
330
294
  # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
331
295
  Metrics/MethodLength:
332
- Max: 116
333
-
334
- # Offense count: 1
335
- # Configuration parameters: CountComments, CountAsOne.
336
- Metrics/ModuleLength:
337
- Max: 231
296
+ Max: 75
338
297
 
339
298
  # Offense count: 1
340
299
  # Configuration parameters: CountKeywordArgs, MaxOptionalParameters.
341
300
  Metrics/ParameterLists:
342
301
  Max: 9
343
302
 
344
- # Offense count: 8
303
+ # Offense count: 10
345
304
  # Configuration parameters: AllowedMethods, AllowedPatterns.
346
305
  Metrics/PerceivedComplexity:
347
- Max: 52
306
+ Max: 41
348
307
 
349
308
  # Offense count: 6
350
309
  # This cop supports safe autocorrection (--autocorrect).
@@ -381,7 +340,7 @@ Naming/MemoizedInstanceVariableName:
381
340
  Exclude:
382
341
  - 'lib/solargraph/rails/schema.rb'
383
342
 
384
- # Offense count: 23
343
+ # Offense count: 21
385
344
  # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
386
345
  # AllowedNames: as, at, by, cc, db, id, if, in, io, ip, of, on, os, pp, to
387
346
  Naming/MethodParameterName:
@@ -397,7 +356,6 @@ Naming/MethodParameterName:
397
356
  - 'lib/solargraph/rails/schema.rb'
398
357
  - 'lib/solargraph/rails/storage.rb'
399
358
  - 'lib/solargraph/rails/util.rb'
400
- - 'spec/helpers.rb'
401
359
 
402
360
  # Offense count: 2
403
361
  # This cop supports safe autocorrection (--autocorrect).
@@ -426,13 +384,6 @@ Performance/ConstantRegexp:
426
384
  Exclude:
427
385
  - 'spec/rails8/bin/bundle'
428
386
 
429
- # Offense count: 1
430
- # This cop supports safe autocorrection (--autocorrect).
431
- # Configuration parameters: IncludeActiveSupportAliases.
432
- Performance/DoubleStartEndWith:
433
- Exclude:
434
- - 'spec/helpers.rb'
435
-
436
387
  # Offense count: 1
437
388
  # Configuration parameters: Prefixes, AllowedPatterns.
438
389
  # Prefixes: when, with, without
@@ -459,7 +410,7 @@ RSpec/DescribedClass:
459
410
  Exclude:
460
411
  - 'spec/solargraph-rails/annotate_spec.rb'
461
412
 
462
- # Offense count: 26
413
+ # Offense count: 27
463
414
  # Configuration parameters: CountAsOne.
464
415
  RSpec/ExampleLength:
465
416
  Max: 32
@@ -511,7 +462,7 @@ RSpec/SpecFilePathFormat:
511
462
  - 'spec/solargraph-rails/schema_spec.rb'
512
463
  - 'spec/solargraph-rails/storage_spec.rb'
513
464
 
514
- # Offense count: 10
465
+ # Offense count: 4
515
466
  # This cop supports safe autocorrection (--autocorrect).
516
467
  # Configuration parameters: AllowOnlyRestArgument, UseAnonymousForwarding, RedundantRestArgumentNames, RedundantKeywordRestArgumentNames, RedundantBlockArgumentNames.
517
468
  # RedundantRestArgumentNames: args, arguments
@@ -520,10 +471,8 @@ RSpec/SpecFilePathFormat:
520
471
  Style/ArgumentsForwarding:
521
472
  Exclude:
522
473
  - 'lib/solargraph/rails/walker.rb'
523
- - 'spec/helpers.rb'
524
- - 'spec/rails8/bin/setup'
525
474
 
526
- # Offense count: 11
475
+ # Offense count: 13
527
476
  # This cop supports unsafe autocorrection (--autocorrect-all).
528
477
  # Configuration parameters: EnforcedStyle, EnforcedStyleForClasses, EnforcedStyleForModules.
529
478
  # SupportedStyles: nested, compact
@@ -552,19 +501,11 @@ Style/ConditionalAssignment:
552
501
  Exclude:
553
502
  - 'spec/helpers.rb'
554
503
 
555
- # Offense count: 32
504
+ # Offense count: 39
556
505
  # Configuration parameters: AllowedConstants.
557
506
  Style/Documentation:
558
507
  Enabled: false
559
508
 
560
- # Offense count: 1
561
- # This cop supports safe autocorrection (--autocorrect).
562
- # Configuration parameters: AutoCorrect, EnforcedStyle.
563
- # SupportedStyles: compact, expanded
564
- Style/EmptyMethod:
565
- Exclude:
566
- - 'lib/solargraph/rails/annotations/active_record.rb'
567
-
568
509
  # Offense count: 1
569
510
  # This cop supports safe autocorrection (--autocorrect).
570
511
  Style/ExpandPathArguments:
@@ -573,14 +514,14 @@ Style/ExpandPathArguments:
573
514
 
574
515
  # Offense count: 10
575
516
  # This cop supports safe autocorrection (--autocorrect).
576
- # Configuration parameters: AllowedVars.
517
+ # Configuration parameters: AllowedVars, DefaultToNil.
577
518
  Style/FetchEnvVar:
578
519
  Exclude:
579
520
  - 'Gemfile'
580
521
  - 'solargraph-rails.gemspec'
581
522
  - 'spec/rails8/bin/bundle'
582
523
 
583
- # Offense count: 81
524
+ # Offense count: 93
584
525
  # This cop supports unsafe autocorrection (--autocorrect-all).
585
526
  # Configuration parameters: EnforcedStyle.
586
527
  # SupportedStyles: always, always_true, never
@@ -597,7 +538,7 @@ Style/GlobalStdStream:
597
538
  - 'spec/rails8/bin/setup'
598
539
  - 'spec/rails8/config/environments/production.rb'
599
540
 
600
- # Offense count: 2
541
+ # Offense count: 1
601
542
  # This cop supports safe autocorrection (--autocorrect).
602
543
  # Configuration parameters: MinBodyLength, AllowConsecutiveConditionals.
603
544
  Style/GuardClause:
@@ -622,11 +563,10 @@ Style/HashSyntax:
622
563
  - 'Rakefile'
623
564
  - 'spec/solargraph-rails/schema_spec.rb'
624
565
 
625
- # Offense count: 7
566
+ # Offense count: 2
626
567
  # This cop supports safe autocorrection (--autocorrect).
627
568
  Style/IfUnlessModifier:
628
569
  Exclude:
629
- - 'spec/helpers.rb'
630
570
  - 'spec/rails8/bin/bundle'
631
571
 
632
572
  # Offense count: 1
@@ -650,13 +590,6 @@ Style/MutableConstant:
650
590
  - 'lib/solargraph/rails/schema.rb'
651
591
  - 'lib/solargraph/rails/version.rb'
652
592
 
653
- # Offense count: 1
654
- # This cop supports safe autocorrection (--autocorrect).
655
- # Configuration parameters: IncludeSemanticChanges.
656
- Style/NonNilCheck:
657
- Exclude:
658
- - 'spec/helpers.rb'
659
-
660
593
  # Offense count: 1
661
594
  # This cop supports unsafe autocorrection (--autocorrect-all).
662
595
  # Configuration parameters: EnforcedStyle, AllowedMethods, AllowedPatterns.
@@ -666,13 +599,6 @@ Style/NumericPredicate:
666
599
  - 'spec/**/*'
667
600
  - 'Gemfile'
668
601
 
669
- # Offense count: 1
670
- # Configuration parameters: AllowedMethods.
671
- # AllowedMethods: respond_to_missing?
672
- Style/OptionalBooleanParameter:
673
- Exclude:
674
- - 'lib/solargraph/rails/annotations/time.rb'
675
-
676
602
  # Offense count: 1
677
603
  # This cop supports safe autocorrection (--autocorrect).
678
604
  Style/PerlBackrefs:
@@ -729,21 +655,13 @@ Style/ReturnNilInPredicateMethodDefinition:
729
655
  Exclude:
730
656
  - 'lib/solargraph/rails/walker.rb'
731
657
 
732
- # Offense count: 2
733
- # This cop supports unsafe autocorrection (--autocorrect-all).
734
- # Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods, MaxChainLength.
735
- # AllowedMethods: present?, blank?, presence, try, try!
736
- Style/SafeNavigation:
737
- Exclude:
738
- - 'script/generate_definitions.rb'
739
-
740
658
  # Offense count: 1
741
659
  # This cop supports safe autocorrection (--autocorrect).
742
660
  Style/SelfAssignment:
743
661
  Exclude:
744
662
  - 'lib/solargraph/rails/util.rb'
745
663
 
746
- # Offense count: 6
664
+ # Offense count: 4
747
665
  # This cop supports unsafe autocorrection (--autocorrect-all).
748
666
  Style/SlicingWithRange:
749
667
  Exclude:
@@ -751,14 +669,6 @@ Style/SlicingWithRange:
751
669
  - 'lib/solargraph/rails/devise.rb'
752
670
  - 'lib/solargraph/rails/util.rb'
753
671
  - 'lib/solargraph/rails/walker.rb'
754
- - 'spec/helpers.rb'
755
-
756
- # Offense count: 1
757
- # This cop supports safe autocorrection (--autocorrect).
758
- # Configuration parameters: AllowModifier.
759
- Style/SoleNestedConditional:
760
- Exclude:
761
- - 'spec/helpers.rb'
762
672
 
763
673
  # Offense count: 1
764
674
  # This cop supports unsafe autocorrection (--autocorrect-all).
@@ -784,14 +694,14 @@ Style/StringConcatenation:
784
694
  - 'lib/solargraph-rails.rb'
785
695
  - 'spec/helpers.rb'
786
696
 
787
- # Offense count: 299
697
+ # Offense count: 321
788
698
  # This cop supports safe autocorrection (--autocorrect).
789
699
  # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
790
700
  # SupportedStyles: single_quotes, double_quotes
791
701
  Style/StringLiterals:
792
702
  Enabled: false
793
703
 
794
- # Offense count: 1
704
+ # Offense count: 3
795
705
  # This cop supports safe autocorrection (--autocorrect).
796
706
  # Configuration parameters: .
797
707
  # SupportedStyles: percent, brackets
@@ -799,13 +709,14 @@ Style/SymbolArray:
799
709
  EnforcedStyle: percent
800
710
  MinSize: 13
801
711
 
802
- # Offense count: 1
712
+ # Offense count: 2
803
713
  # This cop supports unsafe autocorrection (--autocorrect-all).
804
714
  # Configuration parameters: AllowMethodsWithArguments, AllowedMethods, AllowedPatterns, AllowComments.
805
715
  # AllowedMethods: define_method
806
716
  Style/SymbolProc:
807
717
  Exclude:
808
718
  - 'spec/helpers.rb'
719
+ - 'spec/rails8/db/migrate/20250619165029_create_models.rb'
809
720
 
810
721
  # Offense count: 3
811
722
  # This cop supports safe autocorrection (--autocorrect).
@@ -839,19 +750,35 @@ Style/TrailingUnderscoreVariable:
839
750
  Exclude:
840
751
  - 'lib/solargraph/rails/rails_api.rb'
841
752
 
842
- # Offense count: 3
753
+ # Offense count: 2
843
754
  # This cop supports safe autocorrection (--autocorrect).
844
755
  # Configuration parameters: EnforcedStyle, MinSize, WordRegex.
845
756
  # SupportedStyles: percent, brackets
846
757
  Style/WordArray:
847
758
  Exclude:
848
759
  - 'lib/solargraph/rails/schema.rb'
849
- - 'spec/helpers.rb'
850
760
  - 'spec/solargraph-rails/schema_spec.rb'
851
761
 
852
- # Offense count: 10
762
+ # Offense count: 3
763
+ # This cop supports safe autocorrection (--autocorrect).
764
+ # Configuration parameters: EnforcedStylePrototypeName.
765
+ # SupportedStylesPrototypeName: before, after
766
+ YARD/MismatchName:
767
+ Exclude:
768
+ - 'lib/solargraph/rails/model.rb'
769
+ - 'lib/solargraph/rails/rails_api.rb'
770
+
771
+ # Offense count: 7
772
+ YARD/TagTypeSyntax:
773
+ Exclude:
774
+ - 'lib/solargraph/rails/annotations/active_record.rb'
775
+ - 'lib/solargraph/rails/annotations/date.rb'
776
+ - 'lib/solargraph/rails/annotations/time.rb'
777
+ - 'lib/solargraph/rails/model.rb'
778
+
779
+ # Offense count: 7
853
780
  # This cop supports safe autocorrection (--autocorrect).
854
- # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns, SplitStrings.
781
+ # Configuration parameters: AllowHeredoc, AllowURI, AllowQualifiedName, URISchemes, IgnoreCopDirectives, AllowedPatterns, SplitStrings.
855
782
  # URISchemes: http, https
856
783
  Layout/LineLength:
857
784
  Max: 198
data/.solargraph.yml CHANGED
@@ -1,6 +1,9 @@
1
1
  ---
2
2
  include:
3
3
  - "**/*.rb"
4
+ - "Gemfile"
5
+ - "Rakefile"
6
+ - "*.gemspec"
4
7
  exclude:
5
8
  - spec/**/*
6
9
  - lib/solargraph/rails/annotations/**/*
data/CHANGELOG.md CHANGED
@@ -2,9 +2,32 @@
2
2
 
3
3
  ## Changes
4
4
 
5
+ ### v1.2.2
6
+
7
+ Features / fixes:
8
+ - Fix bad gem release
9
+
10
+ Internal improvements:
11
+ - Fix checklist to avoid future
12
+
13
+ ### v1.2.1
14
+
15
+ Features / fixes:
16
+ - Add annotation for ActiveRecord::Base#reload
17
+ - Add annotation for Rails::Application.config
18
+ - Add static Rails::Application.config method annotation
19
+ - Retire earlier version expectations
20
+ - Fix changelog typo
21
+
22
+ Internal improvements:
23
+ - CI/testing improvements:
24
+ - Add PR comments, rubocop-yard
25
+ - Update rbs collection in specs
26
+ - Test current Solargraph pre-release PRs
27
+
5
28
  ### v1.2
6
29
 
7
- Most of these are courtesy of @grndr, with integration work by
30
+ Most of these are courtesy of @grncdr, with integration work by
8
31
  @iftheshoefritz and @apiology
9
32
 
10
33
  Features / fixes:
data/DEVELOPMENT.md CHANGED
@@ -73,11 +73,13 @@ Move .yml files into place, then make sure to review the script and uncomment re
73
73
  ## Preparing a release (maintainers)
74
74
 
75
75
  1. Look up [most recent release](https://rubygems.org/gems/solargraph-rails)
76
- 2. Open up [commit list](https://github.com/iftheshoefritz/solargraph-rails/compare/v1.1.2...main)
76
+ 2. Open up [commit list](https://github.com/iftheshoefritz/solargraph-rails/compare/v1.2.1...main)
77
77
  3. Update [CHANGELOG.md](./CHANGELOG.md)
78
78
  4. Flip to 'files changed view' and refine updates
79
79
  5. Bump [version](./lib/solargraph/rails/version.rb) appropriately
80
80
  6. Create branch, commit and merge changes - "Prepare for vX.Y.Z release", branch: prepare_vX.Y.Z_release
81
81
  7. `git config branch.main.remote`
82
- 8. Ensure your local main branch is directly from iftheshoefritz:
83
- 9. `git checkout main && git pull && bundle exec rake release`
82
+ 8. Ensure your local main branch is directly from iftheshoefritz
83
+ 9. `direnv block`
84
+ 10. `git checkout main && git pull && bundle install && bundle exec rake release`
85
+ 11. `direnv allow`