soft_deletion 1.9.0 → 1.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1cf0c1e653102035bfb7f3bf4532a4e3023ebc8a7ead8748914a10bd2ba7185a
-  data.tar.gz: 8303f8471597e6ca82a2c851fcc28f3d293a621eb8cf7892623f8590f137cfbd
+  metadata.gz: aa304747a0e4749f973d98933fde9fd02fecc120f058dedba835ae68920d7b95
+  data.tar.gz: c21df829755fe43cc19272fe307d32c5a0b62b5e8aa9148e2fd511d23b5532b4
 SHA512:
-  metadata.gz: 756500b68386244904fdc517ea3470f421ab7c9381b1fc678b501d28743ffcfb5ad9d5a7df11169c6f39d235100b51db3c93442d93dc969dcf9da576041fcee6
-  data.tar.gz: b34db1ffd120955d4913f91a0c43649edbf5f19cde454a012bd65e3bbabd045c1b8c6d0a70172a5d9150e0d342a2dc25d28b3c06eaf1b9b5440ca56a31767ace
+  metadata.gz: f07e9ae9e39905458c04cd71a28be75b0f7f1dc9abce4d169adab2ed635f42b598e3b5f4677d46a42cade1f858f83baa1edc28b746e765e3c1d7fd99a88d8192
+  data.tar.gz: 9a4ddb8f61ba8f5cf4de6a0478e1cc12ec088cf6c8a61d2d1c71052f2aee5e1ea9fd674d5933457c2c03abddfb74f4963c5a1dd77ee9921b7a2423f6e5707c2e

data/Readme.md

@@ -62,6 +62,7 @@ Authors
  - [Oliver Nightingale](https://github.com/olivernn)
  - [Kumar Pandya](https://github.com/kpandya91)
  - [Alex Pauly](https://github.com/apauly)
+ - [Yaroslav](https://github.com/viralpraxis)
 
 [Zendesk](http://zendesk.com)<br/>
 michael@grosser.it<br/>

data/lib/soft_deletion/core.rb

@@ -86,14 +86,25 @@ module SoftDeletion
 
     protected
 
-    def update_soft_delete_counter_caches(value)
-      each_counter_cached_associations do |association|
-        association.load_target unless association.loaded?
-        if association.target
-          target = association.target
-          target.class.update_counters(target.id, association.reflection.counter_cache_column => value)
+    if ActiveRecord.version >= Gem::Version.new("7.2.0")
+      def update_soft_delete_counter_caches(value) # uncovered NOTE: covered only at Rails >= 7.2.0 tests
+        counter_cached_association_names.each do |association_name| # uncovered
+          update_soft_delete_counter_cache(association(association_name), value) # uncovered
         end
       end
+    else
+      def update_soft_delete_counter_caches(value) # uncovered NOTE: covered only at Rails < 7.2.0 tests
+        each_counter_cached_associations do |association| # uncovered
+          update_soft_delete_counter_cache(association, value) # uncovered
+        end
+      end
+    end
+
+    def update_soft_delete_counter_cache(association, value)
+      association.load_target unless association.loaded?
+      if (target = association.target) # uncovered TODO: add test coverage for target not existing
+        target.class.update_counters(target.id, association.reflection.counter_cache_column => value)
+      end
     end
 
     def _run_soft_delete(method, *args, **kwargs, &block)
@@ -115,7 +126,7 @@ module SoftDeletion
     end
 
     def _run_soft_undelete(&block)
-      raise "#{self.class} is not deleted" unless deleted_at
+      raise "#{self.class} is not deleted" unless deleted_at # uncovered TODO: add test coverage
 
       result = false
       limit = deleted_at - 1.hour

data/lib/soft_deletion/version.rb

@@ -1,3 +1,3 @@
 module SoftDeletion
-  VERSION = '1.9.0'
+  VERSION = '1.11.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: soft_deletion
 version: !ruby/object:Gem::Version
-  version: 1.9.0
+  version: 1.11.0
 platform: ruby
 authors:
 - Michael Grosser
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-11-10 00:00:00.000000000 Z
+date: 2024-11-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -19,7 +19,7 @@ dependencies:
         version: 5.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7.2'
+        version: '8.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,7 +29,7 @@ dependencies:
         version: 5.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7.2'
+        version: '8.1'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -159,7 +159,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.3
+rubygems_version: 3.4.10
 signing_key:
 specification_version: 4
 summary: Explicit soft deletion for ActiveRecord via deleted_at and default scope.