sof-cycle 0.1.8 → 0.1.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bcb187376738c3b567bf2bc9fc68bba6f1cb7e766302a897ab272db848b1b081
-  data.tar.gz: d841689c22f68f7f273d1791feb7753826c3b5c2235deb467fad88ee163ec18f
+  metadata.gz: efa206d4535b7a45567f643a71738506a7c5a3f318180cba1d576a618b178877
+  data.tar.gz: 3946a1dbfc81ef89d33db3ca0bd1df0fd74dc86cc6aef967055dbdac755afd27
 SHA512:
-  metadata.gz: f193e2a83e149315956c99df5efebabfd05c9ade453bb4e4763db1a39870c62c63bae5e6c82379bddd1f07a85a1a6f898fb90d53a753f0936f146efdf6e5f786
-  data.tar.gz: 7000bd01fd3c3302756b757b406f36ec75db9125a3acf597e5c6fb54ab811356e076b4d45087098db94ffb4d4f0151b33d8bd4ce3c1ebe4e4844ae20029aec66
+  metadata.gz: 697ee468ec9ed5a57f2b1e33fa1ae38f865fac62082edca445f263b8862d368017a5ca42667c12bfa45c05853790dcc3163e7577f13ca60c0d8981085cebf4e1
+  data.tar.gz: c20956003342ba14086a563430d04370872eff64eec0e63b9c7c153f892fe6973a6c805d95bf31f4ae05e12d566a33709858cb3dd35fc996c54c36851c7ab10e

data/.tool-versions

@@ -0,0 +1 @@
+ruby 3.4.3

data/CHANGELOG.md

@@ -5,20 +5,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [0.1.8] - 2025-09-04
+## [0.1.10] - 2025-09-04
 
-### Changed
-
-- Simplified `handles?` logic to do string comparison instead of symbol comparison.
-
-## [0.1.7] - 2025-06-09
+## [0.1.9] - 2025-09-04
 
-### Added
-
-- `Cycle#considered_dates` to get the subset of `#covered_dates` that are
-  considered for the cycle's calculations.
-
-### Fixed
+### Changed
 
-- `Cycles::Lookback.volume_to_delay_expiration` now computes correctly when the
-  `#considered_dates` is smaller than the `#covered_dates` of the cycle.
+- Make use of scoping for `Cycle.cycle_handlers` to prevent collisions with other Cycle classes.

data/checksums/sof-cycle-0.1.8.gem.sha512

@@ -0,0 +1 @@
+3fa79340bfbc44787ee3db5a54f4c67155a90a8fb696a17a91a9a76d9e41c7e4c5bb0993d06657ea18bab82f7d89f3a8d4482a3eceedc91c6e34014ce0d97694

data/checksums/sof-cycle-0.1.9.gem.sha512

@@ -0,0 +1 @@
+827bb10a76bdf83a57b26a111b504f2df8506184fc363d6bc8924755db65f87039be4daadddc2b8455928f68e5d81bb174bea63372dbda8c5271341b38bb5094

data/lib/sof/cycle/version.rb

@@ -2,6 +2,6 @@
 
 module SOF
   class Cycle
-    VERSION = "0.1.8"
+    VERSION = "0.1.10"
   end
 end

data/lib/sof/cycle.rb

@@ -69,7 +69,7 @@ module SOF
           raise InvalidInput, "'#{notation}' is not a valid input"
         end
 
-        cycle = cycle_handlers.find do |klass|
+        cycle = Cycle.cycle_handlers.find do |klass|
           parser.parses?(klass.notation_id)
         end.new(notation, parser:)
         return cycle if parser.active?
@@ -84,7 +84,7 @@ module SOF
       #   class_for_notation_id('L')
       #
       def class_for_notation_id(notation_id)
-        cycle_handlers.find do |klass|
+        Cycle.cycle_handlers.find do |klass|
           klass.notation_id == notation_id
         end || raise(InvalidKind, "'#{notation_id}' is not a valid kind of #{name}")
       end
@@ -152,14 +152,14 @@ module SOF
       end
 
       def inherited(klass)
-        cycle_handlers << klass
+        Cycle.cycle_handlers << klass
       end
 
       private
 
       def build_kind_legend
         legend = {}
-        cycle_handlers.each do |handler|
+        Cycle.cycle_handlers.each do |handler|
           # Skip volume_only since it doesn't have a notation_id
           next if handler.instance_variable_get(:@volume_only)
 
@@ -231,7 +231,15 @@ module SOF
     end
 
     # Return the cycle representation as a notation string
-    def notation = self.class.notation(to_h)
+    def notation
+      hash = to_h
+      [
+        "V#{volume}",
+        self.class.notation_id,
+        TimeSpan.notation(hash.slice(:period, :period_count)),
+        hash.fetch(:from, nil)
+      ].compact.join
+    end
 
     # Cycles are considered equal if their hash representations are equal
     def ==(other) = to_h == other.to_h

data/lib/sof/time_span.rb

@@ -29,7 +29,7 @@ module SOF
 
       # Return a notation string from a hash
       def notation(hash)
-        return unless hash.key?(:period)
+        return unless hash.key?(:period) && hash[:period].present?
 
         [
           hash.fetch(:period_count) { 1 },

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sof-cycle
 version: !ruby/object:Gem::Version
-  version: 0.1.8
+  version: 0.1.10
 platform: ruby
 authors:
 - Jim Gay
@@ -46,6 +46,7 @@ files:
 - ".claude/settings.local.json"
 - ".rspec"
 - ".simplecov"
+- ".tool-versions"
 - CHANGELOG.md
 - CLAUDE.md
 - README.md
@@ -55,6 +56,8 @@ files:
 - checksums/sof-cycle-0.1.2.gem.sha512
 - checksums/sof-cycle-0.1.6.gem.sha512
 - checksums/sof-cycle-0.1.7.gem.sha512
+- checksums/sof-cycle-0.1.8.gem.sha512
+- checksums/sof-cycle-0.1.9.gem.sha512
 - lib/sof-cycle.rb
 - lib/sof/cycle.rb
 - lib/sof/cycle/version.rb