sof-cycle 0.1.10 → 0.1.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: efa206d4535b7a45567f643a71738506a7c5a3f318180cba1d576a618b178877
-  data.tar.gz: 3946a1dbfc81ef89d33db3ca0bd1df0fd74dc86cc6aef967055dbdac755afd27
+  metadata.gz: 24c5b52ab1efb27e840af6448d16f2d74074310909a00d6d8a9bd10d42466b83
+  data.tar.gz: a7507d727a8c7d87b34a6cabeccd49abaabb9ae29374bed6c9eff70a800d9c9b
 SHA512:
-  metadata.gz: 697ee468ec9ed5a57f2b1e33fa1ae38f865fac62082edca445f263b8862d368017a5ca42667c12bfa45c05853790dcc3163e7577f13ca60c0d8981085cebf4e1
-  data.tar.gz: c20956003342ba14086a563430d04370872eff64eec0e63b9c7c153f892fe6973a6c805d95bf31f4ae05e12d566a33709858cb3dd35fc996c54c36851c7ab10e
+  metadata.gz: deb2c0b296fef6fdc65fb0db0e7d92934de2c8a402f96757ac357446e87c2dc4d5cd880e6a8a210aed4bc794ff1977bba1397fb2de96aadd909879566851e783
+  data.tar.gz: e238e4937718f34f644acf024ea4aae39742eee04a9b6d0b75a10df2306219ab8c3ac13abf6d7760e401d9554882f467518348ba0744e1eb51cf0fd2741452b9

data/CHANGELOG.md

@@ -5,10 +5,14 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [0.1.10] - 2025-09-04
+## [0.1.12] - 2025-09-05
 
-## [0.1.9] - 2025-09-04
+### Added
+
+- Missing code coverage and updated EndOf to properly handle dormant cycles.
+
+## [0.1.11] - 2025-09-05
 
 ### Changed
 
-- Make use of scoping for `Cycle.cycle_handlers` to prevent collisions with other Cycle classes.
+- Use `time_span.notation` instead of `TimeSpan.notation` in `Cycle#notation`.

data/checksums/sof-cycle-0.1.10.gem.sha512

@@ -0,0 +1 @@
+1dd8e44d63d65dc2efc605dc2957fde47f7b9dfb7b91ddc7cca43bbc420b10366c26512eb940261381f54ad41d3a240dfa13abeaf8d52688c0ba1075b425ac9f

data/checksums/sof-cycle-0.1.11.gem.sha512

@@ -0,0 +1 @@
+3ce0dfe7d95a5cde507d7563ca9aa834457913dff9861d36547cff571fa9371be9fdeb60ec6892edb23b14945ab7a25f569d86cb023b67adfd3028a4570ac381

data/lib/sof/cycle/version.rb

@@ -2,6 +2,6 @@
 
 module SOF
   class Cycle
-    VERSION = "0.1.10"
+    VERSION = "0.1.12"
   end
 end

data/lib/sof/cycle.rb

@@ -236,7 +236,7 @@ module SOF
       [
         "V#{volume}",
         self.class.notation_id,
-        TimeSpan.notation(hash.slice(:period, :period_count)),
+        time_span.notation,
         hash.fetch(:from, nil)
       ].compact.join
     end

data/lib/sof/cycles/end_of.rb

@@ -27,7 +27,7 @@ module SOF
       end
 
       def to_s
-        return dormant_to_s if dormant?
+        return dormant_to_s if parser.dormant? || from_date.nil?
 
         "#{volume}x by #{final_date.to_fs(:american)}"
       end
@@ -45,12 +45,18 @@ module SOF
       #   Cycle.for("V1E18MF2020-01-09")
       #     .expiration_of(anchor: "2020-06-04".to_date)
       #   # => #<Date: 2021-06-30>
-      def expiration_of(_ = nil, anchor: nil) = final_date
+      def expiration_of(_ = nil, anchor: nil)
+        return nil if parser.dormant? || from_date.nil?
+        final_date
+      end
 
       # Is the supplied anchor date prior to the final date?
       #
       # @return [Boolean] true if the cycle is satisfied, false otherwise
-      def satisfied_by?(_ = nil, anchor: Date.current) = anchor <= final_date
+      def satisfied_by?(_ = nil, anchor: Date.current)
+        return false if parser.dormant? || from_date.nil?
+        anchor <= final_date
+      end
 
       # Calculates the final date of the cycle
       #
@@ -61,11 +67,14 @@ module SOF
       # @example
       #   Cycle.for("V1E18MF2020-01-09").final_date
       #   # => #<Date: 2021-06-30>
-      def final_date(_ = nil) = time_span
-        .end_date(start_date - 1.send(period))
-        .end_of_month
+      def final_date(_ = nil)
+        return nil if parser.dormant? || from_date.nil?
+        time_span
+          .end_date(start_date - 1.send(period))
+          .end_of_month
+      end
 
-      def start_date(_ = nil) = from_date.to_date
+      def start_date(_ = nil) = from_date&.to_date
 
       private
 

data/lib/sof/cycles/volume_only.rb

@@ -12,7 +12,7 @@ module SOF
         def handles?(sym) = sym.nil? || sym.to_s == "volume_only"
 
         def validate_period(period)
-          raise InvalidPeriod, <<~ERR.squish unless period.nil?
+          raise Cycle::InvalidPeriod, <<~ERR.squish unless period.nil?
             Invalid period value of '#{period}' provided. Valid periods are:
             #{valid_periods.join(", ")}
           ERR

data/lib/sof/time_span.rb

@@ -49,6 +49,10 @@ module SOF
       end
     end
 
+    def notation
+      [period_count, code].join
+    end
+
     # Class used to calculate the windows of time so that
     # a TimeSpan object will know the correct end of year,
     # quarter, etc.
@@ -63,7 +67,7 @@ module SOF
         end
 
         def for_notation(notation)
-          types.find do |klass|
+          DatePeriod.types.find do |klass|
             klass.code == notation.to_s.upcase
           end
         end
@@ -189,7 +193,7 @@ module SOF
     end
     attr_reader :window
 
-    delegate [:end_date, :begin_date] => :window
+    delegate [:end_date, :begin_date, :code] => :window
 
     def end_date_of_period(date)
       window.end_of_period(date)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sof-cycle
 version: !ruby/object:Gem::Version
-  version: 0.1.10
+  version: 0.1.12
 platform: ruby
 authors:
 - Jim Gay
@@ -53,6 +53,8 @@ files:
 - Rakefile
 - checksums/sof-cycle-0.1.0.gem.sha512
 - checksums/sof-cycle-0.1.1.gem.sha512
+- checksums/sof-cycle-0.1.10.gem.sha512
+- checksums/sof-cycle-0.1.11.gem.sha512
 - checksums/sof-cycle-0.1.2.gem.sha512
 - checksums/sof-cycle-0.1.6.gem.sha512
 - checksums/sof-cycle-0.1.7.gem.sha512