social_stream 0.4.3 → 0.4.4

data/spec/controllers/posts_controller_spec.rb

@@ -2,6 +2,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
 
 describe PostsController do
+  include SocialStream::TestHelpers
   include SocialStream::TestHelpers::Controllers
 
   render_views
@@ -13,16 +14,46 @@ describe PostsController do
     end
 
     describe "posts to user" do
-      before do
-        model_assigned_to @user.sent_ties.received_by(@user).related_by(@user.relations.sort.first).first
+      describe "with first relation" do
+        before do
+          tie = @user.sent_ties.received_by(@user).related_by(@user.relations.sort.first).first
+          model_assigned_to tie
+          @current_model = Factory(:post, :_activity_tie_id => tie)
+        end
+
+        it_should_behave_like "Allow Creating"
+        it_should_behave_like "Allow Destroying"
+      end
+
+      describe "with last relation" do
+        before do
+          tie = @user.sent_ties.received_by(@user).related_by(@user.relations.sort.last).first
+          model_assigned_to tie
+          @current_model = Factory(:post, :_activity_tie_id => tie)
+        end
+
+        it_should_behave_like "Allow Creating"
+        it_should_behave_like "Allow Destroying"
+      end
+
+      describe "with public relation" do
+        before do
+          tie = @user.sent_ties.received_by(@user).related_by(@user.relation_public).first
+          model_assigned_to tie
+          @current_model = Factory(:post, :_activity_tie_id => tie)
+        end
+
+        it_should_behave_like "Allow Creating"
+        it_should_behave_like "Allow Destroying"
       end
 
-      it_should_behave_like "Allow Creating"
     end
 
     describe "post to friend" do
       before do
-        model_assigned_to Factory(:friend, :receiver => @user.actor)
+        friend = Factory(:friend, :receiver => @user.actor).sender
+
+        model_assigned_to friend.activity_ties_for(@user).first
       end
 
       it_should_behave_like "Allow Creating"
@@ -30,12 +61,69 @@ describe PostsController do
 
     describe "post to acquaintance" do
       before do
-        model_assigned_to Factory(:acquaintance, :receiver => @user.actor)
+        ac = Factory(:acquaintance, :receiver => @user.actor).sender
+
+        model_assigned_to Factory(:friend, :sender => @user.actor, :receiver => ac)
       end
 
       it_should_behave_like "Deny Creating"
     end
 
+    describe "posts represented group" do
+      before do
+        @group = Factory(:member, :receiver_id => @user.actor_id).sender_subject
+      end
+
+      describe "with public relation" do
+        before do
+          tie = @group.activity_ties_for(@user).first
+          model_assigned_to tie
+          @current_model = Factory(:post, :_activity_tie_id => tie)
+        end
+
+        it_should_behave_like "Allow Creating"
+        it_should_behave_like "Allow Destroying"
+      end
+
+      context "representing the group" do
+        before do
+          represent(@group)
+        end
+
+        describe "with first relation" do
+          before do
+            tie = @group.sent_ties.received_by(@group).related_by(@group.relations.sort.first).first
+            model_assigned_to tie
+            @current_model = Factory(:post, :_activity_tie_id => tie)
+          end
+
+          it_should_behave_like "Allow Creating"
+          it_should_behave_like "Allow Destroying"
+        end
+
+        describe "with last relation" do
+          before do
+            tie = @group.sent_ties.received_by(@group).related_by(@group.relations.sort.last).first
+            model_assigned_to tie
+            @current_model = Factory(:post, :_activity_tie_id => tie)
+          end
+
+          it_should_behave_like "Allow Creating"
+          it_should_behave_like "Allow Destroying"
+        end
+
+        describe "with public relation" do
+          before do
+            tie = @group.sent_ties.received_by(@group).related_by(@group.relation_public).first
+            model_assigned_to tie
+            @current_model = Factory(:post, :_activity_tie_id => tie)
+          end
+
+          it_should_behave_like "Allow Creating"
+          it_should_behave_like "Allow Destroying"
+        end
+      end
+    end
   end
 end
 

data/spec/controllers/profiles_controller_spec.rb

@@ -21,11 +21,42 @@ describe ProfilesController do
 
       assert_response :success
     end
+
+    it "should not render others edit" do
+      begin
+        get :edit, :user_id => Factory(:user).to_param
+
+        assert false
+      rescue CanCan::AccessDenied
+        assert true
+      end
+    end
+
+    it "should update" do
+      put :update, :user_id => @user.to_param, :profile => { :organization => "Social Stream" }
+
+      response.should redirect_to([@user, :profile])
+    end
+
+    it "should not update other's" do
+      begin
+        put :update, :user_id => Factory(:user).to_param, :profile => { :organization => "Social Stream" }
+
+        assert false
+      rescue CanCan::AccessDenied
+        assert true
+      end
+    end
+
   end
 
   context "for a group" do
     before do
-      @group = Factory(:group)
+      membership = Factory(:member)
+      @group = membership.sender_subject
+      @user  = membership.receiver_subject
+
+      sign_in @user
       represent @group
     end
 
@@ -40,6 +71,32 @@ describe ProfilesController do
 
       assert_response :success
     end
+
+    it "should not render others edit" do
+      begin
+        get :edit, :group_id => Factory(:group).to_param
+
+        assert false
+      rescue CanCan::AccessDenied
+        assert true
+      end
+    end
+
+    it "should update" do
+      put :update, :group_id => @group.to_param, :profile => { :organization => "Social Stream" }
+
+      response.should redirect_to([@group, :profile])
+    end
+
+    it "should not update other's" do
+      begin
+        put :update, :group_id => Factory(:group).to_param, :profile => { :organization => "Social Stream" }
+
+        assert false
+      rescue CanCan::AccessDenied
+        assert true
+      end
+    end
   end
 end
 

data/spec/controllers/representations_controller_spec.rb

@@ -0,0 +1,51 @@
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+
+describe RepresentationsController do
+  include ActionController::RecordIdentifier
+
+  describe "create" do
+    context "with logged user" do
+      before do
+        @user = Factory(:user)
+        sign_in @user
+      end
+
+      context "representing herself" do
+        it "should redirect_to root" do
+          post :create, :representation => { :subject_dom_id => dom_id(@user) }
+
+          response.should redirect_to(:root)
+        end
+      end
+
+      context "representing own group" do
+        before do
+          @group = Factory(:member, :receiver => @user.actor).sender_subject
+        end
+
+        it "should redirect_to root" do
+          post :create, :representation => { :subject_dom_id => dom_id(@group) }
+
+          response.should redirect_to(:root)
+        end
+      end
+
+      context "representing other group" do
+        before do
+          @group = Factory(:group)
+        end
+
+        it "should deny access" do
+          begin
+            post :create, :representation => { :subject_dom_id => dom_id(@group) }
+
+            assert false
+          rescue CanCan::AccessDenied
+            assert true
+          end
+        end
+      end
+    end
+  end
+end
+

data/spec/controllers/users_controller_spec.rb

@@ -15,6 +15,16 @@ describe UsersController do
 
       assert_response :success
     end
+
+    it "should not render edit" do
+      begin
+        get :edit, :id => Factory(:user).to_param
+
+        assert false
+      rescue CanCan::AccessDenied 
+        assert true
+      end
+    end
   end
 
   describe "when authenticated" do
@@ -41,6 +51,24 @@ describe UsersController do
 
       assert_response :success
     end
+
+    it "should render edit page" do
+      pending "Account section"
+      get :edit, :id => @user.to_param
+
+      assert_response :success
+    end
+
+    it "should not render other's edit" do
+      begin
+        get :edit, :id => Factory(:user).to_param
+
+        assert false
+      rescue CanCan::AccessDenied 
+        assert true
+      end
+    end
+
   end
 end
 

data/spec/dummy/config/relations.yml

@@ -12,20 +12,17 @@ user:
     name: friend
     permissions:
       - [ follow ]                       # follow the activities of the friend
-      - [ create,  activity, tie ]       # let the friend create activities to the same tie
+      - [ create,  activity ]            # let the friend create activities
       - [ read,    activity, star_ties ] # friend can read activities from the other friends
-      - [ update,  activity, tie ]       # update activities to the same tie
-      - [ destroy, activity, tie ]       # destroy activities to the same tie
+      - [ update,  activity ]            # update her activities
+      - [ destroy, activity ]            # destroy her activities
+    sphere: personal
   acquaintance:
     name: acquaintance
     parent: friend # friend relation is stronger than acquaintance
     permissions:
       - [ read,    activity, star_ties ]
-  public:
-    name: public
-    parent: acquaintance # acquaintance is stronger than public
-    permissions:
-      - [ read,    activity, star_ties ]
+    sphere: personal
 
 group:
   member:
@@ -37,13 +34,10 @@ group:
       - [ update,  activity, weak_star_ties ] # update and destroy activities to members,
       - [ destroy, activity, weak_star_ties ] # acquaintance and public
       - [ read,    tie,      weak_star_ties ]
+    sphere: organization
   partner:
     name: partner
     parent: member # member is stronger than partner
     permissions:
       - [ read,    activity, star_ties ]
-  public:
-    name: public
-    parent: partner # partner is stronger than public
-    permissions:
-      - [ read,    activity, star_ties ]
+    sphere: organization

data/spec/dummy/db/schema.rb

@@ -1,18 +1,7 @@
-# Use Social Stream migration template
-path = %w( .. .. .. lib generators social_stream templates migration )
-path.unshift File.dirname(__FILE__)
-
-require File.join(*path)
-
-# Use Mailboxer migration template
-finder = Gem::GemPathSearcher.new
-mailboxer_spec = finder.find('mailboxer')
-mailboxer_migration =
-  finder.matching_files(mailboxer_spec,
-                        File.join("generators", "mailboxer", "templates", "migration")).first
-require mailboxer_migration
+require File.join(File.dirname(__FILE__), '..', '..', 'support', 'migrations')
 
 ActiveRecord::Schema.define(:version => 0) do
   CreateMailboxer.up
   CreateSocialStream.up
+  ActsAsTaggableOnMigration.up
 end

data/spec/factories/tie.rb

@@ -14,7 +14,7 @@ Factory.define :acquaintance, :parent => :tie do |t|
 end
 
 Factory.define :public, :parent => :tie do |t|
-  t.after_build { |u| u.relation = u.sender.relation('public') }
+  t.after_build { |u| u.relation = u.sender.relation_public }
 end
 
 # Group ties

data/spec/models/activity_spec.rb

@@ -74,18 +74,32 @@ end
 describe Activity do
   include ActivityTestHelper
 
-  describe "with like subactivity" do
-    before do
-      @like_activity = Factory(:like_activity)
-      @activity = @like_activity.parent
-    end
+  describe "like" do
+
+    describe "activity" do
+      before do
+        @like_activity = Factory(:like_activity)
+        @activity = @like_activity.parent
+      end
 
-    it "should recognize the user who likes it" do
-      assert @activity.liked_by?(@like_activity.sender)
+      it "should recognize the user who likes it" do
+        assert @activity.liked_by?(@like_activity.sender)
+      end
+
+      it "should not recognize the user who does not like it" do
+        assert ! @activity.liked_by?(Factory(:user))
+      end
     end
 
-    it "should not recognize the user who does not like it" do
-      assert ! @activity.liked_by?(Factory(:user))
+    describe "actor" do
+      before do
+        @tie = Factory(:friend)
+        @like = Like.build(@tie.sender, @tie.receiver).save
+      end
+
+      it "should recognize the user who likes it" do
+        assert @tie.receiver.liked_by?(@tie.sender)
+      end
     end
   end
 
@@ -216,11 +230,11 @@ describe Activity do
     end
   end
 
-  describe "belonging to public tie" do
+  describe "belonging to public self tie" do
 
     before do
       user = Factory(:user)
-      tie = user.ties.where(:relation_id => user.relation('public')).first
+      tie = user.ties.where(:relation_id => user.relation_public).first
       create_activity_assigned_to(tie)
     end
 
@@ -229,10 +243,10 @@ describe Activity do
         create_ability_accessed_by_receiver
       end
 
-      it_should_behave_like "Denies Creating"
+      it_should_behave_like "Allows Creating"
       it_should_behave_like "Allows Reading"
-      it_should_behave_like "Denies Updating"
-      it_should_behave_like "Denies Destroying"
+      it_should_behave_like "Allows Updating"
+      it_should_behave_like "Allows Destroying"
     end
     
     describe "accessed by a friend" do
@@ -328,57 +342,4 @@ describe Activity do
       it_should_behave_like "Denies Destroying"
     end
   end
-  
-  describe "belonging to public tie from a member" do
-
-    before do
-      create_activity_assigned_to(Factory(:member).related('public'))
-    end
-
-    describe "accessed by sender" do
-      before do
-        create_ability_accessed_by_receiver
-      end
-
-      it_should_behave_like "Allows Creating"
-      it_should_behave_like "Allows Reading"
-      it_should_behave_like "Allows Updating"
-      it_should_behave_like "Allows Destroying"
-    end
-    
-    describe "accessed by other member" do
-      before do
-        create_ability_accessed_by :member
-      end
-
-      it_should_behave_like "Denies Creating"
-      it_should_behave_like "Allows Reading"
-      it_should_behave_like "Allows Updating"
-      it_should_behave_like "Allows Destroying"
-    end
-
-   
-    describe "accessed by partner" do
-      before do
-        create_ability_accessed_by :partner
-      end
-
-      it_should_behave_like "Denies Creating"
-      it_should_behave_like "Allows Reading"
-      it_should_behave_like "Denies Updating"
-      it_should_behave_like "Denies Destroying"
-    end
-
-    describe "accessed publicly" do
-      before do
-        create_ability_accessed_publicly
-      end
-
-      it_should_behave_like "Denies Creating"
-      it_should_behave_like "Allows Reading"
-      it_should_behave_like "Denies Updating"
-      it_should_behave_like "Denies Destroying"
-    end
-  end
-
 end

data/spec/models/profile_spec.rb

@@ -0,0 +1,38 @@
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+
+describe Profile do
+  context "belonging to a user" do
+    before do
+      @profile = Factory(:user).profile
+    end
+
+    context "accessed by her" do
+      before do
+        @ability = Ability.new(@profile.subject)
+      end
+
+      it "should allow read" do
+        @ability.should be_able_to(:read, @profile)
+      end
+
+      it "should allow update" do
+        @ability.should be_able_to(:update, @profile)
+      end
+    end
+
+    context "accessed by other" do
+      before do
+        @ability = Ability.new(Factory(:user))
+      end
+
+      it "should allow read" do
+        @ability.should be_able_to(:read, @profile)
+      end
+
+      it "should deny update" do
+        @ability.should_not be_able_to(:update, @profile)
+      end
+    end
+
+  end
+end

data/spec/models/tie_activity_spec.rb

@@ -1,49 +1,106 @@
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
 describe TieActivity do
-  describe "for followers" do
-    before do
-      @tie = Factory(:friend)
-
-      @tie_to_sender_friend   = Factory(:friend, :receiver => @tie.sender)
-      @tie_to_receiver_friend = Factory(:friend, :receiver => @tie.receiver)
-    end
-
-    describe "of a public activity" do
+  describe "dissemination" do
+    context "a friend b" do
       before do
-        @a = Factory(:activity, :_tie => @tie.related(@tie.sender.relations.sort.last))
+        @afb = Factory(:friend)
       end
 
-      it "should be created" do
-        assert @tie_to_sender_friend.activities.include?(@a)
-        assert @tie_to_receiver_friend.activities.include?(@a)
-      end
-    end
+      context "c friend a" do
+        before do
+          @cfa = Factory(:friend, :receiver => @afb.sender)
+          @a = Factory(:activity, :_tie => @afb)
+        end
 
-    describe "of a friend activity" do
-      before do
-        @a = Factory(:activity, :_tie => @tie)
-      end
+        it "should not be created" do
+          @cfa.activities.should_not include(@a)
+        end
+
+        context "and a friend c" do
+          before do
+            @afc = Factory(:friend, :sender => @cfa.receiver, :receiver => @cfa.sender)
+            @a = Factory(:activity, :_tie => @afb)
+          end
+
+          it "should be created" do
+            @cfa.activities.should include(@a)
+          end
 
-      it "should not be created" do
-        assert !@tie_to_sender_friend.activities.include?(@a)
-        assert !@tie_to_receiver_friend.activities.include?(@a)
+        end
       end
-    end
 
-    describe "one of them being friend" do
-      before do
-        Factory(:friend, :sender => @tie.sender, :receiver => @tie_to_receiver_friend.sender)
+      context "and d friend b" do
+        before do
+          @dfb = Factory(:friend, :receiver => @afb.receiver)
+          @a = Factory(:activity, :_tie => @afb)
+        end
+
+        it "should not be created" do
+          @dfb.activities.should_not include(@a)
+        end
+
+        context "and b friend d" do
+          before do
+            @bfd = Factory(:friend, :sender => @dfb.receiver, :receiver => @dfb.sender)
+            @a = Factory(:activity, :_tie => @afb)
+          end
+
+          it "should not be created" do
+            @dfb.activities.should_not include(@a)
+          end
+        end
+
       end
 
-      describe "with a friend activity" do
+      context "and b friend a" do
         before do
-          @a = Factory(:activity, :_tie => @tie)
+          @bfa = Factory(:friend, :sender => @afb.receiver, :receiver => @afb.sender)
+        end
+
+        context "c friend a" do
+          before do
+            @cfa = Factory(:friend, :receiver => @afb.sender)
+            @a = Factory(:activity, :_tie => @afb)
+          end
+
+          it "should not be created" do
+            @cfa.activities.should_not include(@a)
+          end
+
+          context "and a friend c" do
+            before do
+              @afc = Factory(:friend, :sender => @cfa.receiver, :receiver => @cfa.sender)
+              @a = Factory(:activity, :_tie => @afb)
+            end
+
+            it "should be created" do
+              @cfa.activities.should include(@a)
+            end
+
+          end
         end
 
-        it "should be created for the friend" do
-          assert !@tie_to_sender_friend.activities.include?(@a)
-          assert @tie_to_receiver_friend.activities.include?(@a)
+        context "and d friend b" do
+          before do
+            @dfb = Factory(:friend, :receiver => @afb.receiver)
+            @a = Factory(:activity, :_tie => @afb)
+          end
+
+          it "should not be created" do
+            @dfb.activities.should_not include(@a)
+          end
+
+          context "and b friend d" do
+            before do
+              @bfd = Factory(:friend, :sender => @dfb.receiver, :receiver => @dfb.sender)
+              @a = Factory(:activity, :_tie => @afb)
+            end
+
+            it "should be created" do
+              @dfb.activities.should include(@a)
+            end
+          end
         end
       end
     end