social_stream-base 0.13.1 → 0.13.2

data/app/helpers/notifications_helper.rb

@@ -1,5 +1,30 @@
 module NotificationsHelper
 
+  # An activity object title
+  def title_of(act_obj)
+    if act_obj.is_a? Comment
+      'Re: ' + title_of(act_obj.parent_post)
+    elsif act_obj.is_a? Post and (not act_obj.text.nil?)
+      act_obj.text.truncate(30, :separator => ' ')
+    elsif act_obj.respond_to? :title and (not act_obj.title.nil?)
+      act_obj.title.truncate(30, :separator => ' ')
+    elsif act_obj.respond_to? :url and (not act_obj.url.nil?)
+      act_obj.url.truncate(30, :separator => ' ')
+    else t('notification.default')
+    end
+  end
+
+  # An activity object description
+  def description_of(act_obj)
+    if act_obj.respond_to? :text and (not act_obj.text.nil?)
+      sanitize(act_obj.text.truncate(100, :separator =>' '))
+    elsif act_obj.respond_to? :description and (not act_obj.description.nil?)
+      sanitize(act_obj.description.truncate(100, :separator =>' '))
+    else
+      t('notification.watch_it')
+    end
+  end
+
   # Set locale as per subject preference
   def locale_as(subject)
     if subject.respond_to? :language

data/app/models/activity.rb

@@ -11,6 +11,8 @@
 #
 # There are two types of wall, :home and :profile. Check {Actor#wall} for more information
 #
+include NotificationsHelper
+
 class Activity < ActiveRecord::Base
   # See {SocialStream::Models::Channeled}
   channeled
@@ -343,32 +345,11 @@ class Activity < ActiveRecord::Base
               :who => I18n.t('notification.who.'+ receiver.subject.class.to_s.underscore,
                               :name => receiver_name))
       when 'post'
-        if direct_object.is_a? Comment
-          I18n.t('notification.post.'+ receiver.subject.class.to_s.underscore, 
-              :sender => sender_name,
-	      :whose => I18n.t('notification.whose.'+ receiver.subject.class.to_s.underscore,
-	                       :receiver => receiver_name),
-	      :title => if direct_object.parent_post.is_a? Post
-	                  'Re: ' + direct_object.parent_post.text.truncate(30, :separator => ' ')
-			elsif direct_object.parent_post.respond_to? :title
-	                  'Re: ' + direct_object.parent_post.title.truncate(30, :separator => ' ')
-			else t('notification.default')
-	                end)
-	elsif direct_object.is_a? Post
-          I18n.t('notification.post.'+ receiver.subject.class.to_s.underscore, 
-              :sender => sender_name,
-	      :whose => I18n.t('notification.whose.'+ receiver.subject.class.to_s.underscore,
-	                       :receiver => receiver_name),
-	      :title => direct_object.text.truncate(30, :separator => ' '))
-	elsif direct_object.respond_to? :title
-          I18n.t('notification.post.'+ receiver.subject.class.to_s.underscore, 
-              :sender => sender_name,
-	      :whose => I18n.t('notification.whose.'+ receiver.subject.class.to_s.underscore,
-	                       :receiver => receiver_name),
-	      :title => direct_object.title.truncate(30, :separator => ' '))
-	else
-	  I18n.t('notification.default')
-	end
+        I18n.t('notification.post.'+ receiver.subject.class.to_s.underscore, 
+            :sender => sender_name,
+            :whose => I18n.t('notification.whose.'+ receiver.subject.class.to_s.underscore,
+                              :receiver => receiver_name),
+	    :title => title_of(direct_object))
       when 'update'
         I18n.t('notification.update.'+ receiver.subject.class.to_s.underscore, 
               :sender => sender_name,

data/app/views/notifications/activities/_post.html.erb

@@ -1,49 +1,14 @@
 <div class="subject">
-<% if activity.direct_object.is_a? Comment %>
-  <%= raw t('notification.post.'+ activity.receiver.subject.class.to_s.underscore, 
-   :sender => link_to(truncate_name(activity.sender.name), 
-                      polymorphic_url(activity.sender.subject)),
-   :whose => t('notification.whose.'+ activity.receiver.subject.class.to_s.underscore,
-              :receiver => truncate_name(activity.receiver.name)),
-   :title => if activity.direct_object.parent_post.is_a? Post
-               link_to(activity.direct_object.parent_post.text.truncate(30, :separator => ' '),
-                     polymorphic_url(activity.direct_object))
-	     elsif activity.direct_object.parent_post.respond_to? :title
-	       link_to(activity.direct_object.parent_post.title.truncate(30, :separator => ' '),
-	             polymorphic_url(activity.direct_object))
-	     else t('notification.default')
-             end) %>
-<% elsif activity.direct_object.is_a? Post %>
-  <%= raw t('notification.post.'+ activity.receiver.subject.class.to_s.underscore, 
-   :sender => link_to(truncate_name(activity.sender.name), 
-                      polymorphic_url(activity.sender.subject)),
-   :whose => t('notification.whose.'+ activity.receiver.subject.class.to_s.underscore,
-              :receiver => truncate_name(activity.receiver.name)),
-   :title => link_to(activity.direct_object.text.truncate(30, :separator => ' '),
-                     polymorphic_url(activity.direct_object))) %>
-<% elsif activity.direct_object.respond_to? :title %>
-  <%= raw t('notification.post.'+ activity.receiver.subject.class.to_s.underscore, 
-   :sender => link_to(truncate_name(activity.sender.name), 
-                      polymorphic_url(activity.sender.subject)),
-   :whose => t('notification.whose.'+ activity.receiver.subject.class.to_s.underscore,
-              :receiver => truncate_name(activity.receiver.name)),
-   :title => link_to(activity.direct_object.title.truncate(30, :separator => ' '),
-                     polymorphic_url(activity.direct_object))) %>
-<% else %>
-  <%= raw t('notification.default') %>
-<% end %>
+<%= raw t('notification.post.'+ activity.receiver.subject.class.to_s.underscore, 
+ :sender => link_to(truncate_name(activity.sender.name), 
+                    polymorphic_url(activity.sender.subject)),
+ :whose => t('notification.whose.'+ activity.receiver.subject.class.to_s.underscore,
+            :receiver => truncate_name(activity.receiver.name)),
+ :title => link_to(title_of(activity.direct_object),
+                   polymorphic_url(activity.direct_object))) %>
 </div>
 <div class="briefing">
-  <% if activity.direct_object.respond_to? :text %>
-    "<%= link_to(sanitize(activity.direct_object.text.truncate(100, :separator =>' ')),
-                     polymorphic_url(activity.direct_object))%>"
-  <% elsif activity.direct_object.respond_to? :description and not activity.direct_object.description.blank? %>
-    "<%= link_to(sanitize(activity.direct_object.description.truncate(100, :separator =>' ')),
-                     polymorphic_url(activity.direct_object))%>"
-  <% else%>
-    <%= link_to(t('notification.watch_it'),
-                polymorphic_url( activity.direct_object))%>
-  <%end%>
+  "<%= link_to(description_of(activity.direct_object), polymorphic_url(activity.direct_object))%>"
   <% if SocialStream.activity_forms.include? :document and activity.direct_object.is_a? Document %>
     
   <% end%>

data/app/views/notifications/activities/_post.text.erb

@@ -1,41 +1,12 @@
 
-<% if activity.direct_object.is_a? Comment %>
 <%= raw t('notification.post.'+ activity.receiver.subject.class.to_s.underscore, 
            :sender => truncate_name(activity.sender.name),
            :whose => t('notification.whose.'+ activity.receiver.subject.class.to_s.underscore,
                      :receiver => truncate_name(activity.receiver.name)),
-           :title => if activity.direct_object.parent_post.is_a? Post
-	               activity.direct_object.parent_post.text.truncate(30, :separator => ' ')
-		     elsif activity.direct_object.parent_post.respond_to? :title
-	               activity.direct_object.parent_post.title.truncate(30, :separator => ' ')
-		     else t('notification.default')
-		     end) %>
-<% elsif activity.direct_object.is_a? Post %>
-<%= raw t('notification.post.'+ activity.receiver.subject.class.to_s.underscore, 
-           :sender => truncate_name(activity.sender.name),
-           :whose => t('notification.whose.'+ activity.receiver.subject.class.to_s.underscore,
-                     :receiver => truncate_name(activity.receiver.name)),
-           :title => activity.direct_object.text.truncate(30, :separator => ' ')) %>
-<% elsif activity.direct_object.respond_to? :title %>
-<%= raw t('notification.post.'+ activity.receiver.subject.class.to_s.underscore, 
-           :sender => truncate_name(activity.sender.name),
-           :whose => t('notification.whose.'+ activity.receiver.subject.class.to_s.underscore,
-                     :receiver => truncate_name(activity.receiver.name)),
-           :title => activity.direct_object.title.truncate(30, :separator => ' ')) %>
-<% else %>
-  <%= raw t('notification.default') %>
-<% end %>
+           :title => title_of(activity.direct_object)) %>
 
-
-<% if activity.direct_object.respond_to? :text %>
-  "<%= sanitize(activity.direct_object.text.truncate(100, :separator =>' '))%>"
---><%= t('notification.all_text', :url => polymorphic_url(activity.direct_object))%>
-<% elsif activity.direct_object.respond_to? :description and not activity.direct_object.description.blank? %>
-  "<%= sanitize(activity.direct_object.description.truncate(100, :separator =>' '))%>"
+"<%= description_of(activity.direct_object) %>"
 --><%= t('notification.all_text', :url => polymorphic_url(activity.direct_object))%>
-<% else%>
-  <%= t('notification.watch', :url => polymorphic_url(activity.direct_object))%>
-<% end%>
 
 <%= raw t('notification.look', 
           :sender => truncate_name(activity.sender.name))%>: <%=polymorphic_url(activity.sender.subject)%>

data/lib/social_stream/base/version.rb

@@ -1,5 +1,5 @@
 module SocialStream
   module Base
-    VERSION = "0.13.1".freeze
+    VERSION = "0.13.2".freeze
   end
 end

data/social_stream-base.gemspec

@@ -16,7 +16,7 @@ Gem::Specification.new do |s|
   # Do not forget to require the file at lib/social_stream/base/dependencies !
   #
   # Rails
-  s.add_runtime_dependency('rails', '>= 3.1.0')
+  s.add_runtime_dependency('rails', '~> 3.1.0')
   # Activity and Relation hierarchies
   s.add_runtime_dependency('ancestry', '~> 1.2.3')
   # SQL foreign keys

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: social_stream-base
 version: !ruby/object:Gem::Version
-  version: 0.13.1
+  version: 0.13.2
   prerelease: 
 platform: ruby
 authors:
@@ -10,22 +10,22 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-01-23 00:00:00.000000000Z
+date: 2012-01-24 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
-  requirement: &85797150 !ruby/object:Gem::Requirement
+  requirement: &86805000 !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
         version: 3.1.0
   type: :runtime
   prerelease: false
-  version_requirements: *85797150
+  version_requirements: *86805000
 - !ruby/object:Gem::Dependency
   name: ancestry
-  requirement: &85796390 !ruby/object:Gem::Requirement
+  requirement: &86804750 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -33,10 +33,10 @@ dependencies:
         version: 1.2.3
   type: :runtime
   prerelease: false
-  version_requirements: *85796390
+  version_requirements: *86804750
 - !ruby/object:Gem::Dependency
   name: foreigner
-  requirement: &85793790 !ruby/object:Gem::Requirement
+  requirement: &86833310 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -44,10 +44,10 @@ dependencies:
         version: 1.1.1
   type: :runtime
   prerelease: false
-  version_requirements: *85793790
+  version_requirements: *86833310
 - !ruby/object:Gem::Dependency
   name: devise
-  requirement: &85793140 !ruby/object:Gem::Requirement
+  requirement: &86833080 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -55,10 +55,10 @@ dependencies:
         version: 1.4.5
   type: :runtime
   prerelease: false
-  version_requirements: *85793140
+  version_requirements: *86833080
 - !ruby/object:Gem::Dependency
   name: inherited_resources
-  requirement: &85792090 !ruby/object:Gem::Requirement
+  requirement: &86832850 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -66,10 +66,10 @@ dependencies:
         version: 1.3.0
   type: :runtime
   prerelease: false
-  version_requirements: *85792090
+  version_requirements: *86832850
 - !ruby/object:Gem::Dependency
   name: stringex
-  requirement: &85791330 !ruby/object:Gem::Requirement
+  requirement: &86832620 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -77,10 +77,10 @@ dependencies:
         version: 1.3.0
   type: :runtime
   prerelease: false
-  version_requirements: *85791330
+  version_requirements: *86832620
 - !ruby/object:Gem::Dependency
   name: avatars_for_rails
-  requirement: &85790690 !ruby/object:Gem::Requirement
+  requirement: &86832390 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -88,10 +88,10 @@ dependencies:
         version: 0.2.2
   type: :runtime
   prerelease: false
-  version_requirements: *85790690
+  version_requirements: *86832390
 - !ruby/object:Gem::Dependency
   name: jquery-rails
-  requirement: &85789870 !ruby/object:Gem::Requirement
+  requirement: &86832160 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -99,10 +99,10 @@ dependencies:
         version: 1.0.9
   type: :runtime
   prerelease: false
-  version_requirements: *85789870
+  version_requirements: *86832160
 - !ruby/object:Gem::Dependency
   name: cancan
-  requirement: &85789320 !ruby/object:Gem::Requirement
+  requirement: &86831930 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -110,10 +110,10 @@ dependencies:
         version: 1.6.4
   type: :runtime
   prerelease: false
-  version_requirements: *85789320
+  version_requirements: *86831930
 - !ruby/object:Gem::Dependency
   name: kaminari
-  requirement: &85788160 !ruby/object:Gem::Requirement
+  requirement: &86831700 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -121,10 +121,10 @@ dependencies:
         version: 0.13.0
   type: :runtime
   prerelease: false
-  version_requirements: *85788160
+  version_requirements: *86831700
 - !ruby/object:Gem::Dependency
   name: omniauth
-  requirement: &85787550 !ruby/object:Gem::Requirement
+  requirement: &86831470 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -132,10 +132,10 @@ dependencies:
         version: 0.2.6
   type: :runtime
   prerelease: false
-  version_requirements: *85787550
+  version_requirements: *86831470
 - !ruby/object:Gem::Dependency
   name: mailboxer
-  requirement: &85786960 !ruby/object:Gem::Requirement
+  requirement: &86831240 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -143,10 +143,10 @@ dependencies:
         version: 0.6.0
   type: :runtime
   prerelease: false
-  version_requirements: *85786960
+  version_requirements: *86831240
 - !ruby/object:Gem::Dependency
   name: acts-as-taggable-on
-  requirement: &85786640 !ruby/object:Gem::Requirement
+  requirement: &86831010 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -154,10 +154,10 @@ dependencies:
         version: 2.0.6
   type: :runtime
   prerelease: false
-  version_requirements: *85786640
+  version_requirements: *86831010
 - !ruby/object:Gem::Dependency
   name: formtastic
-  requirement: &85785220 !ruby/object:Gem::Requirement
+  requirement: &86830780 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -165,10 +165,10 @@ dependencies:
         version: 1.2.3
   type: :runtime
   prerelease: false
-  version_requirements: *85785220
+  version_requirements: *86830780
 - !ruby/object:Gem::Dependency
   name: simple-navigation
-  requirement: &85784190 !ruby/object:Gem::Requirement
+  requirement: &86830550 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -176,10 +176,10 @@ dependencies:
         version: 3.5.1
   type: :runtime
   prerelease: false
-  version_requirements: *85784190
+  version_requirements: *86830550
 - !ruby/object:Gem::Dependency
   name: resque
-  requirement: &85783560 !ruby/object:Gem::Requirement
+  requirement: &86830320 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -187,10 +187,10 @@ dependencies:
         version: 1.19.0
   type: :runtime
   prerelease: false
-  version_requirements: *85783560
+  version_requirements: *86830320
 - !ruby/object:Gem::Dependency
   name: modernizr-rails
-  requirement: &85783020 !ruby/object:Gem::Requirement
+  requirement: &86830090 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -198,10 +198,10 @@ dependencies:
         version: 2.0.6
   type: :runtime
   prerelease: false
-  version_requirements: *85783020
+  version_requirements: *86830090
 - !ruby/object:Gem::Dependency
   name: thinking-sphinx
-  requirement: &85782420 !ruby/object:Gem::Requirement
+  requirement: &86829860 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -209,10 +209,10 @@ dependencies:
         version: 2.0.8
   type: :runtime
   prerelease: false
-  version_requirements: *85782420
+  version_requirements: *86829860
 - !ruby/object:Gem::Dependency
   name: sass-rails
-  requirement: &85781690 !ruby/object:Gem::Requirement
+  requirement: &86829630 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -220,10 +220,10 @@ dependencies:
         version: 3.1.0
   type: :runtime
   prerelease: false
-  version_requirements: *85781690
+  version_requirements: *86829630
 - !ruby/object:Gem::Dependency
   name: rails_autolink
-  requirement: &85780650 !ruby/object:Gem::Requirement
+  requirement: &86829400 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -231,10 +231,10 @@ dependencies:
         version: 1.0.4
   type: :runtime
   prerelease: false
-  version_requirements: *85780650
+  version_requirements: *86829400
 - !ruby/object:Gem::Dependency
   name: social_cheesecake
-  requirement: &85779560 !ruby/object:Gem::Requirement
+  requirement: &86829170 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -242,10 +242,10 @@ dependencies:
         version: 0.2.0
   type: :runtime
   prerelease: false
-  version_requirements: *85779560
+  version_requirements: *86829170
 - !ruby/object:Gem::Dependency
   name: capybara
-  requirement: &85775610 !ruby/object:Gem::Requirement
+  requirement: &86828940 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -253,10 +253,10 @@ dependencies:
         version: 0.3.9
   type: :development
   prerelease: false
-  version_requirements: *85775610
+  version_requirements: *86828940
 - !ruby/object:Gem::Dependency
   name: sqlite3-ruby
-  requirement: &85774270 !ruby/object:Gem::Requirement
+  requirement: &86828750 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -264,10 +264,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *85774270
+  version_requirements: *86828750
 - !ruby/object:Gem::Dependency
   name: ruby-debug19
-  requirement: &85773320 !ruby/object:Gem::Requirement
+  requirement: &86828510 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -275,10 +275,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *85773320
+  version_requirements: *86828510
 - !ruby/object:Gem::Dependency
   name: rspec-rails
-  requirement: &85772320 !ruby/object:Gem::Requirement
+  requirement: &86828260 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -286,10 +286,10 @@ dependencies:
         version: 2.6.1
   type: :development
   prerelease: false
-  version_requirements: *85772320
+  version_requirements: *86828260
 - !ruby/object:Gem::Dependency
   name: factory_girl
-  requirement: &85771400 !ruby/object:Gem::Requirement
+  requirement: &86828010 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -297,10 +297,10 @@ dependencies:
         version: 1.3.2
   type: :development
   prerelease: false
-  version_requirements: *85771400
+  version_requirements: *86828010
 - !ruby/object:Gem::Dependency
   name: forgery
-  requirement: &85770840 !ruby/object:Gem::Requirement
+  requirement: &86827780 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -308,10 +308,10 @@ dependencies:
         version: 0.4.2
   type: :development
   prerelease: false
-  version_requirements: *85770840
+  version_requirements: *86827780
 - !ruby/object:Gem::Dependency
   name: ci_reporter
-  requirement: &85770330 !ruby/object:Gem::Requirement
+  requirement: &86827550 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -319,10 +319,10 @@ dependencies:
         version: 1.6.4
   type: :development
   prerelease: false
-  version_requirements: *85770330
+  version_requirements: *86827550
 - !ruby/object:Gem::Dependency
   name: nifty-generators
-  requirement: &85769900 !ruby/object:Gem::Requirement
+  requirement: &86827320 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -330,7 +330,7 @@ dependencies:
         version: 0.4.5
   type: :development
   prerelease: false
-  version_requirements: *85769900
+  version_requirements: *86827320
 description: ! 'Social Stream is a Ruby on Rails engine providing your application
   with social networking features and activity streams.