social_connections 0.0.13 → 0.0.14

data/.gitignore

@@ -5,5 +5,6 @@ db/social_connections_plugin.sqlite3
 test/debug.log
 tmp/
 .*.swp
+.*.swo
 social_connections*.gem
 .rvmrc

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    social_connections (0.0.7)
+    social_connections (0.0.13)
 
 GEM
   remote: http://rubygems.org/
@@ -33,6 +33,7 @@ GEM
     ansi (1.3.0)
     arel (2.0.10)
     builder (2.1.2)
+    coderay (1.0.6)
     diff-lcs (1.1.3)
     erubis (2.6.6)
       abstract (>= 1.0.0)
@@ -46,8 +47,13 @@ GEM
       i18n (>= 0.4.0)
       mime-types (~> 1.16)
       treetop (~> 1.4.8)
+    method_source (0.7.1)
     mime-types (1.16)
     polyglot (0.3.2)
+    pry (0.9.9.3)
+      coderay (~> 1.0.5)
+      method_source (~> 0.7.1)
+      slop (>= 2.4.4, < 3)
     rack (1.2.3)
     rack-mount (0.6.14)
       rack (>= 1.0.0)
@@ -72,6 +78,7 @@ GEM
       activesupport (~> 3.0)
       railties (~> 3.0)
       rspec (~> 2.6.0)
+    slop (2.4.4)
     sqlite3 (1.3.4)
     thor (0.14.6)
     treetop (1.4.10)
@@ -89,6 +96,7 @@ DEPENDENCIES
   activerecord
   factory_girl_rails
   i18n
+  pry
   rspec
   rspec-rails
   social_connections!

data/README.md

@@ -64,7 +64,7 @@ is the subject and book `b` is the object. A user `v` can connect to user `u` by
 
 	v.connect_to(u)
 
-. If this is issued before invoking `likes` and `comments` as above, user `v` 
+. If this is issued before invoking `likes` and `comments` as above, user `v`
 receives 2 activities.
 
 These activities can be queried:
@@ -103,7 +103,7 @@ The view (e.g. `app/views/books/show.html.erb`) may then contain the following '
 Views
 -----
 
-A list of social activities can be rendered by 
+A list of social activities can be rendered by
 
 	<%= render @social_activities %>
 
@@ -134,12 +134,8 @@ For this, provide a partial at 'app/views/social_activities/_user_comments_user.
 How to run the Tests (in the gem itself, not in your Rails app)
 --------------------
 
-Run test in ./test:
-
-	rake
-
 Run specs in ./spec:
 
-	rspec spec
+	rspec --color spec
 
-Copyright (c) 2011 Chris Oloff, released under the MIT license
+Copyright (c) 2011, 2012 Chris Oloff, released under the MIT license

data/lib/app/models/social_activity.rb

@@ -27,7 +27,9 @@ class SocialActivity < ActiveRecord::Base
   def self.create_activities(subject, verb, object, options = {})
     # TODO: we may want to delay this
     activities = []
-    [ subject, object ].uniq.each do |owner| # one activity for the subject, and one for the object
+    owners = [ subject, object ]
+    owners.concat(options[:additional_recipients]) if options[:additional_recipients]
+    owners.uniq.each do |owner|
       activities << SocialActivity.create(:owner => owner,
                                           :subject => subject,
                                           :verb => verb,
@@ -47,7 +49,7 @@ class SocialActivity < ActiveRecord::Base
                                           :options_as_json => options.to_json)
     end
     activities
-  end 
+  end
 
   def self.unseen_activities(for_whom)
     SocialActivity.where('owner_id = ? and owner_type = ? and unseen = ?',

data/lib/social_connections/version.rb

@@ -1,3 +1,3 @@
 module SocialConnections
-  VERSION = "0.0.13"
+  VERSION = "0.0.14"
 end

data/spec/acts_as_connectable_spec.rb

@@ -0,0 +1,27 @@
+require File.dirname(__FILE__) + '/../test/test_helper'
+
+describe "acts_as_connectable" do
+  before(:each) do
+    @c1 = Connectable.create(:name => 'Anne')
+    @c2 = Connectable.create(:name => 'Bob')
+  end
+  it "defines collection accessors" do
+    c = Connectable.create(:name => 'Tim', :email => '2@test.com')
+    c.should respond_to(:outgoing_social_connections)
+    c.should respond_to(:incoming_social_connections)
+  end
+  it "fails when connecting to 'nil'" do
+    expect { @c1.connect_to(nil) }.to raise_error(ArgumentError)
+  end
+  it "allows adding connections" do
+    @c1.connected_to?(@c2).should be(false)
+    @c1.connect_to(@c2)
+    @c1.connected_to?(@c2).should be(true)
+    @c1.outgoing_social_connections.count.should be(1)
+    @c1.outgoing_social_connections[0].should be_kind_of(SocialConnection)
+    @c1.incoming_social_connections.count.should be(0)
+    @c2.outgoing_social_connections.count.should be(0)
+    @c2.incoming_social_connections.count.should be(1)
+    @c2.incoming_social_connections[0].should be_kind_of(SocialConnection)
+  end
+end

data/spec/social_activities_spec.rb

@@ -13,7 +13,7 @@ describe "Social Activities" do
       activities = @sub.likes(@obj) # what about the 'owner'? everybody 'connected' to the subject *and*
       # the object becomes an owner!
       activities.should_not be_nil
-      activities[0].verb.should eql(:likes) 
+      activities[0].verb.should eql(:likes)
     end
 
     it "allow the verbs given, but no other verbs" do
@@ -81,6 +81,12 @@ describe "Social Activities" do
     activities.select {|a| a.owner == mary}.should_not be_empty # Mary gets an activity, because she's connected to Tim
   end
 
+  it "creates activities for 'additional_recipients'" do
+    mary = Connectable.create(:name => 'Mary')
+    activities = @sub.likes(@obj, :additional_recipients => [ mary ])
+    activities.select {|a| a.owner == mary }.should_not be_empty # Mary gets an activity, because she's in 'addition_recipients'
+  end
+
   it "do *not* create activities for those the subject is connected to" do
     mary = Connectable.create(:name => 'Mary')
     @sub.connect_to(mary) # Tim is now connected to Mary

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: social_connections
 version: !ruby/object:Gem::Version
-  version: 0.0.13
+  version: 0.0.14
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-10-03 00:00:00.000000000Z
+date: 2012-05-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &2157131000 !ruby/object:Gem::Requirement
+  requirement: &70324070772740 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2157131000
+  version_requirements: *70324070772740
 - !ruby/object:Gem::Dependency
   name: sqlite3
-  requirement: &2157130420 !ruby/object:Gem::Requirement
+  requirement: &70324070770780 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2157130420
+  version_requirements: *70324070770780
 - !ruby/object:Gem::Dependency
   name: rspec-rails
-  requirement: &2152641060 !ruby/object:Gem::Requirement
+  requirement: &70324070769620 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152641060
+  version_requirements: *70324070769620
 - !ruby/object:Gem::Dependency
   name: turn
-  requirement: &2152640660 !ruby/object:Gem::Requirement
+  requirement: &70324070767520 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152640660
+  version_requirements: *70324070767520
 - !ruby/object:Gem::Dependency
   name: factory_girl_rails
-  requirement: &2152640260 !ruby/object:Gem::Requirement
+  requirement: &70324070764120 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +65,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152640260
+  version_requirements: *70324070764120
 - !ruby/object:Gem::Dependency
   name: activerecord
-  requirement: &2152639860 !ruby/object:Gem::Requirement
+  requirement: &70324070761020 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,10 +76,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152639860
+  version_requirements: *70324070761020
 - !ruby/object:Gem::Dependency
   name: actionmailer
-  requirement: &2152639460 !ruby/object:Gem::Requirement
+  requirement: &70324070760180 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -87,10 +87,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152639460
+  version_requirements: *70324070760180
 - !ruby/object:Gem::Dependency
   name: i18n
-  requirement: &2152639060 !ruby/object:Gem::Requirement
+  requirement: &70324070759120 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -98,10 +98,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152639060
+  version_requirements: *70324070759120
 - !ruby/object:Gem::Dependency
   name: pry
-  requirement: &2152638660 !ruby/object:Gem::Requirement
+  requirement: &70324070755780 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -109,7 +109,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152638660
+  version_requirements: *70324070755780
 description: The idea is to provide pluggable social connections, activities and a
   method to digest those activities (e.g. in daily emails).
 email:
@@ -147,13 +147,11 @@ files:
 - run-tests.sh
 - social_connections.gemspec
 - spec/activities_aggregator_spec.rb
+- spec/acts_as_connectable_spec.rb
 - spec/mute_and_curious_guest_spec.rb
 - spec/social_activities_spec.rb
-- test/activities_test.rb
-- test/acts_as_connectable_test.rb
 - test/database.yml
 - test/schema.rb
-- test/social_connection_test.rb
 - test/test_helper.rb
 - uninstall.rb
 homepage: https://sites.google.com/site/socialconnections7/
@@ -176,17 +174,15 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: social_connections
-rubygems_version: 1.8.6
+rubygems_version: 1.8.17
 signing_key: 
 specification_version: 3
 summary: Social connections for ActiveRecord.
 test_files:
 - spec/activities_aggregator_spec.rb
+- spec/acts_as_connectable_spec.rb
 - spec/mute_and_curious_guest_spec.rb
 - spec/social_activities_spec.rb
-- test/activities_test.rb
-- test/acts_as_connectable_test.rb
 - test/database.yml
 - test/schema.rb
-- test/social_connection_test.rb
 - test/test_helper.rb

data/test/activities_test.rb

@@ -1,9 +0,0 @@
-# subject, verb, object
-# both subject and object are 'acts_as_connectable'
-# examples:
-# - tim likes idea x
-# - tom comments "this is awesome" on idea y
-# - ben bought deal "25% off on xyz"
-#
-# how to indicate that someone has seen an activity already?
-# by having "owner, subject, verb, object", there could be a flag on the activity?

data/test/acts_as_connectable_test.rb

@@ -1,35 +0,0 @@
-require File.dirname(__FILE__) + '/test_helper'
-
-class ActsAsConnectableTest < ActiveSupport::TestCase
-
-  load_schema
-
-  def setup
-    @connectable1 = Connectable.create(:name => 'Anne')
-    @connectable2 = Connectable.create(:name => 'Bob')
-  end
-
-  test "should define collection accessors" do
-    c = Connectable.create(:name => 'Tim', :email => '2@test.com')
-    assert c.respond_to?(:outgoing_social_connections) == true, "does not respond to outgoing connections getter."
-    assert c.respond_to?(:incoming_social_connections) == true, "does not respond to incoming connections getter."
-    # etc.
-  end
-
-  test "should not allow nil as 'other'" do
-    assert_raise ArgumentError do
-      @connectable1.connect_to(nil)
-    end
-  end
-
-  test "should allow adding connections" do
-    assert @connectable1.connected_to?(@connectable2) == false
-    @connectable1.connect_to(@connectable2)
-    assert @connectable1.connected_to?(@connectable2) == true
-    assert @connectable1.outgoing_social_connections.count == 1
-    assert @connectable1.incoming_social_connections.count == 0
-    assert @connectable2.outgoing_social_connections.count == 0
-    assert @connectable2.incoming_social_connections.count == 1
-  end
-
-end

data/test/social_connection_test.rb

@@ -1,10 +0,0 @@
-require 'test_helper'
-
-class SocialConnectionTest < ActiveSupport::TestCase
-  load_schema
-
-  test "SocialConnection can be instantiated" do
-    assert_kind_of SocialConnection, SocialConnection.new
-  end
-end
-