sober_swag 0.17.0 → 0.21.0

data/lib/sober_swag/nodes/sum.rb

@@ -1,5 +1,13 @@
 module SoberSwag
   module Nodes
+    ##
+    # A "Sum" type represents either one type or the other.
+    #
+    # It is called "Sum" because, if a type can be either type `A` or type `B`,
+    # the number of possible values for the type of `number_of_values(A) + number_of_values(B)`.
+    #
+    # Internally, this is primarily used when an object can be either one type or another.
+    # It will latter be flattened into {SoberSwag::Nodes::OneOf}
     class Sum < Binary
     end
   end

data/lib/sober_swag/output_object/definition.rb

@@ -9,14 +9,56 @@ module SoberSwag
         @views = []
       end
 
-      attr_reader :fields, :views
+      ##
+      # @return [Array<SoberSwag::OutputObject::Field>]
+      attr_reader :fields
+
+      ##
+      # @return [Array<SoberSwag::OutputObject::View>]
+      attr_reader :views
 
       include FieldSyntax
 
+      ##
+      # Adds a "type key", which is basically a field that will be
+      # serialized out to a constant value.
+      #
+      # This is useful if you have multiple types you may want to serialize out, and want consumers of your API to distinguish between them.
+      #
+      # By default this will have the key "type" but you can set it with the keyword arg.
+      # ```ruby
+      #   type_key('MyObject')
+      #   # is equivalent to
+      #   field :type, SoberSwag::Serializer::Primitive.new(SoberSwag::Types::String.enum('MyObject')) do |_, _|
+      #   'MyObject'
+      #   end
+      # ```
+      # @param str [String, Symbol] the value to serialize (will be converted to a string)
+      # @param
+      def type_key(str, field_name: :type)
+        str = str.to_s
+        field(
+          field_name,
+          SoberSwag::Serializer::Primitive.new(
+            SoberSwag::Types::String.enum(str)
+          )
+        ) { |_, _| str }
+      end
+
+      ##
+      # Adds a new field to the fields array
+      # @param field [SoberSwag::OutputObject::Field]
       def add_field!(field)
         @fields << field
       end
 
+      ##
+      # Define a new view, with the view DSL
+      # @param name [Symbol] the name of the view
+      # @param inherits [Symbol] the name of another view this
+      #   view will "inherit" from
+      # @yieldself [SoberSwag::OutputObject::View]
+      # @return [nil] nothing interesting.
       def view(name, inherits: nil, &block)
         initial_fields =
           if inherits.nil? || inherits == :base
@@ -31,6 +73,14 @@ module SoberSwag
         @views << view
       end
 
+      ##
+      # @overload identifier()
+      #   Get the identifier of this output object.
+      #   @return [String] the identifier
+      # @overload identifier(arg)
+      #   Set the identifier of this output object.
+      #   @param arg [String] the external identifier to use for this OutputObject
+      #   @return [String] `arg`
       def identifier(arg = nil)
         @identifier = arg if arg
         @identifier
@@ -38,6 +88,12 @@ module SoberSwag
 
       private
 
+      ##
+      # Get the already-defined view with a specific name.
+      #
+      # @param name [Symbol] name of view to look up
+      # @return [SoberSwag::OutputObject::View] the view found
+      # @raise [ArgumentError] if no view with that name found
       def find_view(name)
         @views.find { |view| view.name == name } || (raise ArgumentError, "no view #{name.inspect} defined!")
       end

data/lib/sober_swag/output_object/field.rb

@@ -4,6 +4,18 @@ module SoberSwag
     # A single field in an output object.
     # Later used to make an actual serializer from this.
     class Field
+      ##
+      # @param name [Symbol] the name of this field
+      # @param serializer [SoberSwag::Serializer::Base, Proc, Lambda] how to serialize
+      #   the value in this field.
+      #   If given a `Proc` or `Lambda`, the `Proc` or `Lambda` should return
+      #   an instance of SoberSwag::Serializer::Base when called.
+      # @param from [Symbol] an optional parameter specifying
+      #   that this field should be plucked "from" another
+      #   attribute of a ruby object
+      # @param block [Proc] a proc to get this field from a serialized
+      #   object. If not given, will try to grab an attribute
+      #   with the same name, *or* with the name of `from:` if that was sent.
       def initialize(name, serializer, from: nil, &block)
         @name = name
         @root_serializer = serializer
@@ -11,12 +23,18 @@ module SoberSwag
         @block = block
       end
 
+      ##
+      # @return [Symbol] name of this field.
       attr_reader :name
 
+      ##
+      # @return [SoberSwag::Serializer::Base]
       def serializer
         @serializer ||= resolved_serializer.serializer.via_map(&transform_proc)
       end
 
+      ##
+      # @return [SoberSwag::Serializer::Base]
       def resolved_serializer
         if @root_serializer.is_a?(Proc)
           @root_serializer.call
@@ -27,17 +45,19 @@ module SoberSwag
 
       private
 
-      def transform_proc # rubocop:disable Metrics/MethodLength
-        if @block
-          @block
-        else
-          key = @from || @name
-          proc do |object, _|
-            if object.respond_to?(key)
-              object.public_send(key)
-            else
-              object[key]
-            end
+      ##
+      # @return [Proc]
+      def transform_proc
+        return @transform_proc if defined?(@transform_proc)
+
+        return @transform_proc = @block if @block
+
+        key = @from || @name
+        @transform_proc = proc do |object, _|
+          if object.respond_to?(key)
+            object.public_send(key)
+          else
+            object[key]
           end
         end
       end

data/lib/sober_swag/output_object/field_syntax.rb

@@ -3,6 +3,13 @@ module SoberSwag
     ##
     # Syntax for definitions that can add fields.
     module FieldSyntax
+      ##
+      # Defines a new field.
+      # @see SoberSwag::OutputObject::Field#initialize
+      # @param name [Symbol] name of this field
+      # @param serializer [SoberSwag::Serializer::Base] serializer to use for this field.
+      # @param from [Symbol] method name to extract this field from, for convenience.
+      # @param block [Proc] optional way to extract this field.
       def field(name, serializer, from: nil, &block)
         add_field!(Field.new(name, serializer, from: from, &block))
       end
@@ -10,22 +17,31 @@ module SoberSwag
       ##
       # Similar to #field, but adds multiple at once.
       # Named #multi because #fields was already taken.
+      #
+      # @param names [Array<Symbol>] the field names to add.
+      # @param serializer [SoberSwag::Serializer::Base] the serializer to use for all fields.
       def multi(names, serializer)
         names.each { |name| field(name, serializer) }
       end
 
       ##
       # Given a symbol to this, we will use a primitive name
+      # @param name [Symbol] symbol to look up.
+      # @return [SoberSwag::Serializer::Base] serializer to use.
       def primitive(name)
         SoberSwag::Serializer.primitive(SoberSwag::Types.const_get(name))
       end
 
       ##
       # Merge in anything that has a list of fields, and use it.
-      # Note that merging in a full blueprint *will not* also merge in views, just fields defined on the base.
-      def merge(other)
+      # Note that merging in a full output object *will not* also merge in views, just fields defined on the base.
+      #
+      # @param other [#fields] a field container, like a {SoberSwag::OutputObject} or something
+      # @param except [Array<Symbol>] optionally exclude a field from the output object being merged
+      # @return [void]
+      def merge(other, except: [])
         other.fields.each do |field|
-          add_field!(field)
+          add_field!(field) unless except.include?(field.name)
         end
       end
     end

data/lib/sober_swag/output_object/view.rb

@@ -3,44 +3,87 @@ module SoberSwag
     ##
     # DSL for defining a view.
     # Used in `view` blocks within {SoberSwag::OutputObject.define}.
+    #
+    # Views are "variants" of {SoberSwag::OutputObject}s that contain
+    # different fields.
     class View < SoberSwag::Serializer::Base
+      ##
+      # Define a new view with the given base fields.
+      # @param name [Symbol] name for this view
+      # @param base_fields [Array<SoberSwag::OutputObject::Field>] fields already defined
+      # @yieldself [SoberSwag::OutputObject::View]
+      #
+      # @return [SoberSwag::OutputObject::View]
       def self.define(name, base_fields, &block)
         new(name, base_fields).tap do |view|
           view.instance_eval(&block)
         end
       end
 
+      ##
+      # An error thrown when you try to nest views inside views.
       class NestingError < Error; end
 
       include FieldSyntax
 
+      ##
+      # @param name [Sybmol] name for this view.
+      # @param base_fields [Array<SoberSwag::OutputObject::Field>] already-defined fields.
       def initialize(name, base_fields = [])
         @name = name
         @fields = base_fields.dup
       end
 
-      attr_reader :name, :fields
+      ##
+      # @return [Symbol] the name of this view
+      attr_reader :name
+
+      ##
+      # @return [Array<SoberSwag::OutputObject::Fields>] the fields defined in this view.
+      attr_reader :fields
 
+      ##
+      # Serialize an object according to this view.
+      # @param object what to serialize
+      # @param opts [Hash] arbitrary options
+      # @return [Hash] the serialized result
       def serialize(obj, opts = {})
         serializer.serialize(obj, opts)
       end
 
+      ##
+      # Get the type of this view.
+      # @return [Class] the type, a subclass of {Dry::Struct}
       def type
         serializer.type
       end
 
+      ##
+      # Excludes a field with the given name from this view.
+      # @param name [Symbol] field to exclude.
+      # @return [nil] nothing interesting
       def except!(name)
         @fields.reject! { |f| f.name == name }
       end
 
+      ##
+      # Always raises {NestingError}
+      # @raise {NestingError} always
       def view(*)
         raise NestingError, 'no views in views'
       end
 
+      ##
+      # Adds a field do this view.
+      # @param field [SoberSwag::OutputObject::Field]
+      # @return [nil] nothing interesting
       def add_field!(field)
         @fields << field
       end
 
+      ##
+      # Pretty show for humans
+      # @return [String]
       def to_s
         "<SoberSwag::OutputObject::View(#{identifier})>"
       end
@@ -48,6 +91,8 @@ module SoberSwag
       ##
       # Get the serializer defined by this view.
       # WARNING: Don't add more fields after you call this.
+      #
+      # @return [SoberSwag::Serializer::FieldList]
       def serializer
         @serializer ||=
           SoberSwag::Serializer::FieldList.new(fields).tap { |s| s.identifier(identifier) }

data/lib/sober_swag/output_object.rb

@@ -5,7 +5,7 @@ module SoberSwag
   # Create a serializer that is heavily inspired by the "Blueprinter" library.
   # This allows you to make "views" and such inside.
   #
-  # Under the hood, this is actually all based on {SoberSwag::Serialzier::Base}.
+  # Under the hood, this is actually all based on {SoberSwag::Serializer::Base}.
   class OutputObject < SoberSwag::Serializer::Base
     autoload(:Field, 'sober_swag/output_object/field')
     autoload(:Definition, 'sober_swag/output_object/definition')
@@ -20,7 +20,7 @@ module SoberSwag
     #
     #     PersonSerializer = SoberSwag::OutputObject.define do
     #       field :id, primitive(:Integer)
-    #       field :name, primtive(:String).optional
+    #       field :name, primitive(:String).optional
     #
     #       view :complex do
     #         field :age, primitive(:Integer)
@@ -32,9 +32,12 @@ module SoberSwag
     # However, this is only a hack to get rid of the weird naming issue when
     # generating swagger from dry structs: their section of the schema area
     # is defined by their *Ruby Class Name*. In the future, if we get rid of this,
-    # we might be able to keep this on the value-level, in which case {#define}
+    # we might be able to keep this on the value-level, in which case {.define}
     # can simply return an *instance* of SoberSwag::Serializer that does
     # the correct thing, with the name you give it. This works for now, though.
+    #
+    # @return [Class] the serializer generated.
+    # @yieldself [SoberSwag::OutputObject::Definition]
     def self.define(&block)
       d = Definition.new.tap do |o|
         o.instance_eval(&block)
@@ -42,28 +45,51 @@ module SoberSwag
       new(d.fields, d.views, d.identifier)
     end
 
+    ##
+    # @param fields [Array<SoberSwag::OutputObject::Field>] the fields for this OutputObject
+    # @param views [Array<SoberSwag::OutputObject::View>] the views for this OutputObject
+    # @param identifier [String] the external identifier for this OutputObject
     def initialize(fields, views, identifier)
       @fields = fields
       @views = views
       @identifier = identifier
     end
 
-    attr_reader :fields, :views, :identifier
+    ##
+    # @return [Array<SoberSwag::OutputObject::Field>]
+    attr_reader :fields
+    ##
+    # @return [Array<SoberSwag::OutputObject::View>]
+    attr_reader :views
+    ##
+    # @return [String] the external ID to use for this object
+    attr_reader :identifier
 
+    ##
+    # Perform serialization.
     def serialize(obj, opts = {})
       serializer.serialize(obj, opts)
     end
 
+    ##
+    # Get a Dry::Struct of the type this OutputObject will serialize to.
     def type
       serializer.type
     end
 
+    ##
+    # Get a serializer for a single view contained in this output object.
+    # Note: given `:base`, it will return a serializer for the base OutputObject
+    # @param name [Symbol] the name of the view
+    # @return [SoberSwag::Serializer::Base] the serializer
     def view(name)
       return base_serializer if name == :base
 
       @views.find { |v| v.name == name }
     end
 
+    ##
+    # A serializer for the "base type" of this OutputObject, with no views.
     def base
       base_serializer
     end
@@ -72,30 +98,25 @@ module SoberSwag
     # Compile down this to an appropriate serializer.
     # It uses {SoberSwag::Serializer::Conditional} to do view-parsing,
     # and {SoberSwag::Serializer::FieldList} to do the actual serialization.
-    def serializer # rubocop:disable Metrics/MethodLength
+    #
+    # @todo: optimize view selection to use binary instead of linear search
+    def serializer
       @serializer ||=
         begin
-          views.reduce(base_serializer) do |base, view|
-            view_serializer = view.serializer
-            SoberSwag::Serializer::Conditional.new(
-              proc do |object, options|
-                if options[:view].to_s == view.name.to_s
-                  [:left, object]
-                else
-                  [:right, object]
-                end
-              end,
-              view_serializer,
-              base
-            )
-          end
+          view_choices = views.map { |view| [view.name.to_s, view.serializer] }.to_h
+          view_choices['base'] = base_serializer
+          SoberSwag::Serializer::Hash.new(view_choices, base, proc { |_, options| options[:view]&.to_s })
         end
     end
 
+    ##
+    # @return [String]
     def to_s
       "<SoberSwag::OutputObject(#{identifier})>"
     end
 
+    ##
+    # @return [SoberSwag::Serializer::FieldList] serializer for this output object.
     def base_serializer
       @base_serializer ||= SoberSwag::Serializer::FieldList.new(fields).tap do |s|
         s.identifier(identifier)

data/lib/sober_swag/parser.rb

@@ -1,13 +1,19 @@
 module SoberSwag
   ##
   # Parses a *Dry-Types Schema* into a set of nodes we can use to compile.
-  # This is mostly because the vistior pattern sucks and catamorphisms are nice.
+  # This is mostly because the visitor pattern sucks and catamorphisms are nice.
+  #
+  # Do not use this class directly, as it is not part of the public api.
+  # Instead, use classes from the {SoberSwag::Compiler} namespace.
   class Parser
     def initialize(node)
       @node = node
       @found = Set.new
     end
 
+    ##
+    # Compile to one of our internal nodes.
+    # @return [SoberSwag::Nodes::Base] the node that describes this type.
     def to_syntax # rubocop:disable Metrics/MethodLength, Metrics/CyclomaticComplexity
       case @node
       when Dry::Types::Default