soaspec 0.0.75 → 0.0.76

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1a8fec6c74ba6ad782e2dce4d39a49d1dbc719ee
-  data.tar.gz: 919092a45ef2d124747918a65377b326f0ea1394
+  metadata.gz: 6c81bc329ff3d5ea409f8842d6de0d4435584a7b
+  data.tar.gz: db52504cab243e4bce49dcf3e6d594cf017eb543
 SHA512:
-  metadata.gz: 2925eca0d16b2598d2f441a0f897d218203eacc55f218ae83e4dd8e245cddb453274bc0bddb421ecff3349b3fcaeedd29128278627c385f9005c68aed5603c0f
-  data.tar.gz: a495c1ac581a044b6df14abc29ecb871d03bc0b1ed804b3aa78f29f951cb4f1a4176ec37175cad0e7749b5fcbac8f9e4aeb3a0cc1258bb4ee9a86e32947ea505
+  metadata.gz: 2c4344b6b2de4ff083ae273740698e1bdc4f203db777bc133183e75110a79089fee3676551a384fba82f8edfa3c92b7b6211d55857471179e440b2450ec2905a
+  data.tar.gz: 7ab42d4c4e2e347b1856d37ca4accd6d2168949500be62a69bba0fa50c822cd208c96deb41c338ed50544f636e8531d1af647ebcabf2cb888da58b961d7cb7e0

data/ChangeLog

@@ -1,3 +1,10 @@
+Version 0.0.76
+* Bug fix
+  * Fixed BLZService scenario on soaspec-virtual-server
+  * Fixed return value for retry_for_success failure
+* Enhancements
+  * Added method to indicate a factory create should actually return a failure status
+
 Version 0.0.75
 * Enhancements
   * For Factory created methods, set retry_for_success to true. Allow for this to be set at Exchange class level

data/lib/soaspec/exchange.rb

@@ -39,6 +39,8 @@ class Exchange
   attr_accessor :retry_count
   # Name used for displaying class
   attr_accessor :test_name
+  # Expect Factory to fail upon trying to create
+  attr_writer :fail_factory
 
   # Set retry for success variable to true so that request will be retried
   # for retry_count until it's true
@@ -80,6 +82,7 @@ class Exchange
     # As a last resort this uses the global parameter. The handler should be set straight before an exchange is made to use this
     @exchange_handler ||= default_handler_used || Soaspec.api_handler
     raise '@exchange_handler not set. Set either with `Soaspec.api_handler = Handler.new` or within the exchange' unless @exchange_handler
+    @fail_factory = nil
     @override_parameters = override_parameters
     @retry_for_success = false
     self.retry_count = 3
@@ -104,11 +107,11 @@ class Exchange
   def make_request
     Soaspec::SpecLogger.add_to 'Example ' + test_name
     request_params = @override_parameters
-    retry_count.times do
-      response = @exchange_handler.make_request(request_params)
+    (1..retry_count).each do |count|
+      response = exchange_handler.make_request(request_params)
       return response unless retry_for_success?
       return response if (200..299).cover? @exchange_handler.status_code_for(response)
-      response
+      break response if count == retry_count
     end
   end
 
@@ -212,7 +215,7 @@ class Exchange
   # Used by FactoryBot
   # @return [Self]
   def save!
-    @retry_for_success = true # Assume using Factory you'll want a positive response
+    @retry_for_success = @fail_factory ? false : true
     call
     self
   end

data/lib/soaspec/test_server/get_bank.rb

@@ -144,8 +144,9 @@ module Soaspec
           blz_element = doc.at_xpath('//tns:blz')
           return 500, error_response_template unless blz_element
           @bank_name = blz_element.inner_text
-          return 500, ERB.new(bank_not_found).result(binding) if @bank_name.to_i == 0
-          @title = 'DAB Bank' if @bank_id == '500'
+          @bank_id = @bank_name.to_i
+          return 500, ERB.new(bank_not_found).result(binding) if @bank_id.zero?
+          @title = 'DAB Bank' if @bank_id == 500
           ERB.new(success_response_template).result(binding)
         end
 

data/lib/soaspec/version.rb

@@ -1,3 +1,3 @@
 module Soaspec
-  VERSION = '0.0.75'.freeze
+  VERSION = '0.0.76'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: soaspec
 version: !ruby/object:Gem::Version
-  version: 0.0.75
+  version: 0.0.76
 platform: ruby
 authors:
 - SamuelGarrattIQA
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-06-11 00:00:00.000000000 Z
+date: 2018-06-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler