soapy_cake 2.2.4 → 2.2.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 70c84bead32dad291a2969cf47b93f30e7ca08ea
-  data.tar.gz: 71bf3ac75e66d776971df47f70e6d955f3034407
+SHA256:
+  metadata.gz: eb3bcbb80c4153edac27b6d2369ec411cb5aef99a3b23296d080847eb3292f51
+  data.tar.gz: 19e63f665281cdb7c2cacee1dcff97e131faad35890f69aa3011910fe4e6c8ce
 SHA512:
-  metadata.gz: a4ef76954d20b9576ceb510fbcbb015fa750f772ca3719b39bfb41df118b360c0929a8ba1cdf220d89ad6c9685350e23ef0189c35c40f2cfc4513df0d150749b
-  data.tar.gz: 79dc72b5b081674155311aaa690e56e567dda81024eb86dadcc3dd786ebed07d43f8955404018e3feae36140fa095eef710448ceb5024c69f3ebf750b1377a56
+  metadata.gz: 054ed6a30bbc79ea7b7c0c5e9eefaec5cb298377b98567f82776036393a2c348b72ade2c5927f0128ce4dc40744da1da120ae0f09ba636921251494e83ec6e58
+  data.tar.gz: b8ca98057e6e01ad4329ed9397c44b4c0394f06cbd2616f52f656259775761778e1cef50be61bcb1530d4614d33a1e2fc20866d5adb1da6a55cd1c2c73bc0157

data/.ruby-version

@@ -1 +1 @@
-2.4.3
+2.5.1

data/lib/soapy_cake/campaigns.rb

@@ -8,12 +8,12 @@ module SoapyCake
     # be in the list.
     ALL_PARAMS = %i[
       account_status_id affiliate_id auto_disposition_delay_hours campaign_id
-      clear_session_on_conversion currency_id display_link_type_id
-      expiration_date expiration_date_modification_type media_type_id
-      offer_contract_id offer_id paid paid_redirects paid_upsells payout
-      payout_update_option pixel_html postback_delay_ms postback_url
-      redirect_404 redirect_domain redirect_offer_contract_id review test_link
-      third_party_name unique_key_hash use_offer_contract_payout
+      clear_session_on_conversion currency_id expiration_date
+      expiration_date_modification_type media_type_id offer_contract_id
+      offer_id paid paid_redirects paid_upsells payout payout_update_option
+      pixel_html postback_delay_ms postback_url redirect_404 redirect_domain
+      redirect_offer_contract_id review test_link third_party_name
+      unique_key_hash use_offer_contract_payout
     ].freeze
 
     NO_CHANGE_VALUES = {
@@ -54,13 +54,14 @@ module SoapyCake
       nil
     end
 
+    # The default for `display_link_type_id` is "Fallback" in Cake, which
+    # doesn't have an ID and, hence, cannot be set via the API. In order to not
+    # change it, it has to be absent from the request.
     def patch(campaign_id, opts = {})
       campaign = get(campaign_id: campaign_id).first
       opts = NO_CHANGE_VALUES
         .merge(
           affiliate_id: campaign.fetch(:affiliate).fetch(:affiliate_id),
-          # Only present in production:
-          display_link_type_id: campaign.dig(:display_link_type, :link_display_type_id) || 1,
           media_type_id: campaign.fetch(:media_type).fetch(:media_type_id),
           offer_contract_id: campaign.fetch(:offer_contract).fetch(:offer_contract_id),
           offer_id: campaign.fetch(:offer).fetch(:offer_id),

data/lib/soapy_cake/client.rb

@@ -29,17 +29,15 @@ module SoapyCake
       request.time_converter = time_converter
 
       with_retries do
-        begin
-          response = Response.new(response_body(request), request.short_response?, time_converter)
-          xml_response? ? response.to_xml : response.to_enum
-        rescue RequestFailed => e
-          raise RequestFailed.new(
-            e.message,
-            request_path: request.path,
-            request_body: request.xml,
-            response_body: e.response_body || response.body
-          )
-        end
+        response = Response.new(response_body(request), request.short_response?, time_converter)
+        xml_response? ? response.to_xml : response.to_enum
+      rescue RequestFailed => e
+        raise RequestFailed.new(
+          e.message,
+          request_path: request.path,
+          request_body: request.xml,
+          response_body: e.response_body || response.body
+        )
       end
     end
 

data/lib/soapy_cake/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SoapyCake
-  VERSION = '2.2.4'
+  VERSION = '2.2.5'
 end

data/spec/fixtures/vcr_cassettes/SoapyCake_Campaigns/_patch/different_pre-existing_values/does_not_change_anything_unintentionally_attribute_set_0_.yml

@@ -252,7 +252,6 @@ http_interactions:
               <cake:clear_session_on_conversion>no_change</cake:clear_session_on_conversion>
               <cake:postback_delay_ms>-1</cake:postback_delay_ms>
               <cake:affiliate_id>9643</cake:affiliate_id>
-              <cake:display_link_type_id>1</cake:display_link_type_id>
               <cake:media_type_id>1</cake:media_type_id>
               <cake:offer_contract_id>10338</cake:offer_contract_id>
               <cake:offer_id>11390</cake:offer_id>

data/spec/fixtures/vcr_cassettes/SoapyCake_Campaigns/_patch/different_pre-existing_values/does_not_change_anything_unintentionally_attribute_set_1_.yml

@@ -254,7 +254,6 @@ http_interactions:
               <cake:clear_session_on_conversion>no_change</cake:clear_session_on_conversion>
               <cake:postback_delay_ms>-1</cake:postback_delay_ms>
               <cake:affiliate_id>9643</cake:affiliate_id>
-              <cake:display_link_type_id>1</cake:display_link_type_id>
               <cake:media_type_id>2</cake:media_type_id>
               <cake:offer_contract_id>10342</cake:offer_contract_id>
               <cake:offer_id>11390</cake:offer_id>

data/spec/fixtures/vcr_cassettes/SoapyCake_Campaigns/_patch/updates_a_campaign.yml

@@ -101,7 +101,6 @@ http_interactions:
               <cake:clear_session_on_conversion>no_change</cake:clear_session_on_conversion>
               <cake:postback_delay_ms>-1</cake:postback_delay_ms>
               <cake:affiliate_id>9643</cake:affiliate_id>
-              <cake:display_link_type_id>1</cake:display_link_type_id>
               <cake:media_type_id>1</cake:media_type_id>
               <cake:offer_contract_id>10338</cake:offer_contract_id>
               <cake:offer_id>11390</cake:offer_id>
@@ -326,7 +325,6 @@ http_interactions:
               <cake:clear_session_on_conversion>no_change</cake:clear_session_on_conversion>
               <cake:postback_delay_ms>-1</cake:postback_delay_ms>
               <cake:affiliate_id>9643</cake:affiliate_id>
-              <cake:display_link_type_id>1</cake:display_link_type_id>
               <cake:media_type_id>1</cake:media_type_id>
               <cake:offer_contract_id>10338</cake:offer_contract_id>
               <cake:offer_id>11390</cake:offer_id>

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: soapy_cake
 version: !ruby/object:Gem::Version
-  version: 2.2.4
+  version: 2.2.5
 platform: ruby
 authors:
 - ad2games GmbH
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-25 00:00:00.000000000 Z
+date: 2018-06-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -289,7 +289,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Simple client for the CAKE API