soapy_cake 2.1.5 → 2.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: da190b758b6c0f5af1430e5936f15513bf9b5683
-  data.tar.gz: 47aba6b6c5ecd4f47991ad65aacca3169f112ce9
+  metadata.gz: 261b8c302bc81cb8b4836cd3165a3a1733ad454c
+  data.tar.gz: a92becdefc65a1bcfdb366dee8c4c13903d4d3b7
 SHA512:
-  metadata.gz: d7e5093f06cd2050420e75aa46da62899bdde5e5b2f6c6597365b1e47ce1428aca4ce567a2f332d8aa59fbb6171fe4e0cc49312bfb3c288de4b93247c982ecea
-  data.tar.gz: b690df62a8de310a3d7b82888bece55842a5a99896b195e2cefef944ae1e63d350636615bc5a7670db092f1c78de4597531a9ad658bc0c8029ad93e6c149fe81
+  metadata.gz: 112e8a8644afc6dab8168bf2eb1dde11b8198de32aa154409d1ebda8271136491187dedc398a7d3e24321f128fd504ce60a164587dba89b16cad7f26e5e08c98
+  data.tar.gz: 5a27e9132ffddb8adcba3df5143aa5263120a3057255b9c7920e5d2bc0b9e46af5a9595040c4c2962bb905fb04a0c3c8e3db7f8beaf416c04425b1be46297d86

data/.ruby-version

@@ -1 +1 @@
-2.3.1
+2.3.4

data/api.yml

@@ -98,8 +98,7 @@ versions:
       conversion_dispositions: 2
       decrypt_affiliate_link: 1
       mass_conversion_adjustment: 2
-      # Version 2 returns an error about an invalid action, so using version 1
-      mass_conversion_insert: 1
+      mass_conversion_insert: 2
       rejected_dispositions: 1
       update_conversion: 4
       update_conversion_disposition: 2

data/lib/soapy_cake/admin_track.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require 'soapy_cake/request_mass_conversion_insert'
+
 module SoapyCake
   class AdminTrack < Client
     include Helper
@@ -21,7 +23,7 @@ module SoapyCake
                        campaign_id creative_id total_to_insert
                      ])
 
-      run Request.new(:admin, :track, :mass_conversion_insert, opts)
+      run RequestMassConversionInsert.new(:admin, :track, :mass_conversion_insert, opts)
     end
 
     def update_conversion(opts)

data/lib/soapy_cake/request_mass_conversion_insert.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+module SoapyCake
+  class RequestMassConversionInsert < Request
+    private
+
+    # There is a bug in MassConversionInsert version 2 API in cake,
+    # in which xmlns is still using version 1.
+    def xml_namespaces
+      {
+        'xmlns:env' => 'http://www.w3.org/2003/05/soap-envelope',
+        'xmlns:cake' => 'http://cakemarketing.com/api/1/'
+      }
+    end
+  end
+end

data/lib/soapy_cake/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SoapyCake
-  VERSION = '2.1.5'
+  VERSION = '2.1.6'
 end

data/soapy_cake.gemspec

@@ -32,4 +32,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'webmock'
   spec.add_development_dependency 'pry'
   spec.add_development_dependency 'timecop'
+  spec.add_development_dependency 'dotenv'
 end

data/spec/fixtures/vcr_cassettes/SoapyCake_AdminTrack/_mass_conversion_insert/inserts_conversions.yml

@@ -2,9 +2,9 @@
 http_interactions:
 - request:
     method: post
-    uri: https://cake-partner-domain.com/api/1/track.asmx
+    uri: https://cake-partner-domain.com/api/2/track.asmx
     body:
-      encoding: UTF-8
+      encoding: ASCII-8BIT
       string: |
         <?xml version="1.0"?>
         <env:Envelope xmlns:env="http://www.w3.org/2003/05/soap-envelope" xmlns:cake="http://cakemarketing.com/api/1/">
@@ -12,18 +12,28 @@ http_interactions:
           <env:Body>
             <cake:MassConversionInsert>
               <cake:api_key>cake-api-key</cake:api_key>
-              <cake:conversion_date>2015-05-06T02:00:00</cake:conversion_date>
+              <cake:conversion_date>2015-05-07T02:00:00</cake:conversion_date>
               <cake:affiliate_id>16059</cake:affiliate_id>
               <cake:campaign_id>13268</cake:campaign_id>
               <cake:sub_affiliate/>
               <cake:creative_id>5521</cake:creative_id>
-              <cake:total_to_insert>12</cake:total_to_insert>
+              <cake:total_to_insert>3</cake:total_to_insert>
+              <cake:note>Test created on 2017-07-24</cake:note>
+              <cake:payout>0.1</cake:payout>
+              <cake:received>0.2</cake:received>
+              <cake:transaction_ids>test-transaction-id-1,test-transaction-id-2,test-transaction-id-3</cake:transaction_ids>
             </cake:MassConversionInsert>
           </env:Body>
         </env:Envelope>
     headers:
       Content-Type:
       - application/soap+xml;charset=UTF-8
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
   response:
     status:
       code: 200
@@ -31,18 +41,18 @@ http_interactions:
     headers:
       Cache-Control:
       - private, max-age=0
+      Content-Length:
+      - '464'
       Content-Type:
       - application/soap+xml; charset=utf-8
-      Server:
-      - Microsoft-IIS/8.0
+      Date:
+      - Mon, 24 Jul 2017 19:42:39 GMT
       X-Aspnet-Version:
       - 4.0.30319
       X-Powered-By:
       - ASP.NET
-      Date:
-      - Wed, 06 May 2015 12:35:51 GMT
-      Content-Length:
-      - '464'
+      Connection:
+      - close
     body:
       encoding: UTF-8
       string: <?xml version="1.0" encoding="utf-8"?><soap:Envelope xmlns:soap="http://www.w3.org/2003/05/soap-envelope"
@@ -50,5 +60,5 @@ http_interactions:
         xmlns="http://cakemarketing.com/api/1/"><MassConversionInsertResult><success>true</success><message>Conversions
         Inserted</message></MassConversionInsertResult></MassConversionInsertResponse></soap:Body></soap:Envelope>
     http_version: 
-  recorded_at: Wed, 06 May 2015 12:35:53 GMT
-recorded_with: VCR 2.9.3
+  recorded_at: Mon, 24 Jul 2017 19:42:40 GMT
+recorded_with: VCR 3.0.3

data/spec/integration/soapy_cake/admin_track_spec.rb

@@ -8,12 +8,16 @@ RSpec.describe SoapyCake::AdminTrack do
   describe '#mass_conversion_insert', :vcr do
     it 'inserts conversions' do
       result = admin_track.mass_conversion_insert(
-        conversion_date: Date.new(2015, 5, 6),
+        conversion_date: Date.new(2015, 5, 7),
         affiliate_id: 16059,
         campaign_id: 13268,
         sub_affiliate: '',
         creative_id: 5521,
-        total_to_insert: 12
+        total_to_insert: 3,
+        note: 'Test created on 2017-07-24',
+        payout: 0.1,
+        received: 0.2,
+        transaction_ids: (1..3).map { |i| "test-transaction-id-#{i}" }.join(',')
       )
 
       expect(result).to eq(success: true, message: 'Conversions Inserted')

data/spec/spec_helper.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require 'dotenv/load'
 require 'simplecov'
 SimpleCov.start do
   add_filter '/spec/'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: soapy_cake
 version: !ruby/object:Gem::Version
-  version: 2.1.5
+  version: 2.1.6
 platform: ruby
 authors:
 - ad2games GmbH
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-27 00:00:00.000000000 Z
+date: 2017-07-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -164,6 +164,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: dotenv
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Simple client for the CAKE API (http://getcake.com)
 email:
 - developers@ad2games.com
@@ -194,6 +208,7 @@ files:
 - lib/soapy_cake/helper.rb
 - lib/soapy_cake/modification_type.rb
 - lib/soapy_cake/request.rb
+- lib/soapy_cake/request_mass_conversion_insert.rb
 - lib/soapy_cake/response.rb
 - lib/soapy_cake/response_value.rb
 - lib/soapy_cake/time_converter.rb
@@ -271,7 +286,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: Simple client for the CAKE API