soapy_cake 2.1.3 → 2.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a37f381f91ecea276b653c460ae2caaa092780aa
-  data.tar.gz: f38754f61d72c837f36349d1db27f9b992c6fdf1
+  metadata.gz: 67f28d72d0e7ce5c2d37d3d138d0a8e2579b9696
+  data.tar.gz: 737fced76a4f046d011fd6e57817ff0c29f5d435
 SHA512:
-  metadata.gz: 83fbab922c38a5ef3f02c431637b6e49c152a2e573edc05c609c7b482faf7e8dcde32510a68ec674ef143deaef373bade1c69129abdcf9781ede0ddcf2d29d04
-  data.tar.gz: 61aa15d8fd949a4783941893910519771c268d66e572c74e5edb0c2d37c94e2bd46249012802d2366504352f0fb7d512dbd1c2ce521bfb2f8091bee958cc1191
+  metadata.gz: a418b18bb03685e298fedd73aee586fed6c7aa45a0989609b0892cbaf99ab15d2d4919a0a2f2fc0b1e049c66f387fee19ee8df1986ce4653adeac4b459e8c041
+  data.tar.gz: 2f31ae5c96fc4f9e101a9f5aca857f99d6777b278125a21a5ecd3e6016c4b48cc68cc453fb931247a174afa379b149f8e01b6fea1cb819b6625bf5565fd65806

data/Gemfile

@@ -1,10 +1,11 @@
 # frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 gemspec
 
 group :development, :test do
+  gem 'codeclimate-test-reporter', require: false
   gem 'rubocop-ci', git: 'https://github.com/ad2games/rubocop-ci'
   gem 'simplecov'
-  gem 'codeclimate-test-reporter', require: false
 end

data/Rakefile

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 require 'rubocop-ci'

data/api.yml

@@ -77,7 +77,7 @@ versions:
       campaign_summary: 2
       creative_summary: 2
       caps: 4
-      clicks: 7
+      clicks: 11
       conversion_changes: 10
       conversions: 11
       daily_summary_export: 1

data/lib/soapy_cake.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'yaml'
 require 'logger'
 require 'nokogiri'
@@ -27,6 +28,6 @@ require 'soapy_cake/modification_type'
 require 'soapy_cake/campaigns'
 
 module SoapyCake
-  API_CONFIG = YAML.load(File.read(File.expand_path('../../api.yml', __FILE__)))
+  API_CONFIG = YAML.safe_load(File.read(File.expand_path('../../api.yml', __FILE__)))
   NET_TIMEOUT = 600
 end

data/lib/soapy_cake/admin.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module SoapyCake
   # rubocop:disable Metrics/ClassLength
   class Admin < Client

data/lib/soapy_cake/admin_addedit.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module SoapyCake
   # rubocop:disable Metrics/ClassLength
   class AdminAddedit < Client

data/lib/soapy_cake/admin_batched.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module SoapyCake
   class AdminBatched
     ALLOWED_METHODS = %i(

data/lib/soapy_cake/admin_track.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module SoapyCake
   class AdminTrack < Client
     include Helper

data/lib/soapy_cake/affiliate.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module SoapyCake
   class Affiliate < Client
     def bills(opts = {})

data/lib/soapy_cake/campaigns.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module SoapyCake
   class Campaigns
     include Helper
@@ -59,7 +60,7 @@ module SoapyCake
         .merge(
           affiliate_id: campaign.fetch(:affiliate).fetch(:affiliate_id),
           # Only present in production:
-          display_link_type_id: campaign.dig(:link_display_type, :link_display_type_id) || 1,
+          display_link_type_id: campaign.dig(:display_link_type, :link_display_type_id) || 1,
           media_type_id: campaign.fetch(:media_type).fetch(:media_type_id),
           offer_contract_id: campaign.fetch(:offer_contract).fetch(:offer_contract_id),
           offer_id: campaign.fetch(:offer).fetch(:offer_id),

data/lib/soapy_cake/client.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'net/http'
 
 module SoapyCake
@@ -57,6 +58,16 @@ module SoapyCake
       @logger ||= opts[:logger] || (defined?(::Rails) && ::Rails.logger)
     end
 
+    def log_curl_command(request)
+      curl_headers = HEADERS.map { |k, v| "-H \"#{k}: #{v}\"" }.join(' ')
+      curl_body = request.xml
+        .tr("\n", '')
+        .gsub(/>\s*</, '><')
+        .sub(request.api_key, '{{{ INSERT API KEY }}}')
+
+      logger&.info("curl --data '#{curl_body}' #{curl_headers} https://#{domain}/#{request.path}")
+    end
+
     def response_body(request)
       request.opts[:response].presence || http_response(request)
     end
@@ -64,6 +75,8 @@ module SoapyCake
     def http_response(request)
       logger&.info("soapy_cake:request #{request}")
 
+      log_curl_command(request) if fetch_opt(:log_curl)
+
       http_request = Net::HTTP::Post.new(request.path, HEADERS)
       http_request.body = request.xml
       response = perform_http_request(http_request)

data/lib/soapy_cake/const.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module SoapyCake
   module Const
     # The ID mapping in the API docs is wrong, these values are taken from the UI.

data/lib/soapy_cake/error.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module SoapyCake
   class Error < RuntimeError; end
   class RequestFailed < Error; end

data/lib/soapy_cake/helper.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module SoapyCake
   module Helper
     def walk_tree(obj, key = nil, &block)

data/lib/soapy_cake/modification_type.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module SoapyCake
   class ModificationType
     CHANGE = 'change'

data/lib/soapy_cake/request.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module SoapyCake
   class Request
     DATE_CLASSES = [Date, Time, DateTime, ActiveSupport::TimeWithZone].freeze

data/lib/soapy_cake/response.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module SoapyCake
   class Response
     include Helper

data/lib/soapy_cake/response_value.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module SoapyCake
   class ResponseValue
     attr_reader :key, :value

data/lib/soapy_cake/time_converter.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module SoapyCake
   class TimeConverter
     def initialize(time_zone, time_offset = nil)

data/lib/soapy_cake/version.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module SoapyCake
-  VERSION = '2.1.3'
+  VERSION = '2.1.4'
 end

data/soapy_cake.gemspec

@@ -1,5 +1,6 @@
 # coding: utf-8
 # frozen_string_literal: true
+
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'soapy_cake/version'

data/spec/fixtures/vcr_cassettes/SoapyCake_Admin/returns_a_clicks_report_with_a_defined_time_range.yml

@@ -2,18 +2,18 @@
 http_interactions:
 - request:
     method: post
-    uri: https://cake-partner-domain.com/api/7/reports.asmx
+    uri: https://cake-partner-domain.com/api/11/reports.asmx
     body:
       encoding: UTF-8
       string: |
         <?xml version="1.0"?>
-        <env:Envelope xmlns:env="http://www.w3.org/2003/05/soap-envelope" xmlns:cake="http://cakemarketing.com/api/7/">
+        <env:Envelope xmlns:env="http://www.w3.org/2003/05/soap-envelope" xmlns:cake="http://cakemarketing.com/api/11/">
           <env:Header/>
           <env:Body>
             <cake:Clicks>
               <cake:api_key>cake-api-key</cake:api_key>
-              <cake:start_date>2014-06-30T02:00:00</cake:start_date>
-              <cake:end_date>2014-07-01T02:00:00</cake:end_date>
+              <cake:start_date>2017-05-31T02:00:00</cake:start_date>
+              <cake:end_date>2017-06-01T02:00:00</cake:end_date>
               <cake:row_limit>1</cake:row_limit>
             </cake:Clicks>
           </env:Body>
@@ -21,6 +21,12 @@ http_interactions:
     headers:
       Content-Type:
       - application/soap+xml;charset=UTF-8
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
   response:
     status:
       code: 200
@@ -28,38 +34,47 @@ http_interactions:
     headers:
       Cache-Control:
       - private, max-age=0
+      Content-Length:
+      - '4034'
       Content-Type:
       - application/soap+xml; charset=utf-8
-      Server:
-      - Microsoft-IIS/8.0
+      Date:
+      - Tue, 27 Jun 2017 09:14:48 GMT
       X-Aspnet-Version:
       - 4.0.30319
       X-Powered-By:
       - ASP.NET
-      Date:
-      - Fri, 13 Feb 2015 14:29:42 GMT
-      Content-Length:
-      - '2151'
+      Connection:
+      - close
     body:
       encoding: UTF-8
       string: <?xml version="1.0" encoding="utf-8"?><soap:Envelope xmlns:soap="http://www.w3.org/2003/05/soap-envelope"
         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"><soap:Body><ClicksResponse
-        xmlns="http://cakemarketing.com/api/7/"><ClicksResult><success>true</success><row_count>9</row_count><clicks><click><click_id>1275452</click_id><visitor_id>1208222</visitor_id><request_session_id>1303953</request_session_id><click_date>2014-06-30T19:31:35.067</click_date><affiliate><affiliate_id
-        xmlns="API:id_name_store">-1</affiliate_id><affiliate_name xmlns="API:id_name_store">ad2games
-        GmbH</affiliate_name></affiliate><advertiser><advertiser_id xmlns="API:id_name_store">1</advertiser_id><advertiser_name
-        xmlns="API:id_name_store">ad2games GmbH</advertiser_name></advertiser><offer><offer_id
-        xmlns="API:id_name_store">-1</offer_id><offer_name xmlns="API:id_name_store">Global
-        Redirect</offer_name></offer><offer_contract><offer_contract_id xmlns="API:id_name_store">-1</offer_contract_id><offer_contract_name
-        xmlns="API:id_name_store" /></offer_contract><campaign_id>-1</campaign_id><creative><creative_id
-        xmlns="API:id_name_store">-1</creative_id><creative_name xmlns="API:id_name_store">-1
-        - Global Redirect</creative_name></creative><sub_id_1 /><sub_id_2 /><sub_id_3
-        /><sub_id_4 /><sub_id_5 /><ip_address>184.72.184.113</ip_address><user_agent>Cloud%20mapping%20experiment.%20Contact%20research@pdrlabs.net</user_agent><referrer_url
-        /><search_term /><request_url>http://94.236.50.153/</request_url><redirect_url>http://www.getcake.com</redirect_url><country><country_code
+        xmlns="http://cakemarketing.com/api/11/"><ClicksResult><success>true</success><row_count>470134</row_count><clicks><click><click_id>1633967829</click_id><visitor_id>964629655</visitor_id><tracking_id>1251217875</tracking_id><request_session_id>1602923077</request_session_id><click_date>2017-06-01T01:59:59.95</click_date><source_affiliate><source_affiliate_id
+        xmlns="API:id_name_store">26833</source_affiliate_id><source_affiliate_name
+        xmlns="API:id_name_store">Funtomic Adstack</source_affiliate_name></source_affiliate><brand_advertiser><brand_advertiser_id
+        xmlns="API:id_name_store">15176</brand_advertiser_id><brand_advertiser_name
+        xmlns="API:id_name_store">Star Stable Entertainment AB</brand_advertiser_name></brand_advertiser><site_offer><site_offer_id
+        xmlns="API:id_name_store">16698</site_offer_id><site_offer_name xmlns="API:id_name_store">Star
+        Stable (US SOI)</site_offer_name></site_offer><site_offer_contract><site_offer_contract_id
+        xmlns="API:id_name_store">22508</site_offer_contract_id><site_offer_contract_name
+        xmlns="API:id_name_store">Direct</site_offer_contract_name></site_offer_contract><campaign><campaign_id>646697</campaign_id><campaign_type><campaign_type_id>1</campaign_type_id><campaign_type_name>Standard</campaign_type_name></campaign_type></campaign><creative><creative_id
+        xmlns="API:id_name_store">211068</creative_id><creative_name xmlns="API:id_name_store">211068</creative_name></creative><sub_id_1
+        /><sub_id_2>CRpyl4PCacTC-9QTL_8kUg</sub_id_2><sub_id_3>as~</sub_id_3><sub_id_4
+        /><sub_id_5 /><ip_address>73.47.22.147</ip_address><user_agent>Mozilla/5.0%20(Windows%20NT%2010.0;%20WOW64)%20AppleWebKit/537.36%20(KHTML,%20like%20Gecko)%20Chrome/58.0.3029.110%20Safari/537.36</user_agent><referrer_url>http://kizi.com/games/c/family-barn?ref=big_thumb</referrer_url><search_term
+        /><request_url>https://a2g-secure.com/?a=26833&amp;c=211068&amp;s1=&amp;s2=CRpyl4PCacTC-9QTL_8kUg&amp;s3=as~</request_url><redirect_url>https://www.starstable.com/en/creation/offer?affiliate=AD2&amp;utm_source=ad2&amp;utm_medium=cpl&amp;referrer=12344&amp;utm_term=standard&amp;utm_content=empty&amp;AffId=#affid#_#s1#&amp;utm_campaign=US-ad2-Display-Star-Stable&amp;ClickID=#reqid#</redirect_url><country><country_code
         xmlns="API:id_name_store">US</country_code><country_name xmlns="API:id_name_store">United
-        States</country_name></country><region><region_code xmlns="API:id_name_store">VA</region_code><region_name
-        xmlns="API:id_name_store">Virginia</region_name></region><isp><isp_id xmlns="API:id_name_store">29534</isp_id><isp_name
-        xmlns="API:id_name_store">Amazon.Com Inc.</isp_name></isp><disposition>Base
-        Tracking Domain Redirect</disposition><total_clicks>1</total_clicks></click></clicks></ClicksResult></ClicksResponse></soap:Body></soap:Envelope>
+        States</country_name></country><region><region_code xmlns="API:id_name_store">NH</region_code><region_name
+        xmlns="API:id_name_store">New Hampshire</region_name></region><language><language_id
+        xmlns="API:id_name_store">1</language_id><language_name xmlns="API:id_name_store">English</language_name></language><isp><isp_id
+        xmlns="API:id_name_store">16357</isp_id><isp_name xmlns="API:id_name_store">Comcast
+        Cable Communications Inc.</isp_name></isp><operating_system><operating_system_id>18</operating_system_id><operating_system_name>Windows</operating_system_name><operating_system_version><version_id
+        xmlns="API:id_name_store">1</version_id><version_name xmlns="API:id_name_store">Other</version_name></operating_system_version><operating_system_version_minor><version_id
+        xmlns="API:id_name_store">1</version_id><version_name xmlns="API:id_name_store"
+        /></operating_system_version_minor></operating_system><browser><browser_id>2</browser_id><browser_name>Chrome</browser_name><browser_version><version_id
+        xmlns="API:id_name_store">460</version_id><version_name xmlns="API:id_name_store">58</version_name></browser_version><browser_version_minor><version_id
+        xmlns="API:id_name_store">691</version_id><version_name xmlns="API:id_name_store">58.0</version_name></browser_version_minor></browser><disposition
+        /><duplicate>false</duplicate><duplicate_clicks>0</duplicate_clicks><total_clicks>1</total_clicks></click></clicks></ClicksResult></ClicksResponse></soap:Body></soap:Envelope>
     http_version: 
-  recorded_at: Fri, 13 Feb 2015 14:29:53 GMT
+  recorded_at: Mon, 15 Jun 2015 12:00:00 GMT
 recorded_with: VCR 2.9.3

data/spec/integration/soapy_cake/admin_addedit_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 RSpec.describe SoapyCake::AdminAddedit do
   subject(:admin_addedit) { described_class.new }
 

data/spec/integration/soapy_cake/admin_spec.rb

@@ -1,8 +1,10 @@
 # frozen_string_literal: true
+
 RSpec.describe SoapyCake::Admin do
   around { |example| Timecop.freeze(Time.utc(2015, 6, 15, 12), &example) }
 
   let(:logger) { instance_double(Logger) }
+
   before { allow(logger).to receive(:info) }
 
   subject(:admin) { described_class.new(logger: logger) }
@@ -40,15 +42,15 @@ RSpec.describe SoapyCake::Admin do
 
   it 'returns a clicks report with a defined time range', :vcr do
     result = admin.clicks(
-      start_date: Date.new(2014, 6, 30),
-      end_date: Date.new(2014, 7, 1),
+      start_date: Date.new(2017, 5, 31),
+      end_date: Date.new(2017, 6, 1),
       row_limit: 1
     )
 
     expect(result.count).to eq(1)
     expect(result.first).to include(
-      click_id: 1275452,
-      visitor_id: 1208222
+      click_id: 1633967829,
+      visitor_id: 964629655
     )
   end
 

data/spec/integration/soapy_cake/admin_track_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe SoapyCake::AdminTrack do

data/spec/integration/soapy_cake/campaigns_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 RSpec.describe SoapyCake::Campaigns, :vcr do
   let(:offer_id) { 11390 }
   let(:affiliate_id) { 9643 }

data/spec/lib/soapy_cake/admin_addedit_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 RSpec.describe SoapyCake::AdminAddedit do
   subject(:admin_addedit) { described_class.new }
 

data/spec/lib/soapy_cake/admin_batched_spec.rb

@@ -1,6 +1,8 @@
 # frozen_string_literal: true
+
 RSpec.describe SoapyCake::AdminBatched do
   subject(:admin_batched) { described_class.new }
+
   let(:admin) { instance_double(SoapyCake::Admin, xml_response?: false) }
 
   before do

data/spec/lib/soapy_cake/admin_spec.rb

@@ -1,6 +1,8 @@
 # frozen_string_literal: true
+
 RSpec.describe SoapyCake::Admin do
   subject(:admin) { described_class.new }
+
   let(:opts) { nil }
   let(:cake_opts) { opts }
   let(:cake_method) { method }
@@ -11,22 +13,26 @@ RSpec.describe SoapyCake::Admin do
     describe '#affiliate_bills' do
       let(:method) { :affiliate_bills }
       let(:cake_method) { :export_affiliate_bills }
+
       it_behaves_like 'a cake admin method'
     end
 
     describe '#advertiser_bills' do
       let(:method) { :advertiser_bills }
       let(:cake_method) { :export_advertiser_bills }
+
       it_behaves_like 'a cake admin method'
     end
 
     describe '#mark_affiliate_bill_as_received' do
       let(:method) { :mark_affiliate_bill_as_received }
+
       it_behaves_like 'a cake admin method'
     end
 
     describe '#mark_affiliate_bill_as_paid' do
       let(:method) { :mark_affiliate_bill_as_paid }
+
       it_behaves_like 'a cake admin method'
     end
   end
@@ -36,26 +42,31 @@ RSpec.describe SoapyCake::Admin do
 
     describe '#advertisers' do
       let(:method) { :advertisers }
+
       it_behaves_like 'a cake admin method'
     end
 
     describe '#affiliates' do
       let(:method) { :affiliates }
+
       it_behaves_like 'a cake admin method'
     end
 
     describe '#campaigns' do
       let(:method) { :campaigns }
+
       it_behaves_like 'a cake admin method'
     end
 
     describe '#offers' do
       let(:method) { :offers }
+
       it_behaves_like 'a cake admin method'
     end
 
     describe '#creatives' do
       let(:method) { :creatives }
+
       it_behaves_like 'a cake admin method'
     end
   end
@@ -65,37 +76,44 @@ RSpec.describe SoapyCake::Admin do
 
     describe '#campaign_summary' do
       let(:method) { :campaign_summary }
+
       it_behaves_like 'a cake admin method'
     end
 
     describe '#offer_summary' do
       let(:method) { :offer_summary }
+
       it_behaves_like 'a cake admin method'
     end
 
     describe '#affiliate_summary' do
       let(:method) { :affiliate_summary }
+
       it_behaves_like 'a cake admin method'
     end
 
     describe '#advertiser_summary' do
       let(:method) { :advertiser_summary }
+
       it_behaves_like 'a cake admin method'
     end
 
     describe '#clicks' do
       let(:method) { :clicks }
+
       it_behaves_like 'a cake admin method'
     end
 
     describe '#conversions' do
       let(:method) { :conversions }
       let(:cake_opts) {  { conversion_type: 'conversions' } }
+
       it_behaves_like 'a cake admin method'
     end
 
     describe '#conversion_changes' do
       let(:method) { :conversion_changes }
+
       it_behaves_like 'a cake admin method'
     end
 
@@ -103,18 +121,21 @@ RSpec.describe SoapyCake::Admin do
       let(:method) { :events }
       let(:cake_method) { :conversions }
       let(:cake_opts) { { conversion_type: 'events' } }
+
       it_behaves_like 'a cake admin method'
     end
 
     describe '#traffic' do
       let(:method) { :traffic }
       let(:cake_method) { :traffic_export }
+
       it_behaves_like 'a cake admin method'
     end
 
     describe '#caps' do
       let(:method) { :caps }
       let(:cake_opts) { { start_date: '2015-07-01', end_date: '2015-07-07' } }
+
       it_behaves_like 'a cake admin method'
     end
   end
@@ -125,23 +146,27 @@ RSpec.describe SoapyCake::Admin do
     describe '#verticals' do
       let(:method) { :verticals }
       let(:cake_opts) { nil }
+
       it_behaves_like 'a cake admin method'
     end
 
     describe '#countries' do
       let(:method) { :countries }
+
       it_behaves_like 'a cake admin method'
     end
 
     describe '#currencies' do
       let(:method) { :currencies }
       let(:cake_opts) { nil }
+
       it_behaves_like 'a cake admin method'
     end
 
     describe '#exchange_rates' do
       let(:method) { :exchange_rates }
       let(:cake_opts) { { start_date: '2015-07-01', end_date: '2015-07-07' } }
+
       it_behaves_like 'a cake admin method'
     end
 
@@ -149,12 +174,14 @@ RSpec.describe SoapyCake::Admin do
       let(:method) { :tiers }
       let(:cake_method) { :affiliate_tiers }
       let(:cake_opts) { nil }
+
       it_behaves_like 'a cake admin method'
     end
 
     describe '#blacklist_reasons' do
       let(:method) { :blacklist_reasons }
       let(:cake_opts) { nil }
+
       it_behaves_like 'a cake admin method'
     end
   end
@@ -165,12 +192,14 @@ RSpec.describe SoapyCake::Admin do
     describe '#update_creative' do
       let(:method) { :update_creative }
       let(:cake_method) { :creative }
+
       it_behaves_like 'a cake admin method'
     end
 
     describe '#update_campaign' do
       let(:method) { :update_campaign }
       let(:cake_method) { :campaign }
+
       it_behaves_like 'a cake admin method'
     end
 
@@ -204,12 +233,14 @@ RSpec.describe SoapyCake::Admin do
     describe '#affiliate_signup' do
       let(:method) { :affiliate_signup }
       let(:cake_method) { :affiliate }
+
       it_behaves_like 'a cake admin method'
     end
 
     describe '#media_types' do
       let(:method) { :media_types }
       let(:cake_method) { :get_media_types }
+
       it_behaves_like 'a cake admin method'
 
       it 'uses a local response' do

data/spec/lib/soapy_cake/admin_track_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe SoapyCake::AdminTrack do

data/spec/lib/soapy_cake/affiliate_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 RSpec.describe SoapyCake::Affiliate do
   let(:affiliate_id) { 42 }
   let(:opts) { { a: 1 } }
@@ -21,12 +22,14 @@ RSpec.describe SoapyCake::Affiliate do
   describe '#bills' do
     let(:service) { :reports }
     let(:method) { :bills }
+
     it_behaves_like 'a cake affiliate method'
   end
 
   describe '#offer_feed' do
     let(:service) { :offers }
     let(:method) { :offer_feed }
+
     it_behaves_like 'a cake affiliate method'
   end
 end

data/spec/lib/soapy_cake/campaigns_spec.rb

@@ -1,14 +1,10 @@
 # frozen_string_literal: true
+
 RSpec.describe SoapyCake::Campaigns do
   let(:campaigns) { described_class.new }
   let(:client) { instance_double(SoapyCake::Client) }
   let(:campaign_id) { 1 }
 
-  before do
-    allow(SoapyCake::Client).to receive(:new).and_return(client)
-    allow(client).to receive(:run).with(an_instance_of(SoapyCake::Request))
-  end
-
   let(:default_params) do
     {
       affiliate_id: 1,
@@ -26,6 +22,11 @@ RSpec.describe SoapyCake::Campaigns do
     }
   end
 
+  before do
+    allow(SoapyCake::Client).to receive(:new).and_return(client)
+    allow(client).to receive(:run).with(an_instance_of(SoapyCake::Request))
+  end
+
   def expect_request_to_be_built_with(opts)
     expect(SoapyCake::Request).to receive(:new).with(
       :admin,

data/spec/lib/soapy_cake/modification_type_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 RSpec.describe SoapyCake::ModificationType do
   subject(:output_opts) do
     described_class.new(:foo, :foo_mod_type, 'bar').options(input_opts)

data/spec/lib/soapy_cake/request_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 RSpec.describe SoapyCake::Request do
   it 'raises if there is no api version stored' do
     expect do

data/spec/lib/soapy_cake/response_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 RSpec.describe SoapyCake::Response do
   let(:xml) do
     <<-EOD

data/spec/lib/soapy_cake/response_value_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 RSpec.describe SoapyCake::ResponseValue do
   let(:time_converter) { instance_double(SoapyCake::TimeConverter) }
 

data/spec/lib/soapy_cake/time_converter_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 RSpec.describe SoapyCake::TimeConverter do
   subject(:time_converter) { described_class.new('Europe/Berlin') }
 

data/spec/spec_helper.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'simplecov'
 SimpleCov.start do
   add_filter '/spec/'

data/spec/support/admin_method_example.rb

@@ -1,6 +1,8 @@
 # frozen_string_literal: true
+
 RSpec.shared_examples_for 'a cake admin method' do
   subject(:admin) { described_class.new }
+
   let(:request) { instance_double(SoapyCake::Request) }
 
   it 'runs the request' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: soapy_cake
 version: !ruby/object:Gem::Version
-  version: 2.1.3
+  version: 2.1.4
 platform: ruby
 authors:
 - ad2games GmbH
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-05 00:00:00.000000000 Z
+date: 2017-06-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -271,7 +271,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Simple client for the CAKE API