soapy_cake 2.0.0 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5a83e62398d6bf19d63c844e3b38b49ef77e1c32
-  data.tar.gz: d3343d5c47737c662a489885633aa481d71bfa4f
+  metadata.gz: 6f1b3eafd1d67264317255af0c6a0ec5a7bdf768
+  data.tar.gz: 060efd87807a74298141dc39000b59f029e06974
 SHA512:
-  metadata.gz: a76be5731e6506480c83e4a1fbbbf73dcfb0c6121a8e9bef0b5ab79e46e06d9dc18465dadd1f3bcbfea21babe07270aab845f7211b63507094f1145bf1131b54
-  data.tar.gz: 5fe3a19428b63b69d115252904e865e5d4715bdff19b76e1db8bd49c3f74216058ebb6f4667dac7c63b1898d003b9ad1483059a630bb54237367bf235b154b57
+  metadata.gz: 27b28c976de97f17fc8e15e3c2a8052d17855f3edc17fe07b1e116cb713f94fcfb2924fb18bd4ee014cfce5ebedecbfbdb6fe63e8ef5c2fe7330b00595f159de
+  data.tar.gz: f4242f62639da6318b213391528d4c6e7e43038567a4da2a8502c208348a04e8db0a84a608a7be5d84e10997cac1751ec9d6da1d2d85634d98141c6b7901b202

data/lib/soapy_cake/admin_addedit.rb

@@ -111,6 +111,10 @@ module SoapyCake
       run Request.new(:admin, :addedit, :contact, opts)
     end
 
+    def add_geo_targets(opts)
+      edit_geo_targets(opts.merge(add_edit_option: 'add'))
+    end
+
     def edit_geo_targets(opts)
       require_params(opts, %i(offer_contract_id allow_countries))
 
@@ -120,7 +124,8 @@ module SoapyCake
                geo_targets_redirect_options(opts)
              end
 
-      opts = opts.merge(add_edit_option: 'replace', set_targeting_to_geo: true)
+      opts[:add_edit_option] ||= 'replace'
+      opts[:set_targeting_to_geo] = true
 
       run Request.new(:admin, :addedit, :geo_targets, opts)
     end

data/lib/soapy_cake/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module SoapyCake
-  VERSION = '2.0.0'
+  VERSION = '2.1.0'
 end

data/spec/lib/soapy_cake/admin_addedit_spec.rb

@@ -83,4 +83,56 @@ RSpec.describe SoapyCake::AdminAddedit do
       admin_addedit.add_offer(offer_params.merge(tags: 'tag', tags_replace: true))
     end
   end
+
+  describe '#edit_geo_targets' do
+    let(:base_opts) do
+      {
+        offer_contract_id: 1,
+        allow_countries: true,
+        countries: %w(DE)
+      }
+    end
+
+    it 'replaces the existing config by default' do
+      expect(SoapyCake::Request).to receive(:new)
+        .with(:admin, :addedit, :geo_targets,
+          hash_including(add_edit_option: 'replace'))
+
+      admin_addedit.edit_geo_targets(base_opts)
+    end
+
+    it 'allows to override the add_edit_option' do
+      expect(SoapyCake::Request).to receive(:new)
+        .with(:admin, :addedit, :geo_targets,
+          hash_including(add_edit_option: 'add'))
+
+      admin_addedit.edit_geo_targets(base_opts.merge(add_edit_option: 'add'))
+    end
+
+    it 'does not mutate the passed options' do
+      allow(SoapyCake::Request).to receive(:new)
+
+      opts_before = base_opts.dup
+      admin_addedit.edit_geo_targets(base_opts)
+      expect(base_opts).to eq(opts_before)
+    end
+  end
+
+  describe '#add_geo_targets' do
+    let(:base_opts) do
+      {
+        offer_contract_id: 1,
+        allow_countries: true,
+        countries: %w(DE)
+      }
+    end
+
+    it 'adds geo targets' do
+      expect(SoapyCake::Request).to receive(:new)
+        .with(:admin, :addedit, :geo_targets,
+          hash_including(add_edit_option: 'add'))
+
+      admin_addedit.add_geo_targets(base_opts)
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: soapy_cake
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.1.0
 platform: ruby
 authors:
 - ad2games GmbH
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-14 00:00:00.000000000 Z
+date: 2016-10-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport