soapy_cake 1.7.2 → 1.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f734b8e9381f7bbca9559e4d57f507136973c0eb
-  data.tar.gz: a6e5eea51cf350523cb33f49214f6f73efbff7cf
+  metadata.gz: 90201356e6d2385c37b53e49e865c434402896b7
+  data.tar.gz: 28dcc83c8a090dc0fb98840456d826a43dd7811c
 SHA512:
-  metadata.gz: bb60c6a3a8a3be6f42e1b573820d47557402cf476354914e26bb54869cbe59146233e8c77b6f4bf98f5330280d8a962cdad2270501c655d0138f40de0ad04911
-  data.tar.gz: 82712fbdadbfec95211fe6d2632fe559f5d9419ea8924ba76e80c8cb7e665d416f5d925f4477350d18ff898bd41ddee551f11a7467b4ba4a765fb785fe9eb439
+  metadata.gz: 43dafa8fb75b0df882c4d8fdf76536c86b5de504dee9a32b44d8023339b325a6b66873a8ecbeaf46d592eacf11b74f29f40e9de88152a718bf411a97817386fe
+  data.tar.gz: 611d5795f76310439df20c03d9bb0f3d8159f0f0a13ec8fa19fb3b249c8f6fa7d0fb75e06f6a8c076d87ce155310d4e85d73304a7b04522f5e4d8426d93a3bee

data/lib/soapy_cake/admin_addedit.rb

@@ -132,7 +132,6 @@ module SoapyCake
       require_params(opts, %i(cap_type_id cap_interval_id cap_amount send_alert_only))
 
       translate_values!(opts, %i(cap_type_id cap_interval_id))
-      opts[:cap_amount] = -1 if opts[:cap_interval_id] == const_lookup(:cap_interval_id, :disabled)
 
       run Request.new(:admin, :addedit, :caps, opts)
     end

data/lib/soapy_cake/const.rb

@@ -50,7 +50,7 @@ module SoapyCake
         conversion: 2
       },
       cap_interval_id: {
-        disabled: 0,
+        indefinite: 0,
         daily: 1,
         weekly: 2,
         monthly: 3

data/lib/soapy_cake/version.rb

@@ -1,3 +1,3 @@
 module SoapyCake
-  VERSION = '1.7.2'
+  VERSION = '1.8.0'
 end

data/spec/integration/soapy_cake/admin_addedit_spec.rb

@@ -217,18 +217,6 @@ RSpec.describe SoapyCake::AdminAddedit do
 
       expect(result[:message]).to eq('Cap Updated')
     end
-
-    it 'removes a cap for an offer contract', :vcr do
-      result = subject.update_caps(
-        offer_contract_id: offer_contract_id,
-        cap_type_id: :conversion,
-        cap_interval_id: :disabled,
-        cap_amount: 42,
-        send_alert_only: false
-      )
-
-      expect(result[:message]).to eq('Cap Updated')
-    end
   end
 
   describe 'offer tiers' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: soapy_cake
 version: !ruby/object:Gem::Version
-  version: 1.7.2
+  version: 1.8.0
 platform: ruby
 authors:
 - ad2games GmbH
@@ -201,7 +201,6 @@ files:
 - spec/fixtures/vcr_cassettes/SoapyCake_AdminAddedit/affiliates/edits_affiliates.yml
 - spec/fixtures/vcr_cassettes/SoapyCake_AdminAddedit/contacts/edits_a_contact.yml
 - spec/fixtures/vcr_cassettes/SoapyCake_AdminAddedit/geo_targeting/creates_geo_targetings.yml
-- spec/fixtures/vcr_cassettes/SoapyCake_AdminAddedit/offer_/_offer_contract_caps/removes_a_cap_for_an_offer_contract.yml
 - spec/fixtures/vcr_cassettes/SoapyCake_AdminAddedit/offer_/_offer_contract_caps/updates_a_cap_for_an_offer_contract.yml
 - spec/fixtures/vcr_cassettes/SoapyCake_AdminAddedit/offer_contracts/creates_an_offer_contract.yml
 - spec/fixtures/vcr_cassettes/SoapyCake_AdminAddedit/offer_contracts/updates_an_offer_contract.yml
@@ -251,7 +250,6 @@ test_files:
 - spec/fixtures/vcr_cassettes/SoapyCake_AdminAddedit/affiliates/edits_affiliates.yml
 - spec/fixtures/vcr_cassettes/SoapyCake_AdminAddedit/contacts/edits_a_contact.yml
 - spec/fixtures/vcr_cassettes/SoapyCake_AdminAddedit/geo_targeting/creates_geo_targetings.yml
-- spec/fixtures/vcr_cassettes/SoapyCake_AdminAddedit/offer_/_offer_contract_caps/removes_a_cap_for_an_offer_contract.yml
 - spec/fixtures/vcr_cassettes/SoapyCake_AdminAddedit/offer_/_offer_contract_caps/updates_a_cap_for_an_offer_contract.yml
 - spec/fixtures/vcr_cassettes/SoapyCake_AdminAddedit/offer_contracts/creates_an_offer_contract.yml
 - spec/fixtures/vcr_cassettes/SoapyCake_AdminAddedit/offer_contracts/updates_an_offer_contract.yml

data/spec/fixtures/vcr_cassettes/SoapyCake_AdminAddedit/offer_/_offer_contract_caps/removes_a_cap_for_an_offer_contract.yml

@@ -1,53 +0,0 @@
----
-http_interactions:
-- request:
-    method: post
-    uri: https://cake-partner-domain.com/api/1/addedit.asmx
-    body:
-      encoding: UTF-8
-      string: |
-        <?xml version="1.0"?>
-        <env:Envelope xmlns:env="http://www.w3.org/2003/05/soap-envelope" xmlns:cake="http://cakemarketing.com/api/1/">
-          <env:Header/>
-          <env:Body>
-            <cake:Caps>
-              <cake:api_key>cake-api-key</cake:api_key>
-              <cake:offer_contract_id>1456</cake:offer_contract_id>
-              <cake:cap_type_id>2</cake:cap_type_id>
-              <cake:cap_interval_id>0</cake:cap_interval_id>
-              <cake:cap_amount>-1</cake:cap_amount>
-              <cake:send_alert_only>false</cake:send_alert_only>
-            </cake:Caps>
-          </env:Body>
-        </env:Envelope>
-    headers:
-      Content-Type:
-      - application/soap+xml;charset=UTF-8
-  response:
-    status:
-      code: 200
-      message: OK
-    headers:
-      Cache-Control:
-      - private, max-age=0
-      Content-Type:
-      - application/soap+xml; charset=utf-8
-      Server:
-      - Microsoft-IIS/8.0
-      X-Aspnet-Version:
-      - 4.0.30319
-      X-Powered-By:
-      - ASP.NET
-      Date:
-      - Tue, 17 Feb 2015 14:00:08 GMT
-      Content-Length:
-      - '391'
-    body:
-      encoding: UTF-8
-      string: <?xml version="1.0" encoding="utf-8"?><soap:Envelope xmlns:soap="http://www.w3.org/2003/05/soap-envelope"
-        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"><soap:Body><CapsResponse
-        xmlns="http://cakemarketing.com/api/1/"><CapsResult><success>true</success><message>Cap
-        Updated</message></CapsResult></CapsResponse></soap:Body></soap:Envelope>
-    http_version: 
-  recorded_at: Tue, 17 Feb 2015 14:00:11 GMT
-recorded_with: VCR 2.9.3