soapy_cake 1.4.0 → 1.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cd9650087f25d594328017d9adf7455f3d6b3763
-  data.tar.gz: 91a2b6a9eef7ee1b47d2389a7468e43de79b191f
+  metadata.gz: 63cbcc04e20f7fbe8cf51ceaba0b6d42874caee6
+  data.tar.gz: e203b1955f3ff6cc0dad787d0105ed771168106b
 SHA512:
-  metadata.gz: d6eb4e5f4cba2ce09552f8f37671ee22fa4cb64522dadcae33156894a81fa3eea5a1b9aaf03cc241b09811b59ba03cc14ae4eb5d4b02df80c3626ed1364a3e97
-  data.tar.gz: 7e2c571cf58d813ca780dfd56272f41aca615e04b97f7e1d8e1a20bdc820b82a78003c13efb0379b0d04f3217f44d71961b1df074171df5afd838e28ad44d5c7
+  metadata.gz: c3e2017089a8eb0fd1893c4dfc8d7bc81197c51d69ef0a4f666175238c7aa42a9dac1d4aa7b663df7b424e8ac158f739a35bfca55f8afa787d75a211c2ebda11
+  data.tar.gz: bd253fbebfcd9c3d4d15e9c55e913f516c9655329d3d7338eaa1ab4c7b6b86236a42e87bd9639b5ecc3aba3b44618c257bd5d869ee2d018c1a554c52e29c8571

data/Gemfile

@@ -1,8 +1,8 @@
 source 'https://rubygems.org'
 
-# Specify your gem's dependencies in soapy_cake.gemspec
 gemspec
 
-group :test do
+group :development, :test do
+  gem 'rubocop-ci', github: 'ad2games/rubocop-ci'
   gem 'codeclimate-test-reporter', require: false
 end

data/Rakefile

@@ -1,5 +1,6 @@
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
+require 'rubocop-ci'
 
 RSpec::Core::RakeTask.new(:spec)
 

data/circle.yml

@@ -0,0 +1,3 @@
+test:
+  pre:
+    - bundle exec rake rubocop

data/lib/soapy_cake/admin_addedit.rb

@@ -108,6 +108,11 @@ module SoapyCake
 
       translate_values!(opts, %i(currency_id offer_status_id offer_type_id price_format_id))
 
+      %i(conversion_cap_behavior conversion_behavior_on_redirect).each do |key|
+        next unless opts[key]
+        opts[key] = const_lookup(:conversion_behaviour_id, opts[key])
+      end
+
       opts.reverse_merge!(
         offer_name: '',
         third_party_name: '',

data/lib/soapy_cake/const.rb

@@ -4,37 +4,37 @@ module SoapyCake
       account_status_id: {
         active: 1,
         inactive: 2,
-        pending: 3,
+        pending: 3
       },
       offer_status_id: {
         public: 1,
         private: 2,
         apply_to_run: 3,
-        inactive: 4,
+        inactive: 4
       },
       offer_type_id: {
         hosted: 1,
         host_n_post: 2,
-        third_party: 3,
+        third_party: 3
       },
       currency_id: {
         usd: 1,
         eur: 2,
         gbd: 3,
         aud: 4,
-        cad: 5,
+        cad: 5
       },
       payment_setting_id: {
         system_default: 1,
         offer_currency: 2,
-        affiliate_currency: 3,
+        affiliate_currency: 3
       },
       price_format_id: {
         cpa: 1,
         cpc: 2,
         cpm: 3,
         fixed: 4,
-        revshare: 5,
+        revshare: 5
       },
       conversion_behaviour_id: {
         system: 0,
@@ -42,17 +42,17 @@ module SoapyCake
         adv_no_aff: 2,
         ignore: 3,
         no_adv_aff: 4,
-        no_adv_no_aff: 5,
+        no_adv_no_aff: 5
       },
       cap_type_id: {
         click: 1,
-        conversion: 2,
+        conversion: 2
       },
       cap_interval_id: {
         disabled: 0,
         daily: 1,
         weekly: 2,
-        monthly: 3,
+        monthly: 3
       }
     }
   end

data/lib/soapy_cake/version.rb

@@ -1,3 +1,3 @@
 module SoapyCake
-  VERSION = '1.4.0'
+  VERSION = '1.5.0'
 end

data/spec/fixtures/vcr_cassettes/ADDEDIT_integration_test/offers/creates_an_offer.yml

@@ -32,6 +32,8 @@ http_interactions:
               <cake:thankyou_link>http://www.example.com/</cake:thankyou_link>
               <cake:from_lines>from</cake:from_lines>
               <cake:subject_lines>subject</cake:subject_lines>
+              <cake:conversion_cap_behavior>3</cake:conversion_cap_behavior>
+              <cake:conversion_behavior_on_redirect>3</cake:conversion_behavior_on_redirect>
               <cake:advertiser_id>15886</cake:advertiser_id>
               <cake:vertical_id>41</cake:vertical_id>
               <cake:postback_url_ms_delay>60</cake:postback_url_ms_delay>
@@ -51,8 +53,6 @@ http_interactions:
               <cake:redirect_offer_contract_id>0</cake:redirect_offer_contract_id>
               <cake:pixel_html/>
               <cake:postback_url/>
-              <cake:conversion_cap_behavior>0</cake:conversion_cap_behavior>
-              <cake:conversion_behavior_on_redirect>0</cake:conversion_behavior_on_redirect>
               <cake:expiration_date>2115-01-24T01:00:00</cake:expiration_date>
               <cake:expiration_date_modification_type>do_not_change</cake:expiration_date_modification_type>
               <cake:offer_contract_name/>
@@ -82,15 +82,15 @@ http_interactions:
       X-Powered-By:
       - ASP.NET
       Date:
-      - Fri, 06 Mar 2015 13:46:57 GMT
+      - Fri, 27 Mar 2015 10:53:05 GMT
       Content-Length:
-      - '562'
+      - '563'
     body:
       encoding: UTF-8
       string: <?xml version="1.0" encoding="utf-8"?><soap:Envelope xmlns:soap="http://www.w3.org/2003/05/soap-envelope"
         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"><soap:Body><OfferResponse
         xmlns="http://cakemarketing.com/api/4/"><OfferResult><success>true</success><message>Offer
-        9098 Created</message><success_info><offer_id>9098</offer_id><offer_contract_id>2018</offer_contract_id><campaign_id>13866</campaign_id><creative_id>9619</creative_id></success_info></OfferResult></OfferResponse></soap:Body></soap:Envelope>
+        9497 Created</message><success_info><offer_id>9497</offer_id><offer_contract_id>3552</offer_contract_id><campaign_id>15404</campaign_id><creative_id>10018</creative_id></success_info></OfferResult></OfferResponse></soap:Body></soap:Envelope>
     http_version: 
   recorded_at: Tue, 17 Feb 2015 12:00:00 GMT
 recorded_with: VCR 2.9.3

data/spec/lib/soapy_cake/addedit_integration_spec.rb

@@ -34,6 +34,9 @@ RSpec.describe 'ADDEDIT integration test' do
         from_lines: 'from',
         subject_lines: 'subject',
 
+        conversion_cap_behavior: :ignore,
+        conversion_behavior_on_redirect: :ignore,
+
         advertiser_id: advertiser_id,
         vertical_id: vertical_id,
         postback_url_ms_delay: 60,
@@ -52,9 +55,9 @@ RSpec.describe 'ADDEDIT integration test' do
       )
 
       expect(result).to include(
-        creative_id: 9619,
-        offer_contract_id: 2018,
-        offer_id: 9098,
+        creative_id: 10018,
+        offer_contract_id: 3552,
+        offer_id: 9497
       )
     end
 
@@ -105,7 +108,7 @@ RSpec.describe 'ADDEDIT integration test' do
         countries: %w(AT CH),
         redirects: {
           'AT' => redirect_offer_contract_id,
-          'CH' => redirect_offer_contract_id,
+          'CH' => redirect_offer_contract_id
         },
         allow_countries: false
       )

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: soapy_cake
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.5.0
 platform: ruby
 authors:
 - ad2games GmbH
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-17 00:00:00.000000000 Z
+date: 2015-03-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -179,6 +179,7 @@ files:
 - README.md
 - Rakefile
 - api_versions.yml
+- circle.yml
 - lib/soapy_cake.rb
 - lib/soapy_cake/admin.rb
 - lib/soapy_cake/admin_addedit.rb