soapy_cake 1.26.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f0200aa227f1f26c12610300c9848a22b831433a
-  data.tar.gz: 515fda58cc88b35ef23ecfbd83f3bb7dc250bce1
+  metadata.gz: 5a83e62398d6bf19d63c844e3b38b49ef77e1c32
+  data.tar.gz: d3343d5c47737c662a489885633aa481d71bfa4f
 SHA512:
-  metadata.gz: 57058b8a99b05a26c4ee21c0c21b818a957281d0125c56925d764caa07d2f6baeb2e7ec6b217ba27efeeed0cef641d04e19bf17e864fe6b5574b968a26fe00b3
-  data.tar.gz: 22554ab098bcbe0f909539b1ecf2bf72b4745e4fc7d8b10428cb490d526c7dc60cbb8a24b37f8e80c58292d70435e7a3f7a2339f3f6fd53aa1cfc627ed55dd2f
+  metadata.gz: a76be5731e6506480c83e4a1fbbbf73dcfb0c6121a8e9bef0b5ab79e46e06d9dc18465dadd1f3bcbfea21babe07270aab845f7211b63507094f1145bf1131b54
+  data.tar.gz: 5fe3a19428b63b69d115252904e865e5d4715bdff19b76e1db8bd49c3f74216058ebb6f4667dac7c63b1898d003b9ad1483059a630bb54237367bf235b154b57

data/lib/soapy_cake/admin_addedit.rb

@@ -111,7 +111,7 @@ module SoapyCake
       run Request.new(:admin, :addedit, :contact, opts)
     end
 
-    def add_geo_targets(opts)
+    def edit_geo_targets(opts)
       require_params(opts, %i(offer_contract_id allow_countries))
 
       opts = if opts[:allow_countries]
@@ -120,7 +120,7 @@ module SoapyCake
                geo_targets_redirect_options(opts)
              end
 
-      opts = opts.merge(add_edit_option: 'add', set_targeting_to_geo: true)
+      opts = opts.merge(add_edit_option: 'replace', set_targeting_to_geo: true)
 
       run Request.new(:admin, :addedit, :geo_targets, opts)
     end

data/lib/soapy_cake/client.rb

@@ -44,9 +44,8 @@ module SoapyCake
     end
 
     def check_write_enabled!(request)
-      unless request.read_only? || write_enabled
-        raise Error, 'Writes not enabled (pass write_enabled: true or set CAKE_WRITE_ENABLED=yes)'
-      end
+      return if request.read_only? || write_enabled
+      raise Error, 'Writes not enabled (pass write_enabled: true or set CAKE_WRITE_ENABLED=yes)'
     end
 
     def with_retries(&block)
@@ -63,7 +62,7 @@ module SoapyCake
     end
 
     def http_response(request)
-      logger.info("soapy_cake:request #{request}") if logger
+      logger&.info("soapy_cake:request #{request}")
 
       http_request = Net::HTTP::Post.new(request.path, HEADERS)
       http_request.body = request.xml

data/lib/soapy_cake/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module SoapyCake
-  VERSION = '1.26.0'
+  VERSION = '2.0.0'
 end

data/spec/fixtures/vcr_cassettes/SoapyCake_AdminAddedit/geo_targeting/creates_geo_targetings.yml

@@ -16,7 +16,7 @@ http_interactions:
               <cake:countries>DE,FR</cake:countries>
               <cake:allow_countries>true</cake:allow_countries>
               <cake:redirect_site_offer_contract_ids>-1,-1</cake:redirect_site_offer_contract_ids>
-              <cake:add_edit_option>add</cake:add_edit_option>
+              <cake:add_edit_option>replace</cake:add_edit_option>
               <cake:set_targeting_to_geo>true</cake:set_targeting_to_geo>
             </cake:GeoTargets>
           </env:Body>
@@ -24,6 +24,12 @@ http_interactions:
     headers:
       Content-Type:
       - application/soap+xml;charset=UTF-8
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
   response:
     status:
       code: 200
@@ -34,21 +40,21 @@ http_interactions:
       Content-Type:
       - application/soap+xml; charset=utf-8
       Server:
-      - Microsoft-IIS/8.0
+      - Microsoft-IIS/8.5
       X-Aspnet-Version:
       - 4.0.30319
       X-Powered-By:
       - ASP.NET
       Date:
-      - Fri, 07 Aug 2015 13:45:43 GMT
+      - Mon, 10 Oct 2016 10:22:33 GMT
       Content-Length:
-      - '446'
+      - '449'
     body:
       encoding: UTF-8
       string: <?xml version="1.0" encoding="utf-8"?><soap:Envelope xmlns:soap="http://www.w3.org/2003/05/soap-envelope"
         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"><soap:Body><GeoTargetsResponse
         xmlns="http://cakemarketing.com/api/3/"><GeoTargetsResult><success>true</success><message>Geotarget(s)
-        Added</message><row_count>2</row_count></GeoTargetsResult></GeoTargetsResponse></soap:Body></soap:Envelope>
+        Replaced</message><row_count>2</row_count></GeoTargetsResult></GeoTargetsResponse></soap:Body></soap:Envelope>
     http_version: 
   recorded_at: Tue, 17 Feb 2015 12:00:00 GMT
 - request:
@@ -67,7 +73,7 @@ http_interactions:
               <cake:countries>AT,CH</cake:countries>
               <cake:allow_countries>false</cake:allow_countries>
               <cake:redirect_site_offer_contract_ids>1392,1392</cake:redirect_site_offer_contract_ids>
-              <cake:add_edit_option>add</cake:add_edit_option>
+              <cake:add_edit_option>replace</cake:add_edit_option>
               <cake:set_targeting_to_geo>true</cake:set_targeting_to_geo>
             </cake:GeoTargets>
           </env:Body>
@@ -75,6 +81,12 @@ http_interactions:
     headers:
       Content-Type:
       - application/soap+xml;charset=UTF-8
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
   response:
     status:
       code: 200
@@ -85,21 +97,21 @@ http_interactions:
       Content-Type:
       - application/soap+xml; charset=utf-8
       Server:
-      - Microsoft-IIS/8.0
+      - Microsoft-IIS/8.5
       X-Aspnet-Version:
       - 4.0.30319
       X-Powered-By:
       - ASP.NET
       Date:
-      - Fri, 07 Aug 2015 13:45:48 GMT
+      - Mon, 10 Oct 2016 10:22:33 GMT
       Content-Length:
-      - '446'
+      - '449'
     body:
       encoding: UTF-8
       string: <?xml version="1.0" encoding="utf-8"?><soap:Envelope xmlns:soap="http://www.w3.org/2003/05/soap-envelope"
         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"><soap:Body><GeoTargetsResponse
         xmlns="http://cakemarketing.com/api/3/"><GeoTargetsResult><success>true</success><message>Geotarget(s)
-        Added</message><row_count>2</row_count></GeoTargetsResult></GeoTargetsResponse></soap:Body></soap:Envelope>
+        Replaced</message><row_count>2</row_count></GeoTargetsResult></GeoTargetsResponse></soap:Body></soap:Envelope>
     http_version: 
   recorded_at: Tue, 17 Feb 2015 12:00:00 GMT
-recorded_with: VCR 2.9.3
+recorded_with: VCR 3.0.1

data/spec/integration/soapy_cake/admin_addedit_spec.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 RSpec.describe SoapyCake::AdminAddedit do
+  # rubocop:disable RSpec/NestedGroups
   subject(:admin_addedit) { described_class.new }
 
   around { |example| Timecop.freeze(Time.utc(2015, 2, 17, 12), &example) }
@@ -149,14 +150,14 @@ RSpec.describe SoapyCake::AdminAddedit do
 
   describe 'geo targeting' do
     it 'creates geo targetings', :vcr do
-      result = admin_addedit.add_geo_targets(
+      result = admin_addedit.edit_geo_targets(
         offer_contract_id: offer_contract_id,
         countries: %w(DE FR),
         allow_countries: true
       )
       expect(result).to include(success: true, row_count: '2')
 
-      result = admin_addedit.add_geo_targets(
+      result = admin_addedit.edit_geo_targets(
         offer_contract_id: offer_contract_id,
         countries: %w(AT CH),
         redirects: {
@@ -170,7 +171,7 @@ RSpec.describe SoapyCake::AdminAddedit do
 
     it 'fails if it does not get a correct redirect hash' do
       expect do
-        admin_addedit.add_geo_targets(
+        admin_addedit.edit_geo_targets(
           offer_contract_id: offer_contract_id,
           redirects: {},
           allow_countries: false

data/spec/lib/soapy_cake/admin_addedit_spec.rb

@@ -3,6 +3,7 @@ RSpec.describe SoapyCake::AdminAddedit do
   subject(:admin_addedit) { described_class.new }
 
   before do
+    # rubocop:disable RSpec/SubjectStub
     allow(admin_addedit).to receive(:run).and_return({})
   end
 

data/spec/lib/soapy_cake/admin_batched_spec.rb

@@ -3,7 +3,7 @@ RSpec.describe SoapyCake::AdminBatched do
   subject(:admin_batched) { described_class.new }
   let(:admin) { instance_double(SoapyCake::Admin, xml_response?: false) }
 
-  before :each do
+  before do
     allow(SoapyCake::Admin).to receive(:new).and_return(admin)
 
     stub_const('SoapyCake::AdminBatched::BatchedRequest::LIMIT', 2)

data/spec/lib/soapy_cake/admin_spec.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 RSpec.describe SoapyCake::Admin do
+  # rubocop:disable RSpec/NestedGroups
   subject(:admin) { described_class.new }
   let(:opts) { nil }
   let(:cake_opts) { opts }

data/spec/lib/soapy_cake/affiliate_spec.rb

@@ -11,6 +11,7 @@ RSpec.describe SoapyCake::Affiliate do
       request = instance_double(SoapyCake::Request)
       expect(SoapyCake::Request).to receive(:new)
         .with(:affiliate, service, method, cake_opts).and_return(request)
+      # rubocop:disable RSpec/SubjectStub
       expect(affiliate).to receive(:run).with(request)
 
       affiliate.public_send(method, opts)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: soapy_cake
 version: !ruby/object:Gem::Version
-  version: 1.26.0
+  version: 2.0.0
 platform: ruby
 authors:
 - ad2games GmbH
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-16 00:00:00.000000000 Z
+date: 2016-10-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -257,7 +257,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.6
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Simple client for the CAKE API