soapy_cake 1.25.1 → 1.25.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f34206792cd5e4c12a01f151950c2cdc2fb93842
-  data.tar.gz: 3b001b6ab170294913d412bca3d587aac23284d1
+  metadata.gz: 1321d74f53687f87ede80c9d57c96cd0071243f3
+  data.tar.gz: 2a959b7fe70c1bbac22d7e798cd7c1eb76bc20ee
 SHA512:
-  metadata.gz: 0769d845dc9e1ee7ab2b9e967a828b25fa33273f3b2aca9138d9dd9642417405ae1dfe98f29e3891a2416b8b621546cbccbc8ee7e7de54ee2dbf00ff85e7dc7e
-  data.tar.gz: ee939674e9521deb531591dbf10a4ad48d3e42ad8b008361237d77bdee61bd57a5f36fe5b6ba301af0ec49ab14331ab5b70a07326059b2cd2fb0ff0650385e2b
+  metadata.gz: e7217c43f14f3b57ac1b104dfd64924e0f45a120147814ab2dfb4f8bf05efc2dca2d0ce709dd3eff418c3588b3d0049ac58458119bdde00a4a1f62b9d1e6b314
+  data.tar.gz: 64d9af5457a4fd531a01c26f7f02311ef73abbb2027fd5cc9dcf3d8204fd01d844cfeb5e27166af65974f6fda62bf993fe5eb7ae888f6d8dff7abd91c0ee2d49

data/README.md

@@ -38,7 +38,7 @@ Get report for specific date range:
 ```ruby
 SoapyCake::Admin.new.affiliate_summary(
   start_date: Date.beginning_of_month,
-  end_date: Date.today
+  end_date: Date.current
 )
 ```
 

data/lib/soapy_cake/admin.rb

@@ -113,7 +113,7 @@ module SoapyCake
       blacklist_date = opts[:blacklist_date].to_date
       # CAKE applies the blacklisting at 00:00 of the specified day, so add one more day.
       # Unless it is the current day, then blacklisting should take effect immediately.
-      blacklist_date += 1.day if blacklist_date > Date.today
+      blacklist_date += 1.day if blacklist_date > Date.current
 
       run Request.new(
         :admin,

data/lib/soapy_cake/helper.rb

@@ -54,7 +54,7 @@ module SoapyCake
     # It cannot be *that* far in the future though because it causes a datetime overflow
     # in the steam powered rusty black box they call a database server.
     def future_expiration_date
-      Date.today + (365 * 30)
+      Date.current + (365 * 30)
     end
   end
 end

data/lib/soapy_cake/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module SoapyCake
-  VERSION = '1.25.1'
+  VERSION = '1.25.2'
 end

data/spec/integration/soapy_cake/admin_addedit_spec.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 RSpec.describe SoapyCake::AdminAddedit do
+  subject(:admin_addedit) { described_class.new }
+
   around { |example| Timecop.freeze(Time.utc(2015, 2, 17, 12), &example) }
 
   let(:affiliate_id) { 1 }
@@ -13,7 +15,7 @@ RSpec.describe SoapyCake::AdminAddedit do
 
   describe 'affiliates', :vcr do
     it 'edits affiliates' do
-      result = subject.edit_affiliate(
+      result = admin_addedit.edit_affiliate(
         affiliate_id: 1,
         vat_tax_required: false
       )
@@ -24,7 +26,7 @@ RSpec.describe SoapyCake::AdminAddedit do
 
   describe 'advertisers', :vcr do
     it 'creates advertisers' do
-      result = subject.create_advertiser(
+      result = admin_addedit.create_advertiser(
         advertiser_name: 'Foxy Fox',
         account_status_id: 1
       )
@@ -35,7 +37,7 @@ RSpec.describe SoapyCake::AdminAddedit do
 
   describe 'contacts', :vcr do
     it 'edits a contact' do
-      result = subject.edit_contact(
+      result = admin_addedit.edit_contact(
         entity_id: advertiser_id,
         contact_id: contact_id,
         contact_email_address: 'fox@rabbit.com'
@@ -65,7 +67,7 @@ RSpec.describe SoapyCake::AdminAddedit do
     end
 
     it 'creates an offer', :vcr do
-      result = subject.add_offer(
+      result = admin_addedit.add_offer(
         hidden: false,
         offer_status_id: :public,
         offer_type_id: :third_party,
@@ -113,20 +115,20 @@ RSpec.describe SoapyCake::AdminAddedit do
     end
 
     it 'updates an offer', :vcr do
-      result = subject.edit_offer(update_params)
+      result = admin_addedit.edit_offer(update_params)
       expect(result).to include(offer_id: offer_id)
     end
 
     context 'errors' do
       it 'fails when not enough params are given' do
         expect do
-          subject.edit_offer(offer_id: 123)
+          admin_addedit.edit_offer(offer_id: 123)
         end.to raise_error(SoapyCake::Error, "Parameter 'advertiser_id' missing!")
       end
 
       it 'fails when invalid offer_id is given on edit' do
         expect do
-          subject.edit_offer(offer_id: -1)
+          admin_addedit.edit_offer(offer_id: -1)
         end.to raise_error(SoapyCake::Error, "Parameter 'offer_id' must be > 0!")
       end
 
@@ -138,7 +140,7 @@ RSpec.describe SoapyCake::AdminAddedit do
 
         it 'fails with error' do
           expect do
-            subject.edit_offer(update_params)
+            admin_addedit.edit_offer(update_params)
           end.to raise_error(SoapyCake::Error, /Writes not enabled/)
         end
       end
@@ -147,14 +149,14 @@ RSpec.describe SoapyCake::AdminAddedit do
 
   describe 'geo targeting' do
     it 'creates geo targetings', :vcr do
-      result = subject.add_geo_targets(
+      result = admin_addedit.add_geo_targets(
         offer_contract_id: offer_contract_id,
         countries: %w(DE FR),
         allow_countries: true
       )
       expect(result).to include(success: true, row_count: '2')
 
-      result = subject.add_geo_targets(
+      result = admin_addedit.add_geo_targets(
         offer_contract_id: offer_contract_id,
         countries: %w(AT CH),
         redirects: {
@@ -168,7 +170,7 @@ RSpec.describe SoapyCake::AdminAddedit do
 
     it 'fails if it does not get a correct redirect hash' do
       expect do
-        subject.add_geo_targets(
+        admin_addedit.add_geo_targets(
           offer_contract_id: offer_contract_id,
           redirects: {},
           allow_countries: false
@@ -182,7 +184,7 @@ RSpec.describe SoapyCake::AdminAddedit do
 
   describe 'offer contracts' do
     it 'creates an offer contract', :vcr do
-      result = subject.add_offer_contract(
+      result = admin_addedit.add_offer_contract(
         offer_id: offer_id,
         offer_contract_name: 'Test Contract',
         price_format_id: :cpa,
@@ -200,7 +202,7 @@ RSpec.describe SoapyCake::AdminAddedit do
     end
 
     it 'updates an offer contract', :vcr do
-      result = subject.edit_offer_contract(
+      result = admin_addedit.edit_offer_contract(
         offer_id: offer_id,
         offer_contract_id: offer_contract_id,
         offer_contract_name: 'Test Contract',
@@ -221,13 +223,13 @@ RSpec.describe SoapyCake::AdminAddedit do
     context 'errors' do
       it 'fails when not enough params are given' do
         expect do
-          subject.edit_offer_contract(offer_contract_id: 123)
+          admin_addedit.edit_offer_contract(offer_contract_id: 123)
         end.to raise_error(SoapyCake::Error, "Parameter 'offer_id' missing!")
       end
 
       it 'fails when invalid offer_id is given on edit' do
         expect do
-          subject.edit_offer_contract(offer_contract_id: -1)
+          admin_addedit.edit_offer_contract(offer_contract_id: -1)
         end.to raise_error(SoapyCake::Error, "Parameter 'offer_contract_id' must be > 0!")
       end
     end
@@ -235,7 +237,7 @@ RSpec.describe SoapyCake::AdminAddedit do
 
   describe 'offer / offer contract caps' do
     it 'updates a cap for an offer contract', :vcr do
-      result = subject.update_caps(
+      result = admin_addedit.update_caps(
         offer_contract_id: offer_contract_id,
         cap_type_id: :conversion,
         cap_interval_id: :daily,
@@ -247,7 +249,7 @@ RSpec.describe SoapyCake::AdminAddedit do
     end
 
     it 'removes a cap for an offer contract', :vcr do
-      result = subject.remove_caps(
+      result = admin_addedit.remove_caps(
         offer_contract_id: offer_contract_id,
         cap_type_id: :conversion
       )
@@ -258,7 +260,7 @@ RSpec.describe SoapyCake::AdminAddedit do
 
   describe 'offer tiers' do
     it 'adds an offer tier', :vcr do
-      result = subject.add_offer_tier(
+      result = admin_addedit.add_offer_tier(
         offer_id: offer_id,
         offer_contract_id: offer_contract_id,
         tier_id: tier_id,
@@ -270,7 +272,7 @@ RSpec.describe SoapyCake::AdminAddedit do
     end
 
     it 'edits an offer tier', :vcr do
-      result = subject.edit_offer_tier(
+      result = admin_addedit.edit_offer_tier(
         offer_id: offer_id,
         offer_contract_id: offer_contract_id,
         tier_id: tier_id,
@@ -284,7 +286,7 @@ RSpec.describe SoapyCake::AdminAddedit do
 
   describe 'campaigns' do
     it 'adds a campaign', :vcr do
-      result = subject.add_campaign(
+      result = admin_addedit.add_campaign(
         affiliate_id: affiliate_id,
         offer_id: offer_id,
         media_type_id: 1,
@@ -296,7 +298,7 @@ RSpec.describe SoapyCake::AdminAddedit do
     end
 
     it 'edits a campaign', :vcr do
-      result = subject.edit_campaign(
+      result = admin_addedit.edit_campaign(
         campaign_id: 123,
         affiliate_id: affiliate_id,
         offer_id: offer_id,

data/spec/integration/soapy_cake/admin_spec.rb

@@ -5,13 +5,13 @@ RSpec.describe SoapyCake::Admin do
   let(:logger) { instance_double(Logger) }
   before { allow(logger).to receive(:info) }
 
-  subject { described_class.new(logger: logger) }
+  subject(:admin) { described_class.new(logger: logger) }
 
   it 'returns an affiliate with correct data types', :vcr do
     expect(logger).to receive(:info)
       .with('soapy_cake:request admin:export:affiliates:5 {"affiliate_id":16027}')
 
-    result = subject.affiliates(affiliate_id: 16027)
+    result = admin.affiliates(affiliate_id: 16027)
     expect(result.count).to eq(1)
     expect(result.first).to include(
       affiliate_id: 16027,
@@ -39,7 +39,7 @@ RSpec.describe SoapyCake::Admin do
   end
 
   it 'returns a clicks report with a defined time range', :vcr do
-    result = subject.clicks(
+    result = admin.clicks(
       start_date: Date.new(2014, 6, 30),
       end_date: Date.new(2014, 7, 1),
       row_limit: 1
@@ -53,7 +53,7 @@ RSpec.describe SoapyCake::Admin do
   end
 
   it 'does not parse a transaction_id as an integer', :vcr do
-    result = subject.conversions(
+    result = admin.conversions(
       start_date: Date.new(2015, 4, 11),
       end_date: Date.new(2015, 4, 12),
       row_limit: 1
@@ -65,12 +65,12 @@ RSpec.describe SoapyCake::Admin do
 
   it 'raises if there is an error', :vcr do
     expect do
-      subject.affiliates(affiliate_id: 'bloops')
+      admin.affiliates(affiliate_id: 'bloops')
     end.to raise_error(SoapyCake::RequestFailed)
   end
 
   it 'creates an affiliate and returns the ID', :vcr do
-    result = subject.affiliate_signup(
+    result = admin.affiliate_signup(
       contact_timezone: 'CET',
       contact_phone_work: 'n/a',
       address_country: 'n/a',
@@ -85,7 +85,7 @@ RSpec.describe SoapyCake::Admin do
       contact_first_name: 'Foxy',
       contact_last_name: 'Fox',
       contact_email_address: 'foxy@forrest.com',
-      date_added: Date.today
+      date_added: Date.current
     )
 
     expect(result).to eq(
@@ -97,7 +97,7 @@ RSpec.describe SoapyCake::Admin do
   end
 
   it 'returns media types', :vcr do
-    result = subject.media_types
+    result = admin.media_types
 
     expect(result.first).to eq(
       media_type_id: 15,
@@ -106,17 +106,17 @@ RSpec.describe SoapyCake::Admin do
   end
 
   context 'XML responses' do
-    subject { described_class.new(xml_response: true) }
+    subject(:admin) { described_class.new(xml_response: true) }
 
     it 'returns an XML string', :vcr do
-      result = subject.media_types
+      result = admin.media_types
 
       expect(result.next).to eq(File.read('spec/fixtures/raw_response.xml').strip)
     end
 
     it 'fails on error', :vcr do
       expect do
-        subject.affiliates(affiliate_id: -2).next
+        admin.affiliates(affiliate_id: -2).next
       end.to raise_error(SoapyCake::RequestFailed)
     end
   end
@@ -124,7 +124,7 @@ RSpec.describe SoapyCake::Admin do
   describe '#blacklists' do
     it 'returns blacklists', :vcr do
       expect(
-        subject.blacklists(
+        admin.blacklists(
           advertiser_id: 15882,
           offer_id: 10551,
           affiliate_id: 16187,
@@ -157,11 +157,11 @@ RSpec.describe SoapyCake::Admin do
     end
 
     it 'removes blacklists', :vcr do
-      expect(subject.blacklists(blacklist_params).to_a).to be_present
+      expect(admin.blacklists(blacklist_params).to_a).to be_present
 
-      subject.remove_blacklist(blacklist_id: 28)
+      admin.remove_blacklist(blacklist_id: 28)
 
-      expect(subject.blacklists(blacklist_params).to_a).to be_empty
+      expect(admin.blacklists(blacklist_params).to_a).to be_empty
     end
   end
 end

data/spec/integration/soapy_cake/admin_track_spec.rb

@@ -2,9 +2,11 @@
 require 'spec_helper'
 
 RSpec.describe SoapyCake::AdminTrack do
+  subject(:admin_track) { described_class.new }
+
   describe '#mass_conversion_insert', :vcr do
     it 'inserts conversions' do
-      result = subject.mass_conversion_insert(
+      result = admin_track.mass_conversion_insert(
         conversion_date: Date.new(2015, 5, 6),
         affiliate_id: 16059,
         campaign_id: 13268,
@@ -19,7 +21,7 @@ RSpec.describe SoapyCake::AdminTrack do
 
   describe '#update_conversion', :vcr do
     it 'updates a conversion' do
-      result = subject.update_conversion(
+      result = admin_track.update_conversion(
         conversion_id: 145211,
         offer_id: 5032,
         payout: 0.75,

data/spec/lib/soapy_cake/admin_addedit_spec.rb

@@ -1,7 +1,9 @@
 # frozen_string_literal: true
 RSpec.describe SoapyCake::AdminAddedit do
+  subject(:admin_addedit) { described_class.new }
+
   before do
-    allow(subject).to receive(:run).and_return({})
+    allow(admin_addedit).to receive(:run).and_return({})
   end
 
   describe '#edit_offer' do
@@ -25,7 +27,7 @@ RSpec.describe SoapyCake::AdminAddedit do
         .with(:admin, :addedit, :offer,
           hash_including(tags: 'new-tag', tags_modification_type: 'add'))
 
-      subject.edit_offer(offer_params)
+      admin_addedit.edit_offer(offer_params)
     end
 
     it 'allows replacing tags' do
@@ -33,7 +35,7 @@ RSpec.describe SoapyCake::AdminAddedit do
         .with(:admin, :addedit, :offer,
           hash_including(tags: 'new-tag', tags_modification_type: 'replace'))
 
-      subject.edit_offer(offer_params.merge(tags_replace: true))
+      admin_addedit.edit_offer(offer_params.merge(tags_replace: true))
     end
   end
 
@@ -77,7 +79,7 @@ RSpec.describe SoapyCake::AdminAddedit do
         .with(:admin, :addedit, :offer,
           hash_including(tags: 'tag', tags_modification_type: 'add'))
 
-      subject.add_offer(offer_params.merge(tags: 'tag', tags_replace: true))
+      admin_addedit.add_offer(offer_params.merge(tags: 'tag', tags_replace: true))
     end
   end
 end

data/spec/lib/soapy_cake/admin_batched_spec.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 RSpec.describe SoapyCake::AdminBatched do
+  subject(:admin_batched) { described_class.new }
   let(:admin) { instance_double(SoapyCake::Admin, xml_response?: false) }
 
   before :each do
@@ -14,7 +15,7 @@ RSpec.describe SoapyCake::AdminBatched do
     expect(admin).to receive(:offers)
       .with(advertiser: 1, start_at_row: 3, row_limit: 2).and_return(%i(c).to_enum)
 
-    result = subject.offers(advertiser: 1)
+    result = admin_batched.offers(advertiser: 1)
 
     expect(result).to be_a(Enumerator)
     expect(result.to_a).to eq(%i(a b c))
@@ -24,11 +25,11 @@ RSpec.describe SoapyCake::AdminBatched do
     expect(admin).to receive(:offers)
       .with(advertiser: 1, start_at_row: 1, row_limit: 100).and_return(%i(a b).to_enum)
 
-    expect(subject.offers({ advertiser: 1 }, 100).to_a).to eq(%i(a b))
+    expect(admin_batched.offers({ advertiser: 1 }, 100).to_a).to eq(%i(a b))
   end
 
   context 'SoapyCake Batched with XMLResponse set' do
-    subject { described_class.new(xml_response: true) }
+    subject(:admin_batched) { described_class.new(xml_response: true) }
 
     before do
       allow(admin).to receive(:xml_response?).and_return(true)
@@ -42,7 +43,7 @@ RSpec.describe SoapyCake::AdminBatched do
       expect(admin).to receive(:affiliates)
         .with(start_at_row: 21, row_limit: 10).and_return([].to_enum)
 
-      result = subject.affiliates({}, 10)
+      result = admin_batched.affiliates({}, 10)
 
       expect(result).to be_a(Enumerator)
       expect(result.to_a).to eq(%i(a b))
@@ -51,15 +52,19 @@ RSpec.describe SoapyCake::AdminBatched do
 
   context 'errors' do
     it 'fails with an invalid method' do
-      expect { subject.something }.to raise_error(NoMethodError)
+      expect { admin_batched.something }.to raise_error(NoMethodError)
     end
 
     it 'fails when row_limit is set' do
-      expect { subject.offers(row_limit: 123) }.to raise_error(/Cannot set .* in batched mode/)
+      expect { admin_batched.offers(row_limit: 123) }.to(
+        raise_error(/Cannot set .* in batched mode/)
+      )
     end
 
     it 'fails when start_at_row is set' do
-      expect { subject.offers(start_at_row: 123) }.to raise_error(/Cannot set .* in batched mode/)
+      expect { admin_batched.offers(start_at_row: 123) }.to(
+        raise_error(/Cannot set .* in batched mode/)
+      )
     end
   end
 end

data/spec/lib/soapy_cake/admin_spec.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 RSpec.describe SoapyCake::Admin do
+  subject(:admin) { described_class.new }
   let(:opts) { nil }
   let(:cake_opts) { opts }
   let(:cake_method) { method }
@@ -182,7 +183,7 @@ RSpec.describe SoapyCake::Admin do
       let(:opts) { { blacklist_date: date } }
 
       context 'immediate blacklisting for current date' do
-        let(:date) { Date.today }
+        let(:date) { Date.current }
         let(:cake_opts) { { blacklist_date: date } }
 
         it_behaves_like 'a cake admin method'
@@ -212,7 +213,7 @@ RSpec.describe SoapyCake::Admin do
       it_behaves_like 'a cake admin method'
 
       it 'uses a local response' do
-        expect(subject.media_types(response: File.read('spec/fixtures/raw_response.xml'))).to eq(
+        expect(admin.media_types(response: File.read('spec/fixtures/raw_response.xml'))).to eq(
           [
             { media_type_id: 15, type_name: 'Adware' },
             { media_type_id: 7, type_name: 'Banner' },
@@ -253,7 +254,7 @@ RSpec.describe SoapyCake::Admin do
     it_behaves_like 'a cake admin method'
 
     it 'fails if no blacklist_id is passed' do
-      expect { subject.remove_blacklist }
+      expect { admin.remove_blacklist }
         .to raise_error(SoapyCake::Error, "Parameter 'blacklist_id' missing!")
     end
   end

data/spec/lib/soapy_cake/affiliate_spec.rb

@@ -4,16 +4,16 @@ RSpec.describe SoapyCake::Affiliate do
   let(:opts) { { a: 1 } }
   let(:cake_opts) { opts.merge(affiliate_id: affiliate_id) }
 
-  subject { described_class.new(affiliate_id: affiliate_id) }
+  subject(:affiliate) { described_class.new(affiliate_id: affiliate_id) }
 
   shared_examples_for 'a cake affiliate method' do
     it 'runs the request' do
       request = instance_double(SoapyCake::Request)
       expect(SoapyCake::Request).to receive(:new)
         .with(:affiliate, service, method, cake_opts).and_return(request)
-      expect(subject).to receive(:run).with(request)
+      expect(affiliate).to receive(:run).with(request)
 
-      subject.public_send(method, opts)
+      affiliate.public_send(method, opts)
     end
   end
 

data/spec/lib/soapy_cake/response_spec.rb

@@ -24,16 +24,16 @@ RSpec.describe SoapyCake::Response do
     EOD
   end
 
-  subject { described_class.new(xml.strip, false, 0) }
+  subject(:response) { described_class.new(xml.strip, false, 0) }
 
   it 'returns an enumerator' do
-    expect(subject.to_enum).to be_a(Enumerator)
+    expect(response.to_enum).to be_a(Enumerator)
   end
 
   it 'parses the CAKE XML structure properly' do
-    expect(subject.to_enum.to_a).to eq([
-                                         { id: '123' },
-                                         { id: '312' }
-                                       ])
+    expect(response.to_enum.to_a).to eq([
+                                          { id: '123' },
+                                          { id: '312' }
+                                        ])
   end
 end

data/spec/lib/soapy_cake/time_converter_spec.rb

@@ -1,38 +1,38 @@
 # frozen_string_literal: true
 RSpec.describe SoapyCake::TimeConverter do
-  subject { described_class.new('Europe/Berlin') }
+  subject(:time_converter) { described_class.new('Europe/Berlin') }
 
   describe '#to_cake' do
     it 'converts a time-like object into a cake timestamp' do
-      expect(subject.to_cake(DateTime.new(2015, 1, 2, 12, 30))).to eq('2015-01-02T13:30:00')
-      expect(subject.to_cake(Time.utc(2015, 1, 2, 12, 30))).to eq('2015-01-02T13:30:00')
-      expect(subject.to_cake(Date.new(2015, 1, 2))).to eq('2015-01-02T01:00:00')
+      expect(time_converter.to_cake(DateTime.new(2015, 1, 2, 12, 30))).to eq('2015-01-02T13:30:00')
+      expect(time_converter.to_cake(Time.utc(2015, 1, 2, 12, 30))).to eq('2015-01-02T13:30:00')
+      expect(time_converter.to_cake(Date.new(2015, 1, 2))).to eq('2015-01-02T01:00:00')
     end
 
     it 'respects DST' do
-      expect(subject.to_cake(Time.utc(2015, 1, 2, 12, 30))).to eq('2015-01-02T13:30:00')
-      expect(subject.to_cake(Time.utc(2015, 6, 2, 12, 30))).to eq('2015-06-02T14:30:00')
+      expect(time_converter.to_cake(Time.utc(2015, 1, 2, 12, 30))).to eq('2015-01-02T13:30:00')
+      expect(time_converter.to_cake(Time.utc(2015, 6, 2, 12, 30))).to eq('2015-06-02T14:30:00')
     end
   end
 
   describe '#from_cake' do
     it 'parses cake dates into the specified time zone (including DST)' do
-      expect(subject.from_cake('2015-01-11T14:53:40.000')).to be_a(Time)
-      expect(subject.from_cake('2015-01-11T14:53:40.000'))
+      expect(time_converter.from_cake('2015-01-11T14:53:40.000')).to be_a(Time)
+      expect(time_converter.from_cake('2015-01-11T14:53:40.000'))
         .to eq(Time.utc(2015, 1, 11, 13, 53, 40))
-      expect(subject.from_cake('2015-06-11T14:53:40.000'))
+      expect(time_converter.from_cake('2015-06-11T14:53:40.000'))
         .to eq(Time.utc(2015, 6, 11, 12, 53, 40))
     end
   end
 
   context 'legacy mode / CAKE_TIME_OFFSET' do
-    subject { described_class.new('Europe/Berlin', 5) }
+    subject(:time_converter) { described_class.new('Europe/Berlin', 5) }
 
     it 'works as before (broken, without DST)' do
       expect(STDERR).to receive(:puts).with(/Please use time_zone/)
 
-      expect(subject.to_cake(DateTime.new(2015, 1, 2, 12, 30))).to eq('2015-01-02T17:30:00')
-      expect(subject.to_cake(DateTime.new(2015, 6, 2, 12, 30))).to eq('2015-06-02T17:30:00')
+      expect(time_converter.to_cake(DateTime.new(2015, 1, 2, 12, 30))).to eq('2015-01-02T17:30:00')
+      expect(time_converter.to_cake(DateTime.new(2015, 6, 2, 12, 30))).to eq('2015-06-02T17:30:00')
     end
   end
 end

data/spec/support/admin_method_example.rb

@@ -1,12 +1,13 @@
 # frozen_string_literal: true
 RSpec.shared_examples_for 'a cake admin method' do
+  subject(:admin) { described_class.new }
   let(:request) { instance_double(SoapyCake::Request) }
 
   it 'runs the request' do
     expect(SoapyCake::Request).to receive(:new)
       .with(:admin, service, cake_method, cake_opts || {}).and_return(request)
-    expect(subject).to receive(:run).with(request)
+    expect(admin).to receive(:run).with(request)
 
-    subject.public_send(method, *[opts || cake_opts].compact)
+    admin.public_send(method, *[opts || cake_opts].compact)
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: soapy_cake
 version: !ruby/object:Gem::Version
-  version: 1.25.1
+  version: 1.25.2
 platform: ruby
 authors:
 - ad2games GmbH
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-17 00:00:00.000000000 Z
+date: 2016-08-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport