soapy_cake 1.24.1 → 1.25.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 659ad505616720d0362c9f604740448dad327275
-  data.tar.gz: 506d9efebe3aecfee20c7c84ef846811f6c6c430
+  metadata.gz: f34206792cd5e4c12a01f151950c2cdc2fb93842
+  data.tar.gz: 3b001b6ab170294913d412bca3d587aac23284d1
 SHA512:
-  metadata.gz: f3aa817cff5db27b22bbe2bb92110d75d376a552fc68b8aeaca640f23fad3472a2fa756ed87f17edaedf994869f61169dcd496d5b9b52bc7ea8af37520adf7d2
-  data.tar.gz: 0a2670a01da6c9ca8dd797238bb871c5d8060b37e6b39a3800850e29abd991ebb91ff514ffa18d896c348e2f00124856392d9e6359c482d3bb3077f388821da4
+  metadata.gz: 0769d845dc9e1ee7ab2b9e967a828b25fa33273f3b2aca9138d9dd9642417405ae1dfe98f29e3891a2416b8b621546cbccbc8ee7e7de54ee2dbf00ff85e7dc7e
+  data.tar.gz: ee939674e9521deb531591dbf10a4ad48d3e42ad8b008361237d77bdee61bd57a5f36fe5b6ba301af0ec49ab14331ab5b70a07326059b2cd2fb0ff0650385e2b

data/.ruby-version

@@ -1 +1 @@
-2.3.0
+2.3.1

data/api.yml

@@ -22,7 +22,7 @@ versions:
       creative: 1
       creative_files: 1
       exchange_rates: 1
-      geo_targets: 2
+      geo_targets: 3
       offer: 5
       offer_contract: 1
       offer_tiers: 1

data/lib/soapy_cake/admin_addedit.rb

@@ -125,19 +125,19 @@ module SoapyCake
       opts = opts.dup
       countries = Array(opts[:countries])
       opts[:countries] = countries.join(',')
-      opts[:redirect_offer_contract_ids] = ([-1] * countries.count).join(',')
+      opts[:redirect_site_offer_contract_ids] = ([-1] * countries.count).join(',')
       opts
     end
 
     def geo_targets_redirect_options(opts)
       opts = opts.dup
       redirects = opts.delete(:redirects)
-      unless redirects.is_a?(Hash) && redirects.keys.count > 0
+      unless redirects.is_a?(Hash) && redirects.keys.count.positive?
         raise Error, "Parameter 'redirects' must be a COUNTRY=>REDIRECT_OFFER_CONTRACT_ID hash!"
       end
 
       opts[:countries] = redirects.keys.join(',')
-      opts[:redirect_offer_contract_ids] = redirects.values.join(',')
+      opts[:redirect_site_offer_contract_ids] = redirects.values.join(',')
       opts
     end
 
@@ -221,7 +221,7 @@ module SoapyCake
       opts[:tags_modification_type] =
         if opts[:tags].to_s == ''
           'remove_all'
-        elsif opts.delete(:tags_replace) && opts[:offer_id] != 0
+        elsif opts.delete(:tags_replace) && opts[:offer_id].nonzero?
           'replace'
         else
           'add'

data/lib/soapy_cake/admin_batched.rb

@@ -60,10 +60,16 @@ module SoapyCake
       attr_reader :admin, :method, :opts, :offset, :limit
     end
 
-    def method_missing(name, method_opts = {}, limit = nil)
-      raise Error, "Invalid method #{name}" unless ALLOWED_METHODS.include?(name)
+    def respond_to_missing?(name)
+      ALLOWED_METHODS.include?(name)
+    end
 
-      BatchedRequest.new(admin, name, method_opts, limit).to_enum
+    def method_missing(name, method_opts = {}, limit = nil)
+      if respond_to_missing?(name)
+        BatchedRequest.new(admin, name, method_opts, limit).to_enum
+      else
+        super
+      end
     end
 
     private

data/lib/soapy_cake/request.rb

@@ -45,7 +45,7 @@ module SoapyCake
     private
 
     def api_path
-      "#{(role == 'admin') ? '' : "/#{role.pluralize}"}/api/#{version}"
+      "#{role == 'admin' ? '' : "/#{role.pluralize}"}/api/#{version}"
     end
 
     def xml_params(xml)

data/lib/soapy_cake/response.rb

@@ -78,7 +78,7 @@ module SoapyCake
       # for this specific request. Also, this is the only request with a tag depth
       # of 4, not 3 or 5 like ALL OTHER requests.
       # BTW: There is a 10$ reward if anyone can find a worse designed API.
-      return true if sax.for_tag(:MediaType).count > 0
+      return true if sax.for_tag(:MediaType).count.positive?
 
       false
     end

data/lib/soapy_cake/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module SoapyCake
-  VERSION = '1.24.1'
+  VERSION = '1.25.1'
 end

data/spec/fixtures/vcr_cassettes/SoapyCake_AdminAddedit/geo_targeting/creates_geo_targetings.yml

@@ -2,12 +2,12 @@
 http_interactions:
 - request:
     method: post
-    uri: https://cake-partner-domain.com/api/2/addedit.asmx
+    uri: https://cake-partner-domain.com/api/3/addedit.asmx
     body:
       encoding: UTF-8
       string: |
         <?xml version="1.0"?>
-        <env:Envelope xmlns:env="http://www.w3.org/2003/05/soap-envelope" xmlns:cake="http://cakemarketing.com/api/2/">
+        <env:Envelope xmlns:env="http://www.w3.org/2003/05/soap-envelope" xmlns:cake="http://cakemarketing.com/api/3/">
           <env:Header/>
           <env:Body>
             <cake:GeoTargets>
@@ -15,7 +15,7 @@ http_interactions:
               <cake:offer_contract_id>1456</cake:offer_contract_id>
               <cake:countries>DE,FR</cake:countries>
               <cake:allow_countries>true</cake:allow_countries>
-              <cake:redirect_offer_contract_ids>-1,-1</cake:redirect_offer_contract_ids>
+              <cake:redirect_site_offer_contract_ids>-1,-1</cake:redirect_site_offer_contract_ids>
               <cake:add_edit_option>add</cake:add_edit_option>
               <cake:set_targeting_to_geo>true</cake:set_targeting_to_geo>
             </cake:GeoTargets>
@@ -47,18 +47,18 @@ http_interactions:
       encoding: UTF-8
       string: <?xml version="1.0" encoding="utf-8"?><soap:Envelope xmlns:soap="http://www.w3.org/2003/05/soap-envelope"
         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"><soap:Body><GeoTargetsResponse
-        xmlns="http://cakemarketing.com/api/2/"><GeoTargetsResult><success>true</success><message>Geotarget(s)
+        xmlns="http://cakemarketing.com/api/3/"><GeoTargetsResult><success>true</success><message>Geotarget(s)
         Added</message><row_count>2</row_count></GeoTargetsResult></GeoTargetsResponse></soap:Body></soap:Envelope>
     http_version: 
   recorded_at: Tue, 17 Feb 2015 12:00:00 GMT
 - request:
     method: post
-    uri: https://cake-partner-domain.com/api/2/addedit.asmx
+    uri: https://cake-partner-domain.com/api/3/addedit.asmx
     body:
       encoding: UTF-8
       string: |
         <?xml version="1.0"?>
-        <env:Envelope xmlns:env="http://www.w3.org/2003/05/soap-envelope" xmlns:cake="http://cakemarketing.com/api/2/">
+        <env:Envelope xmlns:env="http://www.w3.org/2003/05/soap-envelope" xmlns:cake="http://cakemarketing.com/api/3/">
           <env:Header/>
           <env:Body>
             <cake:GeoTargets>
@@ -66,7 +66,7 @@ http_interactions:
               <cake:offer_contract_id>1456</cake:offer_contract_id>
               <cake:countries>AT,CH</cake:countries>
               <cake:allow_countries>false</cake:allow_countries>
-              <cake:redirect_offer_contract_ids>1392,1392</cake:redirect_offer_contract_ids>
+              <cake:redirect_site_offer_contract_ids>1392,1392</cake:redirect_site_offer_contract_ids>
               <cake:add_edit_option>add</cake:add_edit_option>
               <cake:set_targeting_to_geo>true</cake:set_targeting_to_geo>
             </cake:GeoTargets>
@@ -98,7 +98,7 @@ http_interactions:
       encoding: UTF-8
       string: <?xml version="1.0" encoding="utf-8"?><soap:Envelope xmlns:soap="http://www.w3.org/2003/05/soap-envelope"
         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"><soap:Body><GeoTargetsResponse
-        xmlns="http://cakemarketing.com/api/2/"><GeoTargetsResult><success>true</success><message>Geotarget(s)
+        xmlns="http://cakemarketing.com/api/3/"><GeoTargetsResult><success>true</success><message>Geotarget(s)
         Added</message><row_count>2</row_count></GeoTargetsResult></GeoTargetsResponse></soap:Body></soap:Envelope>
     http_version: 
   recorded_at: Tue, 17 Feb 2015 12:00:00 GMT

data/spec/integration/soapy_cake/admin_addedit_spec.rb

@@ -108,7 +108,7 @@ RSpec.describe SoapyCake::AdminAddedit do
       )
 
       %i(creative_id offer_contract_id offer_id).each do |key|
-        expect(result[key]).to be > 0
+        expect(result[key]).to be_positive
       end
     end
 

data/spec/integration/soapy_cake/admin_spec.rb

@@ -2,7 +2,7 @@
 RSpec.describe SoapyCake::Admin do
   around { |example| Timecop.freeze(Time.utc(2015, 6, 15, 12), &example) }
 
-  let(:logger) { double('logger') }
+  let(:logger) { instance_double(Logger) }
   before { allow(logger).to receive(:info) }
 
   subject { described_class.new(logger: logger) }

data/spec/lib/soapy_cake/admin_batched_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 RSpec.describe SoapyCake::AdminBatched do
-  let(:admin) { double('admin', xml_response?: false) }
+  let(:admin) { instance_double(SoapyCake::Admin, xml_response?: false) }
 
   before :each do
     allow(SoapyCake::Admin).to receive(:new).and_return(admin)
@@ -51,7 +51,7 @@ RSpec.describe SoapyCake::AdminBatched do
 
   context 'errors' do
     it 'fails with an invalid method' do
-      expect { subject.something }.to raise_error(/Invalid method something/)
+      expect { subject.something }.to raise_error(NoMethodError)
     end
 
     it 'fails when row_limit is set' do

data/spec/lib/soapy_cake/admin_spec.rb

@@ -178,7 +178,7 @@ RSpec.describe SoapyCake::Admin do
 
       let(:method) { :add_blacklist }
       let(:cake_method) { :blacklist }
-      let(:request) { double('request') }
+      let(:request) { instance_double(SoapyCake::Request) }
       let(:opts) { { blacklist_date: date } }
 
       context 'immediate blacklisting for current date' do

data/spec/lib/soapy_cake/affiliate_spec.rb

@@ -8,7 +8,7 @@ RSpec.describe SoapyCake::Affiliate do
 
   shared_examples_for 'a cake affiliate method' do
     it 'runs the request' do
-      request = double('request')
+      request = instance_double(SoapyCake::Request)
       expect(SoapyCake::Request).to receive(:new)
         .with(:affiliate, service, method, cake_opts).and_return(request)
       expect(subject).to receive(:run).with(request)

data/spec/lib/soapy_cake/response_value_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 RSpec.describe SoapyCake::ResponseValue do
-  let(:time_converter) { double('date converter') }
+  let(:time_converter) { instance_double(SoapyCake::TimeConverter) }
 
   def parse(key, value)
     described_class.new(key, value, time_converter).parse

data/spec/support/admin_method_example.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 RSpec.shared_examples_for 'a cake admin method' do
-  let(:request) { double('request') }
+  let(:request) { instance_double(SoapyCake::Request) }
 
   it 'runs the request' do
     expect(SoapyCake::Request).to receive(:new)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: soapy_cake
 version: !ruby/object:Gem::Version
-  version: 1.24.1
+  version: 1.25.1
 platform: ruby
 authors:
 - ad2games GmbH
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-25 00:00:00.000000000 Z
+date: 2016-08-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport