soapy_cake 1.16.1 → 1.16.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 63fdc8810fe8b169af3d888ef35d4867043165c2
-  data.tar.gz: ce660c0e1a57dc2ad55632762864c8ad2b90acdd
+  metadata.gz: 90fef756332d326320cff251efb995ae7ecbb552
+  data.tar.gz: ed0f70f712a51a60816ee644dfc37f2def6aff67
 SHA512:
-  metadata.gz: dbffa9ea80e754406f6543a506734aa2ed8e4975d845aab1c34eb6024358a8a0501018712a0778c628a8345b494bc2f38294a7bdf6aa87a32fd05698638649a6
-  data.tar.gz: 33b5fd240b3ce865603ade69d96b1c31c85eeac19842b694e1eb20a3170763fc535ff01726ef8084f7a05318dc38c84aca4cbdd1b9eacb4f0f90e455a62342f2
+  metadata.gz: 387dd15276c23c87bb7edda1b05af420df08b684fadf4e7a5321cab1f5aa73f57c15aaff8a93a5ad0bbda459a9f567e79e8db6692fe1a124c72dbf7dbc009dd0
+  data.tar.gz: 3c89c8fc345633e689d1dac0ab9bdba2164f59be4fd3e44f09d1eea414da4055b05fc3972b7edb318e392c61ad7c7d364682cf3aa7382efbc44d4e95bfe59cd0

data/lib/soapy_cake/client.rb

@@ -1,6 +1,6 @@
 module SoapyCake
   class Client
-    attr_reader :domain, :api_key, :time_converter
+    HEADERS = { 'Content-Type' => 'application/soap+xml;charset=UTF-8' }.freeze
 
     def initialize(opts = {})
       @domain = opts.fetch(:domain, ENV['CAKE_DOMAIN']) || fail(Error, 'Cake domain missing')
@@ -19,7 +19,7 @@ module SoapyCake
 
     protected
 
-    attr_reader :opts
+    attr_reader :domain, :api_key, :time_converter, :opts
 
     def run(request)
       request.api_key = api_key
@@ -32,25 +32,17 @@ module SoapyCake
     private
 
     def response_body(request)
-      if request.opts[:response].present?
-        request.opts[:response]
-      else
-        http_response(request)
-      end
+      request.opts[:response].presence || http_response(request)
     end
 
     def http_response(request)
       url = "https://#{domain}#{request.path}"
-      http_response = HTTParty.post(url, headers: headers, body: request.xml, timeout: NET_TIMEOUT)
+      http_response = HTTParty.post(url, headers: HEADERS, body: request.xml, timeout: NET_TIMEOUT)
 
       fail RequestFailed, "Request failed with HTTP #{http_response.code}: " \
         "#{http_response.body}" unless http_response.success?
 
       http_response
     end
-
-    def headers
-      { 'Content-Type' => 'application/soap+xml;charset=UTF-8' }
-    end
   end
 end

data/lib/soapy_cake/helper.rb

@@ -26,8 +26,8 @@ module SoapyCake
     def translate_booleans(opts)
       opts.transform_values do |v|
         case v
-        when true then 'on'
-        when false then 'off'
+        when true then 'on'.freeze
+        when false then 'off'.freeze
         else v
         end
       end

data/lib/soapy_cake/request.rb

@@ -40,9 +40,9 @@ module SoapyCake
     end
 
     def xml_params(xml)
-      xml.api_key api_key
+      xml.api_key(api_key)
       opts.each do |k, v|
-        xml.public_send(k.to_sym, format_param(k, v))
+        xml.public_send(k, format_param(k, v))
       end
     end
 
@@ -56,7 +56,7 @@ module SoapyCake
     def format_param(key, value)
       return time_converter.to_cake(value) if DATE_CLASSES.include?(value.class)
 
-      if key.to_s.end_with?('_date')
+      if key.to_s.end_with?('_date'.freeze)
         fail Error, "You need to use a Time/DateTime/Date object for '#{key}'"
       end
 

data/lib/soapy_cake/response.rb

@@ -64,7 +64,7 @@ module SoapyCake
     end
 
     def error_check_success!
-      return if sax.for_tag(:success).first == 'true'
+      return if sax.for_tag(:success).first == 'true'.freeze
       fail RequestFailed, error_message
     end
 

data/lib/soapy_cake/response_value.rb

@@ -1,7 +1,6 @@
 module SoapyCake
   class ResponseValue
-    attr_reader :value
-    attr_reader :key
+    attr_reader :key, :value
 
     # Known string ids that should not be parsed as integers
     STRING_IDS = %w(tax_id transaction_id).freeze
@@ -27,11 +26,11 @@ module SoapyCake
     attr_reader :time_converter
 
     def false?
-      value == 'false'
+      value == 'false'.freeze
     end
 
     def true?
-      value == 'true'
+      value == 'true'.freeze
     end
 
     def date?
@@ -39,7 +38,7 @@ module SoapyCake
     end
 
     def id?
-      key.to_s.end_with?('_id')
+      key.end_with?('_id'.freeze)
     end
 
     def string_id?

data/lib/soapy_cake/time_converter.rb

@@ -14,7 +14,7 @@ module SoapyCake
 
     def to_cake(date)
       date = date.to_datetime if date.is_a?(Date)
-      date.in_time_zone(zone).strftime('%Y-%m-%dT%H:%M:%S')
+      date.in_time_zone(zone).strftime('%Y-%m-%dT%H:%M:%S'.freeze)
     end
 
     def from_cake(value)

data/lib/soapy_cake/version.rb

@@ -1,3 +1,3 @@
 module SoapyCake
-  VERSION = '1.16.1'.freeze
+  VERSION = '1.16.2'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: soapy_cake
 version: !ruby/object:Gem::Version
-  version: 1.16.1
+  version: 1.16.2
 platform: ruby
 authors:
 - ad2games GmbH
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-19 00:00:00.000000000 Z
+date: 2015-10-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport