soapy_cake 1.11.0 → 1.11.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0f638bcf63e5c298c8106c4c71bacdbe8acd6927
-  data.tar.gz: 264608b47a9493bc9d3251339a6ceaf1d303495c
+  metadata.gz: ed9db59499f69b6cd0a980b55982bc4b76e232ed
+  data.tar.gz: e7478c8e5784094990a86f11626632c7f0fe4244
 SHA512:
-  metadata.gz: d66e47f6285e02f0e2adde97ee5834d440cb4d67a9f10cd1c36325d73bdacdf2393fa2a29a56e0d4e8ba45af782871467b027f63168051885b7abee9aae02ce3
-  data.tar.gz: aa0d393e775190a19e457406bef37d4b6fd8fe05d41ddc4ab56f767de084f38a1b91c253cd17043bd0a70365f2b3ddde6537c5c82cc9de2a61fc77ef1239ef5b
+  metadata.gz: 43567a1c4a870a24c650c6d23b3c276ba4e63017adc058151fc64b14b4baef063eacfc1e152e265b3558d8047005b5d5b152445d02b172a8bfac5037ee83e199
+  data.tar.gz: d7de64c699a0efdf9e5232402cfd2175195f0b9fed4fcdaba5db711661e98c0b476e44da320cdb44c975ce7238dbbeab6098806ed4229e0dec83a03811edf04f

data/lib/soapy_cake/admin_batched.rb

@@ -9,7 +9,7 @@ module SoapyCake
       # When all offers have a lot of info (e.g. geotargeting) we probably need to decrease this.
       LIMIT = 500
 
-      def initialize(admin, method, opts)
+      def initialize(admin, method, opts, limit)
         if opts.key?(:row_limit) || opts.key?(:start_at_row)
           fail Error, 'Cannot set row_limit/start_at_row in batched mode!'
         end
@@ -18,6 +18,7 @@ module SoapyCake
         @method = method
         @opts = opts
         @offset = INITIAL_OFFSET
+        @limit = limit || LIMIT
         @finished = false
       end
 
@@ -29,22 +30,22 @@ module SoapyCake
 
       private
 
-      attr_reader :admin, :method, :opts, :finished, :offset
+      attr_reader :admin, :method, :opts, :finished, :offset, :limit
 
       def next_batch
-        result = admin.public_send(method, opts.merge(row_limit: LIMIT, start_at_row: offset))
-        @finished = true if result.count < LIMIT
-        @offset += LIMIT
+        result = admin.public_send(method, opts.merge(row_limit: limit, start_at_row: offset))
+        @finished = true if result.count < limit
+        @offset += limit
         result
       end
     end
 
-    ALLOWED_METHODS = %i(advertisers affiliates campaigns offers creatives)
+    ALLOWED_METHODS = %i(advertisers affiliates campaigns offers creatives clicks conversions)
 
-    def method_missing(name, opts = {})
+    def method_missing(name, opts = {}, limit = nil)
       fail Error, "Invalid method #{name}" unless ALLOWED_METHODS.include?(name)
 
-      BatchedRequest.new(admin, name, opts).to_enum
+      BatchedRequest.new(admin, name, opts, limit).to_enum
     end
 
     private

data/lib/soapy_cake/version.rb

@@ -1,3 +1,3 @@
 module SoapyCake
-  VERSION = '1.11.0'
+  VERSION = '1.11.1'
 end

data/spec/lib/soapy_cake/admin_batched_spec.rb

@@ -19,9 +19,16 @@ RSpec.describe SoapyCake::AdminBatched do
     expect(result.to_a).to eq(%i(a b c))
   end
 
+  it 'can use a custom limit' do
+    expect(admin).to receive(:offers)
+      .with(advertiser: 1, start_at_row: 1, row_limit: 100).and_return(%i(a b))
+
+    expect(subject.offers({ advertiser: 1 }, 100).to_a).to eq(%i(a b))
+  end
+
   context 'errors' do
     it 'fails with an invalid method' do
-      expect { subject.clicks }.to raise_error(/Invalid method clicks/)
+      expect { subject.something }.to raise_error(/Invalid method something/)
     end
 
     it 'fails when row_limit is set' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: soapy_cake
 version: !ruby/object:Gem::Version
-  version: 1.11.0
+  version: 1.11.1
 platform: ruby
 authors:
 - ad2games GmbH
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-27 00:00:00.000000000 Z
+date: 2015-07-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport