soapy_cake 1.10.0 → 1.10.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e449eedeaa5cdce80c84426b85054ebc48d19f14
-  data.tar.gz: e44a87372c2030c0971b36c41713b7b78d865395
+  metadata.gz: bd7f28046b9e639c95ee20d72a246a4c82e60b9b
+  data.tar.gz: 36e406d3aa3c8d08120bc37778f0497b5df82c57
 SHA512:
-  metadata.gz: ed74f8a1fc307b5cb32dfee2a8c5c692118ac4338d7003791c4cff3c96e0288cc885eb7739fea8c7f8f91e9189a735c69b6b258830bb2bad853dcebbadf82dbd
-  data.tar.gz: 41137d677751139b8393d4e12abdc317e8e52c0aa806ffcb344c5cf4522f0ed362b528fc9c8511c14f3ab3e93ac9616854ec824f6d3034c43526a6697dfa65f2
+  metadata.gz: 7cc24e2507e40d571b4ad10d300e5662e55fd780fecf80caba7a1a96ab4cbceb3a5f345fa0f37200582d38c81b0e48be37ae63af7595bfdb43b0cbecb5a69414
+  data.tar.gz: cbd21bed265871e15e7c696d4d8549d8122e397133a1dd645c001a0173aff06b2984d6d6adac776eb606501652dad1be189b484781c6c742581b0bdb8ef9657c

data/README.md

@@ -51,11 +51,3 @@ at [api_versions.yml](api_versions.yml).
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create a new Pull Request
-
-## Actual Soapy Cakes
-
-If you are looking for actual soap cakes...
-
-![Soapy Cake](http://soapycakes.co/wp-content/uploads/2012/05/blogpics17-310x205.jpg)
-
-you should head to [soapycakes.co](http://soapycakes.co).

data/lib/soapy_cake/admin_addedit.rb

@@ -167,13 +167,20 @@ module SoapyCake
     def apply_tag_opts!(opts)
       return unless opts[:tags]
 
-      if opts[:tags].to_s == ''
-        opts[:tags_modification_type] = 'remove_all'
-        opts[:tags] = ''
-      else
-        opts[:tags_modification_type] = opts[:offer_id] ? 'add' : 'replace'
-        opts[:tags] = Array(opts[:tags]).join(',')
-      end
+      apply_tag_modification_type!(opts)
+
+      opts[:tags] = Array(opts[:tags]).join(',')
+    end
+
+    def apply_tag_modification_type!(opts)
+      opts[:tags_modification_type] =
+        if opts[:tags].to_s == ''
+          'remove_all'
+        elsif opts.delete(:tags_replace) && opts[:offer_id] != 0
+          'replace'
+        else
+          'add'
+        end
     end
 
     def default_offer_options

data/lib/soapy_cake/version.rb

@@ -1,3 +1,3 @@
 module SoapyCake
-  VERSION = '1.10.0'
+  VERSION = '1.10.1'
 end

data/spec/lib/soapy_cake/admin_addedit_spec.rb

@@ -0,0 +1,82 @@
+RSpec.describe SoapyCake::AdminAddedit do
+  before do
+    allow_any_instance_of(SoapyCake::Client).to receive(:run).and_return({})
+  end
+
+  describe '#edit_offer' do
+    let(:offer_params) do
+      {
+        offer_id: 12,
+        advertiser_id: 1,
+        vertical_id: 1,
+        postback_url_ms_delay: 0,
+        offer_contract_hidden: true,
+        price_format_id: :cpa,
+        received: 0,
+        received_percentage: 0,
+        payout: 0,
+        tags: 'new-tag'
+      }
+    end
+
+    it 'keeps existing tags' do
+      expect(SoapyCake::Request).to receive(:new)
+        .with(:admin, :addedit, :offer,
+          hash_including(tags: 'new-tag', tags_modification_type: 'add'))
+
+      subject.edit_offer(offer_params)
+    end
+
+    it 'allows replacing tags' do
+      expect(SoapyCake::Request).to receive(:new)
+        .with(:admin, :addedit, :offer,
+          hash_including(tags: 'new-tag', tags_modification_type: 'replace'))
+
+      subject.edit_offer(offer_params.merge(tags_replace: true))
+    end
+  end
+
+  describe '#add_offer' do
+    let(:offer_params) do
+      {
+        offer_name: 'Test',
+        hidden: true,
+        offer_status_id: :public,
+        offer_type_id: :third_party,
+        currency_id: :eur,
+        ssl: true,
+        click_cookie_days: 1,
+        impression_cookie_days: 1,
+        redirect_404: true,
+        enable_view_thru_conversions: true,
+        click_trumps_impression: true,
+        disable_click_deduplication: false,
+        last_touch: true,
+        enable_transaction_id_deduplication: true,
+        postbacks_only: false,
+        fire_global_pixel: true,
+        fire_pixel_on_nonpaid_conversions: false,
+        offer_link: 'http://www.ree.com',
+        thankyou_link: 'http://www.www.ww',
+        from_lines: '',
+        subject_lines: '',
+        advertiser_id: 1,
+        vertical_id: 1,
+        postback_url_ms_delay: 0,
+        offer_contract_hidden: false,
+        price_format_id: :cpa,
+        received: 4,
+        received_percentage: false,
+        payout: 4
+      }
+    end
+
+    it 'always adds on creation' do
+      expect(SoapyCake::Request).to receive(:new)
+        .with(:admin, :addedit, :offer,
+          hash_including(tags: 'tag', tags_modification_type: 'add'))
+
+      subject.add_offer(offer_params.merge(tags: 'tag', tags_replace: true))
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: soapy_cake
 version: !ruby/object:Gem::Version
-  version: 1.10.0
+  version: 1.10.1
 platform: ruby
 authors:
 - ad2games GmbH
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-23 00:00:00.000000000 Z
+date: 2015-07-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -215,6 +215,7 @@ files:
 - spec/integration/soapy_cake/admin_addedit_spec.rb
 - spec/integration/soapy_cake/admin_spec.rb
 - spec/integration/soapy_cake/admin_track_spec.rb
+- spec/lib/soapy_cake/admin_addedit_spec.rb
 - spec/lib/soapy_cake/admin_spec.rb
 - spec/lib/soapy_cake/admin_track_spec.rb
 - spec/lib/soapy_cake/affiliate_spec.rb
@@ -268,6 +269,7 @@ test_files:
 - spec/integration/soapy_cake/admin_addedit_spec.rb
 - spec/integration/soapy_cake/admin_spec.rb
 - spec/integration/soapy_cake/admin_track_spec.rb
+- spec/lib/soapy_cake/admin_addedit_spec.rb
 - spec/lib/soapy_cake/admin_spec.rb
 - spec/lib/soapy_cake/admin_track_spec.rb
 - spec/lib/soapy_cake/affiliate_spec.rb