soapy_cake 0.2.1 → 0.2.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d84a9fa4e30d6c6fe16a0b8c4c9ad0f3a7fa5fdb
-  data.tar.gz: 271ad7e092f7c9ee8319b7fa73720bfcbc4c1dbc
+  metadata.gz: 9b53508bd3216bab78655097a29155c363dcd40c
+  data.tar.gz: 307e42a79a8dfe66a984ad27eef27548befa0bf4
 SHA512:
-  metadata.gz: b77069e1844a7c8ba88d5d84982b5a8b95cc81bb1301744e7ef509780a18f376d296fa1ec21021d591804976f8b1656d0b024bd01588def199bc96427457a375
-  data.tar.gz: 2b362c00e8ed251b12025ad67ee73a757e1f7739c376bd6d348cadbabb711ab177836cded26f47d5d906dd23e6ad18c94344d3395276c744c23ba1cf405f4567
+  metadata.gz: edb5178d36653d29c321fa3b28b1abc5637942aa63d9f0159b6e4f7abc768a946ec736437d8ccc8a8464530a99f55731f0e806970ac3745f94aa7880ffb8e470
+  data.tar.gz: 8ba791b73e73e10b8da57bad9d3e87e3407248a1103006104dfbb717a10ea7fdcc7004cce6ea3359f8aae7be6458656cdb5d7cf0c3d8b7cc8c0dd7697cc4c81e

data/.ruby-version

@@ -1 +1 @@
-2.0.0-p451
+2.1.2

data/Gemfile

@@ -2,3 +2,7 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in soapy_cake.gemspec
 gemspec
+
+group :test do
+  gem 'codeclimate-test-reporter', require: false
+end

data/README.md

@@ -1,4 +1,9 @@
 # SoapyCake
+[![Code Climate](https://codeclimate.com/github/ad2games/soapy_cake.png)](https://codeclimate.com/github/ad2games/soapy_cake)
+[![Test Coverage](https://codeclimate.com/github/ad2games/soapy_cake/coverage.png)](https://codeclimate.com/github/ad2games/soapy_cake)
+[![Gem Version](http://img.shields.io/gem/v/soapy_cake.svg)](http://rubygems.org/gems/soapy_cake)
+[![Dependency Status](http://img.shields.io/gemnasium/ad2games/soapy_cake.svg)](https://gemnasium.com/ad2games/soapy_cake)
+[![Build Status](https://circleci.com/gh/ad2games/soapy_cake.png?circle-token=aac691804f58acd8e96db632f8133e3c6155f123)](https://circleci.com/gh/ad2games/soapy_cake)
 
 Simple client library for [cake](http://getcake.com).
 
@@ -37,7 +42,7 @@ SoapyCake::Client.reports.affiliate_summary(
 ```
 
 If you are interested in how we map methods to api endpoints take a look
-at [api_versions.yml](/ad2games/soapy_cake/blob/master/api_versions.yml).
+at [api_versions.yml](api_versions.yml).
 
 ## Contributing
 

data/api_versions.yml

@@ -1,5 +1,10 @@
 ---
 :admin:
+  :accounting:
+    :mark_affiliate_bill_as_received: 1
+    :export_advertiser_bills: 1
+    :export_affiliate_bills: 1
+    :mark_affiliate_bill_as_paid: 1
   :add:
     :advertiser_credit: 1
     :creative: 1
@@ -101,3 +106,6 @@
 :affiliates:
   :reports:
     :bills: 3
+  :offers:
+    :offer_feed: 4
+    :get_campaign: 2

data/lib/soapy_cake/client.rb

@@ -84,22 +84,28 @@ module SoapyCake
 
     def process_response(method, response)
       Time.use_zone('UTC') do
-        raise response[:fault][:reason][:text] if response[:fault]
+        raise RequestUnsuccessful, response[:fault][:reason][:text] if response[:fault]
         node_name = {
           'affiliate_summary' => 'affiliates',
+          'advertiser_summary' => 'advertisers',
           'affiliate_tags' => 'tags',
           'offer_summary' => 'offers',
+          'campaign_summary' => 'campaigns',
+          'offer_feed' => 'offers',
+          'export_affiliate_bills' => 'affiliate_bills',
+          'export_advertiser_bills' => 'advertiser_bills',
         }.fetch(method, method)
+
         result = response[:"#{method}_response"][:"#{method}_result"]
-        raise result[:message] if result[:success] == false
-        return result unless result_has_collection?(result)
+        raise RequestUnsuccessful, result[:message] if result[:success] == false
+        return result unless result_has_collection?(result, method)
         extract_collection(node_name, result).
           map { |hash| remove_prefix(node_name, hash) }
       end
     end
 
-    def result_has_collection?(result)
-      !result.key?(:message)
+    def result_has_collection?(result, method)
+      !result.key?(:message) && !method.to_s.starts_with?('get_')
     end
 
     def extract_collection(node_name, response)
@@ -141,5 +147,7 @@ module SoapyCake
     def supported?(method)
       API_VERSIONS[role][service].keys.include?(method)
     end
+
+    class RequestUnsuccessful < RuntimeError; end
   end
 end

data/lib/soapy_cake/version.rb

@@ -1,3 +1,3 @@
 module SoapyCake
-  VERSION = '0.2.1'
+  VERSION = '0.2.10'
 end

data/soapy_cake.gemspec

@@ -26,5 +26,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rspec', '>= 3.0.0'
   spec.add_development_dependency 'vcr'
   spec.add_development_dependency 'webmock'
-  spec.add_development_dependency 'byebug'
+  spec.add_development_dependency 'pry'
 end

data/spec/lib/soapy_cake/client_spec.rb

@@ -149,10 +149,45 @@ describe SoapyCake::Client do
       }
     end
 
+    let(:get_response) do
+      {
+        get_campaign_response: {
+          get_campaign_result: {
+            success: true,
+            campaign: {
+              offer_id: '5129'
+            }
+          }
+        }
+      }
+    end
+
     it 'handles responses with a message field as not having a collection' do
       expect(client.send(:process_response, :affiliate, response)).to eq(
         response[:affiliate_response][:affiliate_result])
     end
+
+    it 'handles get API responses as having no collection' do
+      expect(client.send(:process_response, :get_campaign, get_response)).to eq(
+        get_response[:get_campaign_response][:get_campaign_result])
+    end
+
+    it 'raises RequestUnsuccessful if response contains success: false' do
+      expect {
+        client.send(:process_response, :affiliate, {
+          affiliate_response: {
+            affiliate_result: { message: 'FAIL!', success: false }
+          }
+        })
+      }.to raise_error(SoapyCake::Client::RequestUnsuccessful, 'FAIL!')
+    end
+
+    it 'raises RequestUnsuccessful if response contains `:fault` key' do
+      expect {
+        client.send(:process_response, :affiliate,
+                    { fault: { reason: { text: 'FAIL!' }}})
+      }.to raise_error(SoapyCake::Client::RequestUnsuccessful, 'FAIL!')
+    end
   end
 
   describe 'instantiating through class method' do

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+require "codeclimate-test-reporter"
+CodeClimate::TestReporter.start
 require 'bundler/setup'
 Bundler.require(:default, :development)
 require 'soapy_cake'
@@ -33,4 +35,7 @@ VCR.configure do |c|
   c.filter_sensitive_data('cake-api-key') { ENV['CAKE_API_KEY'] }
   c.filter_sensitive_data('cake-partner-domain.com') { ENV['CAKE_DOMAIN'] }
   c.default_cassette_options = { match_requests_on: [:method, :uri, :body] }
+
+  # allow codeclimate-test-reporter to phone home
+  c.ignore_hosts 'codeclimate.com'
 end

metadata

@@ -1,125 +1,125 @@
 --- !ruby/object:Gem::Specification
 name: soapy_cake
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.10
 platform: ruby
 authors:
 - ad2games GmbH
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-23 00:00:00.000000000 Z
+date: 2014-09-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: sekken
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.0.0
 - !ruby/object:Gem::Dependency
   name: vcr
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: byebug
+  name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: Simple client for the CAKE API (http://getcake.com)
@@ -129,9 +129,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .ruby-version
+- ".gitignore"
+- ".rspec"
+- ".ruby-version"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -177,17 +177,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.3.0
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Simple client for the CAKE API
@@ -216,4 +216,3 @@ test_files:
 - spec/fixtures/vcr_cassettes/client_sekken_client_caches_results.yml
 - spec/lib/soapy_cake/client_spec.rb
 - spec/spec_helper.rb
-has_rdoc: