soapy_bing 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ea5a6965e864eb014503ddafecb249e2effd9195
-  data.tar.gz: 50ea9e0645a6625676e7516abe118e72f9d05c06
+  metadata.gz: 6afe9e7e07f2ae7766ed8bf8ede8fd09bb44d959
+  data.tar.gz: 471bcd556c53589f2e2721507f85a4e582d29fbc
 SHA512:
-  metadata.gz: 219d83ed3736b437e9840b5ad91dfda4e307ca282097ebfd0d37a4d5e4823036e6a1c4be81be73a75c0a632a463dd170695e0671e3b8b2e89b68eebcb24bf42e
-  data.tar.gz: 831a248fc27408938e8cbe7d22e91b4e1f7bb4ebb86dea0fb27493872757ae34b8c439a5f54bb9ec7dca9f92c16645f522822729b19384aded7264e64e634ff6
+  metadata.gz: 1097d26a4f5a57076061b4a550a9c0cdfdc8579bc0315d86e444c07d0d3690c743ed36e8c94b33a19f4a8f423bfd0af4452eebce034dfad243861534b642e0d1
+  data.tar.gz: 3f3b44dec28fc377efc7cb813efef0d69847b6e5fb6eff01a717b6244cf42da59293d17d0f63f286d5d564735de65f284d5e059df4997d24923c095e5f1c1ad8

data/README.md

@@ -8,7 +8,7 @@ Client library for [Bing Ads API](https://msdn.microsoft.com/en-us/library/bing-
 In your Gemfile
 
 ```ruby
-gem 'soapy-bing', git: 'https://github.com/ad2games/soapy-bing'
+gem 'soapy_bing', git: 'https://github.com/ad2games/soapy_bing'
 ```
 
 ## Usage Examples

data/lib/soapy_bing/accounts.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+module SoapyBing
+  class Accounts
+    attr_reader :oauth_credentials, :customer
+
+    def initialize(oauth: {}, customer: {})
+      @oauth_credentials = OauthCredentials.new(oauth)
+      @customer = Customer.new(customer)
+    end
+
+    def list
+      do_request(Soap::Request::GetAccountsInfoRequest).map do |account|
+        Account.new(
+          developer_token: customer.developer_token,
+          customer_id: customer.customer_id,
+          account_id: account['Id']
+        )
+      end
+    end
+
+    private
+
+    def do_request(klass, options = {})
+      klass.new(context: {
+        authentication_token: oauth_credentials.access_token,
+        developer_token: customer.developer_token
+      }.merge(options))
+        .perform
+        .payload
+    end
+  end
+end

data/lib/soapy_bing/customer.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+module SoapyBing
+  class Customer
+    attr_reader :developer_token, :customer_id
+
+    def initialize(account_options)
+      param_guard = ParamGuard.new(account_options, env_namespace: 'BING_ADS')
+      @developer_token = param_guard.require!(:developer_token)
+      @customer_id = param_guard.require!(:customer_id)
+    end
+  end
+end

data/lib/soapy_bing/soap/request/get_accounts_info_request.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+module SoapyBing
+  module Soap
+    module Request
+      class GetAccountsInfoRequest < Base
+        API_BASE_URL = 'https://clientcenter.api.bingads.microsoft.com'
+        API_VERSION = 9
+        API_ENDPOINT = "#{API_BASE_URL}/Api/CustomerManagement/" \
+          "v#{API_VERSION}/CustomerManagementService.svc"
+
+        def perform
+          Response::GetAccountsInfoResponse.new(post(API_ENDPOINT))
+        end
+      end
+    end
+  end
+end

data/lib/soapy_bing/soap/request.rb

@@ -5,3 +5,4 @@ require 'soapy_bing/soap/request/poll_generate_report_request'
 require 'soapy_bing/soap/request/get_ad_groups_by_campaign_id_request'
 require 'soapy_bing/soap/request/get_ads_by_ad_group_id_request'
 require 'soapy_bing/soap/request/get_targets_by_campaign_ids_request'
+require 'soapy_bing/soap/request/get_accounts_info_request'

data/lib/soapy_bing/soap/response/get_accounts_info_response.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+module SoapyBing
+  module Soap
+    module Response
+      class GetAccountsInfoResponse < Base
+        def extract_payload
+          Array.wrap(body['Envelope']['Body'][class_name]['AccountsInfo']['AccountInfo'])
+        end
+      end
+    end
+  end
+end

data/lib/soapy_bing/soap/response.rb

@@ -9,3 +9,4 @@ require 'soapy_bing/soap/response/poll_generate_report_response'
 require 'soapy_bing/soap/response/get_ad_groups_by_campaign_id_response'
 require 'soapy_bing/soap/response/get_ads_by_ad_group_id_response'
 require 'soapy_bing/soap/response/get_targets_by_campaign_ids_response'
+require 'soapy_bing/soap/response/get_accounts_info_response'

data/lib/soapy_bing/soap/templates/get_accounts_info.erb.xml

@@ -0,0 +1,12 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<s:Envelope xmlns:i="http://www.w3.org/2001/XMLSchema-instance" xmlns:s="http://schemas.xmlsoap.org/soap/envelope/">
+<s:Header xmlns="https://bingads.microsoft.com/Customer/v9">
+  <Action mustUnderstand="1">GetAccountsInfo</Action>
+  <AuthenticationToken><%= authentication_token %></AuthenticationToken>
+  <DeveloperToken><%= developer_token %></DeveloperToken>
+</s:Header>
+<s:Body>
+  <GetAccountsInfoRequest xmlns="https://bingads.microsoft.com/Customer/v9">
+  </GetAccountsInfoRequest>
+</s:Body>
+</s:Envelope>

data/lib/soapy_bing/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module SoapyBing
-  VERSION = '0.1.0'
+  VERSION = '0.2.0'
 end

data/lib/soapy_bing.rb

@@ -6,7 +6,9 @@ require 'active_support/core_ext/string/inflections'
 
 require 'soapy_bing/helpers'
 require 'soapy_bing/param_guard'
+require 'soapy_bing/customer'
 require 'soapy_bing/account'
 require 'soapy_bing/oauth_credentials'
 require 'soapy_bing/soap'
 require 'soapy_bing/ads'
+require 'soapy_bing/accounts'

data/spec/fixtures/vcr_cassettes/SoapyBing_Accounts/_list/returns_a_list_of_SoapyBing_Account_objects.yml

@@ -0,0 +1,100 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: https://login.live.com/oauth20_token.srf
+    body:
+      encoding: UTF-8
+      string: client_id=bing-ads-oauth-client-id&client_secret=bing-ads-oauth-client-secret&grant_type=refresh_token&refresh_token=bing-ads-oauth-refresh-token
+    headers:
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Cache-Control:
+      - no-store
+      Pragma:
+      - no-cache
+      Content-Length:
+      - '1509'
+      Content-Type:
+      - application/json
+      Server:
+      - Microsoft-IIS/8.5
+      X-Content-Type-Options:
+      - nosniff
+      Strict-Transport-Security:
+      - max-age=31536000
+      X-Xss-Protection:
+      - 1; mode=block
+      Date:
+      - Tue, 16 Aug 2016 01:02:11 GMT
+      Connection:
+      - close
+    body:
+      encoding: UTF-8
+      string: '{"token_type":"bearer","expires_in":3600,"scope":"bingads.manage","access_token":"bing-ads-oauth-authentication-token","refresh_token":"bing-ads-oauth-refresh-token","user_id":"bing-ads-oauth-user-id"}'
+    http_version: 
+  recorded_at: Tue, 16 Aug 2016 01:02:11 GMT
+- request:
+    method: post
+    uri: https://clientcenter.api.bingads.microsoft.com/Api/CustomerManagement/v9/CustomerManagementService.svc
+    body:
+      encoding: UTF-8
+      string: |
+        <?xml version="1.0" encoding="UTF-8"?>
+        <s:Envelope xmlns:i="http://www.w3.org/2001/XMLSchema-instance" xmlns:s="http://schemas.xmlsoap.org/soap/envelope/">
+        <s:Header xmlns="https://bingads.microsoft.com/Customer/v9">
+          <Action mustUnderstand="1">GetAccountsInfo</Action>
+          <AuthenticationToken>bing-ads-oauth-authentication-token</AuthenticationToken>
+          <DeveloperToken>bing-ads-developer-token</DeveloperToken>
+        </s:Header>
+        <s:Body>
+          <GetAccountsInfoRequest xmlns="https://bingads.microsoft.com/Customer/v9">
+          </GetAccountsInfoRequest>
+        </s:Body>
+        </s:Envelope>
+    headers:
+      Content-Type:
+      - text/xml;charset=UTF-8
+      Soapaction:
+      - GetAccountsInfo
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Cache-Control:
+      - private
+      Content-Length:
+      - '1078'
+      Content-Type:
+      - text/xml; charset=utf-8
+      Server:
+      - Microsoft-IIS/8.0
+      X-Aspnet-Version:
+      - 4.0.30319
+      X-Powered-By:
+      - ASP.NET
+      Date:
+      - Tue, 16 Aug 2016 01:02:12 GMT
+    body:
+      encoding: UTF-8
+      string: <s:Envelope xmlns:s="http://schemas.xmlsoap.org/soap/envelope/"><s:Header><h:TrackingId
+        xmlns:h="https://bingads.microsoft.com/Customer/v9">bing-ads-report-tracking-id</h:TrackingId></s:Header><s:Body><GetAccountsInfoResponse
+        xmlns="https://bingads.microsoft.com/Customer/v9"><AccountsInfo xmlns:a="https://bingads.microsoft.com/Customer/v9/Entities"
+        xmlns:i="http://www.w3.org/2001/XMLSchema-instance"><a:AccountInfo><a:Id>1111111</a:Id><a:Name>ad2games
+        GmbH</a:Name><a:Number>X000F9Z7</a:Number><a:AccountLifeCycleStatus>Active</a:AccountLifeCycleStatus><a:PauseReason
+        i:nil="true"/></a:AccountInfo><a:AccountInfo><a:Id>2222222</a:Id><a:Name>SuperBrowserGames.com</a:Name><a:Number>X000K92F</a:Number><a:AccountLifeCycleStatus>Active</a:AccountLifeCycleStatus><a:PauseReason
+        i:nil="true"/></a:AccountInfo><a:AccountInfo><a:Id>33333333</a:Id><a:Name>Wildworks.com</a:Name><a:Number>B008CXY6</a:Number><a:AccountLifeCycleStatus>Active</a:AccountLifeCycleStatus><a:PauseReason
+        i:nil="true"/></a:AccountInfo></AccountsInfo></GetAccountsInfoResponse></s:Body></s:Envelope>
+    http_version: 
+  recorded_at: Tue, 16 Aug 2016 01:02:12 GMT
+recorded_with: VCR 3.0.3

data/spec/integration/soapy_bing/accounts_spec.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+RSpec.describe SoapyBing::Accounts do
+  subject(:instance) { described_class.new }
+
+  describe '#list', :vcr do
+    subject(:list) { instance.list }
+
+    it 'returns a list of SoapyBing::Account objects' do
+      expect(list.size).to eq(3)
+      expect(list).to all(be_an_instance_of(SoapyBing::Account))
+    end
+  end
+end

data/spec/integration/soapy_bing/ads/reports/campaign_performance_report_spec.rb

@@ -17,12 +17,12 @@ RSpec.describe SoapyBing::Ads::Reports::CampaignPerformanceReport do
   let(:fixtured_payload) { JSON.load(File.read(payload_fixture_path)) }
 
   describe '#rows' do
-    subject { report.rows }
+    subject(:rows) { report.rows }
 
     context 'when there is a successfull response during polling', :integration do
       it 'responds with report rows',
         vcr: { cassette_name: 'campaign_performance_report/with_successful_status' } do
-        expect(subject).to eq fixtured_payload
+        expect(rows).to eq fixtured_payload
       end
     end
 
@@ -31,7 +31,7 @@ RSpec.describe SoapyBing::Ads::Reports::CampaignPerformanceReport do
 
       it 'throws exception PollingTimeoutError',
         vcr: { cassette_name: 'campaign_performance_report/with_pending_status' } do
-        expect { subject }.to raise_error(
+        expect { rows }.to raise_error(
           SoapyBing::Soap::Request::PollGenerateReportRequest::PollingTimeoutError
         )
       end

data/spec/integration/soapy_bing/ads_spec.rb

@@ -9,24 +9,24 @@ RSpec.describe SoapyBing::Ads do
   describe '#get_ad_groups_by_campaign_id', :vcr do
     let(:fixture_file) { 'get_ad_groups_by_campaign_id.json' }
 
-    subject { instance.get_ad_groups_by_campaign_id(campaign_id) }
+    subject(:ad_groups) { instance.get_ad_groups_by_campaign_id(campaign_id) }
 
-    it { expect(subject).to eq(fixture_payload) }
+    it { expect(ad_groups).to eq(fixture_payload) }
   end
 
   describe '#get_ads_by_ad_group_id', :vcr do
     let(:fixture_file) { 'get_ads_by_ad_group_id.json' }
 
-    subject { instance.get_ads_by_ad_group_id(ad_group_id) }
+    subject(:ads) { instance.get_ads_by_ad_group_id(ad_group_id) }
 
-    it { expect(subject).to eq(fixture_payload) }
+    it { expect(ads).to eq(fixture_payload) }
   end
 
   describe '#get_targets_by_campaign_ids', :vcr do
     let(:fixture_file) { 'get_targets_by_campaign_ids.json' }
 
-    subject { instance.get_targets_by_campaign_ids([campaign_id]) }
+    subject(:targets) { instance.get_targets_by_campaign_ids([campaign_id]) }
 
-    it { expect(subject).to eq(fixture_payload) }
+    it { expect(targets).to eq(fixture_payload) }
   end
 end

data/spec/integration/soapy_bing/oauth_credentials_spec.rb

@@ -1,10 +1,12 @@
 # frozen_string_literal: true
 RSpec.describe SoapyBing::OauthCredentials do
+  subject(:oauth_credentials) { described_class.new }
+
   describe '#access_token' do
     context 'on successful respose', :integration do
       it 'responds with oauth access token',
         vcr: { cassette_name: 'oauth_credentials/access_token/with_successful_status' } do
-        expect(subject.access_token).to eq 'bing-ads-oauth-authentication-token'
+        expect(oauth_credentials.access_token).to eq 'bing-ads-oauth-authentication-token'
       end
     end
   end

data/spec/soapy_bing/account_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 RSpec.describe SoapyBing::Account do
   describe '#initialize' do
-    subject { described_class.new(account) }
+    subject(:account_obj) { described_class.new(account) }
 
     context 'when account credentials passed explicitly' do
       let(:account) do
@@ -14,15 +14,15 @@ RSpec.describe SoapyBing::Account do
       end
 
       it '#developer_token is set' do
-        expect(subject.developer_token).to eq 'foo'
+        expect(account_obj.developer_token).to eq 'foo'
       end
 
       it '#account_id is set' do
-        expect(subject.account_id).to eq 'baz'
+        expect(account_obj.account_id).to eq 'baz'
       end
 
       it '#customer_id is set' do
-        expect(subject.customer_id).to eq 'qux'
+        expect(account_obj.customer_id).to eq 'qux'
       end
     end
 
@@ -35,15 +35,15 @@ RSpec.describe SoapyBing::Account do
       end
 
       it '#developer_token is set' do
-        expect(subject.developer_token).to eq 'foo_env'
+        expect(account_obj.developer_token).to eq 'foo_env'
       end
 
       it '#account_id is set' do
-        expect(subject.account_id).to eq 'baz_env'
+        expect(account_obj.account_id).to eq 'baz_env'
       end
 
       it '#customer_id is set' do
-        expect(subject.customer_id).to eq 'qux_env'
+        expect(account_obj.customer_id).to eq 'qux_env'
       end
     end
 
@@ -61,19 +61,19 @@ RSpec.describe SoapyBing::Account do
 
       it 'throws exception on missing :developer_token' do
         account.delete(:developer_token)
-        expect { subject }.to raise_error SoapyBing::ParamGuard::ParamRequiredError,
+        expect { account_obj }.to raise_error SoapyBing::ParamGuard::ParamRequiredError,
           "developer_token have to be passed explicitly or via ENV['BING_ADS_DEVELOPER_TOKEN']"
       end
 
       it 'throws exception on missing :account_id' do
         account.delete(:account_id)
-        expect { subject }.to raise_error SoapyBing::ParamGuard::ParamRequiredError,
+        expect { account_obj }.to raise_error SoapyBing::ParamGuard::ParamRequiredError,
           "account_id have to be passed explicitly or via ENV['BING_ADS_ACCOUNT_ID']"
       end
 
       it 'throws exception on missing :customer_id' do
         account.delete(:customer_id)
-        expect { subject }.to raise_error SoapyBing::ParamGuard::ParamRequiredError,
+        expect { account_obj }.to raise_error SoapyBing::ParamGuard::ParamRequiredError,
           "customer_id have to be passed explicitly or via ENV['BING_ADS_CUSTOMER_ID']"
       end
     end

data/spec/soapy_bing/ads/reports/campaign_performance_report_spec.rb

@@ -3,7 +3,7 @@ require 'date'
 
 RSpec.describe SoapyBing::Ads::Reports::CampaignPerformanceReport do
   let(:report_options) { { oauth_credentials: nil, account: nil } }
-  subject { described_class.new report_options }
+  subject(:report) { described_class.new report_options }
 
   describe '#initialize' do
     let(:wrong_date) { 'wrong_date' }
@@ -13,7 +13,7 @@ RSpec.describe SoapyBing::Ads::Reports::CampaignPerformanceReport do
 
       let(:start_date) { 'wrong_date' }
       it 'throws exception' do
-        expect { subject }.to raise_error(ArgumentError, 'invalid date')
+        expect { report }.to raise_error(ArgumentError, 'invalid date')
       end
     end
   end
@@ -24,18 +24,18 @@ RSpec.describe SoapyBing::Ads::Reports::CampaignPerformanceReport do
     before { report_options.merge!(date_start: date_start, date_end: date_end) }
 
     it 'is instance of Range' do
-      expect(subject.date_range).to be_an_instance_of Range
+      expect(report.date_range).to be_an_instance_of Range
     end
 
     context 'begin' do
       it 'keeps initialized value' do
-        expect(subject.date_range.begin).to eq Date.parse(date_start)
+        expect(report.date_range.begin).to eq Date.parse(date_start)
       end
     end
 
     context 'end' do
       it 'keeps initialized value' do
-        expect(subject.date_range.end).to eq Date.parse(date_end)
+        expect(report.date_range.end).to eq Date.parse(date_end)
       end
     end
   end

data/spec/soapy_bing/ads/reports/parsers/csv_parser_spec.rb

@@ -4,7 +4,7 @@ require 'csv'
 
 RSpec.describe SoapyBing::Ads::Reports::Parsers::CSVParser do
   describe '#rows' do
-    subject { described_class.new(csv_data).rows }
+    subject(:rows) { described_class.new(csv_data).rows }
     context 'on valid CSV data' do
       let(:csv_fixture_path) do
         File.join('spec', 'fixtures', 'reports', 'campaign_performance_report.csv')
@@ -17,7 +17,7 @@ RSpec.describe SoapyBing::Ads::Reports::Parsers::CSVParser do
       let(:json_data) { JSON.load(File.read(json_fixture_path)) }
 
       it 'responds with array of Hashes' do
-        expect(subject).to eq json_data
+        expect(rows).to eq json_data
       end
     end
 
@@ -25,7 +25,7 @@ RSpec.describe SoapyBing::Ads::Reports::Parsers::CSVParser do
       let(:csv_data) { '"co", "' }
 
       it 'throws exception CSV::MalformedCSVError' do
-        expect { subject }.to raise_error CSV::MalformedCSVError
+        expect { rows }.to raise_error CSV::MalformedCSVError
       end
     end
   end

data/spec/soapy_bing/ads_spec.rb

@@ -6,28 +6,28 @@ RSpec.describe SoapyBing::Ads do
   let(:account) do
     { developer_token: 'foo', account_id: 'baz', customer_id: 'qux' }
   end
-  subject { described_class.new(oauth: oauth, account: account) }
+  subject(:ads) { described_class.new(oauth: oauth, account: account) }
 
   describe '#oauth_credentials' do
     it 'is instance of SoapyBing::OauthCredentials' do
-      expect(subject.oauth_credentials).to be_an_instance_of SoapyBing::OauthCredentials
+      expect(ads.oauth_credentials).to be_an_instance_of SoapyBing::OauthCredentials
     end
   end
 
   describe '#account' do
     it 'is instance of SoapyBing::Account' do
-      expect(subject.account).to be_an_instance_of SoapyBing::Account
+      expect(ads.account).to be_an_instance_of SoapyBing::Account
     end
   end
 
   describe '#campaign_performance_report' do
-    subject do
+    subject(:report) do
       described_class
         .new(oauth: oauth, account: account)
         .campaign_performance_report(date_start: '2015-01-01', date_end: '2015-01-01')
     end
     it 'is instance of SoapyBing::Ads::Reports::CampaignPerformanceReport' do
-      expect(subject).to be_an_instance_of SoapyBing::Ads::Reports::CampaignPerformanceReport
+      expect(report).to be_an_instance_of SoapyBing::Ads::Reports::CampaignPerformanceReport
     end
   end
 end

data/spec/soapy_bing/helpers/class_name_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 RSpec.describe SoapyBing::Helpers::ClassName do
   describe '#class_name' do
-    subject do
+    subject(:class_name) do
       stub_const(
         'OUTERNS::INNERNS::MyClass',
         Class.new.include(described_class)
@@ -9,7 +9,7 @@ RSpec.describe SoapyBing::Helpers::ClassName do
     end
 
     it 'resolves class name' do
-      expect(subject).to eq 'MyClass'
+      expect(class_name).to eq 'MyClass'
     end
   end
 end

data/spec/soapy_bing/helpers/ssl_version_spec.rb

@@ -1,7 +1,9 @@
 # frozen_string_literal: true
 RSpec.describe SoapyBing::Helpers::SSLVersion do
   describe '#ssl_version' do
-    subject { stub_const('MyClass', Class.new.include(described_class)).new.ssl_version }
+    subject(:ssl_version) do
+      stub_const('MyClass', Class.new.include(described_class)).new.ssl_version
+    end
 
     context 'when DEFAULT_SSL_VERSION is available' do
       before do
@@ -9,7 +11,7 @@ RSpec.describe SoapyBing::Helpers::SSLVersion do
       end
 
       it 'responds with DEFAULT_SSL_VERSION' do
-        expect(subject).to be MyClass::DEFAULT_SSL_VERSION
+        expect(ssl_version).to be MyClass::DEFAULT_SSL_VERSION
       end
     end
 
@@ -17,7 +19,7 @@ RSpec.describe SoapyBing::Helpers::SSLVersion do
       before { stub_const('OpenSSL::SSL::SSLContext::METHODS', []) }
 
       it 'responds with OpenSSL default version' do
-        expect(subject).to be OpenSSL::SSL::SSLContext::DEFAULT_PARAMS[:ssl_version]
+        expect(ssl_version).to be OpenSSL::SSL::SSLContext::DEFAULT_PARAMS[:ssl_version]
       end
     end
   end

data/spec/soapy_bing/oauth_credentials_spec.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 RSpec.describe SoapyBing::OauthCredentials do
-  describe '#initialize' do
-    subject { described_class.new(credentials) }
+  subject(:oauth_credentials) { described_class.new(credentials) }
 
+  describe '#initialize' do
     context 'when oauth credentials passed explicitly' do
       let(:credentials) { { client_id: 'foo', client_secret: 'bar', refresh_token: 'baz' } }
       before do
@@ -13,15 +13,15 @@ RSpec.describe SoapyBing::OauthCredentials do
       end
 
       it '#client_id is set' do
-        expect(subject.client_id).to eq 'foo'
+        expect(oauth_credentials.client_id).to eq 'foo'
       end
 
       it '#client_secret is set' do
-        expect(subject.client_secret).to eq 'bar'
+        expect(oauth_credentials.client_secret).to eq 'bar'
       end
 
       it '#refresh_token is set' do
-        expect(subject.refresh_token).to eq 'baz'
+        expect(oauth_credentials.refresh_token).to eq 'baz'
       end
     end
 
@@ -35,15 +35,15 @@ RSpec.describe SoapyBing::OauthCredentials do
       end
 
       it '#client_id is set' do
-        expect(subject.client_id).to eq 'foo_env'
+        expect(oauth_credentials.client_id).to eq 'foo_env'
       end
 
       it '#client_secret is set' do
-        expect(subject.client_secret).to eq 'bar_env'
+        expect(oauth_credentials.client_secret).to eq 'bar_env'
       end
 
       it '#refresh_token is set' do
-        expect(subject.refresh_token).to eq 'baz_env'
+        expect(oauth_credentials.refresh_token).to eq 'baz_env'
       end
     end
 
@@ -59,19 +59,19 @@ RSpec.describe SoapyBing::OauthCredentials do
 
       it 'throws exception on missing :client_id' do
         credentials.delete(:client_id)
-        expect { subject }.to raise_error SoapyBing::ParamGuard::ParamRequiredError,
+        expect { oauth_credentials }.to raise_error SoapyBing::ParamGuard::ParamRequiredError,
           'client_id have to be passed explicitly or via ENV[\'BING_ADS_OAUTH_CLIENT_ID\']'
       end
 
       it 'throws exception on missing :client_secret' do
         credentials.delete(:client_secret)
-        expect { subject }.to raise_error SoapyBing::ParamGuard::ParamRequiredError,
+        expect { oauth_credentials }.to raise_error SoapyBing::ParamGuard::ParamRequiredError,
           'client_secret have to be passed explicitly or via ENV[\'BING_ADS_OAUTH_CLIENT_SECRET\']'
       end
 
       it 'throws exception on missing :refresh_token' do
         credentials.delete(:refresh_token)
-        expect { subject }.to raise_error SoapyBing::ParamGuard::ParamRequiredError,
+        expect { oauth_credentials }.to raise_error SoapyBing::ParamGuard::ParamRequiredError,
           'refresh_token have to be passed explicitly or via ENV[\'BING_ADS_OAUTH_REFRESH_TOKEN\']'
       end
     end
@@ -92,7 +92,7 @@ RSpec.describe SoapyBing::OauthCredentials do
       before { expect(response).to receive(:[]).once.with('access_token').and_return('my-token') }
 
       it 'memoizes http request response' do
-        2.times { expect(subject.access_token).to eq 'my-token' }
+        2.times { expect(oauth_credentials.access_token).to eq 'my-token' }
       end
     end
 
@@ -100,7 +100,7 @@ RSpec.describe SoapyBing::OauthCredentials do
       let(:status_code) { 401 }
 
       it 'throws exception in case of bad status code' do
-        expect { subject.access_token }.to raise_error(
+        expect { oauth_credentials.access_token }.to raise_error(
           SoapyBing::OauthCredentials::TokenRefreshError
         )
       end

data/spec/soapy_bing/param_guard_spec.rb

@@ -2,14 +2,14 @@
 RSpec.describe SoapyBing::ParamGuard do
   describe '#require!' do
     let(:param_guard) { described_class.new(options, env_namespace: 'MY') }
-    subject { param_guard.require!(:foo) }
+    subject(:require_foo) { param_guard.require!(:foo) }
 
     context 'when option is empty' do
       let(:options) { {} }
 
       context 'and environment variable is empty too' do
         it 'thows exception' do
-          expect { subject }.to raise_exception SoapyBing::ParamGuard::ParamRequiredError,
+          expect { require_foo }.to raise_exception SoapyBing::ParamGuard::ParamRequiredError,
             'foo have to be passed explicitly or via ENV[\'MY_FOO\']'
         end
       end
@@ -18,7 +18,7 @@ RSpec.describe SoapyBing::ParamGuard do
         before { allow(ENV).to receive(:[]).with('MY_FOO').and_return('bar_env') }
 
         it 'returns environment variable value' do
-          expect(subject).to eq 'bar_env'
+          expect(require_foo).to eq 'bar_env'
         end
       end
     end
@@ -30,13 +30,13 @@ RSpec.describe SoapyBing::ParamGuard do
         before { allow(ENV).to receive(:[]).with('MY_FOO').and_return('bar_env') }
 
         it 'returns option value' do
-          expect(subject).to eq 'bar'
+          expect(require_foo).to eq 'bar'
         end
       end
 
       context 'but environment variable is empty' do
         it 'returns option value' do
-          expect(subject).to eq 'bar'
+          expect(require_foo).to eq 'bar'
         end
       end
     end

data/spec/soapy_bing/soap/request/base_spec.rb

@@ -1,14 +1,14 @@
 # frozen_string_literal: true
 RSpec.describe SoapyBing::Soap::Request::Base do
   let(:req_context) { { foo: 'Bar' } }
-  subject { described_class.new(context: req_context) }
+  subject(:request) { described_class.new(context: req_context) }
 
   before { stub_const('MyCustomRequest', Class.new(described_class) {}) }
   let(:my_custom_request) { MyCustomRequest.new(context: req_context) }
 
   describe '#context' do
     it 'keeps initialized value' do
-      expect(subject.context).to eq req_context
+      expect(request.context).to eq req_context
     end
   end
 
@@ -21,35 +21,35 @@ RSpec.describe SoapyBing::Soap::Request::Base do
         'http://example.com',
         hash_including(body: body, headers: hash_including(headers))
       )
-      subject.post('http://example.com', body: body, headers: headers)
+      request.post('http://example.com', body: body, headers: headers)
     end
   end
 
   describe '#default_body' do
-    subject { my_custom_request.default_body }
+    subject(:default_body) { my_custom_request.default_body }
     it 'renders request body template' do
       renderer = instance_double(SoapyBing::Soap::TemplateRenderer)
       expect(SoapyBing::Soap::TemplateRenderer).to receive(:new)
         .with(hash_including(req_context)).and_return(renderer)
       expect(renderer).to receive(:render).with('my_custom')
-      subject
+      default_body
     end
   end
 
   describe '#default_headers' do
-    subject { my_custom_request.default_headers }
+    subject(:default_headers) { my_custom_request.default_headers }
     it 'contains soap action' do
-      expect(subject).to include('SOAPAction' => 'MyCustom')
+      expect(default_headers).to include('SOAPAction' => 'MyCustom')
     end
     it 'contains default headers' do
-      expect(subject).to include(described_class::DEFAULT_HTTP_HEADERS)
+      expect(default_headers).to include(described_class::DEFAULT_HTTP_HEADERS)
     end
   end
 
   describe '#action_name' do
-    subject { my_custom_request.action_name }
+    subject(:action_name) { my_custom_request.action_name }
     it 'resolves request\'s class soap action' do
-      expect(subject).to eq 'MyCustom'
+      expect(action_name).to eq 'MyCustom'
     end
   end
 end

data/spec/soapy_bing/soap/request/poll_generate_report_request_spec.rb

@@ -35,7 +35,7 @@ RSpec.describe SoapyBing::Soap::Request::PollGenerateReportRequest do
       end
     end
 
-    subject do
+    subject(:perform) do
       described_class
         .new(
           context: {
@@ -48,13 +48,13 @@ RSpec.describe SoapyBing::Soap::Request::PollGenerateReportRequest do
 
     it 'polls until successful response' do
       expect(HTTParty).to receive(:post).exactly(3).times
-      expect(subject.payload).to eq 'http://example.com'
+      expect(perform.payload).to eq 'http://example.com'
     end
 
     it 'throws PollingTimeoutError when exceeded polling tries' do
       stub_const('SoapyBing::Soap::Request::PollGenerateReportRequest::POLLING_TRIES', 1)
       expect(HTTParty).to receive(:post).once
-      expect { subject }.to raise_error described_class::PollingTimeoutError
+      expect { perform }.to raise_error described_class::PollingTimeoutError
     end
   end
 end

data/spec/soapy_bing/soap/response/base_spec.rb

@@ -5,9 +5,9 @@ RSpec.describe SoapyBing::Soap::Response::Base do
   let(:my_custom_response) { MyCustomResponse.new(response_body) }
 
   describe '#body' do
-    subject { my_custom_response.body }
+    subject(:body) { my_custom_response.body }
     it 'keeps initialized value' do
-      expect(subject).to eq response_body
+      expect(body).to eq response_body
     end
   end
 end

data/spec/soapy_bing/soap/response/payload_spec.rb

@@ -9,18 +9,18 @@ RSpec.describe SoapyBing::Soap::Response::Payload do
     )
   end
 
-  subject { MyCustomResponse.new }
+  subject(:response) { MyCustomResponse.new }
 
   describe '#payload' do
     it 'memoize #extract_payload value' do
-      expect(subject).to receive(:extract_payload).once.and_return(true)
-      2.times { subject.payload }
+      expect(response).to receive(:extract_payload).once.and_return(true)
+      2.times { response.payload }
     end
   end
 
   describe '#extract_payload' do
     it 'throws NotImplementedError' do
-      expect { subject.extract_payload }.to raise_error NotImplementedError
+      expect { response.extract_payload }.to raise_error NotImplementedError
     end
   end
 end

data/spec/soapy_bing/soap/response/poll_generate_report_response_spec.rb

@@ -14,13 +14,13 @@ RSpec.describe SoapyBing::Soap::Response::PollGenerateReportResponse do
       }
     }
   end
-  let(:subject) { described_class.new(response_hash) }
+  subject(:response) { described_class.new(response_hash) }
 
   it 'includes ReportStatus' do
     expect(described_class.ancestors).to include SoapyBing::Soap::Response::ReportStatus
   end
 
   it '#extract_payload returns download url' do
-    expect(subject.extract_payload).to eq url
+    expect(response.extract_payload).to eq url
   end
 end

data/spec/soapy_bing/soap/response/report_status_spec.rb

@@ -21,7 +21,7 @@ RSpec.describe SoapyBing::Soap::Response::ReportStatus do
       }
     }
   end
-  let(:subject) { MyCustomResponse.new(response_hash) }
+  subject(:response) { MyCustomResponse.new(response_hash) }
 
   describe 'status' do
     before do
@@ -33,19 +33,19 @@ RSpec.describe SoapyBing::Soap::Response::ReportStatus do
       let(:status) { 'Error' }
 
       it '#status is Error' do
-        expect(subject.status).to eq status
+        expect(response.status).to eq status
       end
 
       it '#error? is false' do
-        expect(subject).to be_error
+        expect(response).to be_error
       end
 
       it '#success? is false' do
-        expect(subject).not_to be_success
+        expect(response).not_to be_success
       end
 
       it '#pending? is false' do
-        expect(subject).not_to be_pending
+        expect(response).not_to be_pending
       end
     end
 
@@ -53,19 +53,19 @@ RSpec.describe SoapyBing::Soap::Response::ReportStatus do
       let(:status) { 'Success' }
 
       it '#status is Success' do
-        expect(subject.status).to eq status
+        expect(response.status).to eq status
       end
 
       it '#error? is false' do
-        expect(subject).not_to be_error
+        expect(response).not_to be_error
       end
 
       it '#success? is true' do
-        expect(subject).to be_success
+        expect(response).to be_success
       end
 
       it '#pending? is false' do
-        expect(subject).not_to be_pending
+        expect(response).not_to be_pending
       end
     end
 
@@ -73,19 +73,19 @@ RSpec.describe SoapyBing::Soap::Response::ReportStatus do
       let(:status) { 'Pending' }
 
       it '#status is Pending' do
-        expect(subject.status).to eq status
+        expect(response.status).to eq status
       end
 
       it '#error? is false' do
-        expect(subject).not_to be_error
+        expect(response).not_to be_error
       end
 
       it '#success? is false' do
-        expect(subject).not_to be_success
+        expect(response).not_to be_success
       end
 
       it '#pending? is true' do
-        expect(subject).to be_pending
+        expect(response).to be_pending
       end
     end
   end

data/spec/soapy_bing/soap/response/submit_generate_report_response_spec.rb

@@ -12,9 +12,9 @@ RSpec.describe SoapyBing::Soap::Response::SubmitGenerateReportResponse do
       }
     }
   end
-  let(:subject) { described_class.new(response_hash) }
+  subject(:response) { described_class.new(response_hash) }
 
   it '#extract_payload returns request id' do
-    expect(subject.extract_payload).to eq request_id
+    expect(response.extract_payload).to eq request_id
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: soapy_bing
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - ad2games GmbH
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-01 00:00:00.000000000 Z
+date: 2016-08-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: erubis
@@ -195,12 +195,14 @@ files:
 - circle.yml
 - lib/soapy_bing.rb
 - lib/soapy_bing/account.rb
+- lib/soapy_bing/accounts.rb
 - lib/soapy_bing/ads.rb
 - lib/soapy_bing/ads/reports.rb
 - lib/soapy_bing/ads/reports/base.rb
 - lib/soapy_bing/ads/reports/campaign_performance_report.rb
 - lib/soapy_bing/ads/reports/parsers.rb
 - lib/soapy_bing/ads/reports/parsers/csv_parser.rb
+- lib/soapy_bing/customer.rb
 - lib/soapy_bing/helpers.rb
 - lib/soapy_bing/helpers/class_name.rb
 - lib/soapy_bing/helpers/ssl_version.rb
@@ -209,6 +211,7 @@ files:
 - lib/soapy_bing/soap.rb
 - lib/soapy_bing/soap/request.rb
 - lib/soapy_bing/soap/request/base.rb
+- lib/soapy_bing/soap/request/get_accounts_info_request.rb
 - lib/soapy_bing/soap/request/get_ad_groups_by_campaign_id_request.rb
 - lib/soapy_bing/soap/request/get_ads_by_ad_group_id_request.rb
 - lib/soapy_bing/soap/request/get_targets_by_campaign_ids_request.rb
@@ -216,6 +219,7 @@ files:
 - lib/soapy_bing/soap/request/submit_generate_report_request.rb
 - lib/soapy_bing/soap/response.rb
 - lib/soapy_bing/soap/response/base.rb
+- lib/soapy_bing/soap/response/get_accounts_info_response.rb
 - lib/soapy_bing/soap/response/get_ad_groups_by_campaign_id_response.rb
 - lib/soapy_bing/soap/response/get_ads_by_ad_group_id_response.rb
 - lib/soapy_bing/soap/response/get_targets_by_campaign_ids_response.rb
@@ -224,6 +228,7 @@ files:
 - lib/soapy_bing/soap/response/report_status.rb
 - lib/soapy_bing/soap/response/submit_generate_report_response.rb
 - lib/soapy_bing/soap/template_renderer.rb
+- lib/soapy_bing/soap/templates/get_accounts_info.erb.xml
 - lib/soapy_bing/soap/templates/get_ad_groups_by_campaign_id.erb.xml
 - lib/soapy_bing/soap/templates/get_ads_by_ad_group_id.erb.xml
 - lib/soapy_bing/soap/templates/get_targets_by_campaign_ids.erb.xml
@@ -240,12 +245,14 @@ files:
 - spec/fixtures/reports/campaign_performance_report.csv
 - spec/fixtures/reports/campaign_performance_report.json
 - spec/fixtures/soap_templates/simple.erb.xml
+- spec/fixtures/vcr_cassettes/SoapyBing_Accounts/_list/returns_a_list_of_SoapyBing_Account_objects.yml
 - spec/fixtures/vcr_cassettes/SoapyBing_Ads/_get_ad_groups_by_campaign_id/1_1_1.yml
 - spec/fixtures/vcr_cassettes/SoapyBing_Ads/_get_ads_by_ad_group_id/1_2_1.yml
 - spec/fixtures/vcr_cassettes/SoapyBing_Ads/_get_targets_by_campaign_ids/1_3_1.yml
 - spec/fixtures/vcr_cassettes/campaign_performance_report/with_pending_status.yml
 - spec/fixtures/vcr_cassettes/campaign_performance_report/with_successful_status.yml
 - spec/fixtures/vcr_cassettes/oauth_credentials/access_token/with_successful_status.yml
+- spec/integration/soapy_bing/accounts_spec.rb
 - spec/integration/soapy_bing/ads/reports/campaign_performance_report_spec.rb
 - spec/integration/soapy_bing/ads_spec.rb
 - spec/integration/soapy_bing/oauth_credentials_spec.rb
@@ -300,12 +307,14 @@ test_files:
 - spec/fixtures/reports/campaign_performance_report.csv
 - spec/fixtures/reports/campaign_performance_report.json
 - spec/fixtures/soap_templates/simple.erb.xml
+- spec/fixtures/vcr_cassettes/SoapyBing_Accounts/_list/returns_a_list_of_SoapyBing_Account_objects.yml
 - spec/fixtures/vcr_cassettes/SoapyBing_Ads/_get_ad_groups_by_campaign_id/1_1_1.yml
 - spec/fixtures/vcr_cassettes/SoapyBing_Ads/_get_ads_by_ad_group_id/1_2_1.yml
 - spec/fixtures/vcr_cassettes/SoapyBing_Ads/_get_targets_by_campaign_ids/1_3_1.yml
 - spec/fixtures/vcr_cassettes/campaign_performance_report/with_pending_status.yml
 - spec/fixtures/vcr_cassettes/campaign_performance_report/with_successful_status.yml
 - spec/fixtures/vcr_cassettes/oauth_credentials/access_token/with_successful_status.yml
+- spec/integration/soapy_bing/accounts_spec.rb
 - spec/integration/soapy_bing/ads/reports/campaign_performance_report_spec.rb
 - spec/integration/soapy_bing/ads_spec.rb
 - spec/integration/soapy_bing/oauth_credentials_spec.rb