soapy_bing 0.0.5 → 0.1.0

data/spec/fixtures/vcr_cassettes/SoapyBing_Ads/_get_targets_by_campaign_ids/1_3_1.yml

@@ -0,0 +1,111 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: https://login.live.com/oauth20_token.srf
+    body:
+      encoding: UTF-8
+      string: client_id=bing-ads-oauth-client-id&client_secret=bing-ads-oauth-client-secret&grant_type=refresh_token&refresh_token=bing-ads-oauth-refresh-token
+    headers:
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Cache-Control:
+      - no-store
+      Pragma:
+      - no-cache
+      Content-Length:
+      - '1509'
+      Content-Type:
+      - application/json
+      Server:
+      - Microsoft-IIS/8.5
+      X-Content-Type-Options:
+      - nosniff
+      Strict-Transport-Security:
+      - max-age=31536000
+      X-Xss-Protection:
+      - 1; mode=block
+      Date:
+      - Tue, 19 Jul 2016 12:10:20 GMT
+      Connection:
+      - close
+    body:
+      encoding: UTF-8
+      string: '{"token_type":"bearer","expires_in":3600,"scope":"bingads.manage","access_token":"bing-ads-oauth-authentication-token","refresh_token":"bing-ads-oauth-refresh-token","user_id":"bing-ads-oauth-user-id"}'
+    http_version: 
+  recorded_at: Tue, 19 Jul 2016 12:10:20 GMT
+- request:
+    method: post
+    uri: https://campaign.api.bingads.microsoft.com/Api/Advertiser/CampaignManagement/V10/CampaignManagementService.svc
+    body:
+      encoding: UTF-8
+      string: |
+        <?xml version="1.0" encoding="UTF-8"?>
+        <env:Envelope xmlns:tns="https://bingads.microsoft.com/CampaignManagement/v10"
+                      xmlns:env="http://schemas.xmlsoap.org/soap/envelope/"
+                      xmlns:arr="http://schemas.microsoft.com/2003/10/Serialization/Arrays">
+            <env:Header>
+                <tns:CustomerAccountId>bing-ads-account-id</tns:CustomerAccountId>
+                <tns:CustomerId>bing-ads-customer-id</tns:CustomerId>
+                <tns:DeveloperToken>bing-ads-developer-token</tns:DeveloperToken>
+                <tns:AuthenticationToken>bing-ads-oauth-authentication-token</tns:AuthenticationToken>
+            </env:Header>
+            <env:Body>
+                <tns:GetTargetsByCampaignIdsRequest>
+                    <tns:CampaignIds>
+                        <arr:long>91834220</arr:long>
+                    </tns:CampaignIds>
+                </tns:GetTargetsByCampaignIdsRequest>
+            </env:Body>
+        </env:Envelope>
+    headers:
+      Content-Type:
+      - text/xml;charset=UTF-8
+      Soapaction:
+      - GetTargetsByCampaignIds
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Cache-Control:
+      - private
+      Content-Length:
+      - '1922'
+      Content-Type:
+      - text/xml; charset=utf-8
+      Server:
+      - Microsoft-IIS/8.5
+      X-Aspnet-Version:
+      - 4.0.30319
+      X-Powered-By:
+      - ASP.NET
+      Date:
+      - Tue, 19 Jul 2016 12:10:20 GMT
+    body:
+      encoding: UTF-8
+      string: <s:Envelope xmlns:s="http://schemas.xmlsoap.org/soap/envelope/"><s:Header><h:TrackingId
+        xmlns:h="https://bingads.microsoft.com/CampaignManagement/v10">bing-ads-report-tracking-id</h:TrackingId></s:Header><s:Body><GetTargetsByCampaignIdsResponse
+        xmlns="https://bingads.microsoft.com/CampaignManagement/v10"><PartialErrors
+        xmlns:i="http://www.w3.org/2001/XMLSchema-instance"/><Targets xmlns:i="http://www.w3.org/2001/XMLSchema-instance"><Target><Age
+        i:nil="true"/><DayTime i:nil="true"/><DeviceOS><Bids><DeviceOSTargetBid><BidAdjustment>0</BidAdjustment><DeviceName>Computers</DeviceName><OSNames
+        i:nil="true" xmlns:a="http://schemas.microsoft.com/2003/10/Serialization/Arrays"/></DeviceOSTargetBid><DeviceOSTargetBid><BidAdjustment>-100</BidAdjustment><DeviceName>Smartphones</DeviceName><OSNames
+        i:nil="true" xmlns:a="http://schemas.microsoft.com/2003/10/Serialization/Arrays"/></DeviceOSTargetBid><DeviceOSTargetBid><BidAdjustment>0</BidAdjustment><DeviceName>Tablets</DeviceName><OSNames
+        i:nil="true" xmlns:a="http://schemas.microsoft.com/2003/10/Serialization/Arrays"/></DeviceOSTargetBid></Bids></DeviceOS><ForwardCompatibilityMap
+        xmlns:a="http://schemas.datacontract.org/2004/07/System.Collections.Generic"/><Gender
+        i:nil="true"/><Id>462821758</Id><IsLibraryTarget>true</IsLibraryTarget><Location><CityTarget
+        i:nil="true"/><CountryTarget><Bids><CountryTargetBid><BidAdjustment>0</BidAdjustment><CountryAndRegion>AU</CountryAndRegion><IsExcluded>false</IsExcluded></CountryTargetBid><CountryTargetBid><BidAdjustment>0</BidAdjustment><CountryAndRegion>US</CountryAndRegion><IsExcluded>true</IsExcluded></CountryTargetBid></Bids></CountryTarget><IntentOption>PeopleIn</IntentOption><MetroAreaTarget
+        i:nil="true"/><PostalCodeTarget i:nil="true"/><RadiusTarget i:nil="true"/><StateTarget
+        i:nil="true"/></Location><Name>targetgroup1</Name></Target></Targets></GetTargetsByCampaignIdsResponse></s:Body></s:Envelope>
+    http_version: 
+  recorded_at: Tue, 19 Jul 2016 12:10:21 GMT
+recorded_with: VCR 3.0.3

data/spec/integration/soapy_bing/ads_spec.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+RSpec.describe SoapyBing::Ads do
+  let(:campaign_id) { 91834220 }
+  let(:ad_group_id) { 4464286758 }
+  let(:fixture_payload) { JSON.load(File.read(File.join('spec', 'fixtures', fixture_file))) }
+
+  subject(:instance) { described_class.new }
+
+  describe '#get_ad_groups_by_campaign_id', :vcr do
+    let(:fixture_file) { 'get_ad_groups_by_campaign_id.json' }
+
+    subject { instance.get_ad_groups_by_campaign_id(campaign_id) }
+
+    it { expect(subject).to eq(fixture_payload) }
+  end
+
+  describe '#get_ads_by_ad_group_id', :vcr do
+    let(:fixture_file) { 'get_ads_by_ad_group_id.json' }
+
+    subject { instance.get_ads_by_ad_group_id(ad_group_id) }
+
+    it { expect(subject).to eq(fixture_payload) }
+  end
+
+  describe '#get_targets_by_campaign_ids', :vcr do
+    let(:fixture_file) { 'get_targets_by_campaign_ids.json' }
+
+    subject { instance.get_targets_by_campaign_ids([campaign_id]) }
+
+    it { expect(subject).to eq(fixture_payload) }
+  end
+end

data/spec/soapy_bing/oauth_credentials_spec.rb

@@ -79,7 +79,7 @@ RSpec.describe SoapyBing::OauthCredentials do
 
   describe '#access_token' do
     let(:credentials) { { client_id: 'foo', client_secret: 'bar', refresh_token: 'baz' } }
-    let(:response) { double(:response) }
+    let(:response) { double(:response) } # rubocop:disable RSpec/VerifiedDoubles
 
     before do
       expect(response).to receive(:code).once.and_return(status_code)

data/spec/soapy_bing/soap/request/base_spec.rb

@@ -28,7 +28,7 @@ RSpec.describe SoapyBing::Soap::Request::Base do
   describe '#default_body' do
     subject { my_custom_request.default_body }
     it 'renders request body template' do
-      renderer = double('Renderer')
+      renderer = instance_double(SoapyBing::Soap::TemplateRenderer)
       expect(SoapyBing::Soap::TemplateRenderer).to receive(:new)
         .with(hash_including(req_context)).and_return(renderer)
       expect(renderer).to receive(:render).with('my_custom')

data/spec/soapy_bing/soap/request/poll_generate_report_request_spec.rb

@@ -39,8 +39,8 @@ RSpec.describe SoapyBing::Soap::Request::PollGenerateReportRequest do
       described_class
         .new(
           context: {
-            oauth: double(:oauth_credentials).as_null_object,
-            account: double(:account).as_null_object
+            oauth: instance_double(SoapyBing::OauthCredentials).as_null_object,
+            account: instance_double(SoapyBing::Account).as_null_object
           }
         )
         .perform

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: soapy_bing
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.1.0
 platform: ruby
 authors:
 - ad2games GmbH
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-23 00:00:00.000000000 Z
+date: 2016-08-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: erubis
@@ -209,15 +209,24 @@ files:
 - lib/soapy_bing/soap.rb
 - lib/soapy_bing/soap/request.rb
 - lib/soapy_bing/soap/request/base.rb
+- lib/soapy_bing/soap/request/get_ad_groups_by_campaign_id_request.rb
+- lib/soapy_bing/soap/request/get_ads_by_ad_group_id_request.rb
+- lib/soapy_bing/soap/request/get_targets_by_campaign_ids_request.rb
 - lib/soapy_bing/soap/request/poll_generate_report_request.rb
 - lib/soapy_bing/soap/request/submit_generate_report_request.rb
 - lib/soapy_bing/soap/response.rb
 - lib/soapy_bing/soap/response/base.rb
+- lib/soapy_bing/soap/response/get_ad_groups_by_campaign_id_response.rb
+- lib/soapy_bing/soap/response/get_ads_by_ad_group_id_response.rb
+- lib/soapy_bing/soap/response/get_targets_by_campaign_ids_response.rb
 - lib/soapy_bing/soap/response/payload.rb
 - lib/soapy_bing/soap/response/poll_generate_report_response.rb
 - lib/soapy_bing/soap/response/report_status.rb
 - lib/soapy_bing/soap/response/submit_generate_report_response.rb
 - lib/soapy_bing/soap/template_renderer.rb
+- lib/soapy_bing/soap/templates/get_ad_groups_by_campaign_id.erb.xml
+- lib/soapy_bing/soap/templates/get_ads_by_ad_group_id.erb.xml
+- lib/soapy_bing/soap/templates/get_targets_by_campaign_ids.erb.xml
 - lib/soapy_bing/soap/templates/poll_generate_report.erb.xml
 - lib/soapy_bing/soap/templates/submit_generate_report.erb.xml
 - lib/soapy_bing/version.rb
@@ -225,13 +234,20 @@ files:
 - lib/tasks/coverage.rake
 - lib/tasks/spec.rake
 - soapy_bing.gemspec
+- spec/fixtures/get_ad_groups_by_campaign_id.json
+- spec/fixtures/get_ads_by_ad_group_id.json
+- spec/fixtures/get_targets_by_campaign_ids.json
 - spec/fixtures/reports/campaign_performance_report.csv
 - spec/fixtures/reports/campaign_performance_report.json
 - spec/fixtures/soap_templates/simple.erb.xml
+- spec/fixtures/vcr_cassettes/SoapyBing_Ads/_get_ad_groups_by_campaign_id/1_1_1.yml
+- spec/fixtures/vcr_cassettes/SoapyBing_Ads/_get_ads_by_ad_group_id/1_2_1.yml
+- spec/fixtures/vcr_cassettes/SoapyBing_Ads/_get_targets_by_campaign_ids/1_3_1.yml
 - spec/fixtures/vcr_cassettes/campaign_performance_report/with_pending_status.yml
 - spec/fixtures/vcr_cassettes/campaign_performance_report/with_successful_status.yml
 - spec/fixtures/vcr_cassettes/oauth_credentials/access_token/with_successful_status.yml
 - spec/integration/soapy_bing/ads/reports/campaign_performance_report_spec.rb
+- spec/integration/soapy_bing/ads_spec.rb
 - spec/integration/soapy_bing/oauth_credentials_spec.rb
 - spec/simplecov_setup.rb
 - spec/soapy_bing/account_spec.rb
@@ -278,13 +294,20 @@ signing_key:
 specification_version: 4
 summary: Simple client for the Bing Ads APIs
 test_files:
+- spec/fixtures/get_ad_groups_by_campaign_id.json
+- spec/fixtures/get_ads_by_ad_group_id.json
+- spec/fixtures/get_targets_by_campaign_ids.json
 - spec/fixtures/reports/campaign_performance_report.csv
 - spec/fixtures/reports/campaign_performance_report.json
 - spec/fixtures/soap_templates/simple.erb.xml
+- spec/fixtures/vcr_cassettes/SoapyBing_Ads/_get_ad_groups_by_campaign_id/1_1_1.yml
+- spec/fixtures/vcr_cassettes/SoapyBing_Ads/_get_ads_by_ad_group_id/1_2_1.yml
+- spec/fixtures/vcr_cassettes/SoapyBing_Ads/_get_targets_by_campaign_ids/1_3_1.yml
 - spec/fixtures/vcr_cassettes/campaign_performance_report/with_pending_status.yml
 - spec/fixtures/vcr_cassettes/campaign_performance_report/with_successful_status.yml
 - spec/fixtures/vcr_cassettes/oauth_credentials/access_token/with_successful_status.yml
 - spec/integration/soapy_bing/ads/reports/campaign_performance_report_spec.rb
+- spec/integration/soapy_bing/ads_spec.rb
 - spec/integration/soapy_bing/oauth_credentials_spec.rb
 - spec/simplecov_setup.rb
 - spec/soapy_bing/account_spec.rb