soapy_bing 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6caab3cc4168d35e762dc72a01dacb1ae785db50
-  data.tar.gz: 0ca68c7d3d8878d44b45ac511aefa17f968371dd
+  metadata.gz: 75bb3e63ec854d756a3d216b9ddcd0ad8742aa80
+  data.tar.gz: 596a7c5f4d3c5f1f15611d7e98fbea0b0498d985
 SHA512:
-  metadata.gz: 28c1bbfbf10a09dff58afee0bc9f741beed3b3fd6a9d0e54044cde72b34abb568400a855d880a3c79b310ed1e4e23ac1230ae3934d53044b81ca7998ff03da19
-  data.tar.gz: da4aa75a352a6fb9cb15b9116d79c01fb59a4d07cbf89eeb766708d78a27f6407777848ae20cc725935fe3aaa45f2f3ddbec63d71cb93213268ec1e750667b3e
+  metadata.gz: 44998a329b39fda44bff367952ee29ca0e0f5a1df9ee15b38fe8ded6137a98e3b152273cefe8c87c453ff9fd118f7716abe627c2ef94ed44708888f770ace2f1
+  data.tar.gz: 11fe49b2c467a48dacfdc2d9b68cb296fc00759fefa4c867425fa531a0a19476220a661a10503439398adf0bbd125abdec78cab37733e8c88e6900ed5047673e

data/.ruby-version

@@ -1 +1 @@
-2.2.3
+2.3.1

data/Gemfile

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 source 'https://rubygems.org'
 
 gemspec

data/Rakefile

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'rubygems'
 require 'bundler/setup'
 

data/lib/soapy_bing/account.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module SoapyBing
   class Account
     attr_reader :developer_token, :account_id, :customer_id

data/lib/soapy_bing/ads/reports/base.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'ostruct'
 require 'uri'
 require 'httparty'
@@ -35,7 +36,7 @@ module SoapyBing
 
         def parser_class
           class_name = "#{settings.format.upcase}Parser".to_sym
-          fail UnknownParserError, class_name unless Parsers.constants.include?(class_name)
+          raise UnknownParserError, class_name unless Parsers.constants.include?(class_name)
           Parsers.const_get class_name
         end
 

data/lib/soapy_bing/ads/reports/campaign_performance_report.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'date'
 
 module SoapyBing

data/lib/soapy_bing/ads/reports/parsers/csv_parser.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'csv'
 
 module SoapyBing
@@ -17,7 +18,7 @@ module SoapyBing
           def rows
             @rows ||= begin
               header, *body = extract_csv_payload
-              fail FormatError if body.size != payload_rows_number
+              raise FormatError if body.size != payload_rows_number
               body.map { |row| header.zip(row).to_h }
             end
           end

data/lib/soapy_bing/ads/reports/parsers.rb

@@ -1 +1,2 @@
+# frozen_string_literal: true
 require 'soapy_bing/ads/reports/parsers/csv_parser'

data/lib/soapy_bing/ads/reports.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'soapy_bing/ads/reports/parsers'
 require 'soapy_bing/ads/reports/base'
 require 'soapy_bing/ads/reports/campaign_performance_report'

data/lib/soapy_bing/ads.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'soapy_bing/ads/reports'
 
 module SoapyBing

data/lib/soapy_bing/helpers/class_name.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module SoapyBing
   module Helpers
     module ClassName

data/lib/soapy_bing/helpers/ssl_version.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'openssl'
 
 module SoapyBing

data/lib/soapy_bing/helpers.rb

@@ -1,2 +1,3 @@
+# frozen_string_literal: true
 require 'soapy_bing/helpers/class_name'
 require 'soapy_bing/helpers/ssl_version'

data/lib/soapy_bing/oauth_credentials.rb

@@ -1,10 +1,11 @@
+# frozen_string_literal: true
 require 'httparty'
 
 module SoapyBing
   class OauthCredentials
     class TokenRefreshError < StandardError; end
 
-    TOKEN_URL = 'https://login.live.com/oauth20_token.srf'.freeze
+    TOKEN_URL = 'https://login.live.com/oauth20_token.srf'
 
     attr_reader :client_id, :client_secret, :refresh_token, :token_url
 
@@ -24,11 +25,10 @@ module SoapyBing
 
     def request_access_token
       resp = HTTParty.post(token_url, body: access_token_params)
-      if resp.code == 200
-        resp['access_token']
-      else
-        fail TokenRefreshError
-      end
+
+      raise TokenRefreshError unless resp.code == 200
+
+      resp['access_token']
     end
 
     def access_token_params

data/lib/soapy_bing/param_guard.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module SoapyBing
   class ParamGuard
     class ParamRequiredError < StandardError; end
@@ -8,7 +9,7 @@ module SoapyBing
     end
 
     def require!(name)
-      local_options.fetch(name, ENV[env_var_name(name)]) || fail(ParamRequiredError, err_msg(name))
+      local_options.fetch(name, ENV[env_var_name(name)]) || raise(ParamRequiredError, err_msg(name))
     end
 
     private

data/lib/soapy_bing/soap/request/base.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'httparty'
 
 module SoapyBing

data/lib/soapy_bing/soap/request/poll_generate_report_request.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module SoapyBing
   module Soap
     module Request
@@ -6,12 +7,12 @@ module SoapyBing
         class PendingStatusError < StandardError; end
         class PollingTimeoutError < StandardError; end
 
-        API_BASE_URL = 'https://reporting.api.bingads.microsoft.com'.freeze
+        API_BASE_URL = 'https://reporting.api.bingads.microsoft.com'
         API_VERSION = 9
         API_ENDPOINT =
-          "#{API_BASE_URL}/Api/Advertiser/Reporting/V#{API_VERSION}/ReportingService.svc".freeze
+          "#{API_BASE_URL}/Api/Advertiser/Reporting/V#{API_VERSION}/ReportingService.svc"
 
-        POLLING_TRIES = 40
+        POLLING_TRIES = 100
 
         def perform
           Retryable.retryable(tries: POLLING_TRIES, on: PendingStatusError) { poll! }
@@ -23,8 +24,8 @@ module SoapyBing
 
         def poll!
           response = Response::PollGenerateReportResponse.new(post(API_ENDPOINT))
-          fail PendingStatusError if response.pending?
-          fail FailedStatusError if response.error?
+          raise PendingStatusError if response.pending?
+          raise FailedStatusError if response.error?
           response
         end
       end

data/lib/soapy_bing/soap/request/submit_generate_report_request.rb

@@ -1,11 +1,12 @@
+# frozen_string_literal: true
 module SoapyBing
   module Soap
     module Request
       class SubmitGenerateReportRequest < Base
-        API_BASE_URL = 'https://reporting.api.bingads.microsoft.com'.freeze
+        API_BASE_URL = 'https://reporting.api.bingads.microsoft.com'
         API_VERSION = 9
         API_ENDPOINT =
-          "#{API_BASE_URL}/Api/Advertiser/Reporting/V#{API_VERSION}/ReportingService.svc".freeze
+          "#{API_BASE_URL}/Api/Advertiser/Reporting/V#{API_VERSION}/ReportingService.svc"
 
         def perform
           Response::SubmitGenerateReportResponse.new(post(API_ENDPOINT))

data/lib/soapy_bing/soap/request.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'soapy_bing/soap/request/base'
 require 'soapy_bing/soap/request/submit_generate_report_request'
 require 'soapy_bing/soap/request/poll_generate_report_request'

data/lib/soapy_bing/soap/response/base.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module SoapyBing
   module Soap
     module Response

data/lib/soapy_bing/soap/response/payload.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module SoapyBing
   module Soap
     module Response
@@ -7,7 +8,7 @@ module SoapyBing
         end
 
         def extract_payload
-          fail NotImplementedError
+          raise NotImplementedError
         end
       end
     end

data/lib/soapy_bing/soap/response/poll_generate_report_response.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module SoapyBing
   module Soap
     module Response

data/lib/soapy_bing/soap/response/report_status.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module SoapyBing
   module Soap
     module Response

data/lib/soapy_bing/soap/response/submit_generate_report_response.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module SoapyBing
   module Soap
     module Response

data/lib/soapy_bing/soap/response.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'soapy_bing/soap/response/payload'
 require 'soapy_bing/soap/response/report_status'
 require 'soapy_bing/soap/response/base'

data/lib/soapy_bing/soap/template_renderer.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'ostruct'
 require 'erubis'
 

data/lib/soapy_bing/soap.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'soapy_bing/soap/template_renderer'
 require 'soapy_bing/soap/request'
 require 'soapy_bing/soap/response'

data/lib/soapy_bing/version.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module SoapyBing
-  VERSION = '0.0.4'.freeze
+  VERSION = '0.0.5'
 end

data/lib/soapy_bing.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'httparty'
 require 'retryable'
 require 'active_support'

data/lib/tasks/console.rake

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 desc 'Start the IRB console (short-cut alias: "c")'
 task :console do
   sh 'irb -I .  -I ./lib -I ./spec  -r ./spec/spec_helper.rb'

data/lib/tasks/coverage.rake

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 desc 'Run specs and collect code coverage'
 task :coverage do
   ENV['COVERAGE'] = 'true'

data/lib/tasks/spec.rake

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'rspec/core/rake_task'
 RSpec::Core::RakeTask.new(:spec)
 

data/soapy_bing.gemspec

@@ -1,4 +1,5 @@
 # coding: utf-8
+# frozen_string_literal: true
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'soapy_bing/version'

data/spec/integration/soapy_bing/ads/reports/campaign_performance_report_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'json'
 
 RSpec.describe SoapyBing::Ads::Reports::CampaignPerformanceReport do

data/spec/integration/soapy_bing/oauth_credentials_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 RSpec.describe SoapyBing::OauthCredentials do
   describe '#access_token' do
     context 'on successful respose', :integration do

data/spec/simplecov_setup.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 if ENV['CI'] || ENV['COVERAGE']
   require 'simplecov'
 

data/spec/soapy_bing/account_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 RSpec.describe SoapyBing::Account do
   describe '#initialize' do
     subject { described_class.new(account) }

data/spec/soapy_bing/ads/reports/campaign_performance_report_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'date'
 
 RSpec.describe SoapyBing::Ads::Reports::CampaignPerformanceReport do

data/spec/soapy_bing/ads/reports/parsers/csv_parser_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'json'
 require 'csv'
 
@@ -20,7 +21,7 @@ RSpec.describe SoapyBing::Ads::Reports::Parsers::CSVParser do
       end
     end
 
-    context 'on malformed CSV data 'do
+    context 'on malformed CSV data' do
       let(:csv_data) { '"co", "' }
 
       it 'throws exception CSV::MalformedCSVError' do

data/spec/soapy_bing/ads_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 RSpec.describe SoapyBing::Ads do
   let(:oauth) do
     { client_id: 'foo', client_secret: 'bar', refresh_token: 'baz' }

data/spec/soapy_bing/helpers/class_name_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 RSpec.describe SoapyBing::Helpers::ClassName do
   describe '#class_name' do
     subject do

data/spec/soapy_bing/helpers/ssl_version_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 RSpec.describe SoapyBing::Helpers::SSLVersion do
   describe '#ssl_version' do
     subject { stub_const('MyClass', Class.new.include(described_class)).new.ssl_version }

data/spec/soapy_bing/oauth_credentials_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 RSpec.describe SoapyBing::OauthCredentials do
   describe '#initialize' do
     subject { described_class.new(credentials) }

data/spec/soapy_bing/param_guard_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 RSpec.describe SoapyBing::ParamGuard do
   describe '#require!' do
     let(:param_guard) { described_class.new(options, env_namespace: 'MY') }

data/spec/soapy_bing/soap/request/base_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 RSpec.describe SoapyBing::Soap::Request::Base do
   let(:req_context) { { foo: 'Bar' } }
   subject { described_class.new(context: req_context) }

data/spec/soapy_bing/soap/request/poll_generate_report_request_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 RSpec.describe SoapyBing::Soap::Request::PollGenerateReportRequest do
   describe '#perform' do
     let(:response_body) do
@@ -16,13 +17,13 @@ RSpec.describe SoapyBing::Soap::Request::PollGenerateReportRequest do
     end
 
     let(:pending_response_body) do
-      response_body['Envelope']['Body']['PollGenerateReportResponse']['ReportRequestStatus']
-        .merge!('Status' => 'Pending')
+      response_body['Envelope']['Body']['PollGenerateReportResponse'] \
+        ['ReportRequestStatus']['Status'] = 'Pending'
       response_body
     end
     let(:successful_response_body) do
-      response_body['Envelope']['Body']['PollGenerateReportResponse']['ReportRequestStatus']
-        .merge!('Status' => 'Success')
+      response_body['Envelope']['Body']['PollGenerateReportResponse'] \
+        ['ReportRequestStatus']['Status'] = 'Success'
       response_body
     end
 

data/spec/soapy_bing/soap/response/base_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 RSpec.describe SoapyBing::Soap::Response::Base do
   before { stub_const('MyCustomResponse', Class.new(described_class) {}) }
   let(:response_body) { 'Some response body' }

data/spec/soapy_bing/soap/response/payload_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 RSpec.describe SoapyBing::Soap::Response::Payload do
   before do
     stub_const(
@@ -12,7 +13,7 @@ RSpec.describe SoapyBing::Soap::Response::Payload do
 
   describe '#payload' do
     it 'memoize #extract_payload value' do
-      expect_any_instance_of(MyCustomResponse).to receive(:extract_payload).once.and_return(true)
+      expect(subject).to receive(:extract_payload).once.and_return(true)
       2.times { subject.payload }
     end
   end

data/spec/soapy_bing/soap/response/poll_generate_report_response_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 RSpec.describe SoapyBing::Soap::Response::PollGenerateReportResponse do
   let(:url) { 'http://my-site.com' }
   let(:response_hash) do

data/spec/soapy_bing/soap/response/report_status_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 RSpec.describe SoapyBing::Soap::Response::ReportStatus do
   before do
     stub_const(

data/spec/soapy_bing/soap/response/submit_generate_report_response_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 RSpec.describe SoapyBing::Soap::Response::SubmitGenerateReportResponse do
   let(:request_id) { 'foobarbazqux' }
   let(:response_hash) do

data/spec/soapy_bing/soap/template_renderer_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 RSpec.describe SoapyBing::Soap::TemplateRenderer do
   describe '::TEMPLATE_PATH' do
     let(:files) { Dir.glob(File.join(described_class::TEMPLATE_PATH, '*.erb.xml')) }

data/spec/spec_helper.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'simplecov_setup'
 
 require 'bundler/setup'

data/spec/support/dotenv.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'dotenv'
 
 Dotenv.load('.env.local', '.env')

data/spec/support/vcr.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cgi'
 require 'vcr'
 require 'active_support/core_ext/hash/conversions'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: soapy_bing
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - ad2games GmbH
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-17 00:00:00.000000000 Z
+date: 2016-06-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: erubis
@@ -273,7 +273,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Simple client for the Bing Ads APIs