soapy_bing 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 69461ab0d24161a2d94ee614764bc6e1f7bbe699
-  data.tar.gz: 3b72c16582297107d5e5b6d24c2f196317959d2b
+  metadata.gz: 237915c983f873488f70f4a41230f71df20fc592
+  data.tar.gz: 78cbf493d4cd5ad557267ed4f7b79a890ece2567
 SHA512:
-  metadata.gz: 38ca5529a8c3aead01f3788d7a70653fe02548d6dafc9d71cdad03732042bc5b0233f3ef95fb807d789c01392424c7f6064ac3677007992152108b28d658520c
-  data.tar.gz: 3c3616e09ec1463c962d42aa687f794722d4e783e0eef3519d6e2c28d7a415c28616e761da5b069b721065ca5196c19f35ee019c75b809d29579d9da491b30ba
+  metadata.gz: 3818fc941c819b77cb99676394099d5ff6ef5a3879218a9071dc358490ca263239256829b4620a4282629c9aa9c472235be0d66d1d59e1cc67d0fa6b4601ae9c
+  data.tar.gz: 498a63f0cd2e66f7d4d69422cba816723d7d3742b7ced04ec3276409bc50deb686b8d55ccbc8e1d01f9b6103d3cebfbf2f3d5475fb5cc73cf9b4b5a8706225a5

data/lib/soapy_bing/ads/reports/base.rb

@@ -1,4 +1,5 @@
 require 'ostruct'
+require 'uri'
 require 'httparty'
 require 'zip'
 
@@ -8,6 +9,7 @@ module SoapyBing
       class Base
         class UnknownParserError < StandardError; end
         include Helpers::ClassName
+        include Helpers::SSLVersion
 
         DEFAULT_REPORT_SETTINGS = {
           format:      'Csv',
@@ -62,7 +64,9 @@ module SoapyBing
         end
 
         def download_io
-          StringIO.new HTTParty.get(download_url).body
+          https = URI.parse(download_url).scheme == 'https'
+          request_options = https ? { ssl_version: ssl_version } : {}
+          StringIO.new HTTParty.get(download_url, request_options).body
         end
 
         def request_id

data/lib/soapy_bing/helpers/ssl_version.rb

@@ -0,0 +1,17 @@
+require 'openssl'
+
+module SoapyBing
+  module Helpers
+    module SSLVersion
+      DEFAULT_SSL_VERSION = :SSLv3
+
+      def ssl_version
+        if OpenSSL::SSL::SSLContext::METHODS.include? DEFAULT_SSL_VERSION
+          DEFAULT_SSL_VERSION
+        else
+          OpenSSL::SSL::SSLContext::DEFAULT_PARAMS[:ssl_version]
+        end
+      end
+    end
+  end
+end

data/lib/soapy_bing/helpers.rb

@@ -1 +1,2 @@
 require 'soapy_bing/helpers/class_name'
+require 'soapy_bing/helpers/ssl_version'

data/lib/soapy_bing/version.rb

@@ -1,3 +1,3 @@
 module SoapyBing
-  VERSION = '0.0.2'.freeze
+  VERSION = '0.0.3'.freeze
 end

data/spec/soapy_bing/helpers/ssl_version_spec.rb

@@ -0,0 +1,23 @@
+RSpec.describe SoapyBing::Helpers::SSLVersion do
+  describe '#ssl_version' do
+    subject { stub_const('MyClass', Class.new.include(described_class)).new.ssl_version }
+
+    context 'when DEFAULT_SSL_VERSION is available' do
+      before do
+        stub_const('OpenSSL::SSL::SSLContext::METHODS', [described_class::DEFAULT_SSL_VERSION])
+      end
+
+      it 'responds with DEFAULT_SSL_VERSION' do
+        expect(subject).to be MyClass::DEFAULT_SSL_VERSION
+      end
+    end
+
+    context 'when DEFAULT_SSL_VERSION is not available' do
+      before { stub_const('OpenSSL::SSL::SSLContext::METHODS', []) }
+
+      it 'responds with OpenSSL default version' do
+        expect(subject).to be OpenSSL::SSL::SSLContext::DEFAULT_PARAMS[:ssl_version]
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: soapy_bing
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - ad2games GmbH
@@ -203,6 +203,7 @@ files:
 - lib/soapy_bing/ads/reports/parsers/csv_parser.rb
 - lib/soapy_bing/helpers.rb
 - lib/soapy_bing/helpers/class_name.rb
+- lib/soapy_bing/helpers/ssl_version.rb
 - lib/soapy_bing/oauth_credentials.rb
 - lib/soapy_bing/param_guard.rb
 - lib/soapy_bing/soap.rb
@@ -238,6 +239,7 @@ files:
 - spec/soapy_bing/ads/reports/parsers/csv_parser_spec.rb
 - spec/soapy_bing/ads_spec.rb
 - spec/soapy_bing/helpers/class_name_spec.rb
+- spec/soapy_bing/helpers/ssl_version_spec.rb
 - spec/soapy_bing/oauth_credentials_spec.rb
 - spec/soapy_bing/param_guard_spec.rb
 - spec/soapy_bing/soap/request/base_spec.rb
@@ -290,6 +292,7 @@ test_files:
 - spec/soapy_bing/ads/reports/parsers/csv_parser_spec.rb
 - spec/soapy_bing/ads_spec.rb
 - spec/soapy_bing/helpers/class_name_spec.rb
+- spec/soapy_bing/helpers/ssl_version_spec.rb
 - spec/soapy_bing/oauth_credentials_spec.rb
 - spec/soapy_bing/param_guard_spec.rb
 - spec/soapy_bing/soap/request/base_spec.rb