soap_adapters 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2d6dbef0b4e53fcddce347f22e0b380d4dce45cc
-  data.tar.gz: bc80a049c96f79b9b19332ddfaa17add4e46393f
+  metadata.gz: 6c96d60694be86688e4a945c9e61c54e104eb629
+  data.tar.gz: acc171b1065992da4f525c3d3b45b3d5b4cfbecc
 SHA512:
-  metadata.gz: 6034c0105099ebfa33131795c142133ed8027dacbef2e32dfa9ac4608feee5602eaa458f37e3665c939bbf08b163f7b08d544017fb39f6e97be54dd561359ef8
-  data.tar.gz: 350557fe24622988b175018ce216fb309e8b8db4bdf88aa868c205e148704b69f4c6334f14a23df218dcdb076ad5302322aff2ea5d71c032714f29c19ec668e3
+  metadata.gz: 2041851e908051b684b3a0a9cefd7a6b9828cf531104fa58c13e4b549550151bd2a111406f12fff38ddf1afb5391cb2540c67e3ce12504f6e8e98d74eef21327
+  data.tar.gz: f465a9b87b687c9e4306e43b4fb5883a89b5c31d31cdd4f0e2e0896d86f165ab8e94733054a72f1ca9212be29c917f81e19b0393cb97217b8f25711f727a9f58

data/CHANGELOG.md

@@ -0,0 +1,8 @@
+# v0.0.2
+
+- Fix bug where `:ssl_version` is a string when it should be a symbol
+- Fix bug where attributes with nil values are passed into `Savon.client` (like a nil logger)
+
+# v0.0.1
+
+Initial version

data/lib/soap_adapters/savon.rb

@@ -7,7 +7,7 @@ module SoapAdapters
     attribute :wsdl, String
     attribute :logger
     attribute :log, Boolean, default: true
-    attribute :ssl_version, String, default: :TLSv1
+    attribute :ssl_version, Symbol, default: :TLSv1
     attribute :last_request, String
 
     def ssl_version
@@ -24,7 +24,8 @@ module SoapAdapters
 
     def client
       args = CLIENT_ATTRS.reduce({}) do |hash, attr|
-        hash[attr] = self.attributes.fetch(attr)
+        val = self.attributes.fetch(attr)
+        hash[attr] = val unless val.nil?
         hash
       end
       ::Savon.client(args)

data/lib/soap_adapters/version.rb

@@ -1,3 +1,3 @@
 module SoapAdapters
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/soap_adapters.gemspec

@@ -6,8 +6,8 @@ require 'soap_adapters/version'
 Gem::Specification.new do |spec|
   spec.name          = "soap_adapters"
   spec.version       = SoapAdapters::VERSION
-  spec.authors       = ["Ramon Tayag"]
-  spec.email         = ["G5", "ramon.tayag@gmail.com", "lateam@getg5.com"]
+  spec.authors       = ["G5", "Ramon Tayag"]
+  spec.email         = ["ramon.tayag@gmail.com", "lateam@getg5.com"]
   spec.summary       = %q{Common interface to soap clients}
   spec.description   = %q{Common interface to soap clients}
   spec.homepage      = ""

data/spec/lib/soap_adapters/savon_spec.rb

@@ -10,7 +10,7 @@ describe SoapAdapters::Savon do
     it { is_expected.to have_attribute(:logger) }
     it { is_expected.to have_attribute(:log).with_default(true) }
     it do
-      is_expected.to have_attribute(:ssl_version, String).with_default(:TLSv1)
+      is_expected.to have_attribute(:ssl_version, Symbol).with_default(:TLSv1)
     end
     it { is_expected.to have_attribute(:last_request, String) }
   end
@@ -48,6 +48,19 @@ describe SoapAdapters::Savon do
       expect(r.to_s).to eq "response_xml"
       expect(r.xml).to eq "response_xml"
     end
+
+    it "instantiates a Savon client passing only arguments that are present" do
+      allow(::Savon).to receive(:client).with(
+        wsdl: "wsdl",
+        log: false,
+        ssl_version: :TLSv1,
+      ).and_return(client)
+      adapter = described_class.new(wsdl: "wsdl", log: false)
+      r = adapter.call(*client_args)
+      expect(adapter.last_request).to eq "request_xml"
+      expect(r.to_s).to eq "response_xml"
+      expect(r.xml).to eq "response_xml"
+    end
   end
 
 end

metadata

@@ -1,9 +1,10 @@
 --- !ruby/object:Gem::Specification
 name: soap_adapters
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
+- G5
 - Ramon Tayag
 autorequire: 
 bindir: bin
@@ -96,7 +97,6 @@ dependencies:
         version: '0'
 description: Common interface to soap clients
 email:
-- G5
 - ramon.tayag@gmail.com
 - lateam@getg5.com
 executables: []
@@ -104,6 +104,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.md
 - LICENSE.txt