snusnu-dm-accepts_nested_attributes 0.0.6 → 0.10.0

data/spec/integration/has_n_spec.rb

@@ -2,137 +2,7 @@ require 'pathname'
 require Pathname(__FILE__).dirname.expand_path.parent + 'spec_helper'
 
 describe DataMapper::NestedAttributes do
-  
-  describe "every accessible has(n) association with a valid reject_if proc", :shared => true do
-    
-    it "should not allow to create a new task via Project#tasks_attributes" do
-      @project.save
-      Project.all.size.should == 1
-      Task.all.size.should == 0
-      
-      @project.tasks_attributes = { 'new_1' => { :name => 'write specs' } }
-      @project.tasks.should be_empty
-      @project.save
-      Project.all.size.should == 1
-      Task.all.size.should == 0
-    end
-    
-  end
-  
-  describe "every accessible has(n) association with no reject_if proc", :shared => true do
-    
-    it "should allow to create a new task via Project#tasks_attributes" do
-      @project.save
-      Project.all.size.should == 1
-      Task.all.size.should == 0
-      
-      @project.tasks_attributes = { 'new_1' => { :name => 'write specs' } }
-      @project.tasks.should_not be_empty
-      @project.tasks.first.name.should == 'write specs'
-      @project.save
-      @project.tasks.first.should == Task.first
-      Project.all.size.should == 1
-      Task.all.size.should == 1
-      Task.first.name.should == 'write specs'
-    end
-        
-    it "should allow to update an existing task via Project#tasks_attributes" do
-      @project.save
-      task = Task.create(:project => @project, :name => 'write specs')
-      Project.all.size.should == 1
-      Task.all.size.should == 1
-      
-      @project.tasks_attributes = { task.id.to_s => { :id => task.id, :name => 'write more specs' } }
-      @project.tasks.should_not be_empty
-      @project.tasks.first.name.should == 'write more specs'
-      @project.save
-      
-      Project.all.size.should == 1
-      Task.all.size.should == 1
-      Task.first.name.should == 'write more specs'
-    end
-    
-    it "should perform atomic commits" do
-      Project.all.size.should == 0
-      Task.all.size.should == 0
-      
-      @project.name = nil # will fail because of validations
-      @project.tasks_attributes = { 'new_1' => { :name => 'write specs' } }
-      @project.tasks.should_not be_empty
-      @project.tasks.first.name.should == 'write specs'
-      @project.save
-      @project.should be_new_record
-      @project.tasks.all? { |t| t.should be_new_record }
-      Project.all.size.should == 0
-      Task.all.size.should == 0
-      
-      # TODO write specs for xxx_attributes= method that test
-      # if same hash keys properly get overwritten and not end up being multiple records
-      # (which obviously is the case right now)
-      
-      @project.name = 'dm-accepts_nested_attributes'
-      @project.tasks_attributes = { 'new_1' => { :name => nil } } # will fail because of validations
-      @project.tasks.should_not be_empty
-      @project.tasks.first.name.should be_nil
-      @project.save
-      @project.should be_new_record
-      @project.tasks.all? { |t| t.should be_new_record }
-      Project.all.size.should == 0
-      Task.all.size.should == 0
-    end
-    
-  end
-  
-  describe "every accessible has(n) association with :allow_destroy => false", :shared => true do
-    
-    it "should not allow to delete an existing task via Profile#tasks_attributes" do
-      @project.save
-      task = Task.create(:project => @project, :name => 'write specs')
-      
-      Project.all.size.should == 1
-      Task.all.size.should    == 1
-    
-      @project.reload
-      @project.tasks_attributes = { '1' => { :id => task.id, :_delete => true } }
-      @project.save
-      
-      Project.all.size.should == 1
-      Task.all.size.should    == 1
-    end
-    
-  end
-  
-  describe "every accessible has(n) association with :allow_destroy => true", :shared => true do
-    
-    it "should allow to delete an existing task via Profile#tasks_attributes" do
-      @project.save
-      task = Task.create(:project => @project, :name => 'write specs')
-      
-      Project.all.size.should == 1
-      Task.all.size.should    == 1
-    
-      @project.reload
-      @project.tasks_attributes = { '1' => { :id => task.id, :_delete => true } }
-      @project.save
-      
-      Project.all.size.should == 1
-      Task.all.size.should    == 0
-    end
-    
-  end
-
-  describe "every accessible has(n) association with a nested attributes reader", :shared => true do
-
-    it "should return the attributes written to Project#task_attributes from the Project#task_attributes reader" do
-      @project.tasks_attributes.should be_nil
-
-      @project.tasks_attributes = { 'new_1' => { :name => 'write specs' } }
-
-      @project.tasks_attributes.should == { 'new_1' => { :name => 'write specs' } }
-    end
 
-  end
-  
   describe "Project.has(n, :tasks)" do
     
     include OneToManyHelpers
@@ -148,10 +18,10 @@ describe DataMapper::NestedAttributes do
         Project.accepts_nested_attributes_for :tasks
         @project = Project.new :name => 'trippings'
       end
-      
+
+      it_should_behave_like "every accessible has(n) association"
       it_should_behave_like "every accessible has(n) association with no reject_if proc"
       it_should_behave_like "every accessible has(n) association with :allow_destroy => false"
-      it_should_behave_like "every accessible has(n) association with a nested attributes reader"
       
     end
       
@@ -162,7 +32,8 @@ describe DataMapper::NestedAttributes do
         Project.accepts_nested_attributes_for :tasks, :allow_destroy => false
         @project = Project.new :name => 'trippings'
       end
-      
+
+      it_should_behave_like "every accessible has(n) association"
       it_should_behave_like "every accessible has(n) association with no reject_if proc"
       it_should_behave_like "every accessible has(n) association with :allow_destroy => false"
       
@@ -175,26 +46,14 @@ describe DataMapper::NestedAttributes do
         Project.accepts_nested_attributes_for :tasks, :allow_destroy => true
         @project = Project.new :name => 'trippings'
       end
-      
+
+      it_should_behave_like "every accessible has(n) association"
       it_should_behave_like "every accessible has(n) association with no reject_if proc"
       it_should_behave_like "every accessible has(n) association with :allow_destroy => true"
       
     end
     
     describe "accepts_nested_attributes_for :tasks, " do
-      
-      describe ":reject_if => :foo" do
-    
-        before(:each) do
-          clear_data
-          Project.accepts_nested_attributes_for :tasks, :reject_if => :foo
-          @project = Project.new :name => 'trippings'
-        end
-    
-        it_should_behave_like "every accessible has(n) association with no reject_if proc"
-        it_should_behave_like "every accessible has(n) association with :allow_destroy => false"
-      
-      end
             
       describe ":reject_if => lambda { |attrs| true }" do
     
@@ -203,7 +62,8 @@ describe DataMapper::NestedAttributes do
           Project.accepts_nested_attributes_for :tasks, :reject_if => lambda { |attrs| true }
           @project = Project.new :name => 'trippings'
         end
-    
+
+        it_should_behave_like "every accessible has(n) association"
         it_should_behave_like "every accessible has(n) association with a valid reject_if proc"
         it_should_behave_like "every accessible has(n) association with :allow_destroy => false"
       
@@ -216,7 +76,8 @@ describe DataMapper::NestedAttributes do
           Project.accepts_nested_attributes_for :tasks, :reject_if => lambda { |attrs| false }
           @project = Project.new :name => 'trippings'
         end
-    
+
+        it_should_behave_like "every accessible has(n) association"
         it_should_behave_like "every accessible has(n) association with no reject_if proc"
         it_should_behave_like "every accessible has(n) association with :allow_destroy => false"
       

data/spec/integration/has_n_through_spec.rb

@@ -2,150 +2,7 @@ require 'pathname'
 require Pathname(__FILE__).dirname.expand_path.parent + 'spec_helper'
 
 describe DataMapper::NestedAttributes do
-  
-  describe "every accessible has(n, :through) association with a valid reject_if proc", :shared => true do
-  
-    it "should not allow to create a new project via Person#projects_attributes" do
-      @person.save
-      Person.all.size.should == 1
-      ProjectMembership.all.size.should == 0
-      Project.all.size.should == 0
-      
-      @person.projects_attributes = { 'new_1' => { :name => 'dm-accepts_nested_attributes' } }
-      @person.projects.should be_empty
-      @person.save
-      
-      Person.all.size.should == 1
-      ProjectMembership.all.size.should == 0
-      Project.all.size.should == 0
-    end
-    
-  end
-  
-  describe "every accessible has(n, :through) association with no reject_if proc", :shared => true do
-    
-    it "should allow to create a new project via Person#projects_attributes" do
-      @person.save
-      Person.all.size.should == 1
-      ProjectMembership.all.size.should == 0
-      Project.all.size.should == 0
-      
-      @person.projects_attributes = { 'new_1' => { :name => 'dm-accepts_nested_attributes' } }
-      @person.projects.should_not be_empty
-      @person.projects.first.name.should == 'dm-accepts_nested_attributes'
-      @person.save
-      @person.projects.first.should == Project.first
-      
-      Person.all.size.should == 1
-      ProjectMembership.all.size.should == 1
-      Project.all.size.should == 1
-      
-      Project.first.name.should == 'dm-accepts_nested_attributes'
-    end
-        
-    it "should allow to update an existing project via Person#projects_attributes" do
-      @person.save
-      project = Project.create(:name => 'dm-accepts_nested_attributes')
-      project_membership = ProjectMembership.create(:person => @person, :project => project)
-      Person.all.size.should == 1
-      Project.all.size.should == 1
-      ProjectMembership.all.size.should == 1
-      
-      @person.reload
-      
-      @person.projects_attributes = { project.id.to_s => { :id => project.id, :name => 'still dm-accepts_nested_attributes' } }
-      @person.projects.should_not be_empty
-      @person.projects.first.name.should == 'still dm-accepts_nested_attributes'
-      @person.save
-      
-      Person.all.size.should == 1
-      ProjectMembership.all.size.should == 1
-      Project.all.size.should == 1
-      
-      Project.first.name.should == 'still dm-accepts_nested_attributes'
-    end
-    
-    it "should perform atomic commits" do
-      
-      @person.projects_attributes = { 'new_1' => { :name => nil } } # should fail because of validations
-      @person.projects.should be_empty
-      @person.save
-      @person.projects.should be_empty
-      
-      Person.all.size.should            == 1
-      ProjectMembership.all.size.should == 0
-      Project.all.size.should           == 0
-      
-      @person.name = nil # should fail because of validations
-      @person.projects_attributes = { 'new_1' => { :name => nil } }
-      @person.projects.should be_empty
-      @person.save
-      @person.projects.should be_empty
-      
-      Person.all.size.should            == 0
-      ProjectMembership.all.size.should == 0
-      Project.all.size.should           == 0
-      
-    end
-    
-  end
-  
-  describe "every accessible has(n, :through) association with :allow_destroy => false", :shared => true do
-    
-    it "should not allow to delete an existing project via Person#projects_attributes" do
-      @person.save
-      project = Project.create(:name => 'dm-accepts_nested_attributes')
-      project_membership = ProjectMembership.create(:person => @person, :project => project)
-      
-      Person.all.size.should            == 1
-      ProjectMembership.all.size.should == 1
-      Project.all.size.should           == 1
-    
-      @person.reload
-      @person.projects_attributes = { '1' => { :id => project.id, :_delete => true } }
-      @person.save
-      
-      Person.all.size.should            == 1
-      ProjectMembership.all.size.should == 1
-      Project.all.size.should           == 1
-    end
-    
-  end
-  
-  describe "every accessible has(n, :through) association with :allow_destroy => true", :shared => true do
-    
-    it "should allow to delete an existing project via Person#projects_attributes" do
-      @person.save
-      project = Project.create(:name => 'dm-accepts_nested_attributes')
-      project_membership = ProjectMembership.create(:person => @person, :project => project)
-      
-      Person.all.size.should            == 1
-      ProjectMembership.all.size.should == 1
-      Project.all.size.should           == 1
-    
-      @person.reload
-      @person.projects_attributes = { '1' => { :id => project.id, :_delete => true } }
-      @person.save
-      
-      Person.all.size.should            == 1
-      ProjectMembership.all.size.should == 0
-      Project.all.size.should           == 0
-    end
-    
-  end
-
-  describe "every accessible has(n, :through) association with a nested attributes reader", :shared => true do
 
-    it "should return the attributes written to Person#projects_attributes from the Person#projects_attributes reader" do
-      @person.projects_attributes.should be_nil
-
-      @person.projects_attributes = { 'new_1' => { :name => 'write specs' } }
-
-      @person.projects_attributes.should == { 'new_1' => { :name => 'write specs' } }
-    end
-
-  end
-  
   describe "Person.has(n, :projects, :through => :project_memberships)" do
     
     include ManyToManyHelpers
@@ -161,10 +18,10 @@ describe DataMapper::NestedAttributes do
         Person.accepts_nested_attributes_for :projects
         @person = Person.new :name => 'snusnu'
       end
-      
+
+      it_should_behave_like "every accessible has(n, :through) association"
       it_should_behave_like "every accessible has(n, :through) association with no reject_if proc"
       it_should_behave_like "every accessible has(n, :through) association with :allow_destroy => false"
-      it_should_behave_like "every accessible has(n, :through) association with a nested attributes reader"
       
     end
       
@@ -175,7 +32,8 @@ describe DataMapper::NestedAttributes do
         Person.accepts_nested_attributes_for :projects, :allow_destroy => false
         @person = Person.new :name => 'snusnu'
       end
-      
+
+      it_should_behave_like "every accessible has(n, :through) association"
       it_should_behave_like "every accessible has(n, :through) association with no reject_if proc"
       it_should_behave_like "every accessible has(n, :through) association with :allow_destroy => false"
       
@@ -188,26 +46,14 @@ describe DataMapper::NestedAttributes do
         Person.accepts_nested_attributes_for :projects, :allow_destroy => true
         @person = Person.new :name => 'snusnu'
       end
-      
+
+      it_should_behave_like "every accessible has(n, :through) association"
       it_should_behave_like "every accessible has(n, :through) association with no reject_if proc"
       it_should_behave_like "every accessible has(n, :through) association with :allow_destroy => true"
       
     end
     
     describe "accepts_nested_attributes_for :projects, " do
-      
-      describe ":reject_if => :foo" do
-    
-        before(:each) do
-          clear_data
-          Person.accepts_nested_attributes_for :projects, :reject_if => :foo
-          @person = Person.new :name => 'snusnu'
-        end
-    
-        it_should_behave_like "every accessible has(n, :through) association with no reject_if proc"
-        it_should_behave_like "every accessible has(n, :through) association with :allow_destroy => false"
-      
-      end
             
       describe ":reject_if => lambda { |attrs| true }" do
     
@@ -216,7 +62,8 @@ describe DataMapper::NestedAttributes do
           Person.accepts_nested_attributes_for :projects, :reject_if => lambda { |attrs| true }
           @person = Person.new :name => 'snusnu'
         end
-    
+
+        it_should_behave_like "every accessible has(n, :through) association"
         it_should_behave_like "every accessible has(n, :through) association with a valid reject_if proc"
         it_should_behave_like "every accessible has(n, :through) association with :allow_destroy => false"
       
@@ -229,7 +76,8 @@ describe DataMapper::NestedAttributes do
           Person.accepts_nested_attributes_for :projects, :reject_if => lambda { |attrs| false }
           @person = Person.new :name => 'snusnu'
         end
-    
+
+        it_should_behave_like "every accessible has(n, :through) association"
         it_should_behave_like "every accessible has(n, :through) association with no reject_if proc"
         it_should_behave_like "every accessible has(n, :through) association with :allow_destroy => false"
       

data/spec/{shared → lib}/rspec_tmbundle_support.rb

@@ -4,7 +4,7 @@
 
 module RSpecTmBundleHelpers
   
-  class TextmateRspecLogger < DataMapper::Logger
+  class TextmateRspecLogger < Extlib::Logger
     def prep_msg(message, level)
       "#{super}<br />"
     end

data/spec/shared/belongs_to_spec.rb

@@ -0,0 +1,127 @@
+describe "every accessible belongs_to association", :shared => true do
+  
+  it "should allow to update an existing person via Profile#person_attributes" do
+    Profile.all.size.should == 0
+    Person.all.size.should  == 0
+    
+    person = Person.create(:name => 'Martin')
+    @profile.person = person
+    @profile.save.should be_true
+  
+    Profile.all.size.should  == 1
+    Person.all.size.should   == 1
+    Person.first.name.should == 'Martin'
+  
+    @profile.person_attributes = { :id => person.id, :name => 'Martin Gamsjaeger' }
+    @profile.save.should be_true
+  
+    Profile.all.size.should  == 1
+    Person.all.size.should   == 1
+    Person.first.name.should == 'Martin Gamsjaeger'
+  end
+  
+  it "should perform atomic commits" do
+    Profile.all.size.should == 0
+    Person.all.size.should  == 0
+    
+    # related resource is invalid
+    @profile.person_attributes = { :name => nil }
+    @profile.save.should be_false
+    
+    Profile.all.size.should == 0
+    Person.all.size.should  == 0
+  
+    # self is invalid
+    @profile.nick = nil
+    @profile.person_attributes = { :name => 'Martin' }
+    @profile.save.should be_false
+    
+    Profile.all.size.should == 0
+    Person.all.size.should == 0
+  end
+
+  it "should return the attributes written to Profile#person_attributes from the Profile#person_attributes reader" do
+    @profile.person_attributes.should be_nil
+    @profile.person_attributes = { :name => 'Martin' }
+    @profile.person_attributes.should == { :name => 'Martin' }
+  end
+
+end
+
+describe "every accessible belongs_to association with a valid reject_if proc", :shared => true do
+
+  it "should not allow to create a new person via Profile#person_attributes" do
+    Profile.all.size.should == 0
+    Person.all.size.should  == 0
+
+    @profile.person_attributes = { :name => 'Martin' }
+    @profile.save.should be_false
+
+    Profile.all.size.should == 0
+    Person.all.size.should  == 0
+  end
+
+end
+
+describe "every accessible belongs_to association with no reject_if proc", :shared => true do
+
+  it "should allow to create a new person via Profile#person_attributes" do
+    Profile.all.size.should == 0
+    Person.all.size.should  == 0
+
+    @profile.person_attributes = { :name => 'Martin' }
+    @profile.save.should be_true
+
+    Profile.all.size.should  == 1
+    Person.all.size.should   == 1
+    Person.first.name.should == 'Martin'
+  end
+
+end
+
+describe "every accessible belongs_to association with :allow_destroy => false", :shared => true do
+  
+  it "should not allow to delete an existing person via Profile#person_attributes" do
+    Profile.all.size.should == 0
+    Person.all.size.should  == 0
+    
+    person = Person.create(:name => 'Martin')
+    @profile.person = person
+    @profile.save.should be_true
+    
+    Profile.all.size.should == 1
+    Person.all.size.should  == 1
+  
+    @profile.person_attributes = { :id => person.id, :_delete => true }
+    @profile.save
+    
+    Profile.all.size.should == 1
+    Person.all.size.should  == 1
+  end
+  
+end
+  
+describe "every accessible belongs_to association with :allow_destroy => true", :shared => true do
+  
+  it "should allow to delete an existing person via Profile#person_attributes" do
+    Profile.all.size.should == 0
+    Person.all.size.should  == 0
+    
+    person = Person.create(:name => 'Martin')
+    @profile.person = person
+    @profile.save.should be_true
+    
+    Profile.all.size.should == 1
+    Person.all.size.should  == 1
+  
+    @profile.person_attributes = { :id => person.id, :_delete => true }
+    @profile.save
+    
+    Profile.all.size.should == 1 # project.person_id must not be nil
+    Person.all.size.should  == 1
+    
+    # TODO also test this behavior in situations where setting the FK to nil is allowed
+    
+  end
+
+end