snoopy_afip 4.3.0 → 4.3.1

data/spec/snoopy_afip/bill_spec.rb

@@ -1,106 +1,89 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+
+RSpec.describe Snoopy::Bill do
+  def valid_attrs(overrides = {})
+    {
+      cuit:                   "20111111112",
+      sale_point:             "0001",
+      total_net:              100.0,
+      concept:                "Productos",
+      document_type:          "CUIT",
+      document_num:           "30710151543",
+      issuer_iva_cond:        Snoopy::RESPONSABLE_INSCRIPTO,
+      receiver_iva_cond:      :factura_a,
+      receiver_iva_condition: :responsable_inscripto,
+      currency:               :peso,
+      service_date_from:      "20240101",
+      service_date_to:        "20240131",
+      alicivas:               [{ id: 0.21, amount: 21.0, taxeable_base: 100.0 }]
+    }.merge(overrides)
+  end
 
-describe "Bill" do
-  it "should setup a header hash" do
-    @header = Snoopy::Bill.header(0)
-    @header.size.should == 3
-    ["CantReg", "CbteTipo", "PtoVta"].each do |key|
-      @header.has_key?(key).should == true
+  describe "#cbte_type" do
+    it "deriva el código del comprobante desde receiver_iva_cond" do
+      expect(described_class.new(valid_attrs).cbte_type).to eq("01")          # BILL_TYPE[:factura_a]
+      expect(described_class.new(valid_attrs(receiver_iva_cond: :factura_b)).cbte_type).to eq("06")
     end
   end
 
-  describe "instance" do
-    before(:each) {@bill = Snoopy::Bill.new}
-
-    it "should initialize according to Snoopy defaults" do
-      @bill.client.class.name.should == "Savon::Client"
-      ["Token", "Sign", "Cuit"].each do |key|
-        @bill.body["Auth"][key].should_not == nil
-      end
-      @bill.documento.should == Snoopy.default_documento
-      @bill.moneda.should == Snoopy.default_moneda
+  describe "#iva_sum y #total" do
+    it "suma las alícuotas y calcula el total neto + IVA" do
+      bill = described_class.new(valid_attrs)
+      expect(bill.iva_sum).to eq(21.0)
+      expect(bill.total).to eq(121.0)
     end
 
-    it "should calculate it's cbte_tipo for Responsable Inscripto" do
-      @bill.iva_cond = :responsable_inscripto
-      @bill.cbte_type.should == "01"
+    it "total es 0 cuando el neto es 0" do
+      expect(described_class.new(valid_attrs(total_net: 0)).total).to eq(0)
     end
+  end
 
-    it "should calculate it's cbte_tipo for Consumidor Final" do
-      @bill.iva_cond = :consumidor_final
-      @bill.cbte_type.should == "06"
+  describe "#exchange_rate" do
+    it "es 1 para pesos" do
+      expect(described_class.new(valid_attrs(currency: :peso)).exchange_rate).to eq(1)
     end
+  end
 
-    it "raise error on nil iva cond" do
-      @bill.iva_cond = 12
-      expect{@bill.cbte_type}.to raise_error(Snoopy::NullOrInvalidAttribute)
+  describe "#receiver_iva_condition_id" do
+    it "mapea la condición de IVA del receptor (RG 5616)" do
+      expect(described_class.new(valid_attrs).receiver_iva_condition_id).to eq("1")
+      expect(described_class.new(valid_attrs(receiver_iva_condition: :consumidor_final)).receiver_iva_condition_id).to eq("5")
     end
 
-    it "should fetch non Peso currency's exchange rate" do
-      @bill.moneda = :dolar
-      @bill.exchange_rate.to_i.should be > 0
+    it "es '' cuando no se informó la condición" do
+      expect(described_class.new(valid_attrs(receiver_iva_condition: nil)).receiver_iva_condition_id).to eq("")
     end
+  end
 
-    it "should return 1 for Peso currency" do
-      @bill.moneda = :peso
-      @bill.exchange_rate.should == 1
+  describe "estado del resultado" do
+    it "refleja el veredicto de AFIP" do
+      bill = described_class.new(valid_attrs)
+      bill.result = "A"
+      expect(bill.approved?).to be(true)
+      bill.result = "R"
+      expect(bill.rejected?).to be(true)
+      bill.result = "P"
+      expect(bill.partial_approved?).to be(true)
     end
+  end
 
-    it "should calculate the IVA array values" do
-      @bill.iva_cond = :responsable_inscripto
-      @bill.moneda = :peso
-      @bill.net = 100.89
-      @bill.aliciva_id = 2
-
-      @bill.iva_sum.should be_within(0.05).of(21.18)
-      @bill.total.should be_within(0.05).of(122.07)
+  describe "#valid?" do
+    it "es válido con atributos completos y correctos" do
+      bill = described_class.new(valid_attrs)
+      expect(bill.valid?).to be(true)
+      expect(bill.errors).to be_empty
     end
 
-    it "should use give due date an service dates, or todays date" do
-      @bill.net = 100
-      @bill.aliciva_id = 2
-      @bill.doc_num = "30710151543"
-      @bill.iva_cond = :responsable_inscripto
-      @bill.concepto = "Servicios"
-
-      @bill.setup_bill
-
-      detail = @bill.body["FeCAEReq"]["FeDetReq"]["FECAEDetRequest"]
-
-      detail["FchServDesde"].should == Time.new.strftime('%Y%m%d')
-      detail["FchServHasta"].should == Time.new.strftime('%Y%m%d')
-      detail["FchVtoPago"].should   == Time.new.strftime('%Y%m%d')
-
-      @bill.due_date       = Date.new(2011, 12, 10).strftime('%Y%m%d')
-      @bill.fch_serv_desde = Date.new(2011, 11, 01).strftime('%Y%m%d')
-      @bill.fch_serv_hasta = Date.new(2011, 11, 30).strftime('%Y%m%d')
-
-      @bill.setup_bill
-
-      detail = @bill.body["FeCAEReq"]["FeDetReq"]["FECAEDetRequest"]
-
-      detail["FchServDesde"].should == "20111101"
-      detail["FchServHasta"].should == "20111130"
-      detail["FchVtoPago"].should   == "20111210"
+    it "marca currency inválida" do
+      bill = described_class.new(valid_attrs(currency: :yen))
+      expect(bill.valid?).to be(false)
+      expect(bill.errors).to have_key(:currency)
     end
 
-    Snoopy::BILL_TYPE[Snoopy.own_iva_cond].keys.each do |target_iva_cond|
-      it "should authorize a valid bill for #{target_iva_cond.to_s}" do
-        @bill.net = 1000000
-        @bill.aliciva_id = 2
-        @bill.doc_num = "30710151543"
-        @bill.iva_cond = target_iva_cond
-        @bill.concepto = "Servicios"
-
-        @bill.authorized?.should  == false
-        @bill.authorize.should    == true
-        @bill.authorized?.should  == true
-
-        response = @bill.response
-
-        response.length.should     == 28
-        response.cae.length.should == 14
-      end
+    it "marca document_type inválido" do
+      bill = described_class.new(valid_attrs(document_type: "NOPE"))
+      bill.valid?
+      expect(bill.errors).to have_key(:document_type)
     end
   end
 end

data/spec/snoopy_afip/exceptions_spec.rb

@@ -0,0 +1,27 @@
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+
+RSpec.describe Snoopy::Exception do
+  # Regresión #14: ServerTimeout debe seguir siendo un Timeout::Error (compat
+  # hacia atrás) y a la vez quedar bajo el paraguas Snoopy::Exception::Error.
+  describe "jerarquía de ServerTimeout" do
+    subject(:ancestors) { Snoopy::Exception::ServerTimeout.ancestors }
+
+    it "sigue siendo un Timeout::Error" do
+      expect(ancestors).to include(Timeout::Error)
+    end
+
+    it "queda bajo el paraguas Snoopy::Exception::Error" do
+      expect(ancestors).to include(Snoopy::Exception::Error)
+    end
+  end
+
+  it "el paraguas Error cubre también a las excepciones de la base" do
+    expect(Snoopy::Exception::ClientError.ancestors).to include(Snoopy::Exception::Error)
+    expect(Snoopy::Exception::AuthorizeAdapter::BuildBodyRequest.ancestors).to include(Snoopy::Exception::Error)
+  end
+
+  it "un rescue del paraguas atrapa tanto el timeout como los errores de cliente" do
+    expect { raise Snoopy::Exception::ServerTimeout }.to raise_error(Snoopy::Exception::Error)
+    expect { raise Snoopy::Exception::ClientError.new("x") }.to raise_error(Snoopy::Exception::Error)
+  end
+end

data/spec/spec_helper.rb

@@ -1,23 +1,19 @@
-$:.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
-require 'snoopy'
-require 'rspec'
-require 'ruby-debug'
+$LOAD_PATH.unshift(File.expand_path("../lib", __dir__))
 
-class SpecHelper
-  include Savon::Logger
-end
+require "snoopy_afip"
+# Bill#valid? usa blank?/present? (ActiveSupport); en producción lo provee Rails.
+require "active_support/core_ext/object/blank"
+require "rspec"
 
-# Requires supporting files with custom matchers and macros, etc,
-# in ./support/ and its subdirectories.
-Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f}
+# Config base de homologación para construir adapters en los specs.
+# Nunca credenciales reales: pkey/cert/cuit son placeholders de prueba.
+Snoopy.auth_url            = "https://wsaahomo.afip.gov.ar/ws/services/LoginCms?wsdl"
+Snoopy.service_url         = "https://wswhomo.afip.gov.ar/wsfev1/service.asmx?WSDL"
+Snoopy.default_currency    = :peso
+Snoopy.default_concept     = "Productos"
+Snoopy.default_document_type = "CUIT"
 
-Snoopy.pkey = "spec/fixtures/pkey"
-Snoopy.cert = "spec/fixtures/cert.crt"
-Snoopy.cuit = ENV["CUIT"] || raise(Snoopy::NullOrInvalidAttribute.new, "Please set CUIT env variable.")
-Snoopy.sale_point = "0002"
-Snoopy.auth_url = "https://wsaahomo.afip.gov.ar/ws/services/LoginCms"
-Snoopy.service_url = "http://wswhomo.afip.gov.ar/wsfev1/service.asmx?WSDL"
-Snoopy.default_concepto = "Productos y Servicios"
-Snoopy.default_documento = "CUIT"
-Snoopy.default_moneda = :peso
-Snoopy.own_iva_cond = :responsable_inscripto
+RSpec.configure do |config|
+  config.expect_with(:rspec) { |e| e.syntax = :expect }
+  config.disable_monkey_patching!
+end

metadata

@@ -1,13 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: snoopy_afip
 version: !ruby/object:Gem::Version
-  version: 4.3.0
+  version: 4.3.1
 platform: ruby
 authors:
 - g.edera
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2017-06-29 00:00:00.000000000 Z
+date: 2026-06-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon
@@ -23,6 +24,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 2.12.1
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.13'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.13'
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Adaptador para Web Service de Facturación Electrónica Argentina (AFIP)
 email: gab.edera@gmail.com
 executables: []
@@ -30,8 +59,12 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".document"
+- ".github/workflows/main.yml"
+- ".github/workflows/release.yml"
 - ".gitignore"
-- CHANGELOG
+- AGENTS.md
+- CHANGELOG.md
+- CLAUDE.md
 - Gemfile
 - Gemfile.lock
 - LICENSE.txt
@@ -40,6 +73,14 @@ files:
 - Rakefile
 - VERSION
 - autotest/discover.rb
+- docs/behavior/behavior.md
+- docs/config/configuracion.md
+- docs/consumed/afip.md
+- docs/errors/errors.md
+- docs/glossary/glossary.md
+- docs/interface/interface.md
+- docs/test/testing.md
+- docs/topology/topology.md
 - lib/snoopy_afip.rb
 - lib/snoopy_afip/authentication_adapter.rb
 - lib/snoopy_afip/authorize_adapter.rb
@@ -51,9 +92,13 @@ files:
 - lib/snoopy_afip/core_ext/string.rb
 - lib/snoopy_afip/exceptions.rb
 - lib/snoopy_afip/version.rb
+- skill/SKILL.md
+- skills.yml
 - snoopy_afip.gemspec
-- spec/snoopy_afip/authorizer_spec.rb
+- spec/snoopy_afip/authentication_adapter_spec.rb
+- spec/snoopy_afip/authorize_adapter_spec.rb
 - spec/snoopy_afip/bill_spec.rb
+- spec/snoopy_afip/exceptions_spec.rb
 - spec/spec_helper.rb
 - wsaa-client.sh
 - xds_login.xml
@@ -61,6 +106,7 @@ homepage: https://github.com/gedera/snoopy_afip
 licenses:
 - MIT
 metadata: {}
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -68,17 +114,20 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 3.4.19
+signing_key:
 specification_version: 4
 summary: Adaptador AFIP wsfe.
 test_files:
-- spec/snoopy_afip/authorizer_spec.rb
+- spec/snoopy_afip/authentication_adapter_spec.rb
+- spec/snoopy_afip/authorize_adapter_spec.rb
 - spec/snoopy_afip/bill_spec.rb
+- spec/snoopy_afip/exceptions_spec.rb
 - spec/spec_helper.rb

data/CHANGELOG

@@ -1,27 +0,0 @@
-# Changelog
-All notable changes to this project will be documented in this file.
-
-The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
-and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
-
-## [3.0.2] - July 14, 2017
-### Added
-- `Cms Builder exception`.
-
-## [3.0.0] - June 29, 2017
-### Added
-- `Authentication Class` destinada a la comunicación con el **WSAA**.
-- `Authorize Class` destinada a la comunicación con el **WSFE**.
-- `Client Class` destinada para crear el cliente de `Savon`.
-- Mejor manejo de Exceptions.
-- Validaciones en el modelo `Bill`.
-
-### Changed
-- Se pasó toda la logica de comunicación con el **WSFE** del modelo `Bill` al modelo `Authorize`.
-- No se crea mas el rchivo para la clave privada, devuelve en RAW.
-- No se crea mas un archivo para almacenar el _token_, _sign_, se devuelve en RAW.
-- Evitar raisear si se logró autorizar una factura con el **WSFE**. Manejo en el errors del `Bill` o el `Authorize`.
-
-### Removed
-- Eliminiado modulo `AuthData`.
-- Eliminado el uso de `Bash` para autenticar en el **WSAA**.

data/spec/snoopy_afip/authorizer_spec.rb

@@ -1,9 +0,0 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
-
-describe "Authorizer" do
-  it "should read credentials on initialize" do
-    authorizer = Snoopy::Authorizer.new
-    authorizer.pkey.should == 'spec/fixtures/pkey'
-    authorizer.cert.should == 'spec/fixtures/cert.crt'
-  end
-end