snmpjr 0.2.2-java → 0.3.0-java

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MmUwNWVjOGJkMDViODU2YjZiNGU1NWRjMTg0NmIwZDhjYzgyMmRiOQ==
+    MDY3NTgwYjc3ZTBlNDViODkyNzdiY2E4NzY5NWY3NjlhMjRhYzE0ZQ==
   data.tar.gz: !binary |-
-    MzA2MDZlZmE0NjM1ZjIxMDRjYzMyZDQ0MmY1ZWMwYjhlMjQ3YjYxOA==
+    NDQzMjc5ZTcwYzY5ZmRjNTU2NzlkMzBiZGZiY2Q3ZGZkNjJiZGEyZg==
 SHA512:
   metadata.gz: !binary |-
-    MzFlMzlmMjNlY2I4MjlkNWYwN2QxMzZmNWU2NDk0OGUzZmJhZDczMTM3Zjg2
-    NGMyMjY3NTJmMDlkNmRhNzM4ZTc3NTZiMTkyZmI0YjQ5OWUxZjg3OGQ1ODY2
-    ZjIzNDhkZmZhNDEzYTZlZmIzNWMwMTBiNjI3NTE4NDI5Y2RmMzA=
+    MDc5YzIzMWJkZGRmODI1OTU4NjQwZTdmOWZmYzU5MzRjMTc2YWQxZjYwYzQ0
+    NWNlZDhlMDQ1MWU5ZDU0NTIyOWU5ZTA0ZGViYzVmNGIzYTU5YTVhMmFiNjli
+    NjU0MDdkNDRiMWM2NmE5YjQ1ODJiMmIzNjc5Mjc5MDg0NzhhYWQ=
   data.tar.gz: !binary |-
-    MGFkYmI2NTk4ZTBiNjg4YTdiZjdkZTczMjQ5MjBhMjFjZjFlY2U2YTFlZjEx
-    YmYzNDNlM2ZlYjcyOGFmOTZmMTBhN2NhZWE0OTMyZjZhMDQ3NDYxMjY2MTg1
-    ZWM5ZjlhNjU0MjI2MDY2MmZlMDQxNmM4NTcyNzZkZGZjYzhhMWE=
+    OTdkZDdhZjU3NzJiNjRmNjRhYWNkYjVkMzM1Mzk2MmE3YmFiZjM2ZmRiMDNi
+    MTQzYTI5ZmVmZTZlZjJmYjkwOWJiOGM1NjJkN2ExNzhhNWQ5OTIzNDlhYTg0
+    NGM5ODNhY2QxMDczZDM4ZWE3MzYwMDhiMzlmMWEyODA4OGU1MTA=

data/.semver

@@ -1,6 +1,6 @@
 ---
 :major: 0
-:minor: 2
-:patch: 2
+:minor: 3
+:patch: '0'
 :special: ''
 :metadata: ''

data/README.md

@@ -3,14 +3,12 @@ Snmpjr
 
 [![Gem Version](https://badge.fury.io/rb/snmpjr.svg)](http://badge.fury.io/rb/snmpjr) [![Build Status](https://travis-ci.org/zenonas/snmpjr.svg?branch=master)](https://travis-ci.org/zenonas/snmpjr) [![Coverage Status](https://img.shields.io/coveralls/zenonas/snmpjr.svg)](https://coveralls.io/r/zenonas/snmpjr?branch=master) [![Code Climate](https://codeclimate.com/github/zenonas/snmpjr/badges/gpa.svg)](https://codeclimate.com/github/zenonas/snmpjr) [![Dependency Status](https://gemnasium.com/zenonas/snmpjr.svg)](https://gemnasium.com/zenonas/snmpjr) [![Inline docs](http://inch-ci.org/github/zenonas/snmpjr.svg?branch=master)](http://inch-ci.org/github/zenonas/snmpjr)
 
-Snmpjr aims to provide a clean and simple interface to use SNMP in your ruby code. It will wrap the popular SNMP4J library in Java.
-
-Please note the gem is still in early develpment. Do not use as of yet!
+Snmpjr aims to provide a clean and simple interface to use SNMP in your ruby code. It wraps the popular SNMP4J library in Java.
 
 ## Features
 
-* Simple Synchronous SNMP V2 Get requests
-* Synchronous SNMP V2 Walk
+* Synchronous SNMP Get and Walk for SNMPv2c and SNMPv3
+* Simple API
 
 ## Requirements
 
@@ -36,9 +34,34 @@ Or install it yourself as:
 ## Usage
 
 ```ruby
-# Initialize Snmpjr with host, port and a community
-# Optional Params. (port, retries, timeout)
-snmp = Snmpjr.new(host: '127.0.0.1', port: 161, community: 'public')
+# Initialize Snmpjr with the version of SNMP you want to work with
+snmp = Snmpjr.new(Snmpjr::Version::V2C).configure do |config|
+  config.host = 'example.com'
+  config.community = 'public'
+  # Optional Parameters
+  config.port = 161 #(default)
+  config.retries = 0 #(default)
+  config.timeout = 5000 #(default)
+  config.max_oids_per_request = 20 #(default)
+end
+
+snmp = Snmpjr.new(Snmpjr::Version::V3).configure do |config|
+  config.host = 'example.com'
+  config.user = 'some user'
+  # Agent dependent options
+  config.authentication 'authentication_protocol*', 'passphrase'
+  config.privacy 'privacy_protocol**', 'passphrase'
+  config.context = '' #(default)
+  # Optional Parameters
+  config.port = 161 #(default)
+  config.retries = 0 #(default)
+  config.timeout = 5000 #(default)
+  config.max_oids_per_request = 20 #(default)
+end
+
+# There is no need to specify options that you wish to default
+# * Authentication Protocols (SHA|MD5)
+# ** Privacy Protocols (DES|3DES|AES128|AES192|AES256)
 
 # Call get on any single Oid
 snmp.get '1.3.6.1.2.1.1.1.0'
@@ -48,7 +71,7 @@ snmp.get '1.3.6.1.2.1.1.1.0'
 snmp.get ['1.3.6.1.2.1.1.1.0', '1.3.6.1.2.1.1.3.0']
 => [Snmpjr::Response.new(value: 'First result'), Snmpjr::Response.new(value: 'Second result')]
 
-# Response objects respond to error?
+# Response objects respond to response.error? that returns true if an SNMP error occured eg. noSuchInstance
 
 # Call walk on an Oid
 snmp.walk '1.3.6.1.2.1.1.1'
@@ -57,7 +80,7 @@ snmp.walk '1.3.6.1.2.1.1.1'
 
 Snmpjr will catch and raise any exceptions that happen in Java land and raise them as RuntimeErrors while preserving the message.
 
-When you request an Array of Oids these will be pulled sequentially
+When you request an Array of Oids these will be packaged in a single PDU up to a maximum(configurable).
 
 ## Contributing
 

data/history.rdoc

@@ -1,3 +1,5 @@
+== v0.3.0 (01 December 2014)
+
 == v0.2.2 (03 November 2014)
 
 * Add the Oid as part of the response object

data/lib/snmpjr/configuration.rb

@@ -0,0 +1,13 @@
+class Snmpjr
+  class Configuration
+    attr_accessor :host, :port, :retries, :timeout, :max_oids_per_request
+
+    def initialize
+      @port = 161
+      @retries = 0
+      @timeout = 5000
+      @max_oids_per_request = 20
+    end
+
+  end
+end

data/lib/snmpjr/configuration_v2c.rb

@@ -0,0 +1,22 @@
+require 'snmpjr/configuration'
+require 'snmpjr/pdu_v2c'
+require 'snmpjr/target_v2c'
+require 'snmpjr/session_v2c'
+
+class Snmpjr
+  class ConfigurationV2C < Configuration
+    attr_accessor :community
+
+    def create_pdu
+      Snmpjr::PduV2C.new
+    end
+
+    def create_target
+      Snmpjr::TargetV2C.new.create self
+    end
+
+    def create_session
+      Snmpjr::SessionV2C.new
+    end
+  end
+end

data/lib/snmpjr/configuration_v3.rb

@@ -0,0 +1,51 @@
+require 'snmpjr/configuration'
+require 'snmpjr/target_v3'
+require 'snmpjr/session_v3'
+require 'snmpjr/pdu_v3'
+
+class Snmpjr
+  class ConfigurationV3 < Configuration
+    module SecurityLevels
+      NoAuthNoPriv = 1
+      AuthNoPriv = 2
+      AuthPriv = 3
+    end
+
+    attr_accessor :context, :user
+    attr_reader :authentication_protocol, :authentication_key,  :privacy_protocol, :privacy_key
+
+    def initialize
+      @context = ''
+      super
+    end
+
+    def security_level
+      return SecurityLevels::AuthPriv if authentication_protocol && privacy_protocol
+      return SecurityLevels::AuthNoPriv if authentication_protocol
+      SecurityLevels::NoAuthNoPriv
+    end
+
+    def authentication protocol, key
+      @authentication_protocol = protocol
+      @authentication_key = key
+    end
+
+    def privacy protocol, key
+      @privacy_protocol = protocol
+      @privacy_key = key
+    end
+
+    def create_target
+      Snmpjr::TargetV3.new.create self
+    end
+
+    def create_session
+      Snmpjr::SessionV3.new self
+    end
+
+    def create_pdu
+      Snmpjr::PduV3.new context
+    end
+
+  end
+end

data/lib/snmpjr/getter.rb

@@ -1,37 +1,36 @@
-require "snmpjr/pdu"
-require "snmpjr/session"
-
 class Snmpjr
   class Getter
 
     def initialize args = {}
       @target = args.fetch(:target)
-      @max_oids_per_request = args[:max_oids_per_request] || 30
-      @session = Snmpjr::Session.new
-    end
-
-    def get_multiple oids
-      @session.start
-      result = oids.each_slice(@max_oids_per_request).map{|partial_oids|
-        get_request partial_oids
-      }.flatten
-      @session.close
-      result
+      @max_oids_per_request = args.fetch(:config).max_oids_per_request
+      @session = args.fetch(:session)
+      @pdu = args.fetch(:pdu)
     end
 
-    def get oid
+    def get oids
       @session.start
-      result = get_request [oid]
-      @session.close
-      result.first
+      begin
+        results = oids.each_slice(@max_oids_per_request).map{|partial_oids|
+          get_request partial_oids
+        }.flatten
+      ensure
+        @session.close
+      end
+      extract_possible_single_result_from results
     end
 
     private
 
     def get_request oids
-      pdu = Snmpjr::Pdu.new.create oids
+      pdu = @pdu.create oids
       @session.send(pdu, @target)
     end
 
+    def extract_possible_single_result_from results
+      return results.first if results.size.eql?(1)
+      results
+    end
+
   end
 end

data/lib/snmpjr/{pdu.rb → pdu_v2c.rb}

@@ -2,20 +2,23 @@ require 'snmpjr/wrappers/smi'
 require 'snmpjr/wrappers/snmp4j'
 
 class Snmpjr
-  class Pdu
+  class PduV2C
     module Constants
       GET = -96
     end
 
+    def initialize
+      @pdu = Snmpjr::Wrappers::PDU.new
+    end
+
     def create oids
-      pdu = Snmpjr::Wrappers::PDU.new
       oids.map {|oid|
         oid = Snmpjr::Wrappers::SMI::OID.new oid
         variable_binding = Snmpjr::Wrappers::SMI::VariableBinding.new oid
-        pdu.add variable_binding
+        @pdu.add variable_binding
       }
-      pdu.type = Snmpjr::Pdu::Constants::GET
-      pdu
+      @pdu.type = Snmpjr::PduV2C::Constants::GET
+      @pdu
     end
 
   end

data/lib/snmpjr/pdu_v3.rb

@@ -0,0 +1,14 @@
+require 'snmpjr/pdu_v2c'
+require 'snmpjr/wrappers/snmp4j'
+require 'snmpjr/wrappers/smi'
+
+class Snmpjr
+  class PduV3 < Snmpjr::PduV2C
+
+    def initialize context = ''
+      @pdu = Snmpjr::Wrappers::ScopedPDU.new
+      @pdu.context_name = Snmpjr::Wrappers::SMI::OctetString.new(context)
+    end
+
+  end
+end

data/lib/snmpjr/{session.rb → session_v2c.rb}

@@ -1,9 +1,8 @@
 require 'snmpjr/wrappers/transport'
 require 'snmpjr/response'
-require 'snmpjr/target_timeout_error'
 
 class Snmpjr
-  class Session
+  class SessionV2C
     attr_reader :snmp
 
     def initialize
@@ -44,4 +43,7 @@ class Snmpjr
     end
 
   end
+
+  class TargetTimeoutError < StandardError
+  end
 end

data/lib/snmpjr/session_v3.rb

@@ -0,0 +1,63 @@
+require 'snmpjr/session_v2c'
+require 'snmpjr/wrappers/security'
+require 'snmpjr/wrappers/smi'
+require 'snmpjr/wrappers/mp'
+
+class Snmpjr
+  class SessionV3 < Snmpjr::SessionV2C
+    AUTHENTICATION_PROTOCOLS = {
+      'MD5' => Snmpjr::Wrappers::Security::AuthMD5::ID,
+      'SHA' => Snmpjr::Wrappers::Security::AuthSHA::ID
+    }
+
+    PRIVACY_PROTOCOLS = {
+      '3DES' => Snmpjr::Wrappers::Security::Priv3DES::ID,
+      'DES' => Snmpjr::Wrappers::Security::PrivDES::ID,
+      'AES128' => Snmpjr::Wrappers::Security::PrivAES128::ID,
+      'AES192' => Snmpjr::Wrappers::Security::PrivAES192::ID,
+      'AES256' => Snmpjr::Wrappers::Security::PrivAES256::ID
+    }
+
+    def initialize configuration
+      @snmp = Snmpjr::Wrappers::Snmp.new(Snmpjr::Wrappers::Transport::DefaultUdpTransportMapping.new)
+      @config = configuration
+      add_v3_security
+    end
+
+    private
+
+    def add_v3_security
+      create_and_attach_usm
+      @snmp.usm.add_user create_usm_user
+    end
+
+    def create_and_attach_usm
+      usm = Snmpjr::Wrappers::Security::USM.new(
+        Snmpjr::Wrappers::Security::SecurityProtocols.instance,
+        Snmpjr::Wrappers::SMI::OctetString.new(Snmpjr::Wrappers::MP::MPv3.create_local_engine_id),
+        0
+      )
+      Snmpjr::Wrappers::Security::SecurityModels.instance.add_security_model usm
+    end
+
+    def create_usm_user
+      Snmpjr::Wrappers::Security::UsmUser.new(
+        Snmpjr::Wrappers::SMI::OctetString.new(@config.user),
+        AUTHENTICATION_PROTOCOLS[@config.authentication_protocol],
+        authentication_key,
+        PRIVACY_PROTOCOLS[@config.privacy_protocol],
+        privacy_key
+      )
+    end
+
+    def authentication_key
+      return @config.authentication_key if @config.authentication_key.nil?
+      Snmpjr::Wrappers::SMI::OctetString.new(@config.authentication_key)
+    end
+
+    def privacy_key
+      return @config.privacy_key if @config.privacy_key.nil?
+      Snmpjr::Wrappers::SMI::OctetString.new(@config.privacy_key)
+    end
+  end
+end

data/lib/snmpjr/target_v2c.rb

@@ -0,0 +1,18 @@
+require 'snmpjr/wrappers/smi'
+require 'snmpjr/version'
+
+class Snmpjr
+  class TargetV2C
+
+    def create configuration
+      target = Snmpjr::Wrappers::CommunityTarget.new
+      target.community = Snmpjr::Wrappers::SMI::OctetString.new(configuration.community)
+      target.address = Snmpjr::Wrappers::SMI::GenericAddress.parse("udp:#{configuration.host}/#{configuration.port}")
+      target.version = Snmpjr::Version::V2C
+      target.retries = configuration.retries
+      target.timeout = configuration.timeout
+      target
+    end
+
+  end
+end

data/lib/snmpjr/target_v3.rb

@@ -0,0 +1,18 @@
+require 'snmpjr/wrappers/snmp4j'
+require 'snmpjr/wrappers/smi'
+require 'snmpjr/version'
+
+class Snmpjr
+  class TargetV3
+    def create configuration
+      target = Snmpjr::Wrappers::UserTarget.new
+      target.address = Snmpjr::Wrappers::SMI::GenericAddress.parse("udp:#{configuration.host}/#{configuration.port}")
+      target.security_name = Snmpjr::Wrappers::SMI::OctetString.new(configuration.user)
+      target.version = Snmpjr::Version::V3
+      target.retries = configuration.retries
+      target.timeout = configuration.timeout
+      target.security_level = configuration.security_level
+      target
+    end
+  end
+end

data/lib/snmpjr/version.rb

@@ -1,3 +1,6 @@
 class Snmpjr
-  VERSION = "0.2.2"
+  module Version
+    V2C = 1
+    V3 = 3
+  end
 end

data/lib/snmpjr/walker.rb

@@ -1,12 +1,13 @@
 require 'snmpjr/wrappers/util'
 require 'snmpjr/wrappers/smi'
-require 'snmpjr/session'
+require 'snmpjr/response'
+require 'snmpjr/session_v2c'
 
 class Snmpjr
   class Walker
     def initialize opts = {}
       @target = opts.fetch(:target)
-      @session = Snmpjr::Session.new
+      @session = opts.fetch(:session)
       @tree_utils = Snmpjr::Wrappers::Util::TreeUtils.new(@session.snmp, pdu_factory)
     end
 

data/lib/snmpjr/wrappers/mp.rb

@@ -0,0 +1,9 @@
+require 'snmpjr/wrappers/snmp4j'
+
+class Snmpjr
+  module Wrappers
+    module MP
+      include_package 'org.snmp4j.mp'
+    end
+  end
+end

data/lib/snmpjr/wrappers/security.rb

@@ -0,0 +1,9 @@
+require 'snmpjr/wrappers/snmp4j'
+
+class Snmpjr
+  module Wrappers
+    module Security
+      include_package 'org.snmp4j.security'
+    end
+  end
+end

data/lib/snmpjr.rb

@@ -1,46 +1,44 @@
-require "snmpjr/version"
+require 'snmpjr/configuration_v2c'
+require 'snmpjr/configuration_v3'
 require 'snmpjr/wrappers/smi'
 require "snmpjr/getter"
-require "snmpjr/walker"
-require "snmpjr/target"
+require 'snmpjr/walker'
+require 'snmpjr/version'
 
 class Snmpjr
 
-  def initialize options = {}
-    @host = options.fetch(:host)
-    @port = options.fetch(:port) { 161 }
-    @community = options.fetch(:community)
-    @timeout = options.fetch(:timeout) { 5000 }
-    @retries = options.fetch(:retries) { 0 }
+  CONFIGURATION_VERSION = {
+    Snmpjr::Version::V2C => Snmpjr::ConfigurationV2C,
+    Snmpjr::Version::V3 => Snmpjr::ConfigurationV3
+  }
 
-    @target = Snmpjr::Target.new.create(host: @host,
-                                       port: @port,
-                                       community: @community,
-                                       timeout: @timeout,
-                                       retries: @retries
-                                      )
+  def initialize version
+    @version = version
+  end
 
-    @max_oids_per_request = options.fetch(:max_oids_per_request) { 30 }
+  def configuration
+    @configuration ||= CONFIGURATION_VERSION.fetch(@version).new
   end
 
-  def get oids
-    getter = Snmpjr::Getter.new(target: @target, max_oids_per_request: @max_oids_per_request)
+  def configure
+    yield(configuration) if block_given?
+    self
+  end
 
-    if oids.is_a?(String)
-      getter.get oids
-    elsif oids.is_a?(Array)
-      getter.get_multiple oids
-    else
-      raise ArgumentError.new 'You can request a single Oid using a String, or multiple using an Array'
-    end
+  def get oids
+    Snmpjr::Getter.new(
+      session: configuration.create_session,
+      target: configuration.create_target,
+      pdu: configuration.create_pdu,
+      config: configuration
+    ).get Array(oids)
   end
 
   def walk oid
-    if oid.is_a?(String)
-      Snmpjr::Walker.new(target: @target).walk Snmpjr::Wrappers::SMI::OID.new(oid)
-    else
-      raise ArgumentError.new 'The oid needs to be passed in as a String'
-    end
+    Snmpjr::Walker.new(
+      session: configuration.create_session,
+      target: configuration.create_target,
+      pdu: configuration.create_pdu
+    ).walk Snmpjr::Wrappers::SMI::OID.new(oid.to_s)
   end
-
 end

data/snmpjr.gemspec

@@ -5,7 +5,7 @@ require 'snmpjr/version'
 
 Gem::Specification.new do |spec|
   spec.name          = 'snmpjr'
-  spec.version       = Snmpjr::VERSION
+  spec.version       = '0.3.0'
   spec.authors       = ['Zen Kyprianou']
   spec.email         = ['zen@kyprianou.eu']
   spec.summary       = 'Simple SNMP interface for JRuby'

data/spec/integration/{snmpjr_get_spec.rb → snmp_v2c/snmpjr_get_spec.rb}

@@ -1,12 +1,19 @@
 require 'snmpjr'
 require 'snmpjr/response'
-require 'snmpjr/target_timeout_error'
+require 'snmpjr/session_v2c'
 
-describe "snmpjr" do
+describe "snmpjr for snmp v2c" do
 
   describe 'GET' do
+    subject { Snmpjr.new(Snmpjr::Version::V2C) }
+
     context 'when the host is reachable' do
-      subject { Snmpjr.new(host: 'demo.snmplabs.com', port: 161, community: 'public') }
+      before do
+        subject.configure do |config|
+          config.host = 'demo.snmplabs.com'
+          config.community = 'public'
+        end
+      end
 
       it 'can perform a simple synchronous get request on an snmp agent' do
         expect(subject.get '1.3.6.1.2.1.1.1.0').to eq Snmpjr::Response.new(oid: '1.3.6.1.2.1.1.1.0', value: 'SunOS zeus.snmplabs.com 4.1.3_U1 1 sun4m')
@@ -18,7 +25,7 @@ describe "snmpjr" do
         expect(subject.get ['1.3.6.1.2.1.1.1.0', '1.3.6.1.2.1.1.5.0']).to eq expected
       end
 
-      context "when an invalid oid is requested" do
+     context "when an invalid oid is requested" do
 
         let(:expected) { [Snmpjr::Response.new(oid: '1.3.6.1.2.1.1.5', error: 'noSuchInstance'),
                           Snmpjr::Response.new(oid: '1.3.6.1.2.1.1.5.0', value: 'zeus.snmplabs.com')] }
@@ -30,7 +37,13 @@ describe "snmpjr" do
     end
 
     context 'when the host is unreachable' do
-      subject { Snmpjr.new(host: 'example.com', port: 161, community: 'public', timeout: 50) }
+      before do
+        subject.configure do |config|
+          config.host = 'demo.snmplabs.com'
+          config.community = 'public'
+          config.timeout = 50
+        end
+      end
 
       it 'the request times out after 5 seconds' do
         expect{

data/spec/integration/{snmpjr_walk_spec.rb → snmp_v2c/snmpjr_walk_spec.rb}

@@ -1,18 +1,26 @@
 require 'snmpjr'
 require 'snmpjr/response'
-require 'snmpjr/target_timeout_error'
+require 'snmpjr/session_v2c'
 
-describe "snmpjr" do
+describe "snmpjr for snmp v2c" do
 
   describe 'WALK' do
+    subject { Snmpjr.new(Snmpjr::Version::V2C) }
+
     context 'when the host is reachable' do
-      subject { Snmpjr.new(host: 'demo.snmplabs.com', port: 161, community: 'public') }
+      before do
+        subject.configure do |config|
+          config.host = 'demo.snmplabs.com'
+          config.port = 161
+          config.community = 'public'
+        end
+      end
 
       it 'can perform a simple synchronous walk request on an snmp agent' do
         response = subject.walk '1.3.6.1.2.1.1'
         expect(response.count).to eq 11
         expect(response.first.to_s).to eq 'SunOS zeus.snmplabs.com 4.1.3_U1 1 sun4m'
-        expect(response.last.to_s).to match /^\d+\:\d+:\d+\.\d+$/
+        expect(response.last.to_s).to match(/^\d+\:\d+:\d+\.\d+$/)
       end
 
       context "when a non existent subtree is walked" do
@@ -23,7 +31,14 @@ describe "snmpjr" do
     end
 
     context 'when the host is unreachable' do
-      subject { Snmpjr.new(host: 'example.com', port: 161, community: 'public', timeout: 50) }
+      before do
+        subject.configure do |config|
+          config.host = 'demo.snmplabs.com'
+          config.port = 161
+          config.community = 'public'
+          config.timeout = 50
+        end
+      end
 
       it 'the request times out after 5 seconds' do
         expect{