snmp 1.3.1 → 1.3.2

data/lib/snmp.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Copyright (c) 2004-2014 David R. Halliday
 #

data/lib/snmp/agent.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Copyright (c) 2004-2014 David R. Halliday
 #

data/lib/snmp/ber.rb

@@ -1,4 +1,5 @@
 # encoding: ascii-8bit
+# frozen_string_literal: true
 #
 # Copyright (c) 2004-2014 David R. Halliday
 #
@@ -265,9 +266,9 @@ module SNMP
         else
           data = integer_to_octets(value)
           if value > 0 && data[0].ord > 0x7f
-            data = "\000" << data
+            data = "\000".dup << data
           elsif value < 0 && data[0].ord < 0x80
-            data = "\377" << data
+            data = "\377".dup << data
           end
         end
         encode_tlv(tag, data)
@@ -333,7 +334,7 @@ module SNMP
       def encode_object_id(value)
         raise InvalidObjectId, value.to_s if value.length < 1
         raise InvalidObjectId, value.to_s if value[0] > 2
-        data = ""
+        data = "".dup
         if (value.length > 1)
           raise InvalidObjectId if value[0] < 2 && value[1] > 40
           data << (40 * value[0] + value[1]).chr

data/lib/snmp/manager.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Copyright (c) 2004-2014 David R. Halliday
 #

data/lib/snmp/mib.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Copyright (c) 2004-2014 David R. Halliday
 #

data/lib/snmp/options.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Copyright (c) 2004-2014 David R. Halliday
 #

data/lib/snmp/pdu.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Copyright (c) 2004-2014 David R. Halliday
 #
@@ -179,8 +180,8 @@ module SNMP
     def error_status=(status)
       @error_status = ERROR_STATUS_CODE[status]
       unless @error_status
-        if status.respond_to?(:to_int) && ERROR_STATUS_NAME[status.to_int]
-          @error_status = status
+        if status.respond_to?(:to_int)
+          @error_status = status.to_int
         else
           raise InvalidErrorStatus, status.to_s
         end
@@ -188,7 +189,7 @@ module SNMP
     end
 
     def error_status
-      ERROR_STATUS_NAME[@error_status]
+      ERROR_STATUS_NAME[@error_status] || @error_status
     end
 
     def encode_pdu(pdu_tag)

data/lib/snmp/varbind.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Copyright (c) 2004-2014 David R. Halliday
 #
@@ -63,7 +64,7 @@ module SNMP
     end
 
     def encode
-      varbind_data = ""
+      varbind_data = "".dup
       self.each do |varbind|
         varbind_data << varbind.encode
       end
@@ -343,7 +344,7 @@ module SNMP
         if parts.length != 4
           raise InvalidIpAddress, "Expected four octets separated by dots, not #{ip_string.inspect}"
         end
-        value_data = ""
+        value_data = "".dup
         parts.each do |s|
           octet = s.to_i
           raise InvalidIpAddress, "Octets cannot be greater than 255: #{ip_string.inspect}" if octet > 255

data/lib/snmp/version.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module SNMP
-  VERSION = "1.3.1"
+  VERSION = "1.3.2"
 end

data/test/test_ber.rb

@@ -1,4 +1,5 @@
 # encoding: ascii-8bit
+# frozen_string_literal: true
 
 require 'minitest/autorun'
 require 'snmp/varbind'
@@ -39,7 +40,7 @@ class ASN1_Test < Minitest::Test
 
   # Decode TLV data with long-format length field
   def test_decode_tlv_long
-    long_data = ""; 128.times { |i| long_data << i.chr }
+    long_data = "".dup; 128.times { |i| long_data << i.chr }
     tag, value, data = decode_tlv("\001\201\200" + long_data)
     assert_equal(1, tag)
     assert_equal(long_data, value)
@@ -48,7 +49,7 @@ class ASN1_Test < Minitest::Test
 
   # Long format with extra bytes - use four bytes for length
   def test_decode_tlv_long_extra
-    long_data = ""; 129.times { |i| long_data << i.chr }
+    long_data = "".dup; 129.times { |i| long_data << i.chr }
     tag, value, data = decode_tlv("\001\204\000\000\000\201" + long_data + "\123\123\123")
     assert_equal(1, tag)
     assert_equal(long_data, value)
@@ -227,12 +228,12 @@ class ASN1_Test < Minitest::Test
   end
 
   def test_encode_object_id
-    assert_equal("\006\001" << 80.chr, encode_object_id([2]))
+    assert_equal("\006\001".dup << 80.chr, encode_object_id([2]))
     assert_equal("\006\001\000", encode_object_id([0,0]))
     assert_equal("\006\001+", encode_object_id([1,3]))
     assert_equal("\006\002+\006", encode_object_id([1,3,6]))
     assert_equal("\006\003+\202\001", encode_object_id([1,3,257]))
-    assert_equal("\006\003" << 82.chr << "\202\001", encode_object_id([2,2,257]))
+    assert_equal("\006\003".dup << 82.chr << "\202\001", encode_object_id([2,2,257]))
     assert_raises(BER::InvalidObjectId) { encode_object_id([3,2,257]) }
     assert_raises(BER::InvalidObjectId) { encode_object_id([]) }
 

data/test/test_manager.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'minitest/autorun'
 require 'snmp/manager'
 

data/test/test_mib.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'minitest/autorun'
 require 'snmp/mib'
 

data/test/test_pdu.rb

@@ -1,4 +1,5 @@
 # encoding: ascii-8bit
+# frozen_string_literal: true
 
 require 'snmp/pdu'
 require 'minitest/autorun'
@@ -117,7 +118,12 @@ class TestProtocol < Minitest::Test
     request.error_status = 2
     assert_equal(:noSuchName, request.error_status)
 
-    assert_raises(InvalidErrorStatus) {request.error_status = 42}
+    request.error_status = 42
+    assert_equal(42, request.error_status)
+
+    assert_raises(InvalidErrorStatus) {request.error_status = "myErrorString"}
+    
+    assert_raises(InvalidErrorStatus) {request.error_status = :myErrorSymbol}
   end
 
   def test_snmpv2_trap
@@ -184,4 +190,12 @@ class TestProtocol < Minitest::Test
     assert_equal(0, pdu.varbind_list.length)
   end
 
+  def test_response_pdu_unknown_error
+    pdu = Response.new(2147483647, VarBindList.new, 6883501, 0)
+    assert_equal("\xA2\x10\x02\x04\x7F\xFF\xFF\xFF\x02\x03\x69\x08\xAD\x02\x01\x00\x30\x00", pdu.encode)
+
+    encoded = Message.new(:SNMPv2c, "public", pdu).encode
+    pdu = Message.decode(encoded).pdu
+    assert_equal(6883501, pdu.error_status)
+  end
 end

data/test/test_retry.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'minitest/autorun'
 require 'snmp'
 

data/test/test_smi.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'minitest/autorun'
 
 begin

data/test/test_varbind.rb

@@ -1,4 +1,5 @@
 # encoding: ascii-8bit
+# frozen_string_literal: true
 
 require 'snmp/varbind'
 require 'minitest/autorun'

data/test/test_walk.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'snmp'
 require 'minitest/autorun'
 require 'yaml'

metadata

@@ -1,15 +1,71 @@
 --- !ruby/object:Gem::Specification
 name: snmp
 version: !ruby/object:Gem::Version
-  version: 1.3.1
+  version: 1.3.2
 platform: ruby
 authors:
 - Dave Halliday
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-02 00:00:00.000000000 Z
-dependencies: []
+date: 2019-06-20 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rdoc
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: A Ruby implementation of SNMP (the Simple Network Management Protocol).
 email: hallidave@gmail.com
 executables: []
@@ -339,8 +395,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: A Ruby implementation of SNMP (the Simple Network Management Protocol).