snitch_reporting 1.2.1 → 1.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6a1aa5a3caefa942217670a6afbf15688875a996ec9e3b2991b843a6e415e08e
-  data.tar.gz: 496da79e68c0c376b4a073c5830504c7822bd90d200218e0687db1b8397dc6dd
+  metadata.gz: 9f9dd6556f79b56caaf6baade6c7bd4b1cbb6536ac5b92b03186ee3551f4ffcf
+  data.tar.gz: d6447f72373880ef558c1f996532c3afe518e3777be1ac55a35ed22a02428b3b
 SHA512:
-  metadata.gz: f0ccd94e6296060d68498c9c1694562eec6cd2a0b7e20773d35f5b91966e7ebda607e9b170be918fd8528502caafcbe38084ebfd79440ea6363d6f02db3abbbc
-  data.tar.gz: 8ca4544b0990ba43908da155a77acad9f735b69bba53298ef4d5ba97e3a95e2382d4bd74ab36f462f080ff7c760d7f99baa4001d8de177f54112db664e1484bc
+  metadata.gz: '09bc2d5bd44d91588b2d79d8cb70fcbb0663f3530ed0c024832510abd668923c93a56c2c64abb59d17eba0681861fd11ac7fec67fda1cc106256f9fbc703d83b'
+  data.tar.gz: 7a4118612f92924279cc1f057cfe4e1018fe6bc414b1d196a91b891cca8c53a655a3b0a0b01ee1a26d2ffd44534af5751e0e51d8f48aa5c8bbc929a7fab92fec

data/app/controllers/snitch_reporting/snitch_reports_controller.rb

@@ -7,6 +7,7 @@ class ::SnitchReporting::SnitchReportsController < ApplicationController
   layout "application"
 
     def index
+      ::SnitchReporting::SnitchReport.warn("Error", some: :data)
       @reports = ::SnitchReporting::SnitchReport.order("last_occurrence_at DESC NULLS LAST").page(params[:page]).per(params[:per] || 25)
 
       # set_report_preferences

data/app/models/snitch_reporting/snitch_report.rb

@@ -67,7 +67,8 @@ class SnitchReporting::SnitchReport < ApplicationRecord
       always_notify = arg_hash.delete(:always_notify)
 
       report_title = retrieve_report_title(base_exception, arg_hash, arg_values)
-      report = retrieve_or_create_existing_report(log_level, santize_title(report_title), env, base_exception, arg_hash)
+      report_error = retrieve_error_string(base_exception, arg_hash, arg_values)
+      report = retrieve_or_create_existing_report(log_level, santize_title(report_title), santize_title(report_error), env, base_exception, arg_hash)
       return SnitchReporting::SnitchReport.error("Failed to save report.", report.errors.full_messages) unless report.persisted?
 
       report_data = gather_report_data(env, exceptions, arg_hash, arg_values)
@@ -86,7 +87,8 @@ class SnitchReporting::SnitchReport < ApplicationRecord
       occurrence
     rescue StandardError => ex
       env ||= {}
-      SnitchReporting::SnitchReport.fatal("Failed to create report. (#{ex.class})", env.inspect, ex.inspect)
+      binding.pry
+      SnitchReporting::SnitchReport.fatal("Failed to create report. (#{ex.class})", env.to_s, ex.to_s)
     end
 
     def format_args(args)
@@ -183,6 +185,15 @@ class SnitchReporting::SnitchReport < ApplicationRecord
       report_title
     end
 
+    def retrieve_error_string(exception, arg_hash, arg_values)
+      report_error ||= arg_values&.find { |arg_value| arg_value.is_a?(String) }
+      report_error ||= (arg_hash[:klass] || arg_hash[:class]).presence
+      report_error ||= arg_hash&.first.to_s.presence
+      report_error ||= trace_from_exception(exception).find { |row| row.include?("/app/") }
+      report_error ||= exception.try(:class).presence
+      report_error
+    end
+
     def add_leftover_objects_to_report_data(report_data, exceptions, arg_hash, arg_values)
       report_data[:exceptions] = exceptions.map { |ex| "#{ex.try(:class)}: #{ex.try(:message)}" } if exceptions.present?
       report_data.merge!(arg_hash)
@@ -201,10 +212,10 @@ class SnitchReporting::SnitchReport < ApplicationRecord
       report_title.to_s.gsub(regex_find_numbers_and_words_with_numbers, "").presence
     end
 
-    def retrieve_or_create_existing_report(log_level, sanitized_title, env, exception, arg_hash)
+    def retrieve_or_create_existing_report(log_level, sanitized_title, sanitized_error_msg, env, exception, arg_hash)
       report_identifiable_data = {
-        error:     (exception.try(:class) || sanitized_title.presence).to_s,
-        message:   sanitized_title.presence,
+        error:     sanitized_title.presence,
+        message:   sanitized_error_msg.presence,
         log_level: log_level,
         klass:     env&.dig(:"action_controller.instance").try(:class).to_s.split("::").last&.gsub("Controller", ""),
         action:    env&.dig(:"action_controller.instance").try(:action_name)

data/lib/snitch_reporting/version.rb

@@ -1,3 +1,3 @@
 module SnitchReporting
-  VERSION = '1.2.1'
+  VERSION = '1.2.2'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: snitch_reporting
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.2.2
 platform: ruby
 authors:
 - Rocco Nicholls