snfoil 0.5.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8243d9d711a164c99818bd9217d002a4bbeda113d6c68d45dad064bea6a04618
-  data.tar.gz: 53c8ee7b0b44bf7411eb98aebb23793ebf5dd69fab16a278abb2895062edabc6
+  metadata.gz: 47df13555f0efd4bd9ad506a79f9af2d3955f209bd4fabc0e086f6f5e7b7d953
+  data.tar.gz: 74a0a9556cfeed6b434ba40319b7bea0329ddffbcd31f3155aec2b37f0474b71
 SHA512:
-  metadata.gz: 25527b584b0d1c3360ef226ecf16a4934ae209bbc96aed912f4131b056303a16e4bdbdfd801fb0adb2b1d2b47ec120e021990c764fb9ca34886269d68804d921
-  data.tar.gz: 67e8a71e82d49cc5fe3aa45b4fad9140cb234f3d48151af1930279b9109603dcece1bbdbecfe8dd8fe1d99c11252e01ae454435184b3e4e8c34754f6b877de8a
+  metadata.gz: d76ecf6affbc2be179ccd3fef9c28941f4217ff6ad4a0b708605749cf2f89b0108e409fd51cd792fd53915e1f4db00324cce3f9aa430dadd5a6b42315d432b21
+  data.tar.gz: 2acfb8773a4f31bce92c81b66eb9024800990a10804cf9e7d9d72a53ea0bc631b4b9f5ed44af5e7218c668d55c634ae43b5d919e91af32015415326f1994bece

data/TODO.md

@@ -0,0 +1,5 @@
+# TODO
+## Tests
+### Contexts
+- Add tests for propagation of :authorize in options aggregate
+- Add tests for Create now using Build

data/lib/sn_foil.rb

@@ -10,6 +10,8 @@ require_relative 'sn_foil/contexts/destroy_context'
 require_relative 'sn_foil/context'
 require_relative 'sn_foil/policy'
 require_relative 'sn_foil/searcher'
+require_relative 'sn_foil/adapters/orms/base_adapter'
+require_relative 'sn_foil/adapters/orms/active_record'
 require 'active_support/core_ext/module/attribute_accessors'
 require 'logger'
 

data/lib/sn_foil/adapters/orms/active_record.rb

@@ -1,11 +1,13 @@
 # frozen_string_literal: true
 
+require_relative 'base_adapter'
+
 module SnFoil
   module Adapters
     module ORMs
       class ActiveRecord < SnFoil::Adapters::ORMs::BaseAdapter
-        def new(*params)
-          self.class.new(__getobj__.new(*params))
+        def new(**params)
+          self.class.new(__getobj__.new(params))
         end
 
         def all
@@ -21,9 +23,13 @@ module SnFoil
           __getobj__.destroyed?
         end
 
-        def attributes=(*attributes)
+        def attributes=(attributes)
           __getobj__.attributes = attributes
         end
+
+        def is_a?(klass)
+          __getobj__.class.object_id == klass.object_id
+        end
       end
     end
   end

data/lib/sn_foil/adapters/orms/base_adapter.rb

@@ -4,7 +4,7 @@ module SnFoil
   module Adapters
     module ORMs
       class BaseAdapter < SimpleDelegator
-        def new(*_params)
+        def new(**_params)
           raise NotImplementedError, '#new not implemented in adapter'
         end
 
@@ -20,7 +20,7 @@ module SnFoil
           raise NotImplementedError, '#destroy not implemented in adapter'
         end
 
-        def attributes=(**_attributes)
+        def attributes=(_attributes)
           raise NotImplementedError, '#attributes= not implemented in adapter'
         end
       end

data/lib/sn_foil/contexts/build_context.rb

@@ -2,7 +2,6 @@
 
 require 'active_support/concern'
 require_relative './setup_context'
-require_relative './change_context'
 
 module SnFoil
   module Contexts
@@ -11,33 +10,58 @@ module SnFoil
 
       included do
         include SetupContext
-        include ChangeContext
       end
 
       class_methods do
+        attr_reader :i_setup_build_hooks
+
         def build(params:, entity: nil, **options)
           new(entity).build(**options, params: params)
         end
+
+        def setup_build(method = nil, **options, &block)
+          raise ArgumentError, '#setup_build requires either a method name or a block' if method.nil? && block.nil?
+
+          (@i_setup_build_hooks ||= []) << { method: method, block: block, if: options[:if], unless: options[:unless] }
+        end
       end
 
       def setup_build_object(params: {}, object: nil, **options)
-        SnFoil.logger.info 'Warning: Using build bypasses authorize.  It is safer to interact with models through create' unless ENV['ISTEST']
-        return wrap_object(object) if object
+        object = if object
+                   wrap_object(object)
+                 else
+                   klass = options.fetch(:model) { model }
+                   wrap_object(klass).new
+                 end
 
-        klass = options.fetch(:model) { model }
-        options.merge! object: wrap_object(klass).new(**params)
+        object.attributes = params
+        options.merge! object: object
       end
 
       def build(**options)
         options[:action] = :build
-        options = setup_build(setup_change(**options))
+        options = before_setup_build_object(**options)
         options = setup_build_object(**options)
+        authorize(options[:object], options[:authorize], **options) if options[:authorize]
         unwrap_object(options[:object])
       end
 
       def setup_build(**options)
         options
       end
+
+      def setup_build_hooks
+        self.class.i_setup_build_hooks || []
+      end
+
+      private
+
+      def before_setup_build_object(**options)
+        options = setup(**options)
+        options = setup_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
+        options = setup_build(**options)
+        setup_build_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
+      end
     end
   end
 end

data/lib/sn_foil/contexts/create_context.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require 'active_support/concern'
-require_relative './setup_context'
 require_relative './change_context'
 
 module SnFoil
@@ -10,8 +9,10 @@ module SnFoil
       extend ActiveSupport::Concern
 
       included do
-        include SetupContext
+        include BuildContext
         include ChangeContext
+
+        alias_method :setup_create_object, :setup_build_object
       end
 
       class_methods do
@@ -52,25 +53,14 @@ module SnFoil
         end
       end
 
-      def setup_create_object(params: {}, object: nil, **options)
-        object = if object
-                   wrap_object(object)
-                 else
-                   klass = options.fetch(:model) { model }
-                   wrap_object(klass).new
-                 end
-
-        object.attributes = params
-        options.merge! object: object
-      end
-
       def create(**options)
         options[:action] = :create
+        options = before_setup_build_object(**options)
         options = before_setup_create_object(**options)
         options = setup_create_object(**options)
-        authorize(options[:object], :create?, **options)
+        authorize(options[:object], options.fetch(:authorize) { :create? }, **options)
         options = create_hooks(**options)
-        unwrap_object(options[:object])
+        options[:object]
       end
 
       def setup_create(**options)
@@ -116,18 +106,18 @@ module SnFoil
       private
 
       def before_setup_create_object(**options)
-        options = setup_create(**options)
-        options = setup_create_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
         options = setup_change(**options)
         options = setup_change_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
-        options = setup(**options)
-        setup_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
+        options = setup_create(**options)
+        setup_create_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
       end
 
       # This method is private to help protect the order of execution of hooks
       def create_hooks(options)
         options = before_create_save(**options)
-        options = if options[:object].save
+        save_successful = options[:object].save
+        options.merge!(object: unwrap_object(options[:object]))
+        options = if save_successful
                     after_create_save_success(**options)
                   else
                     after_create_save_failure(**options)
@@ -136,31 +126,31 @@ module SnFoil
       end
 
       def before_create_save(**options)
-        options = before_create(**options)
-        options = before_create_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
         options = before_change(**options)
-        before_change_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
+        options = before_change_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
+        options = before_create(**options)
+        before_create_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
       end
 
       def after_create_save(**options)
-        options = after_create(**options)
-        options = after_create_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
         options = after_change(**options)
-        after_change_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
+        options = after_change_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
+        options = after_create(**options)
+        after_create_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
       end
 
       def after_create_save_success(**options)
-        options = after_create_success(**options)
-        options = after_create_success_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
         options = after_change_success(**options)
-        after_change_success_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
+        options = after_change_success_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
+        options = after_create_success(**options)
+        after_create_success_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
       end
 
       def after_create_save_failure(**options)
-        options = after_create_failure(**options)
-        options = after_create_failure_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
         options = after_change_failure(**options)
-        after_change_failure_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
+        options = after_change_failure_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
+        options = after_create_failure(**options)
+        after_create_failure_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
       end
     end
   end

data/lib/sn_foil/contexts/destroy_context.rb

@@ -62,9 +62,9 @@ module SnFoil
         options[:action] = :destroy
         options = before_setup_destroy_object(**options)
         options = setup_destroy_object(**options)
-        authorize(options[:object], :destroy?, **options)
+        authorize(options[:object], options.fetch(:authorize) { :destroy? }, **options)
         options = destroy_hooks(**options)
-        unwrap_object(options[:object])
+        options[:object]
       end
 
       def setup_destroy(**options)
@@ -110,18 +110,20 @@ module SnFoil
       private
 
       def before_setup_destroy_object(**options)
-        options = setup_destroy(**options)
-        options = setup_destroy_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
+        options = setup(**options)
+        options = setup_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
         options = setup_change(**options)
         options = setup_change_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
-        options = setup(**options)
-        setup_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
+        options = setup_destroy(**options)
+        setup_destroy_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
       end
 
       # This method is private to help protect the order of execution of hooks
       def destroy_hooks(options)
         options = before_destroy_save(options)
-        options = if options[:object].destroy
+        destroy_successful = options[:object].destroy
+        options.merge!(object: unwrap_object(options[:object]))
+        options = if destroy_successful
                     after_destroy_save_success(options)
                   else
                     after_destroy_save_failure(options)
@@ -130,31 +132,31 @@ module SnFoil
       end
 
       def before_destroy_save(options)
-        options = before_destroy(**options)
-        options = before_destroy_hooks.reduce(options) { |opts, hook| run_hook(hook, **opts) }
         options = before_change(**options)
-        before_change_hooks.reduce(options) { |opts, hook| run_hook(hook, **opts) }
+        options = before_change_hooks.reduce(options) { |opts, hook| run_hook(hook, **opts) }
+        options = before_destroy(**options)
+        before_destroy_hooks.reduce(options) { |opts, hook| run_hook(hook, **opts) }
       end
 
       def after_destroy_save(options)
-        options = after_destroy(**options)
-        options = after_destroy_hooks.reduce(options) { |opts, hook| run_hook(hook, **opts) }
         options = after_change(**options)
-        after_change_hooks.reduce(options) { |opts, hook| run_hook(hook, **opts) }
+        options = after_change_hooks.reduce(options) { |opts, hook| run_hook(hook, **opts) }
+        options = after_destroy(**options)
+        after_destroy_hooks.reduce(options) { |opts, hook| run_hook(hook, **opts) }
       end
 
       def after_destroy_save_success(options)
-        options = after_destroy_success(**options)
-        options = after_destroy_success_hooks.reduce(options) { |opts, hook| run_hook(hook, **opts) }
         options = after_change_success(**options)
-        after_change_success_hooks.reduce(options) { |opts, hook| run_hook(hook, **opts) }
+        options = after_change_success_hooks.reduce(options) { |opts, hook| run_hook(hook, **opts) }
+        options = after_destroy_success(**options)
+        after_destroy_success_hooks.reduce(options) { |opts, hook| run_hook(hook, **opts) }
       end
 
       def after_destroy_save_failure(options)
-        options = after_destroy_failure(**options)
-        options = after_destroy_failure_hooks.reduce(options) { |opts, hook| run_hook(hook, **opts) }
         options = after_change_failure(**options)
-        after_change_failure_hooks.reduce(options) { |opts, hook| run_hook(hook, **opts) }
+        options = after_change_failure_hooks.reduce(options) { |opts, hook| run_hook(hook, **opts) }
+        options = after_destroy_failure(**options)
+        after_destroy_failure_hooks.reduce(options) { |opts, hook| run_hook(hook, **opts) }
       end
     end
   end

data/lib/sn_foil/contexts/index_context.rb

@@ -54,10 +54,10 @@ module SnFoil
       private
 
       def before_setup_index(**options)
-        options = setup_index(**options)
-        options = setup_index_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
         options = setup(**options)
-        setup_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
+        options = setup_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
+        options = setup_index(**options)
+        setup_index_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
       end
     end
   end

data/lib/sn_foil/contexts/show_context.rb

@@ -51,10 +51,10 @@ module SnFoil
       private
 
       def before_setup_show(**options)
-        options = setup_show(**options)
-        options = setup_show_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
         options = setup(**options)
-        setup_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
+        options = setup_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
+        options = setup_show(**options)
+        setup_show_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
       end
     end
   end

data/lib/sn_foil/contexts/update_context.rb

@@ -56,7 +56,8 @@ module SnFoil
         raise ArgumentError, 'one of the following keywords is required: id, object' unless id || object
 
         object = wrap_object(object || scope.resolve.find(id))
-        authorize(object, :update?, **options)
+        authorize(object, options.fetch(:authorize) { :update? }, **options)
+
         object.attributes = params
         options.merge! object: object
       end
@@ -65,9 +66,9 @@ module SnFoil
         options[:action] = :update
         options = before_setup_update_object(**options)
         options = setup_update_object(**options)
-        authorize(options[:object], :update?, **options)
+        authorize(options[:object], options.fetch(:authorize) { :update? }, **options)
         options = update_hooks(**options)
-        unwrap_object(options[:object])
+        options[:object]
       end
 
       def setup_update(**options)
@@ -113,18 +114,20 @@ module SnFoil
       private
 
       def before_setup_update_object(**options)
-        options = setup_update(**options)
-        options = setup_update_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
+        options = setup(**options)
+        options = setup_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
         options = setup_change(**options)
         options = setup_change_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
-        options = setup(**options)
-        setup_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
+        options = setup_update(**options)
+        setup_update_hooks.reduce(options) { |opts, hook| run_hook(hook, opts) }
       end
 
       # This method is private to help protect the order of execution of hooks
       def update_hooks(options)
         options = before_update_save(options)
-        options = if options[:object].save
+        update_successful = options[:object].save
+        options.merge!(object: unwrap_object(options[:object]))
+        options = if update_successful
                     after_update_save_success(options)
                   else
                     after_update_save_failure(options)
@@ -133,31 +136,31 @@ module SnFoil
       end
 
       def before_update_save(options)
-        options = before_update(**options)
-        options = before_update_hooks.reduce(options) { |opts, hook| run_hook(hook, **opts) }
         options = before_change(**options)
-        before_change_hooks.reduce(options) { |opts, hook| run_hook(hook, **opts) }
+        options = before_change_hooks.reduce(options) { |opts, hook| run_hook(hook, **opts) }
+        options = before_update(**options)
+        before_update_hooks.reduce(options) { |opts, hook| run_hook(hook, **opts) }
       end
 
       def after_update_save(options)
-        options = after_update(**options)
-        options = after_update_hooks.reduce(options) { |opts, hook| run_hook(hook, **opts) }
         options = after_change(**options)
-        after_change_hooks.reduce(options) { |opts, hook| run_hook(hook, **opts) }
+        options = after_change_hooks.reduce(options) { |opts, hook| run_hook(hook, **opts) }
+        options = after_update(**options)
+        after_update_hooks.reduce(options) { |opts, hook| run_hook(hook, **opts) }
       end
 
       def after_update_save_success(options)
-        options = after_update_success(**options)
-        options = after_update_success_hooks.reduce(options) { |opts, hook| run_hook(hook, **opts) }
         options = after_change_success(**options)
-        after_change_success_hooks.reduce(options) { |opts, hook| run_hook(hook, **opts) }
+        options = after_change_success_hooks.reduce(options) { |opts, hook| run_hook(hook, **opts) }
+        options = after_update_success(**options)
+        after_update_success_hooks.reduce(options) { |opts, hook| run_hook(hook, **opts) }
       end
 
       def after_update_save_failure(options)
-        options = after_update_failure(**options)
-        options = after_update_failure_hooks.reduce(options) { |opts, hook| run_hook(hook, **opts) }
         options = after_change_failure(**options)
-        after_change_failure_hooks.reduce(options) { |opts, hook| run_hook(hook, **opts) }
+        options = after_change_failure_hooks.reduce(options) { |opts, hook| run_hook(hook, **opts) }
+        options = after_update_failure(**options)
+        after_update_failure_hooks.reduce(options) { |opts, hook| run_hook(hook, **opts) }
       end
     end
   end

data/lib/sn_foil/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SnFoil
-  VERSION = '0.5.0'
+  VERSION = '0.7.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: snfoil
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.7.0
 platform: ruby
 authors:
 - Matthew Howes
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-04-16 00:00:00.000000000 Z
+date: 2020-07-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -17,14 +17,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.1'
+        version: 5.2.4.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.1'
+        version: 5.2.4.3
 - !ruby/object:Gem::Dependency
   name: logger
   requirement: !ruby/object:Gem::Requirement
@@ -162,6 +162,7 @@ files:
 - CODE_OF_CONDUCT.md
 - README.md
 - Rakefile
+- TODO.md
 - lib/sn_foil.rb
 - lib/sn_foil/adapters/orms/active_record.rb
 - lib/sn_foil/adapters/orms/base_adapter.rb