snaptrade 3.0.14 → 3.0.16

data/spec/regression/all_account_positions_spec.rb

@@ -0,0 +1,86 @@
+require 'spec_helper'
+require 'json'
+
+describe 'All account positions response deserialization' do
+  let(:payload) do
+    JSON.parse(File.read(File.join(__dir__, 'fixtures/all_account_positions.json')))
+  end
+  let(:body) { JSON.generate(payload) }
+  let(:configuration) do
+    SnapTrade::Configuration.new.tap do |config|
+      config.host = 'https://sdk-test.invalid'
+      config.client_id = 'TEST_CLIENT'
+      config.consumer_key = 'TEST_KEY'
+    end
+  end
+  let(:api_client) { SnapTrade::ApiClient.new(configuration) }
+  let(:api) { SnapTrade::AccountInformationApi.new(api_client) }
+  let(:arguments) do
+    { user_id: 12345, user_secret: 'TEST_SECRET', account_id: 'TEST_ACCOUNT' }
+  end
+  let(:stubs) do
+    Faraday::Adapter::Test::Stubs.new do |stub|
+      stub.get('/accounts/TEST_ACCOUNT/positions/all') do
+        [200, { 'content-type' => 'application/json' }, body]
+      end
+    end
+  end
+  let(:connection) do
+    Faraday.new(url: configuration.base_url) { |conn| conn.adapter :test, stubs }
+  end
+
+  before do
+    allow(api_client).to receive(:connection).and_return(connection)
+  end
+
+  after do
+    stubs.verify_stubbed_calls
+  end
+
+  [:get_all_account_positions, :get_all_account_positions_with_http_info].each do |operation|
+    context operation.to_s do
+      let(:data) do
+        result = api.public_send(operation, **arguments)
+        if operation == :get_all_account_positions_with_http_info
+          parsed, status, headers, response = result
+          expect(status).to eq(200)
+          expect(headers['content-type']).to eq('application/json')
+          expect(response.body).to eq(body)
+          parsed
+        else
+          result
+        end
+      end
+
+      it 'returns the full response and both bond instruments from a populated HTTP 200 body' do
+        expect(data).to be_a(SnapTrade::AllAccountPositionsResponse)
+        expect(data.data_freshness.as_of).to eq(Time.utc(2026, 9, 8, 11, 2, 57))
+        expect(data.results.length).to eq(2)
+        expect(data.results.map(&:units)).to eq([70.0, 70.0])
+        expect(data.results.map(&:price)).to eq([99.768, 100.025])
+        expect(data.results.map(&:cost_basis)).to eq([97.51, 100.25])
+        expect(data.results.map(&:instrument)).to all(be_a(SnapTrade::OtherInstrument))
+        expect(data.results.map { |position| position.instrument.kind }).to eq(['bond', 'bond'])
+        expect(data.results.map { |position| position.instrument.symbol }).to eq(['912797SA6', '91282CJT9'])
+        expect(data.to_hash[:results].map { |position| position[:instrument][:kind] }).to eq(['bond', 'bond'])
+      end
+
+      it 'keeps a response object when there are no positions' do
+        payload['results'] = []
+
+        expect(data).to be_a(SnapTrade::AllAccountPositionsResponse)
+        expect(data.results).to eq([])
+        expect(data.data_freshness.as_of).to eq(Time.utc(2026, 9, 8, 11, 2, 57))
+      end
+
+      it 'retains instruments when bond and other positions appear together' do
+        payload['results'][1]['instrument']['kind'] = 'other'
+
+        expect(data).to be_a(SnapTrade::AllAccountPositionsResponse)
+        expect(data.results.map(&:instrument)).to all(be_a(SnapTrade::OtherInstrument))
+        expect(data.results.map { |position| position.instrument.kind }).to eq(['bond', 'other'])
+        expect(data.results.map { |position| position.instrument.symbol }).to eq(['912797SA6', '91282CJT9'])
+      end
+    end
+  end
+end

data/spec/regression/fixtures/all_account_positions.json

@@ -0,0 +1,33 @@
+{
+  "results": [
+    {
+      "instrument": {
+        "kind": "bond",
+        "id": "a7ade77d-74f4-4d8a-a1f8-1a582c2f4e3b",
+        "symbol": "912797SA6",
+        "raw_symbol": "912797SA6",
+        "description": "UNITED STATES TREAS BILLS ZERO CPN 0.00000% 10/01/2026",
+        "currency": "USD"
+      },
+      "units": "70",
+      "price": "99.768",
+      "cost_basis": "97.51",
+      "currency": "USD"
+    },
+    {
+      "instrument": {
+        "kind": "bond",
+        "id": "e538a57c-2bb8-40e2-812d-d07ee525b1cf",
+        "symbol": "91282CJT9",
+        "raw_symbol": "91282CJT9",
+        "description": "UNITED STATES TREAS SER AJ-2027 4.00000% 01/15/2027 NTS NOTE",
+        "currency": "USD"
+      },
+      "units": "70",
+      "price": "100.025",
+      "cost_basis": "100.25",
+      "currency": "USD"
+    }
+  ],
+  "data_freshness": { "as_of": "2026-09-08T11:02:57Z" }
+}

data/spec/regression/request_signing_spec.rb

@@ -0,0 +1,46 @@
+require 'spec_helper'
+
+describe SnapTrade::ApiClientCustom do
+  let(:configuration) do
+    SnapTrade::Configuration.new.tap { |config| config.consumer_key = 'TEST_KEY' }
+  end
+  let(:request) do
+    Faraday::Request.create(:post) do |req|
+      req.path = path
+      req.body = body
+      req.headers = {}
+      req.params = {
+        clientId: 'TEST_CLIENT',
+        userId: 'TEST_USER',
+        userSecret: 'TEST_SECRET'
+      }
+    end
+  end
+
+  before do
+    allow(Time).to receive(:now).and_return(Time.at(1_700_000_000))
+  end
+
+  context 'without a request body' do
+    let(:path) { '/accounts/TEST_ACCOUNT/positions/all' }
+    let(:body) { nil }
+
+    it 'preserves the existing signature bytes' do
+      described_class.request_hook(request, configuration)
+
+      expect(request.params[:timestamp]).to eq(1_700_000_000)
+      expect(request.headers[:Signature]).to eq('R7iYdxifiq/4joFEkOkaQj9QiW8LsgxmSDXco44gqtk=')
+    end
+  end
+
+  context 'with unsorted JSON body keys' do
+    let(:path) { '/orders' }
+    let(:body) { '{"z":2,"a":1}' }
+
+    it 'preserves body key sorting and the existing signature bytes' do
+      described_class.request_hook(request, configuration)
+
+      expect(request.headers[:Signature]).to eq('Zs3cXbvLmIEVPi69lHV6rah6wZ1phfk9cK6kbTYnSf4=')
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,7 +1,7 @@
 =begin
 #SnapTrade
 
-#Connect brokerage accounts to your app for live positions and trading
+#Connect brokerage accounts to your app for live positions and trading.  ## Rate limiting  Two limits apply to requests signed with your `clientId`. The stricter one wins, and exceeding either returns `429 Too Many Requests`.  - **Customer-level** — 250 requests/minute by default, scoped to your   `clientId` and applied across all endpoints. Reported in   `X-RateLimit-Limit`, `X-RateLimit-Remaining` and `X-RateLimit-Reset`. - **Account-level** — 10 requests/minute per account, scoped to   (`clientId`, `accountId`). All covered operations for one account draw on   the same bucket — reading balances and reading positions share it — and   enforcement does not depend on the HTTP method, so updating an account   consumes the same bucket as reading it. Only enforced for Personal users,   and only for integrations it has been rolled out to — it is not yet in   force for every Personal integration. It also does not apply on every   operation that documents a 429 below. Where it applies it is reported in   `X-RateLimit-Account-Limit`, `X-RateLimit-Account-Remaining` and   `X-RateLimit-Account-Reset`. Do not read the absence of those headers as   proof the limit is off — some configurations omit the rate limit headers   while still enforcing the limit, so header absence tells you nothing   about your allowance.  On a 429, `X-RateLimit-Remaining: 0` means you hit the customer-level limit and `X-RateLimit-Account-Remaining: 0` means the account-level one. Wait for the corresponding `*-Reset` value (seconds) before retrying, or fall back to exponential backoff with jitter.  Not every 429 is explained by those headers. A separate per-authenticated-user limit, reported in no `X-RateLimit-*` header, covers OAuth-authenticated requests and signed requests in configurations where the customer-level limit is not in effect — on the operations that use the default throttles. A few operations override those and are governed by the customer-level limit alone. The two do not stack: a signed request governed by the customer-level limit above is not additionally subject to the per-user one. If a 429 arrives with no header at zero — or with no `X-RateLimit-*` headers at all — honour `Retry-After` and back off. Treat the remaining counts as a hint, not a guarantee that the next request will succeed.  Because the customer-level limit applies everywhere, any signed request can return 429.  **OAuth-authenticated requests are an exception.** They are not subject to the customer-level limit and do not receive `X-RateLimit-Limit`, `X-RateLimit-Remaining` or `X-RateLimit-Reset` — do not wait on those headers or design around a customer-level allowance on this path. The account-level limit still applies to them on the account-data endpoints above, reported in the `X-RateLimit-Account-*` headers. On operations using the default throttles the per-user limit above applies to them as well, so an OAuth request can be rejected while the account headers still show capacity; on the few operations that override those throttles, OAuth callers have no per-user ceiling at all. Drive retries from `Retry-After` and exponential backoff with jitter rather than from the headers.  See https://docs.snaptrade.com/docs/ratelimiting. 
 
 The version of the OpenAPI document: 1.0.0
 Contact: api@snaptrade.com