snake-eyes 1.0.0 → 2.0.0

data/spec/nested_attributes_spec.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe 'param\'s nested_attributes option:', type: :controller do
-
-  context "when it is empty" do
+  context 'when it is empty' do
     controller ApplicationController do
       def index
         @params_snake_case = params(nested_attributes: {})
@@ -11,34 +12,31 @@ RSpec.describe 'param\'s nested_attributes option:', type: :controller do
       end
     end
 
-    it "then does not attempt to add the _attributes suffix" do
-      get :index, {
+    it 'then does not attempt to add the _attributes suffix' do
+      # noinspection RubyStringKeysInHashInspection
+      get :index,
           'string' => 'string',
           'boolean' => true,
-          'simpleArray' => [
-              "0", "1", "2"
-          ],
+          'simpleArray' => %w[0 1 2],
           'shallowObject' => {
-              'nestedAttribute' => 'value'
+            'nestedAttribute' => 'value'
           }
-      }
 
-      expect(assigns(:params_snake_case)).to eql({
-          "controller" => "anonymous",
-          "action" => "index",
-          'string' => 'string',
-          'boolean' => true,
-          'simple_array' => [
-              "0", "1", "2"
-          ],
-          'shallow_object' => {
-              'nested_attribute' => 'value'
-          }
-      })
+      # noinspection RubyStringKeysInHashInspection
+      expect(assigns(:params_snake_case)).to eql(
+        'controller' => 'anonymous',
+        'action' => 'index',
+        'string' => 'string',
+        'boolean' => true,
+        'simple_array' => %w[0 1 2],
+        'shallow_object' => {
+          'nested_attribute' => 'value'
+        }
+      )
     end
   end
 
-  context "when it is nil" do
+  context 'when it is nil' do
     controller ApplicationController do
       def index
         @params_snake_case = params(nested_attributes: nil)
@@ -47,82 +45,79 @@ RSpec.describe 'param\'s nested_attributes option:', type: :controller do
       end
     end
 
-    it "then does not attempt to add the _attributes suffix" do
-      get :index, {
+    it 'then does not attempt to add the _attributes suffix' do
+      # noinspection RubyStringKeysInHashInspection
+      get :index,
           'string' => 'string',
           'boolean' => true,
-          'simpleArray' => [
-              "0", "1", "2"
-          ],
+          'simpleArray' => %w[0 1 2],
           'shallowObject' => {
-              'nestedAttribute' => 'value'
+            'nestedAttribute' => 'value'
           }
-      }
 
-      expect(assigns(:params_snake_case)).to eql({
-          "controller" => "anonymous",
-          "action" => "index",
-          'string' => 'string',
-          'boolean' => true,
-          'simple_array' => [
-              "0", "1", "2"
-          ],
-          'shallow_object' => {
-              'nested_attribute' => 'value'
-          }
-      })
+      # noinspection RubyStringKeysInHashInspection
+      expect(assigns(:params_snake_case)).to eql(
+        'controller' => 'anonymous',
+        'action' => 'index',
+        'string' => 'string',
+        'boolean' => true,
+        'simple_array' => %w[0 1 2],
+        'shallow_object' => {
+          'nested_attribute' => 'value'
+        }
+      )
     end
   end
 
-  context "when it points to an attribute that is not a nested object" do
+  context 'when it points to an attribute that is not a nested object' do
     controller ApplicationController do
       def index
-        @params_snake_case = params(nested_attributes: [ :string ])
+        @params_snake_case = params(nested_attributes: [:string])
 
         render nothing: true
       end
     end
 
-    it "then adds the _attributes suffix" do
-      get :index, {
-          'string' => 'string',
-      }
+    it 'then adds the _attributes suffix' do
+      get :index,
+          'string' => 'string'
 
-      expect(assigns(:params_snake_case)).to eql({
-          "controller" => "anonymous",
-          "action" => "index",
-          'string_attributes' => 'string',
-      })
+      expect(assigns(:params_snake_case)).to eql(
+        'controller' => 'anonymous',
+        'action' => 'index',
+        'string_attributes' => 'string'
+      )
     end
   end
 
-  context "when it points to an attribute that is a nested object" do
+  context 'when it points to an attribute that is a nested object' do
     controller ApplicationController do
       def index
-        @params_snake_case = params(nested_attributes: [ :shallow_object ])
+        @params_snake_case = params(nested_attributes: [:shallow_object])
 
         render nothing: true
       end
     end
 
-    it "then adds the _attributes suffix" do
-      get :index, {
+    it 'then adds the _attributes suffix' do
+      # noinspection RubyStringKeysInHashInspection
+      get :index,
           'shallowObject' => {
-              'nestedAttribute' => 'value'
+            'nestedAttribute' => 'value'
           }
-      }
 
-      expect(assigns(:params_snake_case)).to eql({
-          "controller" => "anonymous",
-          "action" => "index",
-          'shallow_object_attributes' => {
-              'nested_attribute' => 'value'
-          }
-      })
+      # noinspection RubyStringKeysInHashInspection
+      expect(assigns(:params_snake_case)).to eql(
+        'controller' => 'anonymous',
+        'action' => 'index',
+        'shallow_object_attributes' => {
+          'nested_attribute' => 'value'
+        }
+      )
     end
   end
 
-  context "when it points to a deeply nested attribute" do
+  context 'when it points to a deeply nested attribute' do
     controller ApplicationController do
       def index
         @params_snake_case = params(nested_attributes: { shallow_object: :nested_attribute })
@@ -131,50 +126,52 @@ RSpec.describe 'param\'s nested_attributes option:', type: :controller do
       end
     end
 
-    it "then adds the _attributes suffix to all parents" do
-      get :index, {
+    it 'then adds the _attributes suffix to all parents' do
+      # noinspection RubyStringKeysInHashInspection
+      get :index,
           'shallowObject' => {
-              'nestedAttribute' => 'value'
+            'nestedAttribute' => 'value'
           }
-      }
 
-      expect(assigns(:params_snake_case)).to eql({
-          "controller" => "anonymous",
-          "action" => "index",
-          'shallow_object_attributes' => {
-              'nested_attribute_attributes' => 'value'
-          }
-      })
+      # noinspection RubyStringKeysInHashInspection
+      expect(assigns(:params_snake_case)).to eql(
+        'controller' => 'anonymous',
+        'action' => 'index',
+        'shallow_object_attributes' => {
+          'nested_attribute_attributes' => 'value'
+        }
+      )
     end
   end
 
-  context "when it points to a deeply nested attribute using nested array" do
+  context 'when it points to a deeply nested attribute using nested array' do
     controller ApplicationController do
       def index
-        @params_snake_case = params(nested_attributes: { shallow_object: [ :nested_attribute ] })
+        @params_snake_case = params(nested_attributes: { shallow_object: [:nested_attribute] })
 
         render nothing: true
       end
     end
 
-    it "then adds the _attributes suffix to all parents" do
-      get :index, {
+    it 'then adds the _attributes suffix to all parents' do
+      # noinspection RubyStringKeysInHashInspection
+      get :index,
           'shallowObject' => {
-              'nestedAttribute' => 'value'
+            'nestedAttribute' => 'value'
           }
-      }
 
-      expect(assigns(:params_snake_case)).to eql({
-          "controller" => "anonymous",
-          "action" => "index",
-          'shallow_object_attributes' => {
-              'nested_attribute_attributes' => 'value'
-          }
-      })
+      # noinspection RubyStringKeysInHashInspection
+      expect(assigns(:params_snake_case)).to eql(
+        'controller' => 'anonymous',
+        'action' => 'index',
+        'shallow_object_attributes' => {
+          'nested_attribute_attributes' => 'value'
+        }
+      )
     end
   end
 
-  context "when it points to an attribute using the leading underscore convention" do
+  context 'when it points to an attribute using the leading underscore convention' do
     controller ApplicationController do
       def index
         @params_snake_case = params(nested_attributes: { _shallow_object: :nested_attribute })
@@ -183,49 +180,50 @@ RSpec.describe 'param\'s nested_attributes option:', type: :controller do
       end
     end
 
-    it "then adds the _attributes suffix to the inner object only" do
-      get :index, {
+    it 'then adds the _attributes suffix to the inner object only' do
+      # noinspection RubyStringKeysInHashInspection
+      get :index,
           'shallowObject' => {
-              'nestedAttribute' => 'value'
+            'nestedAttribute' => 'value'
           }
-      }
 
-      expect(assigns(:params_snake_case)).to eql({
-          "controller" => "anonymous",
-          "action" => "index",
-          'shallow_object' => {
-              'nested_attribute_attributes' => 'value'
-          }
-      })
+      # noinspection RubyStringKeysInHashInspection
+      expect(assigns(:params_snake_case)).to eql(
+        'controller' => 'anonymous',
+        'action' => 'index',
+        'shallow_object' => {
+          'nested_attribute_attributes' => 'value'
+        }
+      )
     end
   end
 
   context "when it points to an attribute using the '*' array index wildcard" do
     controller ApplicationController do
       def index
-        @params_snake_case = params(nested_attributes: [ _array: { '*' => :string } ])
+        @params_snake_case = params(nested_attributes: [_array: { '*' => :string }])
 
         render nothing: true
       end
     end
 
-    it "then adds the _attributes suffix" do
-      get :index, {
+    it 'then adds the _attributes suffix' do
+      # noinspection RubyStringKeysInHashInspection
+      get :index,
           'array' => [
-              { 'string' => 'string' },
-              { 'string' => 'string2' },
-          ],
-
-      }
-
-      expect(assigns(:params_snake_case)).to eql({
-          "controller" => "anonymous",
-          "action" => "index",
-          'array' => [
-              { 'string_attributes' => 'string' },
-              { 'string_attributes' => 'string2' },
+            { 'string' => 'string' },
+            { 'string' => 'string2' }
           ]
-      })
+
+      # noinspection RubyStringKeysInHashInspection
+      expect(assigns(:params_snake_case)).to eql(
+        'controller' => 'anonymous',
+        'action' => 'index',
+        'array' => [
+          { 'string_attributes' => 'string' },
+          { 'string_attributes' => 'string2' }
+        ]
+      )
     end
   end
 end

data/spec/params_spec.rb

@@ -1,6 +1,9 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
-RSpec.describe "params default behaviour:", type: :controller do
+# rubocop:disable Metrics/BlockLength
+RSpec.describe 'params default behaviour:', type: :controller do
   context 'when no arguments are passed' do
     controller ApplicationController do
       def index
@@ -14,141 +17,139 @@ RSpec.describe "params default behaviour:", type: :controller do
       it 'then returns an empty object' do
         get :index
 
-        expect(assigns(:params_snake_case)).to eql({
-            "controller" => "anonymous",
-            "action" => "index"
-        })
+        expect(assigns(:params_snake_case)).to eql(
+          'controller' => 'anonymous',
+          'action' => 'index'
+        )
       end
     end
 
     context 'and there are params' do
       it 'then returns correctly snake cased params' do
-        get :index, {
+        # noinspection RubyStringKeysInHashInspection
+        get :index,
             'integer' => 3,
             'string' => 'string',
             'boolean' => true,
             'simpleArray' => [
-                0, 1, 2
+              0, 1, 2
             ],
             'shallowObject' => {
-                'nestedAttribute' => 'value'
+              'nestedAttribute' => 'value'
             },
             'arrayOfObjects' => [
-                {
-                    'name' => 'object1'
-                },
-                {
-                    'name' => 'object2'
-                },
-                {
-                    'name' => 'object3'
-                },
+              {
+                'name' => 'object1'
+              },
+              {
+                'name' => 'object2'
+              },
+              {
+                'name' => 'object3'
+              }
             ],
             'complexObject' => {
-                'nestedObject' => {
-                    'deeperNestedObject' => {
-                        'name' => 'deeplyNested'
-                    }
-                },
-                'anotherNestedObject' => {
-                    'deeperNestedObject' => {
-                        'name' =>  'anotherDeeplyNested',
-                        'deepestNestedObject' => {
-                            'name' => 'deeplyNested'
-                        }
-                    }
-                },
+              'nestedObject' => {
+                'deeperNestedObject' => {
+                  'name' => 'deeplyNested'
+                }
+              },
+              'anotherNestedObject' => {
+                'deeperNestedObject' => {
+                  'name' => 'anotherDeeplyNested',
+                  'deepestNestedObject' => {
+                    'name' => 'deeplyNested'
+                  }
+                }
+              }
             },
             'arrayOfNestedObjects' => [
-                {
-                    'level' => 1,
-                    'children' => [
-                        {
-                            'index' => 1,
-                        },
-                        {
-                            'index' => 2,
-                        },
-                        {
-                            'index' => 3,
-                        },
-                    ]
+              {
+                'level' => 1,
+                'children' => [
+                  {
+                    'index' => 1
+                  },
+                  {
+                    'index' => 2
+                  },
+                  {
+                    'index' => 3
+                  }
+                ]
 
-                },
-                {
-                    'level' => 1,
-                    'parent' => {
-                        'index' => 1,
-                    }
+              },
+              {
+                'level' => 1,
+                'parent' => {
+                  'index' => 1
                 }
+              }
             ]
 
-        }
-
-        expect(assigns(:params_snake_case)).to eql({
-            "controller" => "anonymous",
-            "action" => "index",
-            'integer' => "3",
-            'string' => 'string',
-            'boolean' => true,
-            'simple_array' => [
-                "0", "1", "2"
-            ],
-            'shallow_object' => {
-                'nested_attribute' => 'value'
+        # noinspection RubyStringKeysInHashInspection
+        expect(assigns(:params_snake_case)).to eql(
+          'controller' => 'anonymous',
+          'action' => 'index',
+          'integer' => '3',
+          'string' => 'string',
+          'boolean' => true,
+          'simple_array' => %w[0 1 2],
+          'shallow_object' => {
+            'nested_attribute' => 'value'
+          },
+          'array_of_objects' => [
+            {
+              'name' => 'object1'
             },
-            'array_of_objects' => [
-                {
-                    'name' => 'object1'
-                },
-                {
-                    'name' => 'object2'
-                },
+            {
+              'name' => 'object2'
+            },
+            {
+              'name' => 'object3'
+            }
+          ],
+          'complex_object' => {
+            'nested_object' => {
+              'deeper_nested_object' => {
+                'name' => 'deeplyNested'
+              }
+            },
+            'another_nested_object' => {
+              'deeper_nested_object' => {
+                'name' => 'anotherDeeplyNested',
+                'deepest_nested_object' => {
+                  'name' => 'deeplyNested'
+                }
+              }
+            }
+          },
+          'array_of_nested_objects' => [
+            {
+              'level' => '1',
+              'children' => [
                 {
-                    'name' => 'object3'
-                },
-            ],
-            'complex_object' => {
-                'nested_object' => {
-                    'deeper_nested_object' => {
-                        'name' => 'deeplyNested'
-                    }
-                },
-                'another_nested_object' => {
-                    'deeper_nested_object' => {
-                        'name' =>  'anotherDeeplyNested',
-                        'deepest_nested_object' => {
-                            'name' => 'deeplyNested'
-                        }
-                    }
+                  'index' => '1'
                 },
-            },
-            'array_of_nested_objects' => [
                 {
-                    'level' => "1",
-                    'children' => [
-                        {
-                            'index' => "1",
-                        },
-                        {
-                            'index' => "2",
-                        },
-                        {
-                            'index' => "3",
-                        },
-                    ]
-
+                  'index' => '2'
                 },
                 {
-                    'level' => "1",
-                    'parent' => {
-                        'index' => "1",
-                    }
+                  'index' => '3'
                 }
-            ]
+              ]
 
-        })
+            },
+            {
+              'level' => '1',
+              'parent' => {
+                'index' => '1'
+              }
+            }
+          ]
+        )
       end
     end
   end
 end
+# rubocop:enable Metrics/BlockLength