sn-revisions 0.2.3 → 0.2.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 061ce6ce9a3ae3e37de60f220e739ac6f2adcc70
-  data.tar.gz: d71ad4784401dd7ca3271986e449a2dd2b1c5420
+SHA256:
+  metadata.gz: 73c57395a3f4ea1fc8bac76dfd665fe9c93f86a46b7ac335e218f989b0307628
+  data.tar.gz: cde2ad068f9c7524bfc13253df6a73bdbd898d36e24abd9a2347dfd094e6874b
 SHA512:
-  metadata.gz: 5cc0418eea127ea49c7b072fcc121eb37a2f84d9e1b8fd7378b1b9f7939e79e593a2d56f31163454cd121c655f4bf0dfb75772962f2a88063f2dbe1e05489c1c
-  data.tar.gz: ddc078ec863473a696559068e5867f0cf898ba93fe2889eafbffc5b9a002a20aac7780b9742347f1b05b8a82962e0c54decbb0bb35e8077c29841e22c96574ab
+  metadata.gz: 2ae879dc7ac4ee69c35ace6773a97735d6aa05c99f15bda47b98724d03d266230c3614d53edb428dab117308b06c51b9428585255d180ad3c66a238dd180abbb
+  data.tar.gz: c748f941e3393cd5535b17e5c57ecc506e2eb2b4d8393b6f606d650c680393ba69e698318419386bd85de19c5231a44b78f546cf49c5bff725ecf6b835b2d14a

data/app/controllers/revisions/application_controller.rb

@@ -7,7 +7,7 @@ module Revisions
 
     def authenticate_user
       user = Revisions::User.find(params[:uid])
-      if user.key != params[:key]
+      if !ActiveSupport::SecurityUtils.secure_compare(user.key, params[:key])
         render_unauthorized
         return
       end

data/app/controllers/revisions/extension_controller.rb

@@ -39,7 +39,12 @@ module Revisions
           end
         end
 
-        render :json => {:name => "Note History", :supported_types => [:Note], :actions => actions}
+        render :json => {
+          :name => "Note History",
+          :supported_types => [:Note],
+          :actions => actions,
+          deprecation: 'This extension will soon be replaced by Remote History, accessible via the History menu.'
+        }
     end
 
   end

data/app/controllers/revisions/items_controller.rb

@@ -1,22 +1,44 @@
-require_dependency "revisions/application_controller"
+require_dependency 'revisions/application_controller'
 
 module Revisions
   class ItemsController < ApplicationController
-
     def save
       items = params[:items]
       auth_params = params[:auth_params]
+      directive = params[:directive]
+
+      if directive == 'delete-account'
+        current_user.destroy
+        head :no_content
+        return
+      end
 
       items.each do |item_hash|
-        item = current_user.items.find_or_create_by(:item_uuid => item_hash["uuid"])
+        item = current_user.items.find_or_create_by(item_uuid: item_hash['uuid'])
+
+        if item_hash['deleted'] == true
+          item.destroy
+          head :no_content
+          next
+        end
+
         item.prune_history
-        item.add_revision(item_hash["content"], item_hash["enc_item_key"], item_hash["auth_hash"], auth_params)
-        if item.content_type == nil
-          item.content_type = item_hash["content_type"]
+
+        item.add_revision(
+          items_key_id: item_hash['items_key_id'],
+          duplicate_of: item_hash['duplicate_of'],
+          content: item_hash['content'],
+          enc_item_key: item_hash['enc_item_key'],
+          auth_hash: item_hash['auth_hash'],
+          auth_params: auth_params
+        )
+        if item.content_type.nil?
+          item.content_type = item_hash['content_type']
           item.save
         end
       end
-    end
 
+      head :no_content
+    end
   end
 end

data/app/controllers/revisions/revisions_controller.rb

@@ -11,7 +11,7 @@ module Revisions
       end
 
       if revision.auth_params
-        # stupid issue where I forgot to serialize auth params before inserting it into MILLIONS of rows
+        # Handles issue where auth params were not previously properly serialized before being inserted
         begin
           auth_params = JSON.parse(revision.auth_params)
         rescue

data/app/models/revisions/item.rb

@@ -1,15 +1,23 @@
 module Revisions
   class Item < ApplicationRecord
 
-    has_many :revisions, -> { order 'created_at desc' }
-
-    def add_revision(content, item_key, auth_hash, auth_params)
+    has_many :revisions, -> { order 'created_at desc' }, dependent: :destroy
+
+    def add_revision(
+      items_key_id: nil,
+      duplicate_of: nil,
+      content: nil,
+      enc_item_key: nil,
+      auth_hash: nil,
+      auth_params: nil
+    )
       revision = self.revisions.new
+      revision.items_key_id = items_key_id
+      revision.duplicate_of = duplicate_of
       revision.content = content
-      revision.enc_item_key = item_key
+      revision.enc_item_key = enc_item_key
       revision.auth_hash = auth_hash
       revision.auth_params = auth_params.to_json
-      # revision.num = self.revisions.length > 0 && self.revisions.first.num ? (self.revisions.first.num + 1) : 0
       revision.save
     end
 
@@ -43,7 +51,9 @@ module Revisions
             end
           end
 
-          Revision.destroy(discard_ids)
+          Revision
+            .where(id: discard_ids)
+            .delete_all
         end
       end
     end

data/app/models/revisions/user.rb

@@ -1,6 +1,5 @@
 module Revisions
   class User < ApplicationRecord
-    has_many :items
-
+    has_many :items, dependent: :destroy
   end
 end

data/db/migrate/20200925151406_add_items_key_id.rb

@@ -0,0 +1,6 @@
+class AddItemsKeyId < ActiveRecord::Migration[5.2]
+  def change
+    add_column :revisions_revisions, :duplicate_of, :string, after: :id
+    add_column :revisions_revisions, :items_key_id, :string, after: :duplicate_of
+  end
+end

data/lib/revisions/version.rb

@@ -1,3 +1,3 @@
 module Revisions
-  VERSION = '0.2.3'
+  VERSION = '0.2.8'
 end

metadata

@@ -1,29 +1,35 @@
 --- !ruby/object:Gem::Specification
 name: sn-revisions
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.2.8
 platform: ruby
 authors:
 - Standard Notes
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-05-27 00:00:00.000000000 Z
+date: 2020-12-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 5.0.1
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 5.0.1
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6'
 description: The Note History extension for Standard Notes allows you to track changes
   to your notes, and restore them to previous versions.
 email:
@@ -69,6 +75,7 @@ files:
 - db/migrate/20170211001350_create_revisions_users.rb
 - db/migrate/20170713154559_change_item_key_to_text.rb
 - db/migrate/20180526182951_add_auth_params_to_revisions.rb
+- db/migrate/20200925151406_add_items_key_id.rb
 - lib/revisions.rb
 - lib/revisions/engine.rb
 - lib/revisions/version.rb
@@ -77,7 +84,7 @@ homepage: https://standardnotes.org
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -92,9 +99,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.12
-signing_key: 
+rubygems_version: 3.0.6
+signing_key:
 specification_version: 4
 summary: The Note History extension for Standard Notes allows you to track changes
   to your notes, and restore them to previous versions.