smsified 0.1.3 → 0.1.4

data/README.md

@@ -31,7 +31,7 @@ Find a subscription:
 Documentation
 -------------
 
-May be found at http://tropo.github.com/smsified & http://smsified.com.
+May be found at http://smsified.github.com/smsified-ruby & http://smsified.com.
 
 License
 -------

data/lib/smsified/oneapi.rb

@@ -23,6 +23,7 @@ module Smsified
     # @example 
     #   one_api = OneAPI.new :username => 'user', :password => '123'
     def initialize(options)
+      raise ArgumentError, 'an options Hash is required' if !options.instance_of?(Hash)
       raise ArgumentError, ':username required' if options[:username].nil?
       raise ArgumentError, ':password required' if options[:password].nil?
       
@@ -53,6 +54,7 @@ module Smsified
     #   one_api.send_sms :address => '14155551212', :message => 'Hi there!', :sender_address => '13035551212'
     #   one_api.send_sms :address => ['14155551212', '13035551212'], :message => 'Hi there!', :sender_address => '13035551212'
     def send_sms(options)
+      raise ArgumentError, 'an options Hash is required' if !options.instance_of?(Hash)
       raise ArgumentError, ':sender_address is required' if options[:sender_address].nil? && @sender_address.nil?
       raise ArgumentError, ':address is required' if options[:address].nil?
       raise ArgumentError, ':message is required' if options[:message].nil?
@@ -92,10 +94,18 @@ module Smsified
     # Builds the necessary query string
     def build_query_string(options)
       query = ''
-      
+
       options.each do |k,v|
         if k == :address
-          v.each { |address| query += "#{ '&' if query != '' }address=#{CGI.escape address}" }
+          if RUBY_VERSION.to_f == 1.9
+            if v.instance_of?(String)
+              v.each_line { |address| query += "#{ '&' if query != '' }address=#{CGI.escape address}" }
+            else
+              v.each { |address| query += "#{ '&' if query != '' }address=#{CGI.escape address}" }
+            end
+          else
+            v.each { |address| query += "#{ '&' if query != '' }address=#{CGI.escape address}" }
+          end
         else
           query += "#{ '&' if query != '' }#{k.to_s}=#{CGI.escape v}"
         end
@@ -104,4 +114,4 @@ module Smsified
       query
     end
   end
-end
+end

data/lib/smsified/reporting.rb

@@ -16,6 +16,7 @@ module Smsified
     # @example
     #   subscription = Subscription.new :username => 'user', :password => '123'
     def initialize(options)
+      raise ArgumentError, 'an options Hash is required' if !options.instance_of?(Hash)
       raise ArgumentError, ':username required' if options[:username].nil?
       raise ArgumentError, ':password required' if options[:password].nil?
       
@@ -38,6 +39,7 @@ module Smsified
     # @example
     #   one_api.delivery_status :request_id => 'f359193765f6a3149ca76a4508e21234', :sender_address => '14155551212'
     def delivery_status(options)
+      raise ArgumentError, 'an options Hash is required' if !options.instance_of?(Hash)
       raise ArgumentError, ':sender_address is required' if options[:sender_address].nil? && @sender_address.nil?
       
       options[:sender_address] = options[:sender_address] || @sender_address

data/lib/smsified/subscriptions.rb

@@ -18,6 +18,7 @@ module Smsified
     # @example
     #   subscription = Subscription.new :username => 'user', :password => '123'
     def initialize(options)
+      raise ArgumentError, 'an options Hash is required' if !options.instance_of?(Hash)
       raise ArgumentError, ':username required' if options[:username].nil?
       raise ArgumentError, ':password required' if options[:password].nil?
       

data/spec/smsified_spec.rb

@@ -26,10 +26,16 @@ describe "Smsified" do
     it "Should get errors if instantiating without all of the right parameters" do
       begin
         Smsified::OneAPI.new 'foobar'
+      rescue => e
+        e.to_s.should eql 'an options Hash is required'
+      end
+
+      begin
+        Smsified::OneAPI.new(:password => nil)
       rescue => e
         e.to_s.should eql ':username required'
       end
-   
+      
       begin
         Smsified::OneAPI.new(:username => @username)
       rescue => e
@@ -40,6 +46,12 @@ describe "Smsified" do
     it "Should raise an error if no :sender_address specified" do
       begin
         @one_api.send_sms('foobar')
+      rescue => e
+        e.to_s.should eql 'an options Hash is required'
+      end
+      
+      begin
+        @one_api.send_sms({})
       rescue => e
         e.to_s.should eql ':sender_address is required'
       end
@@ -104,6 +116,12 @@ describe "Smsified" do
     it "Should get errors if instantiating without all of the right parameters" do
       begin
         Smsified::Subscriptions.new 'foobar'
+      rescue => e
+        e.to_s.should eql 'an options Hash is required'
+      end
+      
+      begin
+        Smsified::Subscriptions.new({})
       rescue => e
         e.to_s.should eql ':username required'
       end
@@ -364,6 +382,12 @@ describe "Smsified" do
     it "Should get errors if instantiating without all of the right parameters" do
       begin
         Smsified::Reporting.new 'foobar'
+      rescue => e
+        e.to_s.should eql 'an options Hash is required'
+      end
+      
+      begin
+        Smsified::Reporting.new({})
       rescue => e
         e.to_s.should eql ':username required'
       end
@@ -378,6 +402,12 @@ describe "Smsified" do
     it "Should raise an error if no :sender_address specified" do
       begin
         @reporting.delivery_status('foobar')
+      rescue => e
+        e.to_s.should eql 'an options Hash is required'
+      end
+      
+      begin
+        @reporting.delivery_status({})
       rescue => e
         e.to_s.should eql ':sender_address is required'
       end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: smsified
 version: !ruby/object:Gem::Version 
-  hash: 29
+  hash: 19
   prerelease: 
   segments: 
   - 0
   - 1
-  - 3
-  version: 0.1.3
+  - 4
+  version: 0.1.4
 platform: ruby
 authors: 
 - Jason Goecke
@@ -15,10 +15,11 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-05-20 00:00:00 -04:00
+date: 2011-06-24 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
+  prerelease: false
   type: :development
   requirement: &id001 !ruby/object:Gem::Requirement 
     none: false
@@ -31,10 +32,10 @@ dependencies:
         - 3
         - 0
         version: 2.3.0
-  name: rspec
   version_requirements: *id001
-  prerelease: false
+  name: rspec
 - !ruby/object:Gem::Dependency 
+  prerelease: false
   type: :development
   requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
@@ -47,10 +48,10 @@ dependencies:
         - 6
         - 0
         version: 0.6.0
-  name: yard
   version_requirements: *id002
-  prerelease: false
+  name: yard
 - !ruby/object:Gem::Dependency 
+  prerelease: false
   type: :development
   requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
@@ -63,10 +64,10 @@ dependencies:
         - 0
         - 0
         version: 1.0.0
-  name: bundler
   version_requirements: *id003
-  prerelease: false
+  name: bundler
 - !ruby/object:Gem::Dependency 
+  prerelease: false
   type: :development
   requirement: &id004 !ruby/object:Gem::Requirement 
     none: false
@@ -79,10 +80,10 @@ dependencies:
         - 5
         - 2
         version: 1.5.2
-  name: jeweler
   version_requirements: *id004
-  prerelease: false
+  name: jeweler
 - !ruby/object:Gem::Dependency 
+  prerelease: false
   type: :development
   requirement: &id005 !ruby/object:Gem::Requirement 
     none: false
@@ -93,10 +94,10 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  name: rcov
   version_requirements: *id005
-  prerelease: false
+  name: rcov
 - !ruby/object:Gem::Dependency 
+  prerelease: false
   type: :development
   requirement: &id006 !ruby/object:Gem::Requirement 
     none: false
@@ -107,10 +108,10 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  name: fakeweb
   version_requirements: *id006
-  prerelease: false
+  name: fakeweb
 - !ruby/object:Gem::Dependency 
+  prerelease: false
   type: :development
   requirement: &id007 !ruby/object:Gem::Requirement 
     none: false
@@ -121,10 +122,10 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  name: awesome_print
   version_requirements: *id007
-  prerelease: false
+  name: awesome_print
 - !ruby/object:Gem::Dependency 
+  prerelease: false
   type: :development
   requirement: &id008 !ruby/object:Gem::Requirement 
     none: false
@@ -135,10 +136,10 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  name: json
   version_requirements: *id008
-  prerelease: false
+  name: json
 - !ruby/object:Gem::Dependency 
+  prerelease: false
   type: :runtime
   requirement: &id009 !ruby/object:Gem::Requirement 
     none: false
@@ -149,9 +150,8 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  name: httparty
   version_requirements: *id009
-  prerelease: false
+  name: httparty
 description: Gem for consuming the SMSified OneAPI
 email: jsgoecke@voxeo.com
 executables: []
@@ -203,7 +203,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.5.2
+rubygems_version: 1.5.0
 signing_key: 
 specification_version: 3
 summary: Gem for consuming the SMSified OneAPI