sms_traffic_sdk 0.0.2 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cd31453fcbcb3a4c917dca77ca0b8e3952407d4f1036891658ac6e8c071c1ee9
-  data.tar.gz: 8f33c69d556fe07454632c5149d7e775bf1604e02795d52d986474dc6d8385f3
+  metadata.gz: 56aa0cade898c0945faa7a4db5b1ffe993961790f1da8620ad8f78f931f3bf10
+  data.tar.gz: 9f3cb3dc53572c1cd217fe9f2dda5026341f4236955717c03c286ed1385d4b0a
 SHA512:
-  metadata.gz: ecd1839c1260f125c896598035175c5ce6c3b3b159e128bea7594c1842aadfd633b8c870012eb16c081e355784bfdf4d644120234562a6e9748a9c80733f88bf
-  data.tar.gz: 8bd005c31bc2b26fec505235d640a64af90f4db62ea4f1a3cf3f54c6e0d2d3aaa947c955e52088c312146b59700a8fff5da45cf7d5f8b0d1df1186d6b097971a
+  metadata.gz: 670f8dd039cc41234e4a477f1a1ac1007f7fc2374d1823776a5975848910c3cd0c5c087f72a2986e07c3f81bae579a3d670548bc8f872e5eb5bde90933c0bf1e
+  data.tar.gz: 61599f0d3633bf2a2220a662de705888beb20e535e722627f709cf18380a7859b256e619afdab615f86cbdd24c19ad5386dc559255a64043bf09e77acbd362af

data/lib/sms_traffic/client/deliver_reply.rb

@@ -5,6 +5,8 @@ module SmsTraffic
 
       def ok?
         fetch_value(hash, :result) == OK_REPLY
+      rescue NoMethodError
+        false
       end
 
       def error?
@@ -29,7 +31,7 @@ module SmsTraffic
 
       def sms_id(phone = nil)
         message_info = fetch_value(message_infos, :message_info)
-        return fetch_value(message_info, :sms_id) if message_info.is_a?(Hash)
+        return fetch_value(message_info, :sms_id) if message_info.is_a?(Hash) || message_info.nil?
 
         raise ArgumentError, 'phone is required' unless phone
 

data/lib/sms_traffic/client/reply.rb

@@ -4,7 +4,7 @@ module SmsTraffic
       attr_reader :xml, :hash
 
       def initialize(xml, xml_parser: SmsTraffic.configuration.xml_parser)
-        @xml = xml.gsub!(/\s+/, ' ')
+        @xml  = xml.gsub!(/\s+/, ' ')
         @hash = fetch_value(xml_parser.parse(xml), :reply)
       end
 
@@ -12,6 +12,8 @@ module SmsTraffic
 
       def fetch_value(hash, key)
         hash.fetch(key.to_s, nil) || hash.fetch(key.to_sym, nil)
+      rescue NoMethodError
+        nil
       end
     end
   end

data/lib/sms_traffic/sms.rb

@@ -4,11 +4,11 @@ module SmsTraffic
     attr_reader :id, :status, :errors
 
     def initialize(phone, message, originator: nil)
-      @phone = phone
-      @message = message
+      @phone      = phone
+      @message    = message
       @originator = originator || SmsTraffic.configuration.originator
-      @status = 'not-sent'
-      @errors = []
+      @status     = 'not-sent'
+      @errors     = []
       validate!
     end
 
@@ -26,10 +26,10 @@ module SmsTraffic
 
       if reply.ok?
         @status = 'sent'
-        @id = reply.sms_id
+        @id     = reply.sms_id(phone)
         true
       else
-        @errors << reply.error_description
+        @errors << (reply.error_description || 'Sms has been not enqueued')
         false
       end
     end

data/lib/sms_traffic/version.rb

@@ -1,3 +1,3 @@
 module SmsTraffic
-  VERSION = '0.0.2'.freeze
+  VERSION = '0.0.4'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sms_traffic_sdk
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.4
 platform: ruby
 authors:
 - David Rybolovlev
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-09-04 00:00:00.000000000 Z
+date: 2024-10-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri