sms_manager 0.2.1 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e4c603afa0deded30e5cb06376e840fc8abbb893
-  data.tar.gz: ac12ef1fa59399065cc9ed33bf65f6a5ab284779
+  metadata.gz: 1b6c5f47ed9565f01fe97dfc14ad5129298f6407
+  data.tar.gz: 7e2c65f5610918bc51f85815342e046477d64600
 SHA512:
-  metadata.gz: 5e2c4942edc14ad882abb5a7373de45e7e984c062683250de7c554ec79d19ce674bc4c6057dc88a1a7938cccd32b18116a76a981b983c8d829ea3c093c78cfa7
-  data.tar.gz: 693bce49dc61dd1cb1342be6b8f4620340f4e06ad2d833bd6708a28977737956b78c74c940bfe1d4fb6a3e4943bd6e0f4194199062e1cf1bf675325f053614af
+  metadata.gz: 88c16b92bd4bec98173b533e9f03a0b6ab706933c382144c159832b738dce0cd5d295363f8b9d96e727f5239662e5dce98df0119ecbefbdf3c1879c4cddc2bc0
+  data.tar.gz: 40b3f4c3291493aa76b9832f697265ee1c01fc0ce34ab1e8e40b1d6d000e5a833cd2f85c3f73a61e0cb417456509db49309023360a751e50254696bcfebc2786

data/CHANGELOG.md

@@ -7,7 +7,19 @@
 * backward incompatible change: renamed `send_message` to `send`
 * code refactor
 
-
 0.2.1
 -----
 * Add `send_message` back to keep backward compatibility
+
+0.3.0
+-----
+* remove `code` attribute from `SmsManager::SendingError`
+* Made changes so that you don't need to rescue `HTTPClient` exceptions. Rescue only `SmsManager::SendingError`
+
+```ruby
+begin
+  SmsManager.send number: '+420123456789', message: 'Hello!'
+rescue SmsManager::Error => e
+  puts e.message # => Neplatný parametr gateway
+end
+```

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    sms_manager (0.2.1)
+    sms_manager (0.3.0)
       httpclient (~> 2.7.0)
 
 GEM

data/lib/sms_manager.rb

@@ -17,8 +17,12 @@ module SmsManager
         number: options[:number],
         message: options[:message]
       }
-      body = HTTPClient.get('http://http-api.smsmanager.cz/Send', options).body
-      raise SendingError.new(options, body) unless body =~ /^OK/
+      begin
+        body = HTTPClient.get('http://http-api.smsmanager.cz/Send', options).body
+      rescue StandardError => e
+        raise Error.new(e.message)
+      end
+      raise SendingError.new(body) unless body =~ /^OK/
     end
 
     def send_message(options = {})

data/lib/sms_manager/error/error.rb

@@ -0,0 +1,3 @@
+module SmsManager
+  class Error < StandardError; end
+end

data/lib/sms_manager/error/sending_error.rb

@@ -1,13 +1,15 @@
-module SmsManager
-  class SendingError < StandardError
-    attr_reader :options, :code
+require 'sms_manager/error/error'
 
-    def initialize(options, body)
-      @code = body.split('|').last.to_i
-      @options = options
+module SmsManager
+  class SendingError < Error
+    def initialize(body)
+      code = body.split('|').last.to_i
+      super code_to_message(code)
     end
 
-    def message
+    private
+
+    def code_to_message(code)
       if code >= 900 && code <= 999
         CODE_9XX
       elsif CODES[code]
@@ -17,8 +19,6 @@ module SmsManager
       end
     end
 
-    private
-
     CODES = {
       101 => 'Neexistující data požadavku (chybí XMLDATA parametr u XML API)',
       102 => 'Metoda neexistuje',

data/lib/sms_manager/version.rb

@@ -1,8 +1,8 @@
 module SmsManager
   class Version
     MAJOR = 0
-    MINOR = 2
-    PATCH = 1
+    MINOR = 3
+    PATCH = 0
 
     class << self
       def to_s

data/sms_manager.gemspec

@@ -6,12 +6,13 @@ require 'sms_manager/version'
 Gem::Specification.new do |gem|
   gem.name          = "sms_manager"
   gem.version       = SmsManager::Version
-  gem.date          = '2016-01-16'
+  gem.date          = '2016-01-18'
   gem.authors       = ["David Hrachovy"]
   gem.email         = ["david.hrachovy@gmail.com"]
   gem.description   = %q{Ruby SDK for smsmanager.cz API}
   gem.summary       = %q{SmsManager is a Ruby library for sending SMS messages by smsmanager.cz provider}
-  gem.homepage      = "https://github.com/dayweek/sms_manager"
+  gem.homepage      = "https://github.com/PrimeHammer/sms_manager"
+  gem.required_ruby_version = '>= 2.0'
   gem.add_dependency  "httpclient", "~> 2.7.0"
   gem.add_development_dependency "bundler"
   gem.files         = `git ls-files`.split($/)

data/spec/sms_manager_spec.rb

@@ -30,14 +30,22 @@ describe SmsManager do
       stub_send.to_return body: 'ERROR|103'
 
       expect { SmsManager.send number: '+420123456789', message: 'Hello!' }.to \
-        raise_error(SmsManager::SendingError) do |e|
-          expect(e.code).to eq(103)
+        raise_error(SmsManager::Error) do |e|
           expect(e.message).to eq('Neplatné uživatelské jméno nebo heslo')
         end
     end
+
+    it 'raises SmsManager error if HTTP request fails' do
+      expect(HTTPClient).to receive(:get).and_raise HTTPClient::ConnectTimeoutError.new('oops')
+
+      expect { SmsManager.send number: '+420123456789', message: 'Hello!' }.to \
+        raise_error(SmsManager::Error) do |e|
+          expect(e.message).to eq('oops')
+        end
+    end
   end
 
-  describe 'send' do
+  describe 'send message' do
     before do
       SmsManager.configure do |config|
         config.username = 'david@example.com'
@@ -56,11 +64,19 @@ describe SmsManager do
       stub_send.to_return body: 'ERROR|103'
 
       expect { SmsManager.send_message number: '+420123456789', message: 'Hello!' }.to \
-        raise_error(SmsManager::SendingError) do |e|
-          expect(e.code).to eq(103)
+        raise_error(SmsManager::Error) do |e|
           expect(e.message).to eq('Neplatné uživatelské jméno nebo heslo')
         end
     end
+
+    it 'raises SmsManager error if HTTP request fails' do
+      expect(HTTPClient).to receive(:get).and_raise HTTPClient::ConnectTimeoutError.new('oops')
+
+      expect { SmsManager.send_message number: '+420123456789', message: 'Hello!' }.to \
+        raise_error(SmsManager::Error) do |e|
+          expect(e.message).to eq('oops')
+        end
+    end
   end
 
   def stub_send

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sms_manager
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.3.0
 platform: ruby
 authors:
 - David Hrachovy
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-16 00:00:00.000000000 Z
+date: 2016-01-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httpclient
@@ -55,12 +55,13 @@ files:
 - README.md
 - Rakefile
 - lib/sms_manager.rb
+- lib/sms_manager/error/error.rb
 - lib/sms_manager/error/sending_error.rb
 - lib/sms_manager/version.rb
 - sms_manager.gemspec
 - spec/sms_manager_spec.rb
 - spec/spec_helper.rb
-homepage: https://github.com/dayweek/sms_manager
+homepage: https://github.com/PrimeHammer/sms_manager
 licenses:
 - MIT
 metadata: {}
@@ -72,7 +73,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="