sms_broker 1.0.0 → 1.0.2

data/spec/support/nexmo_helpers.rb

@@ -1,9 +1,6 @@
 require 'rack'
 
 module NexmoHelpers
-
-  # NEXMO CREATE MESSAGE -------------------------------------------------------
-
   def stub_nexmo_create_message(request_body, response_body)
     stub_request(:post, 'https://rest.nexmo.com/sms/json')
       .with(body: request_body)
@@ -16,36 +13,18 @@ module NexmoHelpers
       )
   end
 
-  def stub_nexmo_create_message_missing_params(to, message)
-    request_body = {
+  def build_request_body(from, to, message)
+    {
       to: to,
-      from: nil,
+      from: from,
       text: message,
-      api_key: ENV['NEXMO_API_KEY'],
-      api_secret: ENV['NEXMO_API_SECRET']
-    }
-
-    response_body = {
-      'message-count' => '1',
-      'messages' => [
-        {
-          'status' => '2',
-          'error-text' => 'Missing from param'
-        }
-      ]
+      api_key: 'api_key',
+      api_secret: 'api_secret'
     }
-
-    stub_nexmo_create_message(request_body, response_body)
   end
 
   def stub_nexmo_create_message_invalid_sender_id_request(sender_id, to, message)
-    request_body = {
-      to: to,
-      from: sender_id,
-      text: message,
-      api_key: ENV['NEXMO_API_KEY'],
-      api_secret: ENV['NEXMO_API_SECRET']
-    }
+    request_body = build_request_body(sender_id, to, message)
 
     response_body = {
       'message-count' => '1',
@@ -61,13 +40,10 @@ module NexmoHelpers
   end
 
   def stub_nexmo_create_message_invalid_credentials(from, to, message)
-    request_body = {
-      to: to,
-      from: from,
-      text: message,
+    request_body = build_request_body(from, to, message)
+    request_body.merge! \
       api_key: 'invalid',
       api_secret: 'invalid'
-    }
 
     response_body = {
       'message-count' => '1',
@@ -83,13 +59,7 @@ module NexmoHelpers
   end
 
   def stub_nexmo_create_message_success(from, to, message)
-    request_body = {
-      to: to,
-      from: from,
-      text: message,
-      api_key: ENV['NEXMO_API_KEY'],
-      api_secret: ENV['NEXMO_API_SECRET']
-    }
+    request_body = build_request_body(from, to, message)
 
     response_body = {
       'message-count': '1',
@@ -109,42 +79,19 @@ module NexmoHelpers
     stub_nexmo_create_message(request_body, response_body)
   end
 
-  # NEXMO GET MESSAGE ----------------------------------------------------------
-
-  def stub_nexmo_get_message(message_id, response_body)
-    query_string = \
-      Rack::Utils.build_query \
-        id: message_id,
-        api_key: ENV['NEXMO_API_KEY'],
-        api_secret: ENV['NEXMO_API_SECRET']
-
-    stub_request(:get, "https://rest.nexmo.com/search/message?#{query_string}")
-      .to_return(
-        status: 200,
-        body: response_body.to_json,
-        headers: {
-          'Content-Type' => 'application/json'
-        }
-      )
-  end
+  def stub_nexmo_create_message_unknown_error(from, to, message)
+    request_body = build_request_body(from, to, message)
 
-  def stub_nexmo_get_message_success(message_id)
     response_body = {
-      "to" => "1234567890",
-      "from" => "1234567890",
-      "body" => "Hello[Nexmo DEMO]",
-      "type" => "MT",
-      "price" => "0.03330000",
-      "network" => "23420",
-      "latency" => 2234,
-      "message-id" => message_id,
-      "account-id" => "12345678",
-      "date-closed" => "2016-05-03 12:03:56",
-      "final-status" => "DELIVRD",
-      "date-received" => "2016-05-03 12:03:53"
+      'message-count' => '1',
+      'messages' => [
+        {
+          'status' => '1',
+          'error-text' => 'Unknown'
+        }
+      ]
     }
 
-    stub_nexmo_get_message(message_id, response_body)
+    stub_nexmo_create_message(request_body, response_body)
   end
-
 end

data/spec/support/vcr_cassettes/twilio/create_invalid_phone_error.yml

@@ -0,0 +1,61 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: https://api.twilio.com/2010-04-01/Accounts/account_sid/Messages.json
+    body:
+      encoding: US-ASCII
+      string: Body=Hello+World&From=%2B15005550001&To=%2B15005550006
+    headers:
+      Accept:
+      - application/json
+      Accept-Charset:
+      - utf-8
+      User-Agent:
+      - twilio-ruby/4.13.0 (ruby/x86_64-darwin14 2.2.1-p85)
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Authorization:
+      - Basic YWNjb3VudF9pZDphdXRoX3Rva2Vu
+      Content-Type:
+      - application/x-www-form-urlencoded
+  response:
+    status:
+      code: 400
+      message: BAD REQUEST
+    headers:
+      Access-Control-Allow-Credentials:
+      - 'true'
+      Access-Control-Allow-Headers:
+      - Accept, Authorization, Content-Type, If-Match, If-Modified-Since, If-None-Match,
+        If-Unmodified-Since
+      Access-Control-Allow-Methods:
+      - GET, POST, DELETE, OPTIONS
+      Access-Control-Allow-Origin:
+      - "*"
+      Access-Control-Expose-Headers:
+      - ETag
+      Content-Type:
+      - application/json; charset=utf-8
+      Date:
+      - Fri, 23 Sep 2016 12:53:22 GMT
+      Twilio-Request-Duration:
+      - '0.093'
+      Twilio-Request-Id:
+      - Twilio-Request-Id
+      X-Powered-By:
+      - AT-5000
+      X-Shenanigans:
+      - none
+      Content-Length:
+      - '199'
+      Connection:
+      - keep-alive
+    body:
+      encoding: UTF-8
+      string: '{"code": 21212, "message": "The ''From'' number +15005550001 is not
+        a valid phone number, shortcode, or alphanumeric sender ID.", "more_info":
+        "https://www.twilio.com/docs/errors/21212", "status": 400}'
+    http_version:
+  recorded_at: Fri, 23 Sep 2016 12:53:22 GMT
+recorded_with: VCR 3.0.3

data/spec/support/vcr_cassettes/twilio/create_success.yml

@@ -0,0 +1,68 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: https://api.twilio.com/2010-04-01/Accounts/account_sid/Messages.json
+    body:
+      encoding: US-ASCII
+      string: Body=Hello+World&From=%2B15005550006&To=%2B15005550006
+    headers:
+      Accept:
+      - application/json
+      Accept-Charset:
+      - utf-8
+      User-Agent:
+      - twilio-ruby/4.13.0 (ruby/x86_64-darwin14 2.2.1-p85)
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Authorization:
+      - Basic YWNjb3VudF9pZDphdXRoX3Rva2Vu
+      Content-Type:
+      - application/x-www-form-urlencoded
+  response:
+    status:
+      code: 201
+      message: CREATED
+    headers:
+      Access-Control-Allow-Credentials:
+      - 'true'
+      Access-Control-Allow-Headers:
+      - Accept, Authorization, Content-Type, If-Match, If-Modified-Since, If-None-Match,
+        If-Unmodified-Since
+      Access-Control-Allow-Methods:
+      - GET, POST, DELETE, OPTIONS
+      Access-Control-Allow-Origin:
+      - "*"
+      Access-Control-Expose-Headers:
+      - ETag
+      Content-Type:
+      - application/json; charset=utf-8
+      Date:
+      - Fri, 23 Sep 2016 12:53:22 GMT
+      Strict-Transport-Security:
+      - max-age=15768000
+      Twilio-Request-Duration:
+      - '0.034'
+      Twilio-Request-Id:
+      - Twilio-Request-Id
+      X-Powered-By:
+      - AT-5000
+      X-Shenanigans:
+      - none
+      Content-Length:
+      - '775'
+      Connection:
+      - keep-alive
+    body:
+      encoding: UTF-8
+      string: '{"sid": "message_sid", "date_created": "Fri,
+        23 Sep 2016 12:53:22 +0000", "date_updated": "Fri, 23 Sep 2016 12:53:22 +0000",
+        "date_sent": null, "account_sid": "account_sid", "to":
+        "+15005550006", "from": "+15005550006", "messaging_service_sid": null, "body":
+        "Hello World", "status": "queued", "num_segments": "1", "num_media": "0",
+        "direction": "outbound-api", "api_version": "2010-04-01", "price": null, "price_unit":
+        "USD", "error_code": null, "error_message": null, "uri": "/2010-04-01/Accounts/account_sid/Messages/message_sid.json",
+        "subresource_uris": {"media": "/2010-04-01/Accounts/account_sid/Messages/message_sid/Media.json"}}'
+    http_version:
+  recorded_at: Fri, 23 Sep 2016 12:53:22 GMT
+recorded_with: VCR 3.0.3

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sms_broker
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.2
 platform: ruby
 authors:
 - Streetbees Dev Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-08 00:00:00.000000000 Z
+date: 2016-09-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nexmo
@@ -117,6 +117,8 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
+- ".travis.yml"
 - Gemfile
 - README.md
 - Rakefile
@@ -139,11 +141,14 @@ files:
 - lib/sms_broker/version.rb
 - sms_broker.gemspec
 - spec/sms_broker/nexmo_spec.rb
+- spec/sms_broker/real_call_spec.rb
 - spec/sms_broker/setup_spec.rb
 - spec/sms_broker/sms_broker_spec.rb
 - spec/sms_broker/twilio_spec.rb
 - spec/spec_helper.rb
 - spec/support/nexmo_helpers.rb
+- spec/support/vcr_cassettes/twilio/create_invalid_phone_error.yml
+- spec/support/vcr_cassettes/twilio/create_success.yml
 homepage: https://github.com/streetbees/sms_broker
 licenses: []
 metadata: {}
@@ -169,8 +174,11 @@ specification_version: 4
 summary: Sms Broker
 test_files:
 - spec/sms_broker/nexmo_spec.rb
+- spec/sms_broker/real_call_spec.rb
 - spec/sms_broker/setup_spec.rb
 - spec/sms_broker/sms_broker_spec.rb
 - spec/sms_broker/twilio_spec.rb
 - spec/spec_helper.rb
 - spec/support/nexmo_helpers.rb
+- spec/support/vcr_cassettes/twilio/create_invalid_phone_error.yml
+- spec/support/vcr_cassettes/twilio/create_success.yml