sms-logparser 0.15.1 → 0.15.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bff5cf76ce93fa19c9d0f5c488363dd5b86d10fd
-  data.tar.gz: 05f02b03ef8e63810a21bd3f6e9061eff6c1b325
+  metadata.gz: 20c89e242f1560045deef189787a1a36e03c6316
+  data.tar.gz: e384c0d183ee76ec5496d44f7b235c19b098f20b
 SHA512:
-  metadata.gz: 3fcba57cac34ad776f065f98169ba2c00bcf8040ad59de87037a37ce0573ef28ee8187804d48875e19cba7b1fb62223b9e2bec9665542b235571050e573a56b6
-  data.tar.gz: 2f496cd73c38b7910a1851de88fe4a3e27873d9f2a935354bac3e81868033c144055c2a184ed8ff3688cec7c792bce296af412439e8e91c2588022bc70ed4e43
+  metadata.gz: bac5632a23b1d03b17494254d03df1aee6c4335243e9e94339f1d836a57191dfb9eb021143a31b642ffdcc8126f119ba9730127bd2ae3198ad418c6bbbff31a2
+  data.tar.gz: 0cf8ac3de610af40966095a76c5bf88f32ae4499f0ee602280f744d78d46ec5f56abd32a6b256b31408d426d92e3d7417c11f36506bcabac9c73ae64769874fb

data/lib/sms-logparser/log_message.rb

@@ -21,7 +21,7 @@ module SmsLogparser
     end
 
     def args
-      match[5]
+      match[5][1..-1] if match[5]
     end
 
     def status
@@ -33,7 +33,7 @@ module SmsLogparser
     end
 
     def file_extname
-      File.extname(file)
+      File.extname(file) if file
     end
     
     def user_agent
@@ -65,7 +65,7 @@ module SmsLogparser
     private 
 
     def match
-      @match ||= @message.match /\/content\/(\d+)\/(\d+)\/(\d+)\/(\w+\.\w+)(\?\S*)*\s.*\"\s(\d+)\s(\d+).+"(.*)"$/
+      @match ||= @message.match /\/content\/(\d+)\/(\d+)\/(\d+)\/(\w+\.\w+)*(\?\S*)*\s.*\"\s(\d+)\s(\d+).+"(.*)"$/
     end
   end
 end 

data/lib/sms-logparser/version.rb

@@ -1,3 +1,3 @@
 module SmsLogparser
-  VERSION = "0.15.1"
+  VERSION = "0.15.3"
 end

data/spec/log_message_spec.rb

@@ -23,9 +23,22 @@ describe SmsLogparser::LogMessage do
     log_message.status.must_equal 206
     log_message.bytes.must_equal 100708
     log_message.file.must_equal 'simvid_1_40.flv'
-    log_message.args.must_equal '?position=22'
+    log_message.args.must_equal 'position=22'
     log_message.file_extname.must_equal '.flv'
     log_message.user_agent.must_equal 'Mozilla/5.0 (Windows NT 6.1; rv:28.0) Gecko/20100101 Firefox/28.0'
   end
 
+  it "can extract the correct values from messages without files" do
+    log_message = SmsLogparser::LogMessage.new('- - [23/Apr/2014:17:47:32 +0200] "GET /content/51/52/42624/ HTTP/1.1" 200 1181 "-" "Googlebot-Video/1.0"')
+    log_message.customer_id.must_equal '51'
+    log_message.author_id.must_equal '52'
+    log_message.project_id.must_equal '42624'
+    log_message.status.must_equal 200
+    log_message.bytes.must_equal 1181
+    log_message.file.must_equal nil
+    log_message.args.must_equal nil
+    log_message.file_extname.must_equal nil
+    log_message.user_agent.must_equal 'Googlebot-Video/1.0'
+  end
+
 end

data/spec/parser_spec.rb

@@ -111,6 +111,17 @@ describe SmsLogparser::Parser do
     data.first[:value].must_equal 100708
   end
 
+  it "count traffic with status 200 and no file from bot as webcast visit" do
+    message = '- - [23/Apr/2014:17:47:32 +0200] "GET /content/51/52/42624/ HTTP/1.1" 200 1181 "-" "Googlebot-Video/1.0"'
+    data = SmsLogparser::Parser.new.extract_data_from_msg(message)
+    data.size.must_equal 1
+    data.first[:customer_id].must_equal "51"
+    data.first[:author_id].must_equal "52"
+    data.first[:project_id].must_equal "42624"
+    data.first[:type].must_equal 'TRAFFIC_WEBCAST'
+    data.first[:value].must_equal 1181
+  end
+
   it "do not count *.css with status 200 as visit" do
     message = '- - [22/Apr/2014:18:00:50 +0200] "GET /content/51/52/42431/application.css HTTP/1.1" 200 192 "http://blick.simplex.tv/NubesPlayer/player.swf" "Mozilla/5.0 (Windows NT 6.1; WOW64; Trident/7.0; rv:11.0) like Gecko"'
     data = SmsLogparser::Parser.new.extract_data_from_msg(message)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sms-logparser
 version: !ruby/object:Gem::Version
-  version: 0.15.1
+  version: 0.15.3
 platform: ruby
 authors:
 - niwo