smooth_operator 1.3.0 → 1.8.0

data/spec/smooth_operator/{resource_name_spec.rb → model_schema_spec.rb}

@@ -1,12 +1,12 @@
 require "spec_helper"
 
-describe SmoothOperator::ResourceName do
+describe SmoothOperator::ModelSchema do
 
   describe "#known_attributes" do
     let(:initial_attributes_keys) { attributes_for(:user).keys.map(&:to_s) }
 
     context "when there is no declared schema" do
-      subject { User::Base.new(attributes_for(:user)) }
+      subject { User.new(attributes_for(:user)) }
 
       it 'it should reflect the attributes used uppon initialization' do
         expect(subject.known_attributes.to_a).to match_array(initial_attributes_keys)

data/spec/smooth_operator/operator_spec.rb

@@ -1,7 +1,7 @@
 require "spec_helper"
 
 describe SmoothOperator::Operator do
-  subject { User::Base }
+  subject { User }
 
   describe "#get" do
 

data/spec/smooth_operator/persistence_spec.rb

@@ -9,7 +9,7 @@ shared_examples_for "successful persistent remote call" do
   it "it should populate 'last_remote_call' with the remote_call used on this transaction" do
     expect(subject.last_remote_call).to be_nil unless method_to_execute.to_s =~ /create/
     execute_method
-    expect(subject.last_remote_call).to be_a_kind_of(SmoothOperator::RemoteCall::Base)
+    expect(subject.last_remote_call).to be_instance_of(SmoothOperator::RemoteCall::Base)
   end
 end
 
@@ -23,13 +23,7 @@ shared_examples_for "persistent remote call" do
     let(:method_arguments) { ['', { status: 200 }] }
 
     it "it should return true" do
-      result = execute_method
-
-      if !(method_to_execute.to_s =~ /create/)
-        expect(result).to be true
-      end
-
-      expect(subject.last_remote_call.ok?).to be true
+      execute_method
       expect(subject.last_remote_call.status).to be true
     end
 
@@ -41,17 +35,11 @@ shared_examples_for "persistent remote call" do
     it_behaves_like "successful persistent remote call"
   end
 
-  context "when the response is unprocessed_entity" do
+  context "when the response is negative" do
     let(:method_arguments) { ['', { status: 422 }] }
 
     it "it should return false" do
-      result = execute_method
-
-      if !(method_to_execute.to_s =~ /create/)
-        expect(result).to be false
-      end
-
-      expect(subject.last_remote_call.not_processed?).to be true
+      execute_method
       expect(subject.last_remote_call.status).to be false
     end
 
@@ -63,39 +51,11 @@ shared_examples_for "persistent remote call" do
     it_behaves_like "successful persistent remote call"
   end
 
-  context "when the response is client side error" do
-    let(:method_arguments) { ['', { status: 404 }] }
-
-    it "it should return nil" do
-      result = execute_method
-
-      if !(method_to_execute.to_s =~ /create/)
-        expect(result).to be nil
-      end
-
-      expect(subject.last_remote_call.client_error?).to be true
-      expect(subject.last_remote_call.error?).to be true
-      expect(subject.last_remote_call.status).to be nil
-    end
-
-    it "it should assert the subject's persistence" do
-      execute_method
-      expect(subject.persisted?).to be(persistence_state[500])
-    end
-  end
-
   context "when the there is a connection error ou http 500" do
     let(:method_arguments) { ['', { status: 500 }] }
 
     it "it should return nil" do
-      result = execute_method
-
-      if !(method_to_execute.to_s =~ /create/)
-        expect(result).to be nil
-      end
-
-      expect(subject.last_remote_call.server_error?).to be true
-      expect(subject.last_remote_call.error?).to be true
+      execute_method
       expect(subject.last_remote_call.status).to be_nil
     end
 
@@ -107,7 +67,7 @@ shared_examples_for "persistent remote call" do
     it "it should populate 'last_remote_call' with the remote_call used on this transaction" do
       expect(subject.last_remote_call).to be_nil unless method_to_execute.to_s =~ /create/
       execute_method
-      expect(subject.last_remote_call).to be_a_kind_of(SmoothOperator::RemoteCall::Base)
+      expect(subject.last_remote_call).to be_instance_of(SmoothOperator::RemoteCall::Base)
     end
 
     it "it should assert the subject's persistence" do
@@ -124,89 +84,15 @@ shared_examples_for "save method" do
   end
 end
 
-shared_examples_for "a method that calls the #make_the_call method" do
-  let(:method_arguments) { ['/custom_path', { "user" => { "first_name" => "nhoJ" }, "extra_params" => 'extra_params' }, { option1: 'option1', option2: 'option2', http_verb: :get, serializable_options: { only: [:first_name] } }] }
-
-  it "it should pass all arguments to #make_the_call" do
-    _method_arguments = method_arguments.dup
-    _method_arguments[0] = SmoothOperator::Helpers.remove_initial_slash(_method_arguments[0])
-
-    expect(subject.class).to receive(:make_the_call).with(:get, *_method_arguments)
-
-    execute_method
-  end
-
-  it "it should pass all arguments to .make_the_call" do
-    _method_arguments = method_arguments.dup
-    _method_arguments[0] = SmoothOperator::Helpers.remove_initial_slash(_method_arguments[0])
-
-    expect(subject.class).to receive(:make_the_call).with(:get, *_method_arguments)
-
-    execute_method
-  end
-end
-
 
 describe SmoothOperator::Persistence, helpers: :persistence do
 
-  describe "#reload" do
-    subject { new_user }
-    let(:method_to_execute) { :reload }
-
-    context "when subject doesn't has an id" do
-      it "it should raise 'UnknownPath'" do
-        expect{ subject.reload }.to raise_error 'UnknownPath'
-      end
-    end
-
-    context "when subject has an id" do
-      before do
-        subject.id = 1
-        subject.reload
-      end
-
-      it "it should fetch server data" do
-        expect(subject.attributes).to eq(attributes_for(:user_with_address_and_posts))
-      end
-    end
-
-    context "when calling #reload on a nested object" do
-
-      context "without the option 'ignore_parent: true'" do
-        before do
-          subject.id = 1
-          subject.reload
-          subject.posts.first.reload
-        end
-
-        it "it should fetch server data, with NESTED REST url" do
-          expect(subject.posts.first.attributes).to eq({ id: 1, body: 'from_nested_url' })
-        end
-      end
-
-      context "with the option 'ignore_parent: true'" do
-        before do
-          subject.id = 1
-          subject.reload
-          subject.posts.first.reload(nil, nil, { ignore_parent: true })
-        end
-
-        it "it should fetch server data, with REST url" do
-          expect(subject.posts.first.attributes).to eq({ id: 1, body: 'from_resource_url' })
-        end
-      end
-
-    end
-
-    it_behaves_like "a method that calls the #make_the_call method"
-  end
-
   describe ".create" do
-
-    subject { created_subject }
+    
     let(:method_arguments) { [] }
 
     context "when attributes DON'T contain an ID" do
+      subject { created_subject }
       let(:method_to_execute) { :create_without_id }
       let(:persistence_state) { { 200 => true, 422 => false, 500 => false } }
 
@@ -221,6 +107,7 @@ describe SmoothOperator::Persistence, helpers: :persistence do
     end
 
     context "when attributes contain an ID" do
+      subject { created_subject }
       let(:method_to_execute) { :create_with_id }
       let(:persistence_state) { { 200 => true, 422 => true, 500 => true } }
 
@@ -271,7 +158,7 @@ describe SmoothOperator::Persistence, helpers: :persistence do
         expect(subject.destroyed?).to be(true)
       end
     end
-
+  
     context "after a failed execution of #destroy" do
       subject { existing_user }
       before  { subject.destroy('', { status: 422 }) }
@@ -331,16 +218,14 @@ describe SmoothOperator::Persistence, helpers: :persistence do
       subject { new_user }
       let(:persistence_state) { { 200 => true, 422 => false, 500 => false } }
 
+      it_behaves_like "persistent remote call"
+
       it "it should make a post http call" do
         execute_method
         expect(subject.last_remote_call.parsed_response['http_verb']).to eq('post')
       end
 
       it_behaves_like "save method"
-
-      it_behaves_like "persistent remote call"
-
-      it_behaves_like "a method that calls the #make_the_call method"
     end
 
     context "when an instance IS persisted" do
@@ -348,34 +233,31 @@ describe SmoothOperator::Persistence, helpers: :persistence do
         subject { existing_user }
         let(:persistence_state) { { 200 => true, 422 => true, 500 => true } }
 
+        it_behaves_like "persistent remote call"
+
         it "it should make a put http call" do
           execute_method
           expect(subject.last_remote_call.parsed_response['http_verb']).to eq('put')
         end
 
         it_behaves_like "save method"
-
-        it_behaves_like "persistent remote call"
-
-        it_behaves_like "a method that calls the #make_the_call method"
       end
 
       context "and it uses 'patch' http verb to save" do
         subject { existing_user_with_patch }
         let(:persistence_state) { { 200 => true, 422 => true, 500 => true } }
 
+        it_behaves_like "persistent remote call"
+
         it "it should make a patch http call" do
           execute_method
           expect(subject.last_remote_call.parsed_response['http_verb']).to eq('patch')
         end
 
         it_behaves_like "save method"
-
-        it_behaves_like "persistent remote call"
-
-        it_behaves_like "a method that calls the #make_the_call method"
       end
     end
+
   end
 
   describe "#save!" do
@@ -395,7 +277,7 @@ describe SmoothOperator::Persistence, helpers: :persistence do
   end
 
   describe "#destroy" do
-
+    
     let(:method_to_execute) { :destroy }
     let(:method_arguments) { [] }
 
@@ -417,14 +299,12 @@ describe SmoothOperator::Persistence, helpers: :persistence do
       subject { existing_user }
       let(:persistence_state) { { 200 => false, 422 => true, 500 => true } }
 
+      it_behaves_like "persistent remote call"
+
       it "it should make a delete http call" do
         execute_method
         expect(subject.last_remote_call.parsed_response['http_verb']).to eq('delete')
       end
-
-      it_behaves_like "persistent remote call"
-
-      it_behaves_like "a method that calls the #make_the_call method"
     end
 
   end

data/spec/smooth_operator/serialization_spec.rb

@@ -20,33 +20,9 @@ describe SmoothOperator::Serialization do
   describe "#to_hash" do
     subject { UserWithAddressAndPosts::Son.new(attributes_for(:user_with_address_and_posts)) }
 
-    it 'it should call #serializable_hash with the same arguments' do
-      options = { option1: 'option1', option2: 'option2' }
-
-      expect(subject).to receive(:serializable_hash).with(options)
-
-      subject.to_hash(options)
-    end
-  end
-
-  describe "#to_json" do
-    subject { UserWithAddressAndPosts::Son.new(attributes_for(:user_with_address_and_posts)) }
-
-    it 'it should call #serializable_hash with the same arguments' do
-      options = { option1: 'option1', option2: 'option2' }
-
-      expect(subject).to receive(:serializable_hash).with(options)
-
-      subject.to_json(options)
-    end
-  end
-
-  describe "#serializable_hash" do
-    subject { UserWithAddressAndPosts::Son.new(attributes_for(:user_with_address_and_posts)) }
-
     context "when no options are given" do
       it 'it should return all attributes' do
-        expect(subject.serializable_hash).to eq(SmoothOperator::Helpers.stringify_keys(attributes_for(:user_with_address_and_posts)))
+        expect(subject.to_hash).to eq(attributes_for(:user_with_address_and_posts))
       end
     end
 
@@ -54,7 +30,7 @@ describe SmoothOperator::Serialization do
       let(:options_with_only) { { only: [:id, :first_name] } }
 
       it 'it should only return the filtered options' do
-        expect(subject.serializable_hash(options_with_only)).to eq(SmoothOperator::Helpers.stringify_keys(attributes_for(:white_list)))
+        expect(subject.to_hash(options_with_only)).to eq(attributes_for(:white_list))
       end
     end
 
@@ -62,7 +38,7 @@ describe SmoothOperator::Serialization do
       let(:options_with_except) { { except: [:last_name, :admin] } }
 
       it 'it should return all fields except for the filtered options' do
-        expect(subject.serializable_hash(options_with_except)).not_to include(attributes_for(:black_list))
+        expect(subject.to_hash(options_with_except)).not_to include(attributes_for(:black_list))
       end
     end
 
@@ -71,7 +47,7 @@ describe SmoothOperator::Serialization do
       subject(:user_with_my_method) { UserWithAddressAndPosts::UserWithMyMethod.new(attributes_for(:user_with_address_and_posts)) }
 
       it 'it should return all fields including the expected method and its returning value' do
-        expect(user_with_my_method.serializable_hash(options_with_method)).to eq(SmoothOperator::Helpers.stringify_keys(attributes_for(:user_with_my_method)))
+        expect(user_with_my_method.to_hash(options_with_method)).to eq(attributes_for(:user_with_my_method))
       end
     end
 

data/spec/spec_helper.rb

@@ -1,12 +1,14 @@
-require 'simplecov'
+$LOAD_PATH.unshift(File.dirname(__FILE__))
+$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), "..", "lib"))
 
-SimpleCov.start do
-  root('lib/')
-  project_name('SmoothOperator')
-  coverage_dir('../tmp/coverage/')
-end
+require 'bundler'
+require 'smooth_operator'
+
+Bundler.require :test, :default
 
-require 'require_helper'
+Dir.chdir("spec/") do
+  Dir["support/**/*.rb"].each { |file| require file }
+end
 
 FactoryGirl.find_definitions
 

data/spec/support/models/address.rb

@@ -1,12 +1,3 @@
 class Address < SmoothOperator::Base
 
-  options resource_name: '',
-          endpoint_user: 'admin',
-          endpoint_pass: 'admin',
-          endpoint: 'http://localhost:4567/',
-          headers: {
-            "X-APPTOKEN" => "app_token",
-            "X-LAYERTOKEN" => "layer_token"
-          }
-
 end

data/spec/support/models/post.rb

@@ -1,13 +1,7 @@
 class Post < SmoothOperator::Base
 
-  options endpoint_user: 'admin',
-          endpoint_pass: 'admin',
-          rails_serialization: true,
-          endpoint: 'http://localhost:4567/',
-          unknown_hash_class: SmoothOperator::OpenStruct
-
-  has_many :comments#, rails_serialization: true
-
-  belongs_to :address#, rails_serialization: true
+  self.turn_unknown_hash_to_open_struct = false
+  
+  self.endpoint = 'http://localhost:3000/api/v0'
 
 end

data/spec/support/models/user.rb

@@ -1,38 +1,15 @@
-module User
+class User < SmoothOperator::Base
 
-  class Base < SmoothOperator::Base
+  self.endpoint_user = 'admin'
 
-    options resource_name: 'user',
-            endpoint_user: 'admin',
-            endpoint_pass: 'admin',
-            endpoint: 'http://localhost:4567/'
+  self.endpoint_pass = 'admin'
 
-    def self.query_string(params)
-      params['query_string_param'] = true
+  self.endpoint = 'http://localhost:4567/'
 
-      params
-    end
+  def self.query_string(params)
+    params['query_string_param'] = true
 
-  end
-
-  module UnknownHashClass
-
-    class OpenStructBase < User::Base
-      options unknown_hash_class: SmoothOperator::OpenStruct
-    end
-
-    class None < User::Base
-      options unknown_hash_class: nil
-    end
-
-  end
-
-  class BrokenConnection < SmoothOperator::Base
-    options endpoint: 'http://localhost:1234/'
-  end
-
-  class TimeoutConnection < Base
-    options timeout: 1
+    params
   end
 
 end