smoke_detector 0.0.4 → 0.1.0

data/spec/models/providers/airbrake_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe SmokeDetector::Providers::Airbrake do
-  let(:provider) { SmokeDetector::Providers::Airbrake.new('api_key', settings) }
+  let(:provider) { SmokeDetector::Providers::Airbrake.new('api_key', nil, settings) }
   let(:settings) { {} }
   let(:err) { double('error', backtrace: [], message: 'bad news') }
   let(:data) { {custom: :data} }

data/spec/models/providers/provider_spec.rb

@@ -1,7 +1,8 @@
 require 'spec_helper'
 
 describe SmokeDetector::Providers::Provider do
-  let(:provider) { SmokeDetector::Providers::Provider.new }
+  let(:api_key) { 'some_key' }
+  let(:provider) { SmokeDetector::Providers::Provider.new(api_key) }
 
   describe '#alert' do
     subject { provider.alert(Exception.new) }

data/spec/models/providers/rollbar_spec.rb

@@ -1,14 +1,14 @@
 require 'spec_helper'
 
 describe SmokeDetector::Providers::Rollbar do
-  let(:provider) { SmokeDetector::Providers::Rollbar.new('api_key', settings) }
+  let(:provider) { SmokeDetector::Providers::Rollbar.new('api_key', nil, settings) }
   let(:settings) { {} }
   let(:err) { StandardError.new('error') }
   let(:data) { {custom: :data} }
 
   describe '#initialize' do
     describe 'environment setting' do
-      before { SmokeDetector::Providers::Rollbar.new('api_key', settings) }
+      before { SmokeDetector::Providers::Rollbar.new('api_key', nil, settings) }
 
       it 'defaults to the Rails environment' do
         expect(::Rollbar.configuration.environment).to eql Rails.env

data/spec/models/providers_spec.rb

@@ -3,6 +3,7 @@ require 'spec_helper'
 describe SmokeDetector do
   let(:provider) { :rollbar }
   let(:api_key) { 'some_key' }
+  let(:client_api_key) { nil }
   let(:provider_class) { SmokeDetector::Providers::Rollbar }
 
   describe '.register_provider' do
@@ -13,7 +14,7 @@ describe SmokeDetector do
         end
 
         it 'adds the provider to the SmokeDetector providers' do
-          SmokeDetector.register_provider(provider, api_key)
+          SmokeDetector.register_provider(provider, api_key, client_api_key)
           SmokeDetector.providers.last.should be_a provider_class
         end
       end
@@ -24,7 +25,7 @@ describe SmokeDetector do
         end
 
         it 'raises an error' do
-          expect { SmokeDetector.register_provider(provider, api_key) }.to raise_error SmokeDetector::ProviderRegistrationError
+          expect { SmokeDetector.register_provider(provider, api_key, client_api_key) }.to raise_error SmokeDetector::ProviderRegistrationError
         end
       end
 
@@ -34,7 +35,7 @@ describe SmokeDetector do
       let(:provider) { :not_a_provider }
 
       it 'raises an error' do
-        expect { SmokeDetector.register_provider(provider, api_key) }.to raise_error SmokeDetector::ProviderRegistrationError
+        expect { SmokeDetector.register_provider(provider, api_key, client_api_key) }.to raise_error SmokeDetector::ProviderRegistrationError
       end
     end
   end
@@ -45,7 +46,7 @@ describe SmokeDetector do
     context "with a supported provider" do
       context 'that is registered' do
         before do
-          SmokeDetector.register_provider(provider, api_key)
+          SmokeDetector.register_provider(provider, api_key, client_api_key)
         end
 
         it { should == true }

data/spec/models/smoke_detector_spec.rb

@@ -5,8 +5,8 @@ describe SmokeDetector do
     let(:err) { Exception.new }
 
     before do
-      SmokeDetector.register_provider(:airbrake, 'key')
-      SmokeDetector.register_provider(:rollbar, 'key')
+      SmokeDetector.register_provider(:airbrake, 'key', 'client_key')
+      SmokeDetector.register_provider(:rollbar, 'key', 'client_key')
       SmokeDetector.providers.size.should > 1
     end
 

data/spec/requests/aibrake_config_spec.rb

@@ -4,7 +4,7 @@ describe 'Airbrake config: An exception' do
 
   before do
     SmokeDetector.instance_variable_set(:@providers, [])
-    SmokeDetector.register_provider(:airbrake, 'key')
+    SmokeDetector.register_provider(:airbrake, 'key', nil)
   end
 
   it_behaves_like 'Airbrake integrated error handler'

data/spec/requests/middleware/javascript_monitors_spec.rb

@@ -0,0 +1,38 @@
+require 'spec_helper'
+require 'nokogiri'
+
+describe SmokeDetector::JavaScriptMonitors do
+
+  before do
+    SmokeDetector.instance_variable_set(:@providers, [])
+    # FIXME There is only one instance of the middleware class so the @monitoring_code instance
+    #       variable is only set once on app init and there's no easy way to access that
+    #       instance.
+    ObjectSpace.each_object(SmokeDetector::JavaScriptMonitors) do |jsm|
+      jsm.instance_variable_set(:@monitoring_code, nil)
+    end
+  end
+
+  context 'with a Rollbar client API key configured' do
+    before do
+      SmokeDetector.register_provider(:rollbar, 'key', 'client_key')
+    end
+
+    it 'injects the Rollbar JS snippet into the <head>' do
+      get '/widgets'
+      expect(Nokogiri::HTML(response.body).css('head script:contains("_rollbarConfig")')).to_not be_empty
+    end
+  end
+
+  context 'without a Rollbar client API key configured' do
+    before do
+      SmokeDetector.register_provider(:rollbar, 'key', nil)
+    end
+
+    it 'does not inject the Rollbar JS snippet into the <head>' do
+      get '/widgets'
+      expect(Nokogiri::HTML(response.body).css('head script:contains("_rollbarConfig")')).to be_empty
+    end
+  end
+
+end

data/spec/requests/multi_provider_config_spec.rb

@@ -5,8 +5,8 @@ describe 'Multi-provider config: An exception' do
   before do
     SmokeDetector.instance_variable_set(:@providers, [])
 
-    SmokeDetector.register_provider(:rollbar, 'key')
-    SmokeDetector.register_provider(:airbrake, 'key')
+    SmokeDetector.register_provider(:rollbar, 'key', nil)
+    SmokeDetector.register_provider(:airbrake, 'key', nil)
     SmokeDetector.providers.size.should == 2
   end
 

data/spec/requests/rollbar_config_spec.rb

@@ -5,7 +5,7 @@ describe 'Rollbar config: An exception' do
   before do
     SmokeDetector.instance_variable_set(:@providers, [])
 
-    SmokeDetector.register_provider(:rollbar, 'key')
+    SmokeDetector.register_provider(:rollbar, 'key', nil)
   end
 
   it_behaves_like 'Rollbar integrated error handler'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: smoke_detector
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.1.0
 platform: ruby
 authors:
 - Chris Friedrich
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-10 00:00:00.000000000 Z
+date: 2014-03-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -53,115 +53,115 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0.11'
 - !ruby/object:Gem::Dependency
-  name: sqlite3
+  name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec-rails
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pry-nav
+  name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pry-rescue
+  name: pry-nav
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pry-stack_explorer
+  name: pry-rescue
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: ruby-debug19
+  name: pry-stack_explorer
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: Provides a single interface for posting errors to multiple error reporting
@@ -175,6 +175,7 @@ files:
 - lib/smoke_detector/controller_methods.rb
 - lib/smoke_detector/engine.rb
 - lib/smoke_detector/exceptions.rb
+- lib/smoke_detector/middleware/javascript_monitors.rb
 - lib/smoke_detector/providers/airbrake.rb
 - lib/smoke_detector/providers/provider.rb
 - lib/smoke_detector/providers/rollbar.rb
@@ -222,22 +223,13 @@ files:
 - spec/dummy/Rakefile
 - spec/dummy/README.rdoc
 - spec/dummy/script/rails
-- spec/dummy/tmp/cache/assets/C5F/270/sprockets%2F32a6d17723de2976b8456753922862fc
-- spec/dummy/tmp/cache/assets/CA3/870/sprockets%2F703bc6444d2a153516ad9804dc24b467
-- spec/dummy/tmp/cache/assets/CD8/370/sprockets%2F357970feca3ac29060c1e3861e2c0953
-- spec/dummy/tmp/cache/assets/D2F/510/sprockets%2F42e50ab0277768533b1cad2237fb5ade
-- spec/dummy/tmp/cache/assets/D32/A10/sprockets%2F13fe41fee1fe35b49d145bcc06610705
-- spec/dummy/tmp/cache/assets/D4E/1B0/sprockets%2Ff7cbd26ba1d28d48de824f0e94586655
-- spec/dummy/tmp/cache/assets/D5A/EA0/sprockets%2Fd771ace226fc8215a3572e0aa35bb0d6
-- spec/dummy/tmp/cache/assets/DAE/CC0/sprockets%2Fcf340221edaaed61b5821abd28052dbb
-- spec/dummy/tmp/cache/assets/DDC/400/sprockets%2Fcffd775d018f68ce5dba1ee0d951a994
-- spec/dummy/tmp/cache/assets/E04/890/sprockets%2F2f5173deea6c795b8fdde723bb4b63af
 - spec/models/providers/airbrake_spec.rb
 - spec/models/providers/provider_spec.rb
 - spec/models/providers/rollbar_spec.rb
 - spec/models/providers_spec.rb
 - spec/models/smoke_detector_spec.rb
 - spec/requests/aibrake_config_spec.rb
+- spec/requests/middleware/javascript_monitors_spec.rb
 - spec/requests/multi_provider_config_spec.rb
 - spec/requests/rollbar_config_spec.rb
 - spec/spec_helper.rb
@@ -252,17 +244,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.1.4
+rubygems_version: 2.0.14
 signing_key: 
 specification_version: 4
 summary: Errors Alerts
@@ -304,22 +296,13 @@ test_files:
 - spec/dummy/Rakefile
 - spec/dummy/README.rdoc
 - spec/dummy/script/rails
-- spec/dummy/tmp/cache/assets/C5F/270/sprockets%2F32a6d17723de2976b8456753922862fc
-- spec/dummy/tmp/cache/assets/CA3/870/sprockets%2F703bc6444d2a153516ad9804dc24b467
-- spec/dummy/tmp/cache/assets/CD8/370/sprockets%2F357970feca3ac29060c1e3861e2c0953
-- spec/dummy/tmp/cache/assets/D2F/510/sprockets%2F42e50ab0277768533b1cad2237fb5ade
-- spec/dummy/tmp/cache/assets/D32/A10/sprockets%2F13fe41fee1fe35b49d145bcc06610705
-- spec/dummy/tmp/cache/assets/D4E/1B0/sprockets%2Ff7cbd26ba1d28d48de824f0e94586655
-- spec/dummy/tmp/cache/assets/D5A/EA0/sprockets%2Fd771ace226fc8215a3572e0aa35bb0d6
-- spec/dummy/tmp/cache/assets/DAE/CC0/sprockets%2Fcf340221edaaed61b5821abd28052dbb
-- spec/dummy/tmp/cache/assets/DDC/400/sprockets%2Fcffd775d018f68ce5dba1ee0d951a994
-- spec/dummy/tmp/cache/assets/E04/890/sprockets%2F2f5173deea6c795b8fdde723bb4b63af
 - spec/models/providers/airbrake_spec.rb
 - spec/models/providers/provider_spec.rb
 - spec/models/providers/rollbar_spec.rb
 - spec/models/providers_spec.rb
 - spec/models/smoke_detector_spec.rb
 - spec/requests/aibrake_config_spec.rb
+- spec/requests/middleware/javascript_monitors_spec.rb
 - spec/requests/multi_provider_config_spec.rb
 - spec/requests/rollbar_config_spec.rb
 - spec/spec_helper.rb