smith-agents 0.12.5 → 0.12.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 663a12c4a26041ded1da57a8bd899213cc28d330eae1d42a9dc3e4fdbda4dd87
-  data.tar.gz: c997927bbcea376c0db21a92aacdc21e510ac3c8e664d4ebb1eb0f8282cd2b32
+  metadata.gz: 97813bcba79ce652b05eb860da067e3c566b8ba3450344d66940c9f65d23a1dc
+  data.tar.gz: ea20e0a30b7517aab44a43b2668cb5e59fde6b98a829056e8e73ba585338f216
 SHA512:
-  metadata.gz: 27cc5f8437f8325afde26cd1816f8ca007a1c0f43b0ea02cc14cdcd49c17504cc5b2a22934c8b26ddcac132f5d2dc28f40e9e6fcde8976e01b3d4438523235b2
-  data.tar.gz: d621799d104e1b3b1ba97f14974afb6fa01c99cd179f8817471a55148d0587c9b2e333d47a0ab016855e48b8ab7739badb5db72c22e6730294f23da4947bc96d
+  metadata.gz: 37d47a1f6268dc96cd05ce69f4138998d1c5a9649bbb41921882b6ae93a8f5d030586c273f37231501c121dd43492e1a37034cefe88981a5f89138cbf1ccd128
+  data.tar.gz: 40eb2c1a4ac979411860e4971b4814e0c2cdaebc39f1a827e956f7fcb2a5ca33c3f34d18aad339edfa1460a8fce07188f505aa174a2e59233d735c50bab258d3

data/CHANGELOG.md

@@ -4,6 +4,27 @@ All notable changes to Smith are documented in this file.
 
 Format follows [Keep a Changelog](https://keepachangelog.com/en/1.1.0/). Versioning follows [Semantic Versioning](https://semver.org/spec/v2.0.0.html). Smith is pre-1.0 and under active development; expect occasional contract tightening between minor versions until 1.0.
 
+## [0.12.6] - 2026-10-13
+
+### Fixed
+
+- An error of a streamed request is what the provider said it was
+  (`Smith::ProviderErrors`). RubyLLM builds a streamed request's error
+  response itself, guessing its status from the error event's type:
+  Anthropic's adapter says 500 unless overloaded, OpenAI's 400 unless a
+  server error or a rate limit. With 0.12.5 sending a streamed request
+  once, an Anthropic bad request, wrong key or unknown model looked like a
+  passing outage (fallbacks and retries instead of failing or moving to
+  another account), and an OpenAI wrong key, unknown model, regional refusal
+  or rate limit like a bad request (no fallback). Before, RubyLLM's retry
+  hid this by garbling the error into one of the response's real status.
+  Smith reads the type the provider gave in the body (Anthropic's
+  `error.type`, OpenAI's `error.code`, else its `error.type`) and, when it
+  names another status, raises what RubyLLM raises for that status, through
+  RubyLLM's own mapping (context length included), with the provider's
+  message and the response's headers, its cause the error RubyLLM raised.
+  An error the provider sent whole keeps its own status.
+
 ## [0.12.5] - 2026-10-13
 
 ### Fixed

data/README.md

@@ -30,7 +30,7 @@ What you get:
 
 ```ruby
 # Gemfile
-gem "smith-agents", "0.12.5", require: "smith"
+gem "smith-agents", "0.12.6", require: "smith"
 ```
 
 In a Rails app:

data/docs/ERRORS_AND_RETRIES.md

@@ -117,6 +117,15 @@ rate limit. RubyLLM's own HTTP retries (`max_retries`) may repeat a 429 of a
 call that does not stream before Smith sees it (a refused request is not
 charged); a streamed call is sent once, so its refusal reaches Smith whole.
 
+RubyLLM guesses the status of a streamed request's error from the error
+event's type (Anthropic's adapter says 500 unless overloaded, OpenAI's 400
+unless a server error or a rate limit). Smith takes it as what the provider
+said it was, from the type in the body (Anthropic's `error.type`, OpenAI's
+`error.code`, else its `error.type`), through RubyLLM's own mapping, with the
+response's headers: a streamed bad request fails, a wrong key is the
+account's, an unknown model moves to the next candidate, an overload is a
+passing outage. An error the provider sent whole keeps its own status.
+
 Name only errors that mean your own systems failed. A provider's own failure
 (`RubyLLM::Error`, or its HTTP client's `Faraday::Error`) is the provider's
 whatever it was raised from, so naming a low-level class such as

data/lib/smith/agent/provider_call_timing.rb

@@ -123,9 +123,11 @@ module Smith
       # have their join target; the error then propagates unchanged. A
       # provider failure's own reported usage is accounted beside the
       # completed prefix, so its trace totals both.
-      # A billing refusal is recorded as the provider account's (BillingRefusals).
+      # An error is recorded as what the provider said it was
+      # (ProviderErrors), a billing refusal as the provider account's
+      # (BillingRefusals).
       def failed_provider_attempt(error, observed_reference, timer, facts, prefix_usages)
-        error = BillingRefusals.classified(error)
+        error = BillingRefusals.classified(ProviderErrors.classified(error))
         aborted = !provider_failure?(error)
         usages = aborted ? prefix_usages : [*prefix_usages, ProviderUsage.from_message(error)].compact
         attempt = ProviderAttempt.failure(

data/lib/smith/provider_errors.rb

@@ -0,0 +1,98 @@
+# frozen_string_literal: true
+
+require "json"
+require "ruby_llm"
+
+module Smith
+  # An error of a streamed request as the provider said it was. RubyLLM
+  # builds a streamed request's error response itself, its status a guess
+  # from the error event's type (Anthropic's adapter says 500 unless
+  # overloaded, OpenAI's 400 unless a server error or a rate limit), so a
+  # wrong key, a model the provider does not serve or a refusal by region
+  # could look like a passing outage or a bad request. Smith reads the type
+  # the provider gave in the body (Anthropic's `error.type`, OpenAI's
+  # `error.code`, else its `error.type`) and, when it names another status,
+  # raises what RubyLLM raises for that status (its own mapping, context
+  # length included), with the provider's message, the response's headers
+  # kept, its cause the error RubyLLM raised. An error from a response the
+  # provider sent whole (its status the provider's own), or whose body
+  # names nothing it knows, stays as it is.
+  module ProviderErrors
+    STATUSES = {
+      "invalid_request_error" => 400,
+      "authentication_error" => 401,
+      "invalid_api_key" => 401,
+      "billing_error" => 402,
+      "permission_error" => 403,
+      "unsupported_country_region_territory" => 403,
+      "not_found_error" => 404,
+      "model_not_found" => 404,
+      "request_too_large" => 413,
+      "rate_limit_error" => 429,
+      "rate_limit_exceeded" => 429,
+      "timeout_error" => 504
+    }.freeze
+    private_constant :STATUSES
+
+    Response = Struct.new(:status, :body)
+    Said = Struct.new(:message) do
+      def parse_error(_response) = message
+    end
+    private_constant :Response, :Said
+
+    module_function
+
+    # The error as Smith takes it: a streamed request's error whose body
+    # names another status as the error RubyLLM raises for that status,
+    # anything else unchanged.
+    def classified(error)
+      return error unless error.is_a?(RubyLLM::Error) && streamed?(error)
+
+      said = said_of(body_of(error))
+      status = named_status(said)
+      return error if status.nil? || status == error.response.status.to_i
+
+      reclassify(error, with_status(error.response, status), said["message"])
+    end
+
+    def named_status(said) = said && (STATUSES[said["code"].to_s] || STATUSES[said["type"].to_s])
+
+    # A response RubyLLM built for a streamed request's error, never one the
+    # provider sent whole (a Faraday::Response).
+    def streamed?(error)
+      response = error.response
+      response.respond_to?(:status) && response.respond_to?(:body) && !response.is_a?(Faraday::Response)
+    end
+
+    def reclassify(error, response, message)
+      named = begin
+        RubyLLM::ErrorMiddleware.parse_error(provider: Said.new(message.is_a?(String) ? message : nil), response:)
+      rescue RubyLLM::Error => e
+        e
+      end
+      return error unless named.is_a?(RubyLLM::Error)
+
+      begin
+        raise named.class.new(response, named.message), cause: error
+      rescue RubyLLM::Error => e
+        e
+      end
+    end
+
+    def with_status(response, status)
+      response.respond_to?(:merge) ? response.merge(status:) : Response.new(status, response.body)
+    end
+
+    def said_of(body)
+      said = body.is_a?(Hash) ? body["error"] : nil
+      said.is_a?(Hash) ? said : nil
+    end
+
+    def body_of(error)
+      body = error.response.body
+      body.is_a?(String) ? JSON.parse(body) : body
+    rescue JSON::ParserError
+      nil
+    end
+  end
+end

data/lib/smith/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
 module Smith
-  VERSION = "0.12.5"
+  VERSION = "0.12.6"
   EXECUTION_SEMANTICS_VERSION = "7"
 end

data/lib/smith.rb

@@ -212,6 +212,7 @@ require_relative "smith/tool_failure_notification_failed"
 require_relative "smith/persistence_payload_conflict"
 require_relative "smith/exponential_backoff"
 require_relative "smith/interruptions"
+require_relative "smith/provider_errors"
 require_relative "smith/billing_refusals"
 
 # Event system (depends on Types)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: smith-agents
 version: !ruby/object:Gem::Version
-  version: 0.12.5
+  version: 0.12.6
 platform: ruby
 authors:
 - Samuel Ralak
@@ -298,6 +298,7 @@ files:
 - lib/smith/pricing.rb
 - lib/smith/pricing/catalog_validation.rb
 - lib/smith/pricing_configuration_error.rb
+- lib/smith/provider_errors.rb
 - lib/smith/provider_permanent_failure.rb
 - lib/smith/providers/anthropic/batches.rb
 - lib/smith/providers/batch_exchange.rb